Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Make _reset follow done shape #2189

Merged
merged 5 commits into from
May 31, 2024
Merged

[BugFix] Make _reset follow done shape #2189

merged 5 commits into from
May 31, 2024

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented May 31, 2024 •
edited
Loading

Fixes #2179
Replaces #2181

By enforcing resets to have the same shape as dones

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2189

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 14f904a with merge base c0c32a0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2024
@matteobettini matteobettini marked this pull request as ready for review May 31, 2024 11:04
@vmoens vmoens added the bug Something isn't working label May 31, 2024
@matteobettini
Copy link
Contributor Author

matteobettini commented May 31, 2024 •
edited
Loading

Pls add environment label to test pettingzoo

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label May 31, 2024
vmoens
vmoens reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@vmoens vmoens merged commit 7b145b5 into pytorch:main May 31, 2024
52 of 58 checks passed
@matteobettini matteobettini deleted the fix_reset branch June 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ParallelEnv does not work with PettingZooEnv.
3 participants
@matteobettini @vmoens @facebook-github-bot