Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix sampling in NonTensorSpec #2172

Merged
merged 1 commit into from
May 26, 2024
Merged

[BugFix] Fix sampling in NonTensorSpec #2172

merged 1 commit into from
May 26, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 26, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2172

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 10 Unrelated Failures

As of commit 7a9887f with merge base a93063b (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2024
@vmoens vmoens added the bug Something isn't working label May 26, 2024
@vmoens vmoens linked an issue May 26, 2024 that may be closed by this pull request
[BUG] NonTensorSpec calls NonTensorData with unexpected shape argument #2168
Closed
3 tasks
@vmoens vmoens merged commit 78b4717 into main May 26, 2024
31 of 47 checks passed
@vmoens vmoens deleted the fix-nontensorspec branch May 26, 2024 00:13
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1032s 58.0402ms 17.2294 Ops/s 18.2792 Ops/s $\textbf{\color{#d91a1a}-5.74\%}$
test_sync 45.8047ms 30.1152ms 33.2058 Ops/s 33.5985 Ops/s $\color{#d91a1a}-1.17\%$
test_async 57.9375ms 26.8748ms 37.2095 Ops/s 35.6249 Ops/s $\color{#35bf28}+4.45\%$
test_simple 0.4021s 0.3505s 2.8529 Ops/s 2.8884 Ops/s $\color{#d91a1a}-1.23\%$
test_transformed 0.4972s 0.4915s 2.0346 Ops/s 1.9814 Ops/s $\color{#35bf28}+2.68\%$
test_serial 1.2777s 1.2244s 0.8168 Ops/s 0.8061 Ops/s $\color{#35bf28}+1.32\%$
test_parallel 1.0676s 1.0203s 0.9801 Ops/s 0.9866 Ops/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[True-True-True-True-True] 0.1220ms 21.1262μs 47.3346 KOps/s 46.7277 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[True-True-True-True-False] 39.1130μs 13.0938μs 76.3722 KOps/s 76.2178 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[True-True-True-False-True] 46.3460μs 12.5138μs 79.9120 KOps/s 78.9418 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-True-True-False-False] 35.7470μs 7.6281μs 131.0949 KOps/s 130.1815 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-True-False-True-True] 58.6900μs 22.5432μs 44.3592 KOps/s 43.9914 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-True-False-True-False] 61.5040μs 14.3305μs 69.7812 KOps/s 69.9375 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[True-True-False-False-True] 56.7970μs 13.7230μs 72.8705 KOps/s 72.8011 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[True-True-False-False-False] 35.4560μs 8.8843μs 112.5578 KOps/s 112.2198 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-False-True-True-True] 64.8710μs 23.8559μs 41.9183 KOps/s 41.6095 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[True-False-True-True-False] 47.1180μs 15.7531μs 63.4795 KOps/s 64.2228 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[True-False-True-False-True] 51.8370μs 13.7258μs 72.8555 KOps/s 72.1687 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-False-True-False-False] 35.5570μs 9.0305μs 110.7362 KOps/s 112.4339 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-False-True-True] 52.2880μs 25.0764μs 39.8782 KOps/s 39.7478 KOps/s $\color{#35bf28}+0.33\%$
test_step_mdp_speed[True-False-False-True-False] 37.2300μs 16.9668μs 58.9387 KOps/s 58.9472 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[True-False-False-False-True] 35.8670μs 14.9371μs 66.9473 KOps/s 67.1919 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[True-False-False-False-False] 42.5100μs 10.2577μs 97.4878 KOps/s 99.3306 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[False-True-True-True-True] 58.9600μs 24.0441μs 41.5903 KOps/s 41.3634 KOps/s $\color{#35bf28}+0.55\%$
test_step_mdp_speed[False-True-True-True-False] 54.3810μs 15.6415μs 63.9325 KOps/s 63.3914 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[False-True-True-False-True] 56.2460μs 16.0836μs 62.1752 KOps/s 61.6582 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[False-True-True-False-False] 49.4830μs 10.0237μs 99.7632 KOps/s 98.9611 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-True-False-True-True] 60.8140μs 24.9560μs 40.0705 KOps/s 39.5566 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[False-True-False-True-False] 52.8290μs 16.7114μs 59.8395 KOps/s 58.4534 KOps/s $\color{#35bf28}+2.37\%$
test_step_mdp_speed[False-True-False-False-True] 57.0970μs 17.1259μs 58.3910 KOps/s 57.5884 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-True-False-False-False] 60.9400μs 11.2763μs 88.6813 KOps/s 88.8994 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-False-True-True-True] 65.7540μs 26.1380μs 38.2585 KOps/s 37.5039 KOps/s $\color{#35bf28}+2.01\%$
test_step_mdp_speed[False-False-True-True-False] 50.9550μs 18.0355μs 55.4462 KOps/s 54.9746 KOps/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[False-False-True-False-True] 39.1030μs 17.1072μs 58.4548 KOps/s 58.0733 KOps/s $\color{#35bf28}+0.66\%$
test_step_mdp_speed[False-False-True-False-False] 39.3440μs 11.3247μs 88.3024 KOps/s 88.9476 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-False-False-True-True] 41.8780μs 27.7659μs 36.0154 KOps/s 33.4781 KOps/s $\textbf{\color{#35bf28}+7.58\%}$
test_step_mdp_speed[False-False-False-True-False] 56.7860μs 19.0719μs 52.4331 KOps/s 52.3783 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[False-False-False-False-True] 44.2930μs 18.1713μs 55.0317 KOps/s 54.5925 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-False-False-False-False] 34.0530μs 12.3203μs 81.1668 KOps/s 80.7699 KOps/s $\color{#35bf28}+0.49\%$
test_values[generalized_advantage_estimate-True-True] 10.1550ms 9.5445ms 104.7725 Ops/s 104.2356 Ops/s $\color{#35bf28}+0.52\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.4151ms 33.3433ms 29.9911 Ops/s 29.5321 Ops/s $\color{#35bf28}+1.55\%$
test_values[td0_return_estimate-False-False] 0.2222ms 0.1647ms 6.0701 KOps/s 5.6710 KOps/s $\textbf{\color{#35bf28}+7.04\%}$
test_values[td1_return_estimate-False-False] 23.6765ms 23.3926ms 42.7485 Ops/s 40.9096 Ops/s $\color{#35bf28}+4.49\%$
test_values[vec_td1_return_estimate-False-False] 35.3858ms 33.4788ms 29.8697 Ops/s 30.0471 Ops/s $\color{#d91a1a}-0.59\%$
test_values[td_lambda_return_estimate-True-False] 36.7394ms 33.8298ms 29.5597 Ops/s 28.5755 Ops/s $\color{#35bf28}+3.44\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.4737ms 33.4648ms 29.8822 Ops/s 29.9043 Ops/s $\color{#d91a1a}-0.07\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.5454ms 8.3881ms 119.2167 Ops/s 118.8372 Ops/s $\color{#35bf28}+0.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.5836ms 2.0189ms 495.3179 Ops/s 494.8880 Ops/s $\color{#35bf28}+0.09\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4451ms 0.3576ms 2.7961 KOps/s 2.7634 KOps/s $\color{#35bf28}+1.18\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.5054ms 46.6528ms 21.4349 Ops/s 21.2154 Ops/s $\color{#35bf28}+1.03\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7075ms 3.0353ms 329.4555 Ops/s 329.5428 Ops/s $\color{#d91a1a}-0.03\%$
test_dqn_speed 6.8590ms 1.3635ms 733.4184 Ops/s 714.7689 Ops/s $\color{#35bf28}+2.61\%$
test_ddpg_speed 3.6594ms 2.9022ms 344.5689 Ops/s 341.0119 Ops/s $\color{#35bf28}+1.04\%$
test_sac_speed 11.9762ms 8.6844ms 115.1494 Ops/s 115.5677 Ops/s $\color{#d91a1a}-0.36\%$
test_redq_speed 15.2472ms 13.3454ms 74.9323 Ops/s 69.4916 Ops/s $\textbf{\color{#35bf28}+7.83\%}$
test_redq_deprec_speed 14.3788ms 13.4740ms 74.2169 Ops/s 73.8567 Ops/s $\color{#35bf28}+0.49\%$
test_td3_speed 16.2890ms 8.6196ms 116.0145 Ops/s 116.4957 Ops/s $\color{#d91a1a}-0.41\%$
test_cql_speed 37.6380ms 37.1158ms 26.9427 Ops/s 27.1343 Ops/s $\color{#d91a1a}-0.71\%$
test_a2c_speed 8.0014ms 7.5241ms 132.9059 Ops/s 132.9094 Ops/s $-0.00\%$
test_ppo_speed 9.0649ms 7.7740ms 128.6343 Ops/s 128.4378 Ops/s $\color{#35bf28}+0.15\%$
test_reinforce_speed 7.3529ms 6.6966ms 149.3292 Ops/s 149.5488 Ops/s $\color{#d91a1a}-0.15\%$
test_iql_speed 34.1692ms 32.9107ms 30.3853 Ops/s 30.0547 Ops/s $\color{#35bf28}+1.10\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5177ms 2.1504ms 465.0318 Ops/s 475.4355 Ops/s $\color{#d91a1a}-2.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0386ms 0.5042ms 1.9832 KOps/s 1.9761 KOps/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7000ms 0.4808ms 2.0800 KOps/s 2.0509 KOps/s $\color{#35bf28}+1.42\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.3638ms 2.1208ms 471.5240 Ops/s 466.7972 Ops/s $\color{#35bf28}+1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0209ms 0.4933ms 2.0272 KOps/s 2.0094 KOps/s $\color{#35bf28}+0.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7002ms 0.4732ms 2.1132 KOps/s 2.1087 KOps/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4316ms 1.2595ms 793.9899 Ops/s 785.0395 Ops/s $\color{#35bf28}+1.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4642ms 1.1896ms 840.6348 Ops/s 831.2677 Ops/s $\color{#35bf28}+1.13\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2919ms 2.2343ms 447.5650 Ops/s 452.2759 Ops/s $\color{#d91a1a}-1.04\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1016s 0.6988ms 1.4310 KOps/s 1.6071 KOps/s $\textbf{\color{#d91a1a}-10.96\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8491ms 0.5931ms 1.6862 KOps/s 1.6675 KOps/s $\color{#35bf28}+1.12\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2740ms 2.1046ms 475.1395 Ops/s 475.2023 Ops/s $\color{#d91a1a}-0.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0568ms 0.5029ms 1.9883 KOps/s 1.9673 KOps/s $\color{#35bf28}+1.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6819ms 0.4894ms 2.0433 KOps/s 2.0635 KOps/s $\color{#d91a1a}-0.97\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.5198ms 2.1482ms 465.5115 Ops/s 479.8985 Ops/s $\color{#d91a1a}-3.00\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6277ms 0.4970ms 2.0119 KOps/s 1.9875 KOps/s $\color{#35bf28}+1.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.7486ms 0.4805ms 2.0812 KOps/s 2.0974 KOps/s $\color{#d91a1a}-0.77\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4278ms 2.2500ms 444.4420 Ops/s 450.1490 Ops/s $\color{#d91a1a}-1.27\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9613ms 0.6288ms 1.5903 KOps/s 1.5379 KOps/s $\color{#35bf28}+3.41\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7830ms 0.5951ms 1.6803 KOps/s 1.6543 KOps/s $\color{#35bf28}+1.57\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1089s 5.8820ms 170.0101 Ops/s 128.7030 Ops/s $\textbf{\color{#35bf28}+32.09\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1093s 14.4602ms 69.1552 Ops/s 80.8272 Ops/s $\textbf{\color{#d91a1a}-14.44\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2721ms 1.0563ms 946.7233 Ops/s 914.0402 Ops/s $\color{#35bf28}+3.58\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1083s 5.8475ms 171.0132 Ops/s 180.7606 Ops/s $\textbf{\color{#d91a1a}-5.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.7419ms 12.4630ms 80.2375 Ops/s 80.5618 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1806ms 1.0581ms 945.1185 Ops/s 834.1422 Ops/s $\textbf{\color{#35bf28}+13.30\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1004s 6.0006ms 166.6502 Ops/s 128.9236 Ops/s $\textbf{\color{#35bf28}+29.26\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1061s 14.6648ms 68.1905 Ops/s 78.5733 Ops/s $\textbf{\color{#d91a1a}-13.21\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8252ms 1.3844ms 722.3585 Ops/s 715.9159 Ops/s $\color{#35bf28}+0.90\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1196s 0.1170s 8.5490 Ops/s 8.5620 Ops/s $\color{#d91a1a}-0.15\%$
test_sync 99.5386ms 98.5480ms 10.1473 Ops/s 10.2035 Ops/s $\color{#d91a1a}-0.55\%$
test_async 0.1923s 97.2214ms 10.2858 Ops/s 10.3714 Ops/s $\color{#d91a1a}-0.83\%$
test_single_pixels 0.1259s 0.1254s 7.9733 Ops/s 7.9565 Ops/s $\color{#35bf28}+0.21\%$
test_sync_pixels 82.5642ms 79.7875ms 12.5333 Ops/s 12.4748 Ops/s $\color{#35bf28}+0.47\%$
test_async_pixels 0.1595s 78.9050ms 12.6735 Ops/s 15.3279 Ops/s $\textbf{\color{#d91a1a}-17.32\%}$
test_simple 0.7577s 0.7492s 1.3348 Ops/s 1.3045 Ops/s $\color{#35bf28}+2.32\%$
test_transformed 1.0711s 1.0175s 0.9828 Ops/s 0.9907 Ops/s $\color{#d91a1a}-0.80\%$
test_serial 2.4980s 2.4238s 0.4126 Ops/s 0.4127 Ops/s $\color{#d91a1a}-0.04\%$
test_parallel 2.3517s 2.3015s 0.4345 Ops/s 0.4305 Ops/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-True-True-True-True] 60.3000μs 32.5958μs 30.6788 KOps/s 31.0997 KOps/s $\color{#d91a1a}-1.35\%$
test_step_mdp_speed[True-True-True-True-False] 38.8510μs 19.4562μs 51.3974 KOps/s 51.5609 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[True-True-True-False-True] 34.4100μs 18.3531μs 54.4867 KOps/s 54.5520 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[True-True-True-False-False] 27.9110μs 11.1383μs 89.7804 KOps/s 89.6335 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-False-True-True] 62.3510μs 34.3004μs 29.1542 KOps/s 29.1656 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[True-True-False-True-False] 39.3500μs 21.1696μs 47.2375 KOps/s 47.2387 KOps/s $-0.00\%$
test_step_mdp_speed[True-True-False-False-True] 36.1210μs 19.9296μs 50.1765 KOps/s 50.1320 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-False-False] 28.9100μs 12.7947μs 78.1575 KOps/s 78.7531 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[True-False-True-True-True] 53.3810μs 36.1770μs 27.6418 KOps/s 27.9222 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[True-False-True-True-False] 48.0000μs 22.9728μs 43.5297 KOps/s 43.4340 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-True-False-True] 39.7810μs 20.1903μs 49.5287 KOps/s 50.2031 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[True-False-True-False-False] 32.7800μs 12.8380μs 77.8939 KOps/s 78.7630 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[True-False-False-True-True] 56.3600μs 37.3446μs 26.7776 KOps/s 26.9769 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[True-False-False-True-False] 50.4600μs 24.8356μs 40.2647 KOps/s 40.3727 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[True-False-False-False-True] 40.1510μs 21.9967μs 45.4613 KOps/s 46.1228 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[True-False-False-False-False] 40.3200μs 14.6911μs 68.0683 KOps/s 68.9742 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-True-True-True-True] 64.0410μs 36.3882μs 27.4814 KOps/s 28.3273 KOps/s $\color{#d91a1a}-2.99\%$
test_step_mdp_speed[False-True-True-True-False] 41.3300μs 23.5215μs 42.5143 KOps/s 43.6693 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[False-True-True-False-True] 41.2000μs 24.3431μs 41.0794 KOps/s 42.3806 KOps/s $\color{#d91a1a}-3.07\%$
test_step_mdp_speed[False-True-True-False-False] 32.7900μs 14.8725μs 67.2383 KOps/s 68.2136 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-True-False-True-True] 64.7400μs 37.9188μs 26.3721 KOps/s 27.1570 KOps/s $\color{#d91a1a}-2.89\%$
test_step_mdp_speed[False-True-False-True-False] 80.7200μs 25.3483μs 39.4503 KOps/s 40.8767 KOps/s $\color{#d91a1a}-3.49\%$
test_step_mdp_speed[False-True-False-False-True] 46.4410μs 26.0765μs 38.3486 KOps/s 39.5395 KOps/s $\color{#d91a1a}-3.01\%$
test_step_mdp_speed[False-True-False-False-False] 37.5100μs 16.8354μs 59.3987 KOps/s 60.6212 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[False-False-True-True-True] 67.5810μs 39.8337μs 25.1044 KOps/s 25.1610 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-True-True-False] 52.3200μs 26.7992μs 37.3146 KOps/s 36.8590 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-False-True-False-True] 45.6600μs 25.7920μs 38.7717 KOps/s 37.9850 KOps/s $\color{#35bf28}+2.07\%$
test_step_mdp_speed[False-False-True-False-False] 38.6800μs 16.6512μs 60.0557 KOps/s 59.8772 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[False-False-False-True-True] 0.1318ms 42.6159μs 23.4654 KOps/s 23.6629 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-False-False-True-False] 49.5920μs 28.9513μs 34.5408 KOps/s 34.4791 KOps/s $\color{#35bf28}+0.18\%$
test_step_mdp_speed[False-False-False-False-True] 50.9800μs 27.3561μs 36.5549 KOps/s 35.5775 KOps/s $\color{#35bf28}+2.75\%$
test_step_mdp_speed[False-False-False-False-False] 44.6300μs 18.2681μs 54.7402 KOps/s 53.3236 KOps/s $\color{#35bf28}+2.66\%$
test_values[generalized_advantage_estimate-True-True] 24.7874ms 24.4571ms 40.8880 Ops/s 39.8594 Ops/s $\color{#35bf28}+2.58\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.3287ms 3.2270ms 309.8855 Ops/s 307.3300 Ops/s $\color{#35bf28}+0.83\%$
test_values[td0_return_estimate-False-False] 88.2300μs 63.4930μs 15.7498 KOps/s 15.6839 KOps/s $\color{#35bf28}+0.42\%$
test_values[td1_return_estimate-False-False] 51.8600ms 51.5756ms 19.3890 Ops/s 18.6943 Ops/s $\color{#35bf28}+3.72\%$
test_values[vec_td1_return_estimate-False-False] 2.0467ms 1.7550ms 569.7939 Ops/s 566.6306 Ops/s $\color{#35bf28}+0.56\%$
test_values[td_lambda_return_estimate-True-False] 82.7206ms 82.2871ms 12.1526 Ops/s 11.6810 Ops/s $\color{#35bf28}+4.04\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0660ms 1.7524ms 570.6320 Ops/s 570.5639 Ops/s $\color{#35bf28}+0.01\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.7962ms 23.5276ms 42.5034 Ops/s 42.7433 Ops/s $\color{#d91a1a}-0.56\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8763ms 0.6832ms 1.4637 KOps/s 1.4507 KOps/s $\color{#35bf28}+0.89\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7096ms 0.6434ms 1.5542 KOps/s 1.5427 KOps/s $\color{#35bf28}+0.75\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4769ms 1.4381ms 695.3641 Ops/s 692.7228 Ops/s $\color{#35bf28}+0.38\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9233ms 0.6595ms 1.5163 KOps/s 1.5009 KOps/s $\color{#35bf28}+1.03\%$
test_dqn_speed 7.8502ms 1.4411ms 693.9347 Ops/s 675.2613 Ops/s $\color{#35bf28}+2.77\%$
test_ddpg_speed 3.1801ms 2.9470ms 339.3262 Ops/s 339.5363 Ops/s $\color{#d91a1a}-0.06\%$
test_sac_speed 9.4313ms 8.4706ms 118.0547 Ops/s 117.4191 Ops/s $\color{#35bf28}+0.54\%$
test_redq_speed 11.2768ms 10.3269ms 96.8348 Ops/s 96.4153 Ops/s $\color{#35bf28}+0.44\%$
test_redq_deprec_speed 12.3199ms 11.5497ms 86.5826 Ops/s 79.7867 Ops/s $\textbf{\color{#35bf28}+8.52\%}$
test_td3_speed 17.3733ms 8.4779ms 117.9540 Ops/s 118.6321 Ops/s $\color{#d91a1a}-0.57\%$
test_cql_speed 27.4287ms 26.0278ms 38.4205 Ops/s 38.2874 Ops/s $\color{#35bf28}+0.35\%$
test_a2c_speed 5.9190ms 5.6003ms 178.5629 Ops/s 175.0797 Ops/s $\color{#35bf28}+1.99\%$
test_ppo_speed 6.1378ms 5.9079ms 169.2649 Ops/s 166.4886 Ops/s $\color{#35bf28}+1.67\%$
test_reinforce_speed 4.8455ms 4.6365ms 215.6777 Ops/s 212.5840 Ops/s $\color{#35bf28}+1.46\%$
test_iql_speed 20.6064ms 19.8931ms 50.2686 Ops/s 49.8384 Ops/s $\color{#35bf28}+0.86\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8923ms 2.7879ms 358.6899 Ops/s 357.9257 Ops/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7320ms 0.5962ms 1.6772 KOps/s 1.6796 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5027ms 0.5770ms 1.7330 KOps/s 1.7351 KOps/s $\color{#d91a1a}-0.12\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9637ms 2.7970ms 357.5309 Ops/s 353.6658 Ops/s $\color{#35bf28}+1.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7307ms 0.5848ms 1.7099 KOps/s 1.6961 KOps/s $\color{#35bf28}+0.82\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.4288ms 0.5672ms 1.7631 KOps/s 1.7556 KOps/s $\color{#35bf28}+0.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5990ms 1.5128ms 661.0187 Ops/s 651.4656 Ops/s $\color{#35bf28}+1.47\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5628ms 1.4445ms 692.2616 Ops/s 682.7057 Ops/s $\color{#35bf28}+1.40\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9952ms 2.8874ms 346.3345 Ops/s 341.4479 Ops/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3518ms 0.7267ms 1.3761 KOps/s 1.3846 KOps/s $\color{#d91a1a}-0.61\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1203s 0.8072ms 1.2389 KOps/s 1.4209 KOps/s $\textbf{\color{#d91a1a}-12.81\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9643ms 2.7799ms 359.7223 Ops/s 358.6803 Ops/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7288ms 0.6003ms 1.6658 KOps/s 1.6716 KOps/s $\color{#d91a1a}-0.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.7509ms 0.5828ms 1.7159 KOps/s 1.7260 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9625ms 2.8006ms 357.0711 Ops/s 352.3303 Ops/s $\color{#35bf28}+1.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1196s 0.7716ms 1.2960 KOps/s 1.6720 KOps/s $\textbf{\color{#d91a1a}-22.49\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7581ms 0.5670ms 1.7636 KOps/s 1.7697 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0381ms 2.9186ms 342.6262 Ops/s 338.4729 Ops/s $\color{#35bf28}+1.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8355ms 0.7296ms 1.3707 KOps/s 1.3831 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8235ms 0.7117ms 1.4050 KOps/s 1.4202 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1206s 7.1427ms 140.0023 Ops/s 101.2617 Ops/s $\textbf{\color{#35bf28}+38.26\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.7497ms 14.9204ms 67.0225 Ops/s 65.2536 Ops/s $\color{#35bf28}+2.71\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2430ms 1.2155ms 822.7258 Ops/s 825.3754 Ops/s $\color{#d91a1a}-0.32\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1196s 9.4130ms 106.2365 Ops/s 139.2070 Ops/s $\textbf{\color{#d91a1a}-23.68\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.3556ms 15.1311ms 66.0891 Ops/s 64.9623 Ops/s $\color{#35bf28}+1.73\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.4209ms 1.2433ms 804.2889 Ops/s 839.8596 Ops/s $\color{#d91a1a}-4.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1209s 7.5744ms 132.0244 Ops/s 134.0563 Ops/s $\color{#d91a1a}-1.52\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.6431ms 15.2602ms 65.5300 Ops/s 64.4339 Ops/s $\color{#35bf28}+1.70\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.6312ms 1.5584ms 641.6977 Ops/s 637.7155 Ops/s $\color{#35bf28}+0.62\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NonTensorSpec calls NonTensorData with unexpected shape argument
2 participants
@vmoens @facebook-github-bot