Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix sampling of values from NonTensorSpec #2169

Merged
merged 1 commit into from
May 22, 2024
Merged

[BugFix] Fix sampling of values from NonTensorSpec #2169

merged 1 commit into from
May 22, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 22, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2169

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 15 Unrelated Failures

As of commit 7f03378 with merge base eaa3dd8 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2024
@vmoens vmoens linked an issue May 22, 2024 that may be closed by this pull request
[BUG] NonTensorSpec calls NonTensorData with unexpected shape argument #2168
Closed
3 tasks
@vmoens vmoens added the bug Something isn't working label May 22, 2024
@vmoens vmoens merged commit a93063b into main May 22, 2024
29 of 46 checks passed
@vmoens vmoens deleted the fix-nontensorspec branch May 22, 2024 17:49
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 54.5561ms 54.1208ms 18.4772 Ops/s 18.4043 Ops/s $\color{#35bf28}+0.40\%$
test_sync 34.9992ms 29.4668ms 33.9365 Ops/s 33.3401 Ops/s $\color{#35bf28}+1.79\%$
test_async 49.2194ms 28.1636ms 35.5069 Ops/s 35.7468 Ops/s $\color{#d91a1a}-0.67\%$
test_simple 0.4019s 0.3486s 2.8690 Ops/s 2.9449 Ops/s $\color{#d91a1a}-2.58\%$
test_transformed 0.5410s 0.4919s 2.0329 Ops/s 2.0397 Ops/s $\color{#d91a1a}-0.33\%$
test_serial 1.2703s 1.2171s 0.8216 Ops/s 0.8085 Ops/s $\color{#35bf28}+1.63\%$
test_parallel 1.0614s 1.0230s 0.9775 Ops/s 0.9891 Ops/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-True-True-True-True] 0.2347ms 21.3633μs 46.8092 KOps/s 46.7361 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-True-True-False] 42.6400μs 12.8587μs 77.7684 KOps/s 75.5065 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[True-True-True-False-True] 41.3470μs 12.5939μs 79.4034 KOps/s 79.1349 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-True-False-False] 36.0870μs 7.5549μs 132.3636 KOps/s 129.7966 KOps/s $\color{#35bf28}+1.98\%$
test_step_mdp_speed[True-True-False-True-True] 48.7710μs 22.8769μs 43.7123 KOps/s 44.1009 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[True-True-False-True-False] 46.4560μs 14.0769μs 71.0386 KOps/s 69.3794 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-True-False-False-True] 39.5140μs 13.9930μs 71.4645 KOps/s 72.0882 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[True-True-False-False-False] 62.5260μs 8.6965μs 114.9890 KOps/s 111.2071 KOps/s $\color{#35bf28}+3.40\%$
test_step_mdp_speed[True-False-True-True-True] 65.4110μs 24.2975μs 41.1565 KOps/s 41.2319 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-True-True-False] 54.6720μs 15.3985μs 64.9415 KOps/s 63.3633 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[True-False-True-False-True] 70.4210μs 13.7086μs 72.9471 KOps/s 72.1039 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-False-True-False-False] 36.7080μs 8.7852μs 113.8279 KOps/s 111.6085 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[True-False-False-True-True] 67.2960μs 25.4667μs 39.2670 KOps/s 39.6309 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[True-False-False-True-False] 43.1310μs 16.6545μs 60.0438 KOps/s 59.3505 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-False-False-False-True] 55.9040μs 14.9895μs 66.7134 KOps/s 66.6252 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-False-False-False-False] 31.6790μs 10.0165μs 99.8349 KOps/s 98.6873 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[False-True-True-True-True] 66.3340μs 24.1409μs 41.4234 KOps/s 41.2971 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-True-True-True-False] 40.4750μs 15.7712μs 63.4066 KOps/s 63.2815 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[False-True-True-False-True] 50.0930μs 16.1681μs 61.8503 KOps/s 62.0384 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-True-True-False-False] 27.7820μs 10.1068μs 98.9430 KOps/s 99.2477 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[False-True-False-True-True] 52.7580μs 25.5336μs 39.1641 KOps/s 39.9389 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[False-True-False-True-False] 83.5150μs 16.6818μs 59.9454 KOps/s 59.2788 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[False-True-False-False-True] 44.5630μs 17.2379μs 58.0115 KOps/s 58.2385 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-True-False-False-False] 32.9720μs 11.1736μs 89.4968 KOps/s 87.7120 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-False-True-True-True] 52.9490μs 26.8419μs 37.2552 KOps/s 38.3281 KOps/s $\color{#d91a1a}-2.80\%$
test_step_mdp_speed[False-False-True-True-False] 72.3720μs 17.8726μs 55.9514 KOps/s 54.7458 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[False-False-True-False-True] 48.2500μs 17.3918μs 57.4983 KOps/s 57.9222 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-False-True-False-False] 32.2610μs 11.3090μs 88.4255 KOps/s 88.7401 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-False-False-True-True] 56.1850μs 28.0587μs 35.6395 KOps/s 35.9885 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[False-False-False-True-False] 51.6260μs 19.1210μs 52.2985 KOps/s 52.3578 KOps/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[False-False-False-False-True] 44.3120μs 18.5412μs 53.9338 KOps/s 55.3799 KOps/s $\color{#d91a1a}-2.61\%$
test_step_mdp_speed[False-False-False-False-False] 78.1750μs 12.4125μs 80.5637 KOps/s 80.8448 KOps/s $\color{#d91a1a}-0.35\%$
test_values[generalized_advantage_estimate-True-True] 11.8554ms 9.5637ms 104.5622 Ops/s 102.3294 Ops/s $\color{#35bf28}+2.18\%$
test_values[vec_generalized_advantage_estimate-True-True] 39.1277ms 35.0887ms 28.4992 Ops/s 28.5777 Ops/s $\color{#d91a1a}-0.27\%$
test_values[td0_return_estimate-False-False] 0.2245ms 0.1664ms 6.0079 KOps/s 5.7878 KOps/s $\color{#35bf28}+3.80\%$
test_values[td1_return_estimate-False-False] 26.3471ms 23.2080ms 43.0887 Ops/s 40.4454 Ops/s $\textbf{\color{#35bf28}+6.54\%}$
test_values[vec_td1_return_estimate-False-False] 36.3679ms 35.2030ms 28.4067 Ops/s 28.3825 Ops/s $\color{#35bf28}+0.09\%$
test_values[td_lambda_return_estimate-True-False] 35.6589ms 33.2329ms 30.0906 Ops/s 28.3955 Ops/s $\textbf{\color{#35bf28}+5.97\%}$
test_values[vec_td_lambda_return_estimate-True-False] 50.0624ms 35.7127ms 28.0012 Ops/s 28.3985 Ops/s $\color{#d91a1a}-1.40\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.1751ms 8.2332ms 121.4598 Ops/s 115.5970 Ops/s $\textbf{\color{#35bf28}+5.07\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2809ms 1.8010ms 555.2393 Ops/s 502.9930 Ops/s $\textbf{\color{#35bf28}+10.39\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4870ms 0.3485ms 2.8691 KOps/s 2.8094 KOps/s $\color{#35bf28}+2.12\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.5197ms 47.5435ms 21.0334 Ops/s 21.1027 Ops/s $\color{#d91a1a}-0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5163ms 3.0287ms 330.1758 Ops/s 329.0354 Ops/s $\color{#35bf28}+0.35\%$
test_dqn_speed 6.8689ms 1.3690ms 730.4674 Ops/s 724.1174 Ops/s $\color{#35bf28}+0.88\%$
test_ddpg_speed 3.8035ms 2.8904ms 345.9704 Ops/s 343.2330 Ops/s $\color{#35bf28}+0.80\%$
test_sac_speed 9.9434ms 8.4779ms 117.9536 Ops/s 105.7642 Ops/s $\textbf{\color{#35bf28}+11.52\%}$
test_redq_speed 13.8440ms 13.0783ms 76.4625 Ops/s 75.5197 Ops/s $\color{#35bf28}+1.25\%$
test_redq_deprec_speed 15.5021ms 13.6279ms 73.3788 Ops/s 74.4357 Ops/s $\color{#d91a1a}-1.42\%$
test_td3_speed 16.2190ms 8.5069ms 117.5523 Ops/s 117.4345 Ops/s $\color{#35bf28}+0.10\%$
test_cql_speed 39.0961ms 37.1795ms 26.8965 Ops/s 27.2008 Ops/s $\color{#d91a1a}-1.12\%$
test_a2c_speed 8.2377ms 7.5014ms 133.3082 Ops/s 133.4227 Ops/s $\color{#d91a1a}-0.09\%$
test_ppo_speed 8.8736ms 7.7500ms 129.0328 Ops/s 129.5827 Ops/s $\color{#d91a1a}-0.42\%$
test_reinforce_speed 7.2862ms 6.6981ms 149.2961 Ops/s 150.1471 Ops/s $\color{#d91a1a}-0.57\%$
test_iql_speed 34.6756ms 33.0677ms 30.2410 Ops/s 30.3419 Ops/s $\color{#d91a1a}-0.33\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3177ms 2.1185ms 472.0366 Ops/s 467.8510 Ops/s $\color{#35bf28}+0.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 87.9995ms 0.5642ms 1.7724 KOps/s 2.0054 KOps/s $\textbf{\color{#d91a1a}-11.62\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6472ms 0.4783ms 2.0906 KOps/s 2.0857 KOps/s $\color{#35bf28}+0.24\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.3755ms 2.1791ms 458.9021 Ops/s 470.8738 Ops/s $\color{#d91a1a}-2.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6974ms 0.4966ms 2.0135 KOps/s 2.0453 KOps/s $\color{#d91a1a}-1.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6453ms 0.4703ms 2.1262 KOps/s 2.1419 KOps/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.0226ms 1.2372ms 808.2668 Ops/s 803.0197 Ops/s $\color{#35bf28}+0.65\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.3601ms 1.1867ms 842.6666 Ops/s 843.6691 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3689ms 2.2883ms 436.9983 Ops/s 442.6212 Ops/s $\color{#d91a1a}-1.27\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1837ms 0.6214ms 1.6094 KOps/s 1.6304 KOps/s $\color{#d91a1a}-1.29\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.2805ms 0.5995ms 1.6681 KOps/s 1.6973 KOps/s $\color{#d91a1a}-1.72\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3891ms 2.1306ms 469.3578 Ops/s 469.2102 Ops/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0958ms 0.5061ms 1.9758 KOps/s 2.0004 KOps/s $\color{#d91a1a}-1.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5755ms 0.4786ms 2.0894 KOps/s 2.0879 KOps/s $\color{#35bf28}+0.07\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4397ms 2.1657ms 461.7472 Ops/s 472.9369 Ops/s $\color{#d91a1a}-2.37\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5934ms 0.4948ms 2.0211 KOps/s 2.0353 KOps/s $\color{#d91a1a}-0.70\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.9809ms 0.4804ms 2.0818 KOps/s 2.0944 KOps/s $\color{#d91a1a}-0.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3127ms 2.2934ms 436.0370 Ops/s 446.0043 Ops/s $\color{#d91a1a}-2.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1979ms 0.6181ms 1.6179 KOps/s 1.6321 KOps/s $\color{#d91a1a}-0.87\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8296ms 0.6011ms 1.6637 KOps/s 1.6777 KOps/s $\color{#d91a1a}-0.83\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1069s 7.5761ms 131.9938 Ops/s 131.0830 Ops/s $\color{#35bf28}+0.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.8470ms 12.5490ms 79.6873 Ops/s 79.1502 Ops/s $\color{#35bf28}+0.68\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2106ms 1.0527ms 949.9525 Ops/s 950.0932 Ops/s $\color{#d91a1a}-0.01\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 98.5925ms 5.5147ms 181.3332 Ops/s 180.1261 Ops/s $\color{#35bf28}+0.67\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1076s 14.3584ms 69.6458 Ops/s 74.4080 Ops/s $\textbf{\color{#d91a1a}-6.40\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1385ms 1.0503ms 952.0742 Ops/s 824.7092 Ops/s $\textbf{\color{#35bf28}+15.44\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.6761ms 5.9131ms 169.1164 Ops/s 127.0774 Ops/s $\textbf{\color{#35bf28}+33.08\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4781ms 12.8547ms 77.7926 Ops/s 77.4592 Ops/s $\color{#35bf28}+0.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.2161ms 1.4357ms 696.5024 Ops/s 725.6147 Ops/s $\color{#d91a1a}-4.01\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1176s 0.1168s 8.5622 Ops/s 8.4417 Ops/s $\color{#35bf28}+1.43\%$
test_sync 0.1059s 0.1013s 9.8698 Ops/s 10.1254 Ops/s $\color{#d91a1a}-2.52\%$
test_async 0.1937s 96.5946ms 10.3525 Ops/s 10.3879 Ops/s $\color{#d91a1a}-0.34\%$
test_single_pixels 0.1269s 0.1263s 7.9158 Ops/s 7.7453 Ops/s $\color{#35bf28}+2.20\%$
test_sync_pixels 83.6780ms 80.6074ms 12.4058 Ops/s 12.2332 Ops/s $\color{#35bf28}+1.41\%$
test_async_pixels 0.1660s 69.9762ms 14.2906 Ops/s 12.8105 Ops/s $\textbf{\color{#35bf28}+11.55\%}$
test_simple 0.8460s 0.7796s 1.2828 Ops/s 1.2849 Ops/s $\color{#d91a1a}-0.17\%$
test_transformed 1.0870s 1.0285s 0.9723 Ops/s 0.9683 Ops/s $\color{#35bf28}+0.42\%$
test_serial 2.5290s 2.4703s 0.4048 Ops/s 0.4036 Ops/s $\color{#35bf28}+0.29\%$
test_parallel 2.4384s 2.3375s 0.4278 Ops/s 0.4317 Ops/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-True-True-True-True] 99.9120μs 32.9232μs 30.3737 KOps/s 30.8596 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[True-True-True-True-False] 86.1520μs 19.7630μs 50.5996 KOps/s 51.0627 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-True-True-False-True] 0.1070ms 18.8554μs 53.0353 KOps/s 53.5781 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[True-True-True-False-False] 47.1700μs 11.2718μs 88.7168 KOps/s 90.1961 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-True-False-True-True] 67.5410μs 34.4678μs 29.0126 KOps/s 29.6670 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[True-True-False-True-False] 44.1910μs 21.4655μs 46.5864 KOps/s 46.5280 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-True-False-False-True] 48.1910μs 20.6132μs 48.5126 KOps/s 49.2326 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[True-True-False-False-False] 47.3810μs 12.9902μs 76.9813 KOps/s 77.1591 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-False-True-True-True] 61.2910μs 36.3773μs 27.4896 KOps/s 28.0490 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[True-False-True-True-False] 49.4510μs 23.1140μs 43.2637 KOps/s 43.5199 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[True-False-True-False-True] 73.9710μs 20.2897μs 49.2861 KOps/s 50.1249 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-True-False-False] 63.2820μs 12.9702μs 77.1001 KOps/s 76.6133 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[True-False-False-True-True] 0.1852ms 38.1137μs 26.2373 KOps/s 26.2726 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-False-False-True-False] 52.0610μs 25.0725μs 39.8844 KOps/s 40.2006 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[True-False-False-False-True] 0.1082ms 22.0754μs 45.2994 KOps/s 46.0840 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[True-False-False-False-False] 39.6110μs 14.7596μs 67.7526 KOps/s 67.9122 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-True-True-True-True] 0.2014ms 36.4191μs 27.4581 KOps/s 28.2603 KOps/s $\color{#d91a1a}-2.84\%$
test_step_mdp_speed[False-True-True-True-False] 0.2020ms 23.3063μs 42.9068 KOps/s 43.6609 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[False-True-True-False-True] 0.2265ms 25.3678μs 39.4201 KOps/s 41.3330 KOps/s $\color{#d91a1a}-4.63\%$
test_step_mdp_speed[False-True-True-False-False] 65.1120μs 15.1191μs 66.1416 KOps/s 68.6363 KOps/s $\color{#d91a1a}-3.63\%$
test_step_mdp_speed[False-True-False-True-True] 64.7520μs 38.1145μs 26.2367 KOps/s 26.9494 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[False-True-False-True-False] 50.6510μs 25.2187μs 39.6532 KOps/s 40.6743 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[False-True-False-False-True] 52.2810μs 26.6563μs 37.5146 KOps/s 39.1498 KOps/s $\color{#d91a1a}-4.18\%$
test_step_mdp_speed[False-True-False-False-False] 73.1810μs 16.7912μs 59.5550 KOps/s 60.8338 KOps/s $\color{#d91a1a}-2.10\%$
test_step_mdp_speed[False-False-True-True-True] 69.4910μs 40.1660μs 24.8967 KOps/s 25.3243 KOps/s $\color{#d91a1a}-1.69\%$
test_step_mdp_speed[False-False-True-True-False] 55.4310μs 27.2979μs 36.6328 KOps/s 37.1468 KOps/s $\color{#d91a1a}-1.38\%$
test_step_mdp_speed[False-False-True-False-True] 49.6310μs 26.3185μs 37.9961 KOps/s 38.9085 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-False-True-False-False] 41.1310μs 16.8264μs 59.4303 KOps/s 61.3232 KOps/s $\color{#d91a1a}-3.09\%$
test_step_mdp_speed[False-False-False-True-True] 69.7910μs 42.6229μs 23.4615 KOps/s 23.5189 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[False-False-False-True-False] 0.1200ms 29.2233μs 34.2193 KOps/s 34.7344 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[False-False-False-False-True] 50.8210μs 28.1289μs 35.5506 KOps/s 35.2878 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-False-False-False] 50.6100μs 18.5392μs 53.9398 KOps/s 55.2379 KOps/s $\color{#d91a1a}-2.35\%$
test_values[generalized_advantage_estimate-True-True] 28.0445ms 27.6896ms 36.1147 Ops/s 38.3187 Ops/s $\textbf{\color{#d91a1a}-5.75\%}$
test_values[vec_generalized_advantage_estimate-True-True] 82.7901ms 3.2339ms 309.2217 Ops/s 311.2460 Ops/s $\color{#d91a1a}-0.65\%$
test_values[td0_return_estimate-False-False] 89.3720μs 64.9999μs 15.3846 KOps/s 15.9329 KOps/s $\color{#d91a1a}-3.44\%$
test_values[td1_return_estimate-False-False] 59.7729ms 59.0270ms 16.9414 Ops/s 18.4141 Ops/s $\textbf{\color{#d91a1a}-8.00\%}$
test_values[vec_td1_return_estimate-False-False] 2.1000ms 1.7854ms 560.0996 Ops/s 566.4075 Ops/s $\color{#d91a1a}-1.11\%$
test_values[td_lambda_return_estimate-True-False] 95.0603ms 94.1524ms 10.6211 Ops/s 11.4452 Ops/s $\textbf{\color{#d91a1a}-7.20\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1247ms 1.7792ms 562.0477 Ops/s 566.7155 Ops/s $\color{#d91a1a}-0.82\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 26.5644ms 26.1881ms 38.1853 Ops/s 41.2435 Ops/s $\textbf{\color{#d91a1a}-7.42\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9258ms 0.7174ms 1.3938 KOps/s 1.4311 KOps/s $\color{#d91a1a}-2.61\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8669ms 0.6890ms 1.4514 KOps/s 1.5242 KOps/s $\color{#d91a1a}-4.77\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.7426ms 1.4794ms 675.9346 Ops/s 687.8325 Ops/s $\color{#d91a1a}-1.73\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9773ms 0.6779ms 1.4752 KOps/s 1.4922 KOps/s $\color{#d91a1a}-1.14\%$
test_dqn_speed 1.7098ms 1.4628ms 683.6087 Ops/s 669.9015 Ops/s $\color{#35bf28}+2.05\%$
test_ddpg_speed 3.2526ms 3.0081ms 332.4335 Ops/s 327.3540 Ops/s $\color{#35bf28}+1.55\%$
test_sac_speed 9.0434ms 8.6436ms 115.6929 Ops/s 111.9864 Ops/s $\color{#35bf28}+3.31\%$
test_redq_speed 11.4797ms 10.5510ms 94.7779 Ops/s 93.0847 Ops/s $\color{#35bf28}+1.82\%$
test_redq_deprec_speed 14.5539ms 12.0322ms 83.1102 Ops/s 83.1064 Ops/s $+0.00\%$
test_td3_speed 17.5635ms 8.6414ms 115.7221 Ops/s 115.1406 Ops/s $\color{#35bf28}+0.51\%$
test_cql_speed 27.0934ms 26.1724ms 38.2082 Ops/s 37.2954 Ops/s $\color{#35bf28}+2.45\%$
test_a2c_speed 5.9946ms 5.6816ms 176.0061 Ops/s 172.8935 Ops/s $\color{#35bf28}+1.80\%$
test_ppo_speed 6.3180ms 5.9938ms 166.8379 Ops/s 162.4542 Ops/s $\color{#35bf28}+2.70\%$
test_reinforce_speed 5.5009ms 4.6811ms 213.6257 Ops/s 209.0485 Ops/s $\color{#35bf28}+2.19\%$
test_iql_speed 20.5302ms 19.8201ms 50.4538 Ops/s 48.4157 Ops/s $\color{#35bf28}+4.21\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0302ms 2.8507ms 350.7963 Ops/s 352.1526 Ops/s $\color{#d91a1a}-0.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3236ms 0.5999ms 1.6669 KOps/s 1.6385 KOps/s $\color{#35bf28}+1.73\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8260ms 0.5773ms 1.7322 KOps/s 1.7034 KOps/s $\color{#35bf28}+1.69\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1578ms 2.8476ms 351.1753 Ops/s 349.8918 Ops/s $\color{#35bf28}+0.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2217ms 0.5900ms 1.6949 KOps/s 1.6653 KOps/s $\color{#35bf28}+1.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8607ms 0.5681ms 1.7603 KOps/s 1.7048 KOps/s $\color{#35bf28}+3.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8068ms 1.5865ms 630.3303 Ops/s 620.5531 Ops/s $\color{#35bf28}+1.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 5.6921ms 1.5198ms 657.9813 Ops/s 655.8697 Ops/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2751ms 2.9778ms 335.8171 Ops/s 339.4811 Ops/s $\color{#d91a1a}-1.08\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9026ms 0.7388ms 1.3535 KOps/s 1.3411 KOps/s $\color{#35bf28}+0.93\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1213s 0.8246ms 1.2127 KOps/s 1.3859 KOps/s $\textbf{\color{#d91a1a}-12.50\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9964ms 2.8334ms 352.9274 Ops/s 354.7595 Ops/s $\color{#d91a1a}-0.52\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4005ms 0.6052ms 1.6524 KOps/s 1.6276 KOps/s $\color{#35bf28}+1.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7726ms 0.5786ms 1.7284 KOps/s 1.6854 KOps/s $\color{#35bf28}+2.55\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0954ms 2.8545ms 350.3270 Ops/s 353.0909 Ops/s $\color{#d91a1a}-0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7737ms 0.5934ms 1.6852 KOps/s 1.6634 KOps/s $\color{#35bf28}+1.31\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1184s 0.7527ms 1.3285 KOps/s 1.7301 KOps/s $\textbf{\color{#d91a1a}-23.21\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2420ms 2.9711ms 336.5737 Ops/s 338.5077 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4804ms 0.7332ms 1.3638 KOps/s 1.3411 KOps/s $\color{#35bf28}+1.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8901ms 0.7131ms 1.4024 KOps/s 1.3861 KOps/s $\color{#35bf28}+1.17\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1239s 7.2771ms 137.4175 Ops/s 100.2117 Ops/s $\textbf{\color{#35bf28}+37.13\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1264s 18.0860ms 55.2913 Ops/s 61.5806 Ops/s $\textbf{\color{#d91a1a}-10.21\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2504ms 1.1775ms 849.2494 Ops/s 804.5243 Ops/s $\textbf{\color{#35bf28}+5.56\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1161s 7.1959ms 138.9675 Ops/s 137.6764 Ops/s $\color{#35bf28}+0.94\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.2869ms 15.8023ms 63.2820 Ops/s 62.3001 Ops/s $\color{#35bf28}+1.58\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.6284ms 1.3164ms 759.6717 Ops/s 809.1713 Ops/s $\textbf{\color{#d91a1a}-6.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1176s 7.5509ms 132.4344 Ops/s 131.6036 Ops/s $\color{#35bf28}+0.63\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5951ms 16.0887ms 62.1555 Ops/s 62.1196 Ops/s $\color{#35bf28}+0.06\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.4344ms 1.7151ms 583.0732 Ops/s 621.5493 Ops/s $\textbf{\color{#d91a1a}-6.19\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NonTensorSpec calls NonTensorData with unexpected shape argument
2 participants
@vmoens @facebook-github-bot