Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update README.md #2155

Merged
merged 3 commits into from
May 6, 2024
Merged

[Doc] Update README.md #2155

merged 3 commits into from
May 6, 2024

Conversation

KPCOFGS
Copy link

@KPCOFGS KPCOFGS commented May 6, 2024

Description

Modified all relative links to absolute links

Motivation and Context

PyPI document compatibility issue. Relative links on PyPI will lead to page not found

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2155

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 6 Unrelated Failures

As of commit b21e9bb with merge base 730cfb4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2024
@KPCOFGS KPCOFGS changed the title Update README.md [Documentation]Update README.md May 6, 2024
@vmoens
Copy link
Contributor

vmoens commented May 6, 2024

Thanks for this! Two very similar PRs were shipped simultaneously, can you make this mergeable by solving the few conflicts?
Thanks for contributing!

@KPCOFGS
Copy link
Author

KPCOFGS commented May 6, 2024 •
edited
Loading

Hello! Thank you for your feedback. I just resolved the conflicts.

@vmoens vmoens changed the title [Documentation]Update README.md [Doc] Update README.md May 6, 2024
@vmoens vmoens added documentation Improvements or additions to documentation ciflow/docs tests full docs CI labels May 6, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 6, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

vmoens
vmoens approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit 0707e07 into pytorch:main May 6, 2024
45 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
ciflow/docs tests full docs CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KPCOFGS @vmoens @facebook-github-bot