Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Code quality improvements #2140

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[Minor] Code quality improvements #2140

merged 1 commit into from
Apr 30, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 30, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2140

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 10 Unrelated Failures

As of commit 6f4f624 with merge base c25ec59 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2024
@vmoens vmoens added the quality code quality label Apr 30, 2024
@vmoens vmoens merged commit 68101b0 into main Apr 30, 2024
35 of 47 checks passed
@vmoens vmoens deleted the fix-tests-cuda branch April 30, 2024 09:07
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 55.2738ms 53.7818ms 18.5937 Ops/s 18.0367 Ops/s $\color{#35bf28}+3.09\%$
test_sync 37.5589ms 31.1454ms 32.1075 Ops/s 33.7136 Ops/s $\color{#d91a1a}-4.76\%$
test_async 71.3167ms 30.0192ms 33.3120 Ops/s 34.6069 Ops/s $\color{#d91a1a}-3.74\%$
test_simple 0.4108s 0.3498s 2.8591 Ops/s 2.9084 Ops/s $\color{#d91a1a}-1.70\%$
test_transformed 0.4859s 0.4838s 2.0669 Ops/s 2.0257 Ops/s $\color{#35bf28}+2.03\%$
test_serial 1.2706s 1.2098s 0.8266 Ops/s 0.8051 Ops/s $\color{#35bf28}+2.68\%$
test_parallel 1.1174s 1.0396s 0.9619 Ops/s 0.9787 Ops/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[True-True-True-True-True] 76.5120μs 21.7552μs 45.9660 KOps/s 44.6853 KOps/s $\color{#35bf28}+2.87\%$
test_step_mdp_speed[True-True-True-True-False] 71.7130μs 13.4062μs 74.5924 KOps/s 73.8986 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[True-True-True-False-True] 44.6430μs 12.6981μs 78.7517 KOps/s 77.2326 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[True-True-True-False-False] 37.2890μs 7.8444μs 127.4793 KOps/s 126.3362 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-True-False-True-True] 58.2380μs 23.0551μs 43.3743 KOps/s 42.4629 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-True-False-True-False] 44.7020μs 14.6322μs 68.3423 KOps/s 66.4489 KOps/s $\color{#35bf28}+2.85\%$
test_step_mdp_speed[True-True-False-False-True] 41.9380μs 14.0302μs 71.2748 KOps/s 69.8560 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-True-False-False-False] 35.8960μs 9.0534μs 110.4563 KOps/s 107.4419 KOps/s $\color{#35bf28}+2.81\%$
test_step_mdp_speed[True-False-True-True-True] 54.8420μs 24.7361μs 40.4267 KOps/s 39.8763 KOps/s $\color{#35bf28}+1.38\%$
test_step_mdp_speed[True-False-True-True-False] 54.3510μs 16.0481μs 62.3126 KOps/s 60.5169 KOps/s $\color{#35bf28}+2.97\%$
test_step_mdp_speed[True-False-True-False-True] 40.7260μs 14.0342μs 71.2547 KOps/s 69.5890 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-False-True-False-False] 46.3660μs 9.1626μs 109.1391 KOps/s 106.5941 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-False-False-True-True] 57.0960μs 25.7867μs 38.7797 KOps/s 37.8449 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-False-False-True-False] 47.4680μs 17.1802μs 58.2065 KOps/s 55.9782 KOps/s $\color{#35bf28}+3.98\%$
test_step_mdp_speed[True-False-False-False-True] 40.7860μs 15.2620μs 65.5221 KOps/s 63.8732 KOps/s $\color{#35bf28}+2.58\%$
test_step_mdp_speed[True-False-False-False-False] 66.9840μs 10.1694μs 98.3345 KOps/s 94.2407 KOps/s $\color{#35bf28}+4.34\%$
test_step_mdp_speed[False-True-True-True-True] 59.0200μs 24.4769μs 40.8549 KOps/s 39.7566 KOps/s $\color{#35bf28}+2.76\%$
test_step_mdp_speed[False-True-True-True-False] 43.9920μs 16.0175μs 62.4315 KOps/s 60.3713 KOps/s $\color{#35bf28}+3.41\%$
test_step_mdp_speed[False-True-True-False-True] 56.2750μs 16.2970μs 61.3609 KOps/s 59.2794 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-True-True-False-False] 36.6680μs 10.3573μs 96.5500 KOps/s 93.9476 KOps/s $\color{#35bf28}+2.77\%$
test_step_mdp_speed[False-True-False-True-True] 49.3010μs 25.7000μs 38.9104 KOps/s 38.0892 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[False-True-False-True-False] 48.0890μs 17.3748μs 57.5547 KOps/s 56.1349 KOps/s $\color{#35bf28}+2.53\%$
test_step_mdp_speed[False-True-False-False-True] 72.3940μs 17.4752μs 57.2241 KOps/s 55.2309 KOps/s $\color{#35bf28}+3.61\%$
test_step_mdp_speed[False-True-False-False-False] 36.5480μs 11.4845μs 87.0740 KOps/s 83.8950 KOps/s $\color{#35bf28}+3.79\%$
test_step_mdp_speed[False-False-True-True-True] 61.0730μs 26.8830μs 37.1982 KOps/s 35.7580 KOps/s $\color{#35bf28}+4.03\%$
test_step_mdp_speed[False-False-True-True-False] 43.7710μs 18.5688μs 53.8538 KOps/s 52.4580 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[False-False-True-False-True] 59.0200μs 17.5853μs 56.8656 KOps/s 54.8206 KOps/s $\color{#35bf28}+3.73\%$
test_step_mdp_speed[False-False-True-False-False] 59.0100μs 11.6187μs 86.0679 KOps/s 83.1087 KOps/s $\color{#35bf28}+3.56\%$
test_step_mdp_speed[False-False-False-True-True] 54.2210μs 28.0915μs 35.5979 KOps/s 34.2467 KOps/s $\color{#35bf28}+3.95\%$
test_step_mdp_speed[False-False-False-True-False] 83.5770μs 19.2129μs 52.0484 KOps/s 49.3687 KOps/s $\textbf{\color{#35bf28}+5.43\%}$
test_step_mdp_speed[False-False-False-False-True] 67.5940μs 18.5241μs 53.9836 KOps/s 52.5510 KOps/s $\color{#35bf28}+2.73\%$
test_step_mdp_speed[False-False-False-False-False] 43.6410μs 12.4244μs 80.4866 KOps/s 77.3728 KOps/s $\color{#35bf28}+4.02\%$
test_values[generalized_advantage_estimate-True-True] 9.9841ms 9.6715ms 103.3969 Ops/s 106.0607 Ops/s $\color{#d91a1a}-2.51\%$
test_values[vec_generalized_advantage_estimate-True-True] 39.1184ms 35.5998ms 28.0900 Ops/s 29.7221 Ops/s $\textbf{\color{#d91a1a}-5.49\%}$
test_values[td0_return_estimate-False-False] 0.2150ms 0.1806ms 5.5379 KOps/s 5.9700 KOps/s $\textbf{\color{#d91a1a}-7.24\%}$
test_values[td1_return_estimate-False-False] 24.7924ms 24.3686ms 41.0364 Ops/s 42.1044 Ops/s $\color{#d91a1a}-2.54\%$
test_values[vec_td1_return_estimate-False-False] 51.3457ms 36.3967ms 27.4750 Ops/s 29.1697 Ops/s $\textbf{\color{#d91a1a}-5.81\%}$
test_values[td_lambda_return_estimate-True-False] 37.6167ms 34.6424ms 28.8664 Ops/s 29.0977 Ops/s $\color{#d91a1a}-0.79\%$
test_values[vec_td_lambda_return_estimate-True-False] 39.9029ms 35.9485ms 27.8175 Ops/s 29.1444 Ops/s $\color{#d91a1a}-4.55\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 12.1341ms 8.2053ms 121.8731 Ops/s 120.3244 Ops/s $\color{#35bf28}+1.29\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4331ms 1.9718ms 507.1435 Ops/s 541.8968 Ops/s $\textbf{\color{#d91a1a}-6.41\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4841ms 0.3541ms 2.8243 KOps/s 2.8048 KOps/s $\color{#35bf28}+0.70\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.3989ms 46.0407ms 21.7199 Ops/s 20.9691 Ops/s $\color{#35bf28}+3.58\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2100ms 3.0482ms 328.0660 Ops/s 326.7389 Ops/s $\color{#35bf28}+0.41\%$
test_dqn_speed 6.6957ms 1.3823ms 723.4100 Ops/s 713.3543 Ops/s $\color{#35bf28}+1.41\%$
test_ddpg_speed 3.4452ms 2.9321ms 341.0529 Ops/s 339.0192 Ops/s $\color{#35bf28}+0.60\%$
test_sac_speed 11.4542ms 9.0883ms 110.0317 Ops/s 112.8674 Ops/s $\color{#d91a1a}-2.51\%$
test_redq_speed 15.6926ms 13.8352ms 72.2792 Ops/s 72.1909 Ops/s $\color{#35bf28}+0.12\%$
test_redq_deprec_speed 16.9855ms 15.1037ms 66.2089 Ops/s 69.7120 Ops/s $\textbf{\color{#d91a1a}-5.03\%}$
test_td3_speed 11.2693ms 8.9386ms 111.8748 Ops/s 113.6484 Ops/s $\color{#d91a1a}-1.56\%$
test_cql_speed 38.7688ms 37.5923ms 26.6012 Ops/s 26.6717 Ops/s $\color{#d91a1a}-0.26\%$
test_a2c_speed 8.9850ms 7.9587ms 125.6493 Ops/s 127.7067 Ops/s $\color{#d91a1a}-1.61\%$
test_ppo_speed 10.1120ms 8.0115ms 124.8202 Ops/s 123.5231 Ops/s $\color{#35bf28}+1.05\%$
test_reinforce_speed 9.1185ms 6.9431ms 144.0275 Ops/s 148.0388 Ops/s $\color{#d91a1a}-2.71\%$
test_iql_speed 35.1464ms 33.6758ms 29.6949 Ops/s 29.6422 Ops/s $\color{#35bf28}+0.18\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9072ms 2.3315ms 428.9111 Ops/s 423.2344 Ops/s $\color{#35bf28}+1.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9013ms 0.5112ms 1.9563 KOps/s 1.9867 KOps/s $\color{#d91a1a}-1.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7316ms 0.4844ms 2.0644 KOps/s 2.0672 KOps/s $\color{#d91a1a}-0.13\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5761ms 2.4248ms 412.3967 Ops/s 404.4546 Ops/s $\color{#35bf28}+1.96\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0150ms 0.5121ms 1.9526 KOps/s 2.0029 KOps/s $\color{#d91a1a}-2.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8818ms 0.4850ms 2.0617 KOps/s 2.0838 KOps/s $\color{#d91a1a}-1.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8068ms 1.2395ms 806.7590 Ops/s 797.3784 Ops/s $\color{#35bf28}+1.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6539ms 1.1689ms 855.5143 Ops/s 850.4375 Ops/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7176ms 2.4849ms 402.4371 Ops/s 424.5423 Ops/s $\textbf{\color{#d91a1a}-5.21\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9450ms 0.6319ms 1.5824 KOps/s 1.5880 KOps/s $\color{#d91a1a}-0.35\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.9857ms 0.6056ms 1.6512 KOps/s 1.6878 KOps/s $\color{#d91a1a}-2.17\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.4504ms 2.2861ms 437.4189 Ops/s 442.5663 Ops/s $\color{#d91a1a}-1.16\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8410ms 0.5099ms 1.9614 KOps/s 2.0222 KOps/s $\color{#d91a1a}-3.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.8228ms 0.4886ms 2.0468 KOps/s 2.0571 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9309ms 2.3794ms 420.2719 Ops/s 427.1598 Ops/s $\color{#d91a1a}-1.61\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8581ms 0.5109ms 1.9572 KOps/s 2.0264 KOps/s $\color{#d91a1a}-3.42\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7027ms 0.4801ms 2.0830 KOps/s 2.1219 KOps/s $\color{#d91a1a}-1.83\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7832ms 2.4581ms 406.8235 Ops/s 410.2600 Ops/s $\color{#d91a1a}-0.84\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7864ms 0.6250ms 1.6001 KOps/s 1.5847 KOps/s $\color{#35bf28}+0.97\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.6993ms 0.6151ms 1.6257 KOps/s 1.6355 KOps/s $\color{#d91a1a}-0.60\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1256s 8.5845ms 116.4888 Ops/s 119.7124 Ops/s $\color{#d91a1a}-2.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.0677ms 12.3508ms 80.9665 Ops/s 81.5038 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.9507ms 1.0789ms 926.8310 Ops/s 946.7993 Ops/s $\color{#d91a1a}-2.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1166s 5.9534ms 167.9700 Ops/s 169.8045 Ops/s $\color{#d91a1a}-1.08\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.3851ms 12.1107ms 82.5713 Ops/s 69.3821 Ops/s $\textbf{\color{#35bf28}+19.01\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5713ms 1.0596ms 943.7383 Ops/s 914.2465 Ops/s $\color{#35bf28}+3.23\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1078s 8.0480ms 124.2549 Ops/s 154.2648 Ops/s $\textbf{\color{#d91a1a}-19.45\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4891ms 12.8134ms 78.0434 Ops/s 77.8038 Ops/s $\color{#35bf28}+0.31\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9271ms 1.3720ms 728.8494 Ops/s 699.7749 Ops/s $\color{#35bf28}+4.15\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1162s 0.1151s 8.6852 Ops/s 8.5021 Ops/s $\color{#35bf28}+2.15\%$
test_sync 0.1031s 0.1017s 9.8284 Ops/s 9.6210 Ops/s $\color{#35bf28}+2.16\%$
test_async 0.1929s 97.4394ms 10.2628 Ops/s 10.2185 Ops/s $\color{#35bf28}+0.43\%$
test_single_pixels 0.1265s 0.1256s 7.9646 Ops/s 7.9042 Ops/s $\color{#35bf28}+0.76\%$
test_sync_pixels 0.1413s 85.4286ms 11.7057 Ops/s 11.5270 Ops/s $\color{#35bf28}+1.55\%$
test_async_pixels 0.1596s 80.5372ms 12.4166 Ops/s 14.2165 Ops/s $\textbf{\color{#d91a1a}-12.66\%}$
test_simple 0.7545s 0.7517s 1.3304 Ops/s 1.2866 Ops/s $\color{#35bf28}+3.40\%$
test_transformed 1.0061s 1.0045s 0.9955 Ops/s 0.9799 Ops/s $\color{#35bf28}+1.59\%$
test_serial 2.4759s 2.4185s 0.4135 Ops/s 0.4106 Ops/s $\color{#35bf28}+0.70\%$
test_parallel 2.4185s 2.3124s 0.4324 Ops/s 0.4321 Ops/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[True-True-True-True-True] 0.1383ms 32.9176μs 30.3789 KOps/s 30.4188 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-True-True-True-False] 41.5300μs 20.0164μs 49.9590 KOps/s 49.9295 KOps/s $\color{#35bf28}+0.06\%$
test_step_mdp_speed[True-True-True-False-True] 45.5910μs 18.7827μs 53.2405 KOps/s 52.9694 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[True-True-True-False-False] 34.5910μs 11.3277μs 88.2795 KOps/s 88.0780 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-False-True-True] 49.9410μs 34.4449μs 29.0319 KOps/s 28.5939 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[True-True-False-True-False] 36.2410μs 21.4342μs 46.6543 KOps/s 46.0057 KOps/s $\color{#35bf28}+1.41\%$
test_step_mdp_speed[True-True-False-False-True] 40.9110μs 20.3928μs 49.0369 KOps/s 48.2429 KOps/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[True-True-False-False-False] 29.9000μs 13.2165μs 75.6630 KOps/s 76.2564 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[True-False-True-True-True] 63.0510μs 36.9631μs 27.0540 KOps/s 27.0541 KOps/s $-0.00\%$
test_step_mdp_speed[True-False-True-True-False] 40.4310μs 23.9439μs 41.7644 KOps/s 42.0713 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[True-False-True-False-True] 39.1500μs 20.6942μs 48.3226 KOps/s 48.4594 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[True-False-True-False-False] 34.5400μs 13.2937μs 75.2234 KOps/s 75.8257 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[True-False-False-True-True] 59.6110μs 38.6889μs 25.8472 KOps/s 25.9879 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[True-False-False-True-False] 50.1700μs 25.4819μs 39.2435 KOps/s 39.1359 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-False-False-False-True] 50.5400μs 22.2588μs 44.9260 KOps/s 44.6644 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[True-False-False-False-False] 30.2210μs 14.8652μs 67.2714 KOps/s 65.8880 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-True-True-True-True] 55.9110μs 36.8612μs 27.1288 KOps/s 27.0995 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[False-True-True-True-False] 48.7310μs 23.8650μs 41.9024 KOps/s 42.2775 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-True-True-False-True] 42.4610μs 24.7638μs 40.3816 KOps/s 40.7808 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[False-True-True-False-False] 40.6010μs 15.0830μs 66.2997 KOps/s 67.5064 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-True-False-True-True] 69.1010μs 38.7251μs 25.8230 KOps/s 25.7145 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-True-False-True-False] 44.2700μs 25.6266μs 39.0219 KOps/s 39.6431 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-True-False-False-True] 44.4810μs 25.9142μs 38.5889 KOps/s 37.7903 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[False-True-False-False-False] 36.9810μs 16.8197μs 59.4540 KOps/s 60.5186 KOps/s $\color{#d91a1a}-1.76\%$
test_step_mdp_speed[False-False-True-True-True] 0.1163ms 40.2779μs 24.8275 KOps/s 24.9642 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[False-False-True-True-False] 52.8210μs 27.4662μs 36.4084 KOps/s 36.2921 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[False-False-True-False-True] 41.3810μs 25.9079μs 38.5983 KOps/s 38.2199 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-False-True-False-False] 31.6300μs 16.8627μs 59.3026 KOps/s 60.2389 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-False-False-True-True] 63.6010μs 42.8080μs 23.3601 KOps/s 23.2080 KOps/s $\color{#35bf28}+0.66\%$
test_step_mdp_speed[False-False-False-True-False] 54.2810μs 29.6948μs 33.6759 KOps/s 33.9454 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-False-False-False-True] 53.6210μs 27.6084μs 36.2208 KOps/s 36.3816 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[False-False-False-False-False] 45.9400μs 18.4898μs 54.0839 KOps/s 54.6907 KOps/s $\color{#d91a1a}-1.11\%$
test_values[generalized_advantage_estimate-True-True] 24.8984ms 24.1898ms 41.3398 Ops/s 40.9886 Ops/s $\color{#35bf28}+0.86\%$
test_values[vec_generalized_advantage_estimate-True-True] 81.6053ms 3.2021ms 312.2927 Ops/s 310.0445 Ops/s $\color{#35bf28}+0.73\%$
test_values[td0_return_estimate-False-False] 91.1810μs 64.0417μs 15.6148 KOps/s 15.7073 KOps/s $\color{#d91a1a}-0.59\%$
test_values[td1_return_estimate-False-False] 52.3648ms 51.2106ms 19.5272 Ops/s 19.5284 Ops/s $-0.01\%$
test_values[vec_td1_return_estimate-False-False] 2.0443ms 1.7593ms 568.4187 Ops/s 566.1399 Ops/s $\color{#35bf28}+0.40\%$
test_values[td_lambda_return_estimate-True-False] 82.8372ms 81.2194ms 12.3123 Ops/s 12.1318 Ops/s $\color{#35bf28}+1.49\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0678ms 1.7578ms 568.9045 Ops/s 567.6618 Ops/s $\color{#35bf28}+0.22\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.5596ms 23.1147ms 43.2624 Ops/s 43.2455 Ops/s $\color{#35bf28}+0.04\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9286ms 0.6881ms 1.4533 KOps/s 1.4508 KOps/s $\color{#35bf28}+0.17\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7059ms 0.6422ms 1.5573 KOps/s 1.5336 KOps/s $\color{#35bf28}+1.54\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5019ms 1.4432ms 692.8817 Ops/s 691.0050 Ops/s $\color{#35bf28}+0.27\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9362ms 0.6599ms 1.5154 KOps/s 1.4700 KOps/s $\color{#35bf28}+3.09\%$
test_dqn_speed 7.8272ms 1.4391ms 694.8622 Ops/s 685.4012 Ops/s $\color{#35bf28}+1.38\%$
test_ddpg_speed 3.2060ms 2.9585ms 338.0122 Ops/s 339.6928 Ops/s $\color{#d91a1a}-0.49\%$
test_sac_speed 9.5113ms 8.4991ms 117.6597 Ops/s 117.4687 Ops/s $\color{#35bf28}+0.16\%$
test_redq_speed 98.7754ms 11.1737ms 89.4958 Ops/s 95.5024 Ops/s $\textbf{\color{#d91a1a}-6.29\%}$
test_redq_deprec_speed 12.4678ms 11.9567ms 83.6351 Ops/s 87.6879 Ops/s $\color{#d91a1a}-4.62\%$
test_td3_speed 8.6090ms 8.4644ms 118.1416 Ops/s 105.2437 Ops/s $\textbf{\color{#35bf28}+12.26\%}$
test_cql_speed 27.4224ms 26.2432ms 38.1051 Ops/s 38.2885 Ops/s $\color{#d91a1a}-0.48\%$
test_a2c_speed 6.0407ms 5.8371ms 171.3181 Ops/s 173.6396 Ops/s $\color{#d91a1a}-1.34\%$
test_ppo_speed 6.3081ms 6.0418ms 165.5140 Ops/s 166.6805 Ops/s $\color{#d91a1a}-0.70\%$
test_reinforce_speed 4.9983ms 4.7978ms 208.4305 Ops/s 210.9069 Ops/s $\color{#d91a1a}-1.17\%$
test_iql_speed 20.9076ms 20.3626ms 49.1095 Ops/s 49.6688 Ops/s $\color{#d91a1a}-1.13\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9823ms 2.8322ms 353.0879 Ops/s 358.0543 Ops/s $\color{#d91a1a}-1.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4333ms 0.5948ms 1.6812 KOps/s 1.6500 KOps/s $\color{#35bf28}+1.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7661ms 0.5775ms 1.7315 KOps/s 1.7211 KOps/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9912ms 2.8099ms 355.8882 Ops/s 360.5624 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3726ms 0.5920ms 1.6892 KOps/s 1.6776 KOps/s $\color{#35bf28}+0.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7057ms 0.5718ms 1.7488 KOps/s 1.7508 KOps/s $\color{#d91a1a}-0.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6615ms 1.5106ms 661.9898 Ops/s 646.5697 Ops/s $\color{#35bf28}+2.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 7.3124ms 1.4702ms 680.1778 Ops/s 643.4382 Ops/s $\textbf{\color{#35bf28}+5.71\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1204ms 2.9478ms 339.2400 Ops/s 344.1850 Ops/s $\color{#d91a1a}-1.44\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9472ms 0.7291ms 1.3716 KOps/s 1.3617 KOps/s $\color{#35bf28}+0.73\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8970ms 0.7108ms 1.4069 KOps/s 1.4009 KOps/s $\color{#35bf28}+0.43\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9404ms 2.8161ms 355.1058 Ops/s 357.2237 Ops/s $\color{#d91a1a}-0.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7030ms 0.6015ms 1.6626 KOps/s 1.6354 KOps/s $\color{#35bf28}+1.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7191ms 0.5791ms 1.7267 KOps/s 1.7147 KOps/s $\color{#35bf28}+0.70\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0401ms 2.8461ms 351.3630 Ops/s 356.0412 Ops/s $\color{#d91a1a}-1.31\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7135ms 0.5951ms 1.6805 KOps/s 1.6677 KOps/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.9791ms 0.5770ms 1.7332 KOps/s 1.7160 KOps/s $\color{#35bf28}+1.00\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0920ms 2.9734ms 336.3153 Ops/s 345.0787 Ops/s $\color{#d91a1a}-2.54\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8758ms 0.7311ms 1.3679 KOps/s 1.3639 KOps/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8348ms 0.7087ms 1.4110 KOps/s 1.4155 KOps/s $\color{#d91a1a}-0.32\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1394s 7.5999ms 131.5805 Ops/s 103.3946 Ops/s $\textbf{\color{#35bf28}+27.26\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1318s 17.0600ms 58.6168 Ops/s 66.9069 Ops/s $\textbf{\color{#d91a1a}-12.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.6629ms 1.4123ms 708.0675 Ops/s 773.1195 Ops/s $\textbf{\color{#d91a1a}-8.41\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1188s 7.2117ms 138.6644 Ops/s 140.5291 Ops/s $\color{#d91a1a}-1.33\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.0573ms 14.8055ms 67.5423 Ops/s 67.0668 Ops/s $\color{#35bf28}+0.71\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.4897ms 1.2528ms 798.2089 Ops/s 780.9246 Ops/s $\color{#35bf28}+2.21\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1185s 7.4989ms 133.3523 Ops/s 131.9145 Ops/s $\color{#35bf28}+1.09\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.5791ms 15.1517ms 65.9993 Ops/s 56.4134 Ops/s $\textbf{\color{#35bf28}+16.99\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7191ms 1.5837ms 631.4148 Ops/s 579.3555 Ops/s $\textbf{\color{#35bf28}+8.99\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot