[Feature] Extract primers from modules that contain RNNs #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2127
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Unrelated FailuresAs of commit f48eb0c with merge base 68101b0 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
albertbou92
changed the title
albertbou92
commented
Apr 29, 2024
torchrl/data/tensor_specs.py
Outdated
| @@ -1597,12 +1597,18 @@ def __init__( | |||
| if high is not None: | |||
| raise TypeError(self.CONFLICTING_KWARGS.format("high", "maximum")) | |||
| high = kwargs.pop("maximum") | |||
| warnings.warn("Maximum is deprecated since v0.4.0, using high instead.", category=DeprecationWarning) | |||
| warnings.warn( | |||
There was a problem hiding this comment.
pre-commit reformatted this
albertbou92
commented
Apr 29, 2024
vmoens
changed the title
vmoens
reviewed
Apr 30, 2024
vmoens
reviewed
Apr 30, 2024
vmoens
reviewed
Apr 30, 2024
|
I was about to push them haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a utils method to address #1771
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!