Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[BugFix] Fix Isaac" #2118

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Revert "[BugFix] Fix Isaac" #2118

merged 1 commit into from
Apr 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 25, 2024

Reverts #2072

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2118

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 14 Unrelated Failures

As of commit bcb9e6d with merge base 422f1ac (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@vmoens vmoens merged commit 908ca39 into main Apr 25, 2024
15 of 28 checks passed
@vmoens vmoens deleted the revert-2072-fix-isaac branch April 25, 2024 15:39
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 54.9861ms 54.3182ms 18.4100 Ops/s 18.1557 Ops/s $\color{#35bf28}+1.40\%$
test_sync 38.5265ms 29.6406ms 33.7376 Ops/s 31.2499 Ops/s $\textbf{\color{#35bf28}+7.96\%}$
test_async 55.3360ms 26.7970ms 37.3176 Ops/s 35.0514 Ops/s $\textbf{\color{#35bf28}+6.47\%}$
test_simple 0.4077s 0.3532s 2.8315 Ops/s 2.9167 Ops/s $\color{#d91a1a}-2.92\%$
test_transformed 0.4830s 0.4824s 2.0728 Ops/s 1.9783 Ops/s $\color{#35bf28}+4.78\%$
test_serial 1.2786s 1.2288s 0.8138 Ops/s 0.8056 Ops/s $\color{#35bf28}+1.02\%$
test_parallel 1.0612s 1.0209s 0.9795 Ops/s 0.9751 Ops/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[True-True-True-True-True] 0.2433ms 21.5045μs 46.5018 KOps/s 45.9334 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[True-True-True-True-False] 62.1560μs 13.1030μs 76.3187 KOps/s 76.5718 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[True-True-True-False-True] 39.3730μs 12.4862μs 80.0882 KOps/s 78.7198 KOps/s $\color{#35bf28}+1.74\%$
test_step_mdp_speed[True-True-True-False-False] 42.3490μs 7.5230μs 132.9265 KOps/s 130.3210 KOps/s $\color{#35bf28}+2.00\%$
test_step_mdp_speed[True-True-False-True-True] 58.5190μs 22.9630μs 43.5482 KOps/s 44.0257 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-True-False-True-False] 42.1880μs 14.4365μs 69.2686 KOps/s 69.6175 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-True-False-False-True] 41.6670μs 13.8189μs 72.3644 KOps/s 71.0934 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[True-True-False-False-False] 51.2260μs 8.7607μs 114.1460 KOps/s 105.2576 KOps/s $\textbf{\color{#35bf28}+8.44\%}$
test_step_mdp_speed[True-False-True-True-True] 70.4720μs 24.1575μs 41.3951 KOps/s 41.1561 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[True-False-True-True-False] 62.8980μs 15.7684μs 63.4181 KOps/s 63.7212 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-True-False-True] 45.3350μs 13.7428μs 72.7653 KOps/s 71.2318 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-False-True-False-False] 30.6680μs 8.9300μs 111.9817 KOps/s 113.0251 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[True-False-False-True-True] 60.3430μs 25.2934μs 39.5360 KOps/s 39.7045 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[True-False-False-True-False] 47.3780μs 17.0159μs 58.7687 KOps/s 60.1078 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[True-False-False-False-True] 53.5500μs 14.9721μs 66.7909 KOps/s 67.2378 KOps/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[True-False-False-False-False] 55.1630μs 10.0712μs 99.2928 KOps/s 99.6959 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[False-True-True-True-True] 72.2250μs 24.1370μs 41.4301 KOps/s 41.2648 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-True-True-True-False] 42.5300μs 15.8682μs 63.0190 KOps/s 63.7617 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-True-True-False-True] 59.5410μs 15.8634μs 63.0382 KOps/s 63.1961 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-True-False-False] 33.5930μs 10.1845μs 98.1881 KOps/s 99.4865 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-True-False-True-True] 38.3220μs 25.7049μs 38.9032 KOps/s 38.6163 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-True-False-True-False] 48.6310μs 17.0309μs 58.7170 KOps/s 59.8759 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[False-True-False-False-True] 43.4710μs 17.2090μs 58.1092 KOps/s 58.9510 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-True-False-False-False] 37.5500μs 11.3543μs 88.0724 KOps/s 89.3916 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[False-False-True-True-True] 89.0880μs 26.7578μs 37.3723 KOps/s 38.2956 KOps/s $\color{#d91a1a}-2.41\%$
test_step_mdp_speed[False-False-True-True-False] 61.7650μs 18.5041μs 54.0420 KOps/s 55.6596 KOps/s $\color{#d91a1a}-2.91\%$
test_step_mdp_speed[False-False-True-False-True] 60.1920μs 17.2309μs 58.0351 KOps/s 58.7199 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[False-False-True-False-False] 0.3021ms 13.2613μs 75.4072 KOps/s 89.2779 KOps/s $\textbf{\color{#d91a1a}-15.54\%}$
test_step_mdp_speed[False-False-False-True-True] 68.9390μs 27.8449μs 35.9132 KOps/s 36.7052 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-False-False-True-False] 54.5220μs 19.5354μs 51.1890 KOps/s 52.8265 KOps/s $\color{#d91a1a}-3.10\%$
test_step_mdp_speed[False-False-False-False-True] 58.3190μs 18.3720μs 54.4308 KOps/s 54.5943 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-False-False-False-False] 37.5710μs 12.6738μs 78.9027 KOps/s 81.8456 KOps/s $\color{#d91a1a}-3.60\%$
test_values[generalized_advantage_estimate-True-True] 11.2670ms 9.4059ms 106.3158 Ops/s 107.9646 Ops/s $\color{#d91a1a}-1.53\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.9159ms 33.2096ms 30.1117 Ops/s 28.3901 Ops/s $\textbf{\color{#35bf28}+6.06\%}$
test_values[td0_return_estimate-False-False] 0.2168ms 0.1671ms 5.9832 KOps/s 5.8391 KOps/s $\color{#35bf28}+2.47\%$
test_values[td1_return_estimate-False-False] 27.1745ms 23.6016ms 42.3699 Ops/s 42.1121 Ops/s $\color{#35bf28}+0.61\%$
test_values[vec_td1_return_estimate-False-False] 34.5830ms 33.3299ms 30.0031 Ops/s 28.4496 Ops/s $\textbf{\color{#35bf28}+5.46\%}$
test_values[td_lambda_return_estimate-True-False] 34.7881ms 33.9614ms 29.4452 Ops/s 29.5719 Ops/s $\color{#d91a1a}-0.43\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.5122ms 33.3167ms 30.0150 Ops/s 28.4428 Ops/s $\textbf{\color{#35bf28}+5.53\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.2951ms 8.2455ms 121.2778 Ops/s 121.8428 Ops/s $\color{#d91a1a}-0.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2680ms 1.9471ms 513.5811 Ops/s 493.0851 Ops/s $\color{#35bf28}+4.16\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4249ms 0.3509ms 2.8499 KOps/s 2.8483 KOps/s $\color{#35bf28}+0.05\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 41.8458ms 40.7554ms 24.5366 Ops/s 21.3436 Ops/s $\textbf{\color{#35bf28}+14.96\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7159ms 3.0452ms 328.3903 Ops/s 329.0881 Ops/s $\color{#d91a1a}-0.21\%$
test_dqn_speed 7.5220ms 1.3561ms 737.3867 Ops/s 734.4274 Ops/s $\color{#35bf28}+0.40\%$
test_ddpg_speed 3.3316ms 2.8684ms 348.6279 Ops/s 347.6358 Ops/s $\color{#35bf28}+0.29\%$
test_sac_speed 9.9504ms 8.6692ms 115.3510 Ops/s 107.4941 Ops/s $\textbf{\color{#35bf28}+7.31\%}$
test_redq_speed 92.0205ms 14.4793ms 69.0643 Ops/s 74.4264 Ops/s $\textbf{\color{#d91a1a}-7.20\%}$
test_redq_deprec_speed 16.0734ms 13.8921ms 71.9833 Ops/s 72.4369 Ops/s $\color{#d91a1a}-0.63\%$
test_td3_speed 9.1064ms 8.4881ms 117.8124 Ops/s 118.1203 Ops/s $\color{#d91a1a}-0.26\%$
test_cql_speed 38.8251ms 36.7929ms 27.1792 Ops/s 26.8910 Ops/s $\color{#35bf28}+1.07\%$
test_a2c_speed 8.3986ms 7.5535ms 132.3886 Ops/s 131.6269 Ops/s $\color{#35bf28}+0.58\%$
test_ppo_speed 8.7207ms 7.8122ms 128.0050 Ops/s 127.4093 Ops/s $\color{#35bf28}+0.47\%$
test_reinforce_speed 7.3603ms 6.7208ms 148.7920 Ops/s 147.4826 Ops/s $\color{#35bf28}+0.89\%$
test_iql_speed 34.9897ms 33.2754ms 30.0522 Ops/s 30.0993 Ops/s $\color{#d91a1a}-0.16\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8056ms 2.2678ms 440.9555 Ops/s 452.9208 Ops/s $\color{#d91a1a}-2.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8070ms 0.5020ms 1.9921 KOps/s 2.0138 KOps/s $\color{#d91a1a}-1.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.7053ms 0.4772ms 2.0956 KOps/s 2.1134 KOps/s $\color{#d91a1a}-0.84\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3226ms 2.2098ms 452.5229 Ops/s 440.1383 Ops/s $\color{#35bf28}+2.81\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9125ms 0.4976ms 2.0096 KOps/s 2.0176 KOps/s $\color{#d91a1a}-0.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8561ms 0.4979ms 2.0086 KOps/s 1.8003 KOps/s $\textbf{\color{#35bf28}+11.57\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8596ms 1.2323ms 811.5170 Ops/s 808.8082 Ops/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6732ms 1.1620ms 860.6200 Ops/s 854.8547 Ops/s $\color{#35bf28}+0.67\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.5072ms 2.2929ms 436.1369 Ops/s 423.1915 Ops/s $\color{#35bf28}+3.06\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7063ms 0.6088ms 1.6425 KOps/s 1.6055 KOps/s $\color{#35bf28}+2.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.6714ms 0.5910ms 1.6921 KOps/s 1.6732 KOps/s $\color{#35bf28}+1.13\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2231ms 2.1851ms 457.6478 Ops/s 457.6131 Ops/s $+0.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8011ms 0.4964ms 2.0145 KOps/s 1.9631 KOps/s $\color{#35bf28}+2.62\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.9392ms 0.4804ms 2.0815 KOps/s 2.0975 KOps/s $\color{#d91a1a}-0.76\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4439ms 2.2021ms 454.1030 Ops/s 453.9748 Ops/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0416ms 0.4900ms 2.0408 KOps/s 1.9989 KOps/s $\color{#35bf28}+2.10\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7359ms 0.4746ms 2.1069 KOps/s 2.1239 KOps/s $\color{#d91a1a}-0.80\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4507ms 2.2703ms 440.4617 Ops/s 432.8066 Ops/s $\color{#35bf28}+1.77\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9385ms 0.6155ms 1.6248 KOps/s 1.5993 KOps/s $\color{#35bf28}+1.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.6508ms 0.6441ms 1.5527 KOps/s 1.6647 KOps/s $\textbf{\color{#d91a1a}-6.73\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1113s 7.7954ms 128.2808 Ops/s 126.0174 Ops/s $\color{#35bf28}+1.80\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.1567ms 11.8014ms 84.7357 Ops/s 82.9751 Ops/s $\color{#35bf28}+2.12\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.7286ms 1.0348ms 966.3767 Ops/s 925.3315 Ops/s $\color{#35bf28}+4.44\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 97.2382ms 5.6118ms 178.1957 Ops/s 175.9326 Ops/s $\color{#35bf28}+1.29\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1095s 13.8010ms 72.4587 Ops/s 82.9676 Ops/s $\textbf{\color{#d91a1a}-12.67\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.7623ms 1.0518ms 950.7368 Ops/s 930.0778 Ops/s $\color{#35bf28}+2.22\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1011s 5.9746ms 167.3746 Ops/s 126.2378 Ops/s $\textbf{\color{#35bf28}+32.59\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.0292ms 12.2620ms 81.5528 Ops/s 81.2063 Ops/s $\color{#35bf28}+0.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1884ms 1.4166ms 705.8988 Ops/s 727.3000 Ops/s $\color{#d91a1a}-2.94\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1172s 0.1163s 8.5981 Ops/s 8.2962 Ops/s $\color{#35bf28}+3.64\%$
test_sync 0.1059s 0.1030s 9.7093 Ops/s 10.0326 Ops/s $\color{#d91a1a}-3.22\%$
test_async 0.1882s 95.1933ms 10.5049 Ops/s 10.1816 Ops/s $\color{#35bf28}+3.18\%$
test_single_pixels 0.1264s 0.1264s 7.9143 Ops/s 7.8984 Ops/s $\color{#35bf28}+0.20\%$
test_sync_pixels 0.1391s 85.3925ms 11.7106 Ops/s 11.7161 Ops/s $\color{#d91a1a}-0.05\%$
test_async_pixels 0.1601s 77.1809ms 12.9566 Ops/s 12.8978 Ops/s $\color{#35bf28}+0.46\%$
test_simple 0.7579s 0.7571s 1.3208 Ops/s 1.2786 Ops/s $\color{#35bf28}+3.30\%$
test_transformed 1.0088s 1.0078s 0.9923 Ops/s 0.9792 Ops/s $\color{#35bf28}+1.33\%$
test_serial 2.4934s 2.4398s 0.4099 Ops/s 0.3992 Ops/s $\color{#35bf28}+2.67\%$
test_parallel 2.3757s 2.3257s 0.4300 Ops/s 0.4326 Ops/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[True-True-True-True-True] 0.1013ms 33.5772μs 29.7821 KOps/s 29.3698 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[True-True-True-True-False] 0.1228ms 20.1170μs 49.7091 KOps/s 49.7866 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-True-True-False-True] 37.2720μs 18.9441μs 52.7868 KOps/s 52.0789 KOps/s $\color{#35bf28}+1.36\%$
test_step_mdp_speed[True-True-True-False-False] 37.3620μs 11.3643μs 87.9946 KOps/s 86.7334 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-True-False-True-True] 0.1261ms 35.5145μs 28.1575 KOps/s 27.9016 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-True-False-True-False] 76.8030μs 22.1714μs 45.1032 KOps/s 44.8027 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-True-False-False-True] 52.6020μs 20.6287μs 48.4762 KOps/s 46.7407 KOps/s $\color{#35bf28}+3.71\%$
test_step_mdp_speed[True-True-False-False-False] 33.1010μs 13.3211μs 75.0690 KOps/s 74.6024 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[True-False-True-True-True] 62.5830μs 37.6169μs 26.5838 KOps/s 26.1928 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[True-False-True-True-False] 73.8930μs 23.9045μs 41.8332 KOps/s 40.5614 KOps/s $\color{#35bf28}+3.14\%$
test_step_mdp_speed[True-False-True-False-True] 54.2020μs 20.6517μs 48.4221 KOps/s 46.6991 KOps/s $\color{#35bf28}+3.69\%$
test_step_mdp_speed[True-False-True-False-False] 38.4120μs 13.3900μs 74.6824 KOps/s 73.9491 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[True-False-False-True-True] 64.2730μs 38.9090μs 25.7010 KOps/s 25.2241 KOps/s $\color{#35bf28}+1.89\%$
test_step_mdp_speed[True-False-False-True-False] 0.1222ms 25.6591μs 38.9726 KOps/s 37.7588 KOps/s $\color{#35bf28}+3.21\%$
test_step_mdp_speed[True-False-False-False-True] 44.8520μs 22.6249μs 44.1992 KOps/s 43.4116 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[True-False-False-False-False] 36.5410μs 15.2370μs 65.6298 KOps/s 64.8174 KOps/s $\color{#35bf28}+1.25\%$
test_step_mdp_speed[False-True-True-True-True] 62.7730μs 37.3621μs 26.7651 KOps/s 26.4328 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[False-True-True-True-False] 39.9120μs 24.1800μs 41.3565 KOps/s 40.9491 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-True-True-False-True] 43.9920μs 25.3609μs 39.4308 KOps/s 39.3294 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-True-True-False-False] 32.2320μs 15.4747μs 64.6214 KOps/s 65.0890 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-False-True-True] 69.6930μs 39.9187μs 25.0509 KOps/s 25.1141 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-False-True-False] 75.0930μs 26.1253μs 38.2770 KOps/s 38.0197 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[False-True-False-False-True] 52.0220μs 27.1592μs 36.8199 KOps/s 37.0038 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-True-False-False-False] 43.5520μs 17.2664μs 57.9159 KOps/s 58.4115 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-False-True-True-True] 61.2030μs 41.6503μs 24.0094 KOps/s 24.3148 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-False-True-True-False] 0.1007ms 28.2711μs 35.3718 KOps/s 35.7393 KOps/s $\color{#d91a1a}-1.03\%$
test_step_mdp_speed[False-False-True-False-True] 48.2820μs 27.1856μs 36.7842 KOps/s 36.7348 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[False-False-True-False-False] 37.6420μs 17.3540μs 57.6234 KOps/s 58.7881 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-False-False-True-True] 69.1230μs 42.7897μs 23.3701 KOps/s 23.2434 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[False-False-False-True-False] 48.0620μs 29.8038μs 33.5528 KOps/s 33.6158 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[False-False-False-False-True] 45.3720μs 28.5068μs 35.0794 KOps/s 34.6119 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[False-False-False-False-False] 46.0020μs 19.1878μs 52.1164 KOps/s 52.4385 KOps/s $\color{#d91a1a}-0.61\%$
test_values[generalized_advantage_estimate-True-True] 24.7731ms 24.3279ms 41.1051 Ops/s 41.3066 Ops/s $\color{#d91a1a}-0.49\%$
test_values[vec_generalized_advantage_estimate-True-True] 89.5771ms 3.3564ms 297.9385 Ops/s 308.7513 Ops/s $\color{#d91a1a}-3.50\%$
test_values[td0_return_estimate-False-False] 92.5040μs 63.9076μs 15.6476 KOps/s 15.7955 KOps/s $\color{#d91a1a}-0.94\%$
test_values[td1_return_estimate-False-False] 52.3947ms 52.0911ms 19.1971 Ops/s 19.4203 Ops/s $\color{#d91a1a}-1.15\%$
test_values[vec_td1_return_estimate-False-False] 2.5270ms 1.7744ms 563.5562 Ops/s 569.8325 Ops/s $\color{#d91a1a}-1.10\%$
test_values[td_lambda_return_estimate-True-False] 83.9570ms 83.5008ms 11.9759 Ops/s 12.2092 Ops/s $\color{#d91a1a}-1.91\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0619ms 1.7639ms 566.9111 Ops/s 570.4545 Ops/s $\color{#d91a1a}-0.62\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.9914ms 23.3792ms 42.7731 Ops/s 43.4633 Ops/s $\color{#d91a1a}-1.59\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8911ms 0.7082ms 1.4120 KOps/s 1.4504 KOps/s $\color{#d91a1a}-2.64\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7534ms 0.6490ms 1.5409 KOps/s 1.5612 KOps/s $\color{#d91a1a}-1.30\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5934ms 1.4483ms 690.4473 Ops/s 691.8914 Ops/s $\color{#d91a1a}-0.21\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9456ms 0.6665ms 1.5003 KOps/s 1.5117 KOps/s $\color{#d91a1a}-0.76\%$
test_dqn_speed 8.0687ms 1.5027ms 665.4735 Ops/s 678.3457 Ops/s $\color{#d91a1a}-1.90\%$
test_ddpg_speed 3.2842ms 2.9864ms 334.8540 Ops/s 327.4572 Ops/s $\color{#35bf28}+2.26\%$
test_sac_speed 9.0378ms 8.6109ms 116.1315 Ops/s 115.9013 Ops/s $\color{#35bf28}+0.20\%$
test_redq_speed 99.4653ms 11.4630ms 87.2373 Ops/s 95.2216 Ops/s $\textbf{\color{#d91a1a}-8.38\%}$
test_redq_deprec_speed 11.8214ms 11.4134ms 87.6165 Ops/s 84.2974 Ops/s $\color{#35bf28}+3.94\%$
test_td3_speed 8.6649ms 8.5118ms 117.4846 Ops/s 116.9469 Ops/s $\color{#35bf28}+0.46\%$
test_cql_speed 27.7254ms 26.4532ms 37.8027 Ops/s 37.9385 Ops/s $\color{#d91a1a}-0.36\%$
test_a2c_speed 6.0209ms 5.6915ms 175.7001 Ops/s 173.3923 Ops/s $\color{#35bf28}+1.33\%$
test_ppo_speed 6.2036ms 5.9906ms 166.9287 Ops/s 166.1598 Ops/s $\color{#35bf28}+0.46\%$
test_reinforce_speed 4.9034ms 4.6280ms 216.0756 Ops/s 213.4845 Ops/s $\color{#35bf28}+1.21\%$
test_iql_speed 20.3010ms 19.7148ms 50.7232 Ops/s 49.6451 Ops/s $\color{#35bf28}+2.17\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9758ms 2.8208ms 354.5103 Ops/s 355.6074 Ops/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3296ms 0.5944ms 1.6823 KOps/s 1.6610 KOps/s $\color{#35bf28}+1.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7529ms 0.5717ms 1.7492 KOps/s 1.7296 KOps/s $\color{#35bf28}+1.14\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0842ms 2.8561ms 350.1293 Ops/s 352.0564 Ops/s $\color{#d91a1a}-0.55\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3468ms 0.5858ms 1.7070 KOps/s 1.6955 KOps/s $\color{#35bf28}+0.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7753ms 0.5651ms 1.7695 KOps/s 1.7546 KOps/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6642ms 1.5236ms 656.3234 Ops/s 651.4154 Ops/s $\color{#35bf28}+0.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 6.1312ms 1.5472ms 646.3368 Ops/s 676.7968 Ops/s $\color{#d91a1a}-4.50\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1444ms 2.9755ms 336.0734 Ops/s 338.0067 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8975ms 0.7307ms 1.3685 KOps/s 1.3607 KOps/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8445ms 0.7048ms 1.4189 KOps/s 1.4153 KOps/s $\color{#35bf28}+0.26\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0921ms 2.8395ms 352.1762 Ops/s 357.0225 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4543ms 0.5962ms 1.6774 KOps/s 1.6753 KOps/s $\color{#35bf28}+0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7284ms 0.5714ms 1.7500 KOps/s 1.7197 KOps/s $\color{#35bf28}+1.76\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0627ms 2.8551ms 350.2531 Ops/s 353.5175 Ops/s $\color{#d91a1a}-0.92\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7446ms 0.5891ms 1.6975 KOps/s 1.6852 KOps/s $\color{#35bf28}+0.73\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.8844ms 0.5724ms 1.7472 KOps/s 1.7531 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1332ms 2.9749ms 336.1421 Ops/s 339.3302 Ops/s $\color{#d91a1a}-0.94\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.7536ms 0.7306ms 1.3687 KOps/s 1.3741 KOps/s $\color{#d91a1a}-0.39\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8713ms 0.7074ms 1.4137 KOps/s 1.4051 KOps/s $\color{#35bf28}+0.61\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1365s 7.5421ms 132.5894 Ops/s 103.1303 Ops/s $\textbf{\color{#35bf28}+28.56\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1287s 17.4816ms 57.2030 Ops/s 65.9277 Ops/s $\textbf{\color{#d91a1a}-13.23\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.6036ms 1.4188ms 704.7971 Ops/s 754.8093 Ops/s $\textbf{\color{#d91a1a}-6.63\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1192s 7.2334ms 138.2481 Ops/s 139.6694 Ops/s $\color{#d91a1a}-1.02\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.5845ms 15.0551ms 66.4225 Ops/s 66.2996 Ops/s $\color{#35bf28}+0.19\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.7229ms 1.2910ms 774.6129 Ops/s 818.0759 Ops/s $\textbf{\color{#d91a1a}-5.31\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1185s 7.5698ms 132.1043 Ops/s 100.8937 Ops/s $\textbf{\color{#35bf28}+30.93\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.9794ms 15.4942ms 64.5402 Ops/s 64.6349 Ops/s $\color{#d91a1a}-0.15\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7517ms 1.5950ms 626.9562 Ops/s 637.6827 Ops/s $\color{#d91a1a}-1.68\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot