-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Versioning] Deprecations for 0.4 #2109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2109
Note: Links to docs will display an error until the docs builds have been completed. ❌ 13 New Failures, 3 Unrelated FailuresAs of commit 4522c02 with merge base 93e9e30 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 24, 2024
|
Name | Max | Mean | Ops | Ops on Repo HEAD
|
Change |
---|---|---|---|---|---|
test_single | 54.4099ms | 53.3654ms | 18.7387 Ops/s | 18.7823 Ops/s | |
test_sync | 34.0925ms | 29.8906ms | 33.4554 Ops/s | 31.9158 Ops/s | |
test_async | 55.5229ms | 26.3172ms | 37.9980 Ops/s | 37.3099 Ops/s | |
test_simple | 0.3988s | 0.3441s | 2.9061 Ops/s | 2.9660 Ops/s | |
test_transformed | 0.5320s | 0.4844s | 2.0646 Ops/s | 2.0213 Ops/s | |
test_serial | 1.2426s | 1.1880s | 0.8418 Ops/s | 0.8287 Ops/s | |
test_parallel | 1.0720s | 1.0039s | 0.9961 Ops/s | 0.9771 Ops/s | |
test_step_mdp_speed[True-True-True-True-True] | 0.1355ms | 21.0093μs | 47.5979 KOps/s | 47.5272 KOps/s | |
test_step_mdp_speed[True-True-True-True-False] | 48.1900μs | 12.6889μs | 78.8088 KOps/s | 78.4030 KOps/s | |
test_step_mdp_speed[True-True-True-False-True] | 41.5580μs | 12.2042μs | 81.9392 KOps/s | 80.7909 KOps/s | |
test_step_mdp_speed[True-True-True-False-False] | 27.6810μs | 7.3645μs | 135.7859 KOps/s | 133.3520 KOps/s | |
test_step_mdp_speed[True-True-False-True-True] | 58.0780μs | 22.1152μs | 45.2178 KOps/s | 44.7619 KOps/s | |
test_step_mdp_speed[True-True-False-True-False] | 54.4910μs | 13.8887μs | 72.0008 KOps/s | 71.7290 KOps/s | |
test_step_mdp_speed[True-True-False-False-True] | 51.1950μs | 13.3511μs | 74.8999 KOps/s | 74.0870 KOps/s | |
test_step_mdp_speed[True-True-False-False-False] | 31.2190μs | 8.6390μs | 115.7535 KOps/s | 115.3953 KOps/s | |
test_step_mdp_speed[True-False-True-True-True] | 56.3560μs | 23.3518μs | 42.8233 KOps/s | 42.1253 KOps/s | |
test_step_mdp_speed[True-False-True-True-False] | 51.2560μs | 15.1973μs | 65.8011 KOps/s | 65.7026 KOps/s | |
test_step_mdp_speed[True-False-True-False-True] | 42.4090μs | 13.3555μs | 74.8757 KOps/s | 73.6333 KOps/s | |
test_step_mdp_speed[True-False-True-False-False] | 58.3290μs | 8.5968μs | 116.3225 KOps/s | 115.5449 KOps/s | |
test_step_mdp_speed[True-False-False-True-True] | 69.0690μs | 24.5456μs | 40.7406 KOps/s | 39.9001 KOps/s | |
test_step_mdp_speed[True-False-False-True-False] | 48.4210μs | 16.5657μs | 60.3656 KOps/s | 60.8120 KOps/s | |
test_step_mdp_speed[True-False-False-False-True] | 42.1190μs | 14.5803μs | 68.5857 KOps/s | 67.8032 KOps/s | |
test_step_mdp_speed[True-False-False-False-False] | 48.7010μs | 9.7020μs | 103.0715 KOps/s | 101.6891 KOps/s | |
test_step_mdp_speed[False-True-True-True-True] | 0.1161ms | 23.6019μs | 42.3695 KOps/s | 41.9802 KOps/s | |
test_step_mdp_speed[False-True-True-True-False] | 50.6240μs | 15.0929μs | 66.2563 KOps/s | 65.9078 KOps/s | |
test_step_mdp_speed[False-True-True-False-True] | 97.3210μs | 15.9293μs | 62.7772 KOps/s | 63.4820 KOps/s | |
test_step_mdp_speed[False-True-True-False-False] | 39.0830μs | 9.7465μs | 102.6014 KOps/s | 102.5158 KOps/s | |
test_step_mdp_speed[False-True-False-True-True] | 44.6030μs | 24.6048μs | 40.6425 KOps/s | 39.8115 KOps/s | |
test_step_mdp_speed[False-True-False-True-False] | 38.9930μs | 16.2847μs | 61.4075 KOps/s | 61.3976 KOps/s | |
test_step_mdp_speed[False-True-False-False-True] | 52.7280μs | 16.5767μs | 60.3257 KOps/s | 59.4433 KOps/s | |
test_step_mdp_speed[False-True-False-False-False] | 36.2970μs | 10.8774μs | 91.9334 KOps/s | 91.1743 KOps/s | |
test_step_mdp_speed[False-False-True-True-True] | 62.0560μs | 25.7785μs | 38.7920 KOps/s | 38.0717 KOps/s | |
test_step_mdp_speed[False-False-True-True-False] | 42.5900μs | 17.6000μs | 56.8181 KOps/s | 56.7981 KOps/s | |
test_step_mdp_speed[False-False-True-False-True] | 40.6460μs | 16.6590μs | 60.0277 KOps/s | 58.0710 KOps/s | |
test_step_mdp_speed[False-False-True-False-False] | 39.4530μs | 11.0759μs | 90.2860 KOps/s | 90.5383 KOps/s | |
test_step_mdp_speed[False-False-False-True-True] | 61.5550μs | 26.6316μs | 37.5494 KOps/s | 36.5406 KOps/s | |
test_step_mdp_speed[False-False-False-True-False] | 41.8080μs | 18.6375μs | 53.6553 KOps/s | 53.8705 KOps/s | |
test_step_mdp_speed[False-False-False-False-True] | 64.4600μs | 17.6966μs | 56.5081 KOps/s | 55.6794 KOps/s | |
test_step_mdp_speed[False-False-False-False-False] | 38.3320μs | 11.9363μs | 83.7783 KOps/s | 83.3217 KOps/s | |
test_values[generalized_advantage_estimate-True-True] | 12.0202ms | 9.2152ms | 108.5163 Ops/s | 108.5097 Ops/s | |
test_values[vec_generalized_advantage_estimate-True-True] | 36.9253ms | 35.8556ms | 27.8897 Ops/s | 28.0804 Ops/s | |
test_values[td0_return_estimate-False-False] | 0.2273ms | 0.1753ms | 5.7054 KOps/s | 5.5473 KOps/s | |
test_values[td1_return_estimate-False-False] | 26.5121ms | 23.3458ms | 42.8342 Ops/s | 43.3718 Ops/s | |
test_values[vec_td1_return_estimate-False-False] | 42.8595ms | 36.4281ms | 27.4513 Ops/s | 27.8707 Ops/s | |
test_values[td_lambda_return_estimate-True-False] | 34.1086ms | 33.6459ms | 29.7213 Ops/s | 30.0919 Ops/s | |
test_values[vec_td_lambda_return_estimate-True-False] | 37.1626ms | 35.8845ms | 27.8672 Ops/s | 27.8712 Ops/s | |
test_gae_speed[generalized_advantage_estimate-False-1-512] | 9.0879ms | 8.0116ms | 124.8193 Ops/s | 123.1179 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] | 2.2326ms | 1.9374ms | 516.1651 Ops/s | 496.8728 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] | 0.5363ms | 0.3446ms | 2.9016 KOps/s | 2.8145 KOps/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] | 48.5487ms | 45.9724ms | 21.7522 Ops/s | 22.8703 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] | 3.6773ms | 3.0175ms | 331.4031 Ops/s | 324.7394 Ops/s | |
test_dqn_speed | 7.7076ms | 1.3308ms | 751.4047 Ops/s | 692.4895 Ops/s | |
test_ddpg_speed | 3.6023ms | 2.8393ms | 352.1974 Ops/s | 346.1067 Ops/s | |
test_sac_speed | 8.9147ms | 8.3632ms | 119.5720 Ops/s | 116.2405 Ops/s | |
test_redq_speed | 14.5724ms | 13.2321ms | 75.5738 Ops/s | 73.9623 Ops/s | |
test_redq_deprec_speed | 20.5524ms | 13.9281ms | 71.7973 Ops/s | 71.3598 Ops/s | |
test_td3_speed | 8.7646ms | 8.3094ms | 120.3462 Ops/s | 116.7880 Ops/s | |
test_cql_speed | 38.3909ms | 36.6655ms | 27.2736 Ops/s | 26.8576 Ops/s | |
test_a2c_speed | 8.2677ms | 7.4965ms | 133.3955 Ops/s | 132.2314 Ops/s | |
test_ppo_speed | 9.1910ms | 7.7574ms | 128.9094 Ops/s | 127.6767 Ops/s | |
test_reinforce_speed | 7.2996ms | 6.6527ms | 150.3149 Ops/s | 149.2191 Ops/s | |
test_iql_speed | 34.6764ms | 33.1447ms | 30.1708 Ops/s | 30.3595 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 2.4320ms | 2.1645ms | 461.9939 Ops/s | 445.1651 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 1.0695ms | 0.5006ms | 1.9976 KOps/s | 1.9521 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.6919ms | 0.4791ms | 2.0873 KOps/s | 2.0730 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 2.6758ms | 2.3502ms | 425.4902 Ops/s | 430.4862 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.7287ms | 0.5020ms | 1.9921 KOps/s | 2.0070 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 3.3434ms | 0.4931ms | 2.0281 KOps/s | 2.1380 KOps/s | |
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] | 1.3301ms | 1.2174ms | 821.3966 Ops/s | 712.8528 Ops/s | |
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] | 4.0383ms | 1.1679ms | 856.2564 Ops/s | 854.1715 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 2.6416ms | 2.4083ms | 415.2257 Ops/s | 437.1155 Ops/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 1.1522ms | 0.6210ms | 1.6102 KOps/s | 1.6132 KOps/s | |
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.7826ms | 0.5876ms | 1.7019 KOps/s | 1.7101 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 2.5891ms | 2.1353ms | 468.3197 Ops/s | 449.1297 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 1.0710ms | 0.4924ms | 2.0311 KOps/s | 1.9387 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 0.6925ms | 0.4773ms | 2.0951 KOps/s | 2.0435 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 3.4087ms | 2.3006ms | 434.6725 Ops/s | 442.4337 Ops/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.6036ms | 0.4903ms | 2.0395 KOps/s | 1.9963 KOps/s | |
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 3.8293ms | 0.4791ms | 2.0871 KOps/s | 2.1188 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 2.5867ms | 2.2842ms | 437.7976 Ops/s | 434.9411 Ops/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 0.8923ms | 0.6179ms | 1.6185 KOps/s | 1.6061 KOps/s | |
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.8319ms | 0.5977ms | 1.6731 KOps/s | 1.6768 KOps/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] | 0.1139s | 8.0102ms | 124.8403 Ops/s | 159.8189 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] | 14.5010ms | 12.0240ms | 83.1673 Ops/s | 82.3795 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] | 1.6405ms | 1.0867ms | 920.2161 Ops/s | 930.2751 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] | 0.1233s | 6.1240ms | 163.2921 Ops/s | 177.2464 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] | 14.8285ms | 12.2613ms | 81.5573 Ops/s | 83.1615 Ops/s | |
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] | 1.6703ms | 1.0918ms | 915.9073 Ops/s | 941.1469 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] | 0.1243s | 8.9650ms | 111.5443 Ops/s | 119.7788 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] | 15.2432ms | 12.5372ms | 79.7629 Ops/s | 80.9135 Ops/s | |
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] | 4.2628ms | 1.4890ms | 671.6006 Ops/s | 731.0214 Ops/s |
Result of GPU Benchmark TestsExpand to view detailed results
|
vmoens
added
Environments
Adds or modifies an environment wrapper
Data
Data-related PR, will launch data-related jobs
labels
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bc breaking
backward compatibility breaking change
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Data
Data-related PR, will launch data-related jobs
Environments
Adds or modifies an environment wrapper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.