Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Lint #2096

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[Minor] Lint #2096

merged 1 commit into from
Apr 22, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 22, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2096

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 16 Unrelated Failures

As of commit c879bb1 with merge base 32533a5 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2024
@vmoens vmoens merged commit d1cfa3a into main Apr 22, 2024
11 of 19 checks passed
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}10$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 55.2855ms 54.0646ms 18.4964 Ops/s 17.4948 Ops/s $\textbf{\color{#35bf28}+5.73\%}$
test_sync 41.3635ms 30.0112ms 33.3209 Ops/s 32.4794 Ops/s $\color{#35bf28}+2.59\%$
test_async 53.0310ms 26.4192ms 37.8512 Ops/s 37.4515 Ops/s $\color{#35bf28}+1.07\%$
test_simple 0.4154s 0.3517s 2.8434 Ops/s 2.9239 Ops/s $\color{#d91a1a}-2.75\%$
test_transformed 0.5546s 0.4957s 2.0172 Ops/s 1.9892 Ops/s $\color{#35bf28}+1.41\%$
test_serial 1.2554s 1.2000s 0.8333 Ops/s 0.8328 Ops/s $\color{#35bf28}+0.05\%$
test_parallel 1.0799s 1.0176s 0.9827 Ops/s 0.9819 Ops/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-True-True-True] 0.1850ms 21.8949μs 45.6728 KOps/s 47.2219 KOps/s $\color{#d91a1a}-3.28\%$
test_step_mdp_speed[True-True-True-True-False] 40.0640μs 13.2810μs 75.2958 KOps/s 77.8147 KOps/s $\color{#d91a1a}-3.24\%$
test_step_mdp_speed[True-True-True-False-True] 41.5680μs 12.7297μs 78.5562 KOps/s 80.3572 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[True-True-True-False-False] 61.6750μs 7.8145μs 127.9673 KOps/s 134.0839 KOps/s $\color{#d91a1a}-4.56\%$
test_step_mdp_speed[True-True-False-True-True] 56.0340μs 23.2132μs 43.0789 KOps/s 44.6383 KOps/s $\color{#d91a1a}-3.49\%$
test_step_mdp_speed[True-True-False-True-False] 48.2600μs 14.5739μs 68.6156 KOps/s 71.3645 KOps/s $\color{#d91a1a}-3.85\%$
test_step_mdp_speed[True-True-False-False-True] 43.6220μs 14.0183μs 71.3353 KOps/s 73.4175 KOps/s $\color{#d91a1a}-2.84\%$
test_step_mdp_speed[True-True-False-False-False] 0.1181ms 9.0828μs 110.0988 KOps/s 113.9066 KOps/s $\color{#d91a1a}-3.34\%$
test_step_mdp_speed[True-False-True-True-True] 72.3640μs 24.6465μs 40.5737 KOps/s 42.2234 KOps/s $\color{#d91a1a}-3.91\%$
test_step_mdp_speed[True-False-True-True-False] 45.5140μs 15.9524μs 62.6864 KOps/s 64.7911 KOps/s $\color{#d91a1a}-3.25\%$
test_step_mdp_speed[True-False-True-False-True] 43.2110μs 14.0429μs 71.2102 KOps/s 73.6044 KOps/s $\color{#d91a1a}-3.25\%$
test_step_mdp_speed[True-False-True-False-False] 47.1980μs 9.0881μs 110.0340 KOps/s 114.5652 KOps/s $\color{#d91a1a}-3.96\%$
test_step_mdp_speed[True-False-False-True-True] 0.1578ms 26.0938μs 38.3233 KOps/s 40.3422 KOps/s $\textbf{\color{#d91a1a}-5.00\%}$
test_step_mdp_speed[True-False-False-True-False] 57.4870μs 17.0797μs 58.5492 KOps/s 60.4004 KOps/s $\color{#d91a1a}-3.06\%$
test_step_mdp_speed[True-False-False-False-True] 62.8680μs 15.2191μs 65.7067 KOps/s 68.5846 KOps/s $\color{#d91a1a}-4.20\%$
test_step_mdp_speed[True-False-False-False-False] 38.7320μs 10.2329μs 97.7243 KOps/s 101.2118 KOps/s $\color{#d91a1a}-3.45\%$
test_step_mdp_speed[False-True-True-True-True] 66.5540μs 24.4969μs 40.8215 KOps/s 42.4403 KOps/s $\color{#d91a1a}-3.81\%$
test_step_mdp_speed[False-True-True-True-False] 60.8840μs 15.7484μs 63.4984 KOps/s 64.7144 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[False-True-True-False-True] 47.1080μs 16.4742μs 60.7011 KOps/s 63.3648 KOps/s $\color{#d91a1a}-4.20\%$
test_step_mdp_speed[False-True-True-False-False] 37.0490μs 10.2764μs 97.3105 KOps/s 99.5550 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[False-True-False-True-True] 39.9340μs 26.1238μs 38.2793 KOps/s 39.6405 KOps/s $\color{#d91a1a}-3.43\%$
test_step_mdp_speed[False-True-False-True-False] 53.7900μs 17.1815μs 58.2021 KOps/s 60.6974 KOps/s $\color{#d91a1a}-4.11\%$
test_step_mdp_speed[False-True-False-False-True] 46.2970μs 17.4558μs 57.2875 KOps/s 59.0532 KOps/s $\color{#d91a1a}-2.99\%$
test_step_mdp_speed[False-True-False-False-False] 37.8300μs 11.3297μs 88.2636 KOps/s 89.7290 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[False-False-True-True-True] 79.4580μs 26.6814μs 37.4793 KOps/s 38.0733 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[False-False-True-True-False] 67.0050μs 18.2453μs 54.8087 KOps/s 55.7650 KOps/s $\color{#d91a1a}-1.71\%$
test_step_mdp_speed[False-False-True-False-True] 89.2860μs 17.2430μs 57.9944 KOps/s 58.8461 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-False-True-False-False] 37.2400μs 11.4776μs 87.1264 KOps/s 89.4991 KOps/s $\color{#d91a1a}-2.65\%$
test_step_mdp_speed[False-False-False-True-True] 66.9550μs 27.6605μs 36.1526 KOps/s 37.1328 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[False-False-False-True-False] 49.9840μs 19.2802μs 51.8666 KOps/s 53.0016 KOps/s $\color{#d91a1a}-2.14\%$
test_step_mdp_speed[False-False-False-False-True] 50.3540μs 18.4672μs 54.1501 KOps/s 56.6123 KOps/s $\color{#d91a1a}-4.35\%$
test_step_mdp_speed[False-False-False-False-False] 38.2010μs 12.4545μs 80.2923 KOps/s 82.5101 KOps/s $\color{#d91a1a}-2.69\%$
test_values[generalized_advantage_estimate-True-True] 9.9507ms 9.5828ms 104.3538 Ops/s 105.2146 Ops/s $\color{#d91a1a}-0.82\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.4142ms 35.3557ms 28.2840 Ops/s 29.9044 Ops/s $\textbf{\color{#d91a1a}-5.42\%}$
test_values[td0_return_estimate-False-False] 0.2025ms 0.1770ms 5.6505 KOps/s 5.3871 KOps/s $\color{#35bf28}+4.89\%$
test_values[td1_return_estimate-False-False] 25.4792ms 24.1902ms 41.3391 Ops/s 42.0431 Ops/s $\color{#d91a1a}-1.67\%$
test_values[vec_td1_return_estimate-False-False] 37.3575ms 35.5037ms 28.1661 Ops/s 29.7892 Ops/s $\textbf{\color{#d91a1a}-5.45\%}$
test_values[td_lambda_return_estimate-True-False] 37.7197ms 34.7474ms 28.7791 Ops/s 29.4893 Ops/s $\color{#d91a1a}-2.41\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3979ms 35.4292ms 28.2253 Ops/s 29.8045 Ops/s $\textbf{\color{#d91a1a}-5.30\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.3370ms 8.2512ms 121.1942 Ops/s 120.3594 Ops/s $\color{#35bf28}+0.69\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.9999ms 1.7913ms 558.2534 Ops/s 506.0848 Ops/s $\textbf{\color{#35bf28}+10.31\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4518ms 0.3545ms 2.8205 KOps/s 2.8570 KOps/s $\color{#d91a1a}-1.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.6900ms 45.2538ms 22.0976 Ops/s 23.3864 Ops/s $\textbf{\color{#d91a1a}-5.51\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.6123ms 3.0873ms 323.9065 Ops/s 325.3959 Ops/s $\color{#d91a1a}-0.46\%$
test_dqn_speed 7.0989ms 1.3677ms 731.1640 Ops/s 734.8972 Ops/s $\color{#d91a1a}-0.51\%$
test_ddpg_speed 3.6635ms 2.7663ms 361.4892 Ops/s 369.2862 Ops/s $\color{#d91a1a}-2.11\%$
test_sac_speed 9.8787ms 8.7341ms 114.4932 Ops/s 108.1404 Ops/s $\textbf{\color{#35bf28}+5.87\%}$
test_redq_speed 14.9482ms 13.8128ms 72.3964 Ops/s 73.4941 Ops/s $\color{#d91a1a}-1.49\%$
test_redq_deprec_speed 15.9840ms 14.9496ms 66.8914 Ops/s 69.4538 Ops/s $\color{#d91a1a}-3.69\%$
test_td3_speed 18.0308ms 8.8409ms 113.1107 Ops/s 118.3365 Ops/s $\color{#d91a1a}-4.42\%$
test_cql_speed 40.4119ms 37.9373ms 26.3593 Ops/s 27.1355 Ops/s $\color{#d91a1a}-2.86\%$
test_a2c_speed 9.0245ms 7.9046ms 126.5094 Ops/s 127.9976 Ops/s $\color{#d91a1a}-1.16\%$
test_ppo_speed 8.7429ms 8.1950ms 122.0252 Ops/s 121.4803 Ops/s $\color{#35bf28}+0.45\%$
test_reinforce_speed 8.1584ms 6.9294ms 144.3126 Ops/s 143.5899 Ops/s $\color{#35bf28}+0.50\%$
test_iql_speed 35.5077ms 33.9296ms 29.4728 Ops/s 29.5459 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9365ms 2.6177ms 382.0190 Ops/s 412.2002 Ops/s $\textbf{\color{#d91a1a}-7.32\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6814ms 0.5236ms 1.9099 KOps/s 1.9533 KOps/s $\color{#d91a1a}-2.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.6687ms 0.4969ms 2.0125 KOps/s 2.0636 KOps/s $\color{#d91a1a}-2.48\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7932ms 2.5776ms 387.9583 Ops/s 411.3866 Ops/s $\textbf{\color{#d91a1a}-5.69\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6603ms 0.5165ms 1.9360 KOps/s 1.9758 KOps/s $\color{#d91a1a}-2.02\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.0981ms 0.5017ms 1.9930 KOps/s 2.0550 KOps/s $\color{#d91a1a}-3.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7804ms 1.2411ms 805.7463 Ops/s 815.8626 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.1573ms 1.1651ms 858.3295 Ops/s 864.5148 Ops/s $\color{#d91a1a}-0.72\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8781ms 2.5942ms 385.4740 Ops/s 388.2929 Ops/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1181s 0.7408ms 1.3498 KOps/s 1.5701 KOps/s $\textbf{\color{#d91a1a}-14.03\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7972ms 0.6131ms 1.6310 KOps/s 1.5815 KOps/s $\color{#35bf28}+3.13\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7984ms 2.5260ms 395.8751 Ops/s 410.2365 Ops/s $\color{#d91a1a}-3.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2297ms 0.5203ms 1.9221 KOps/s 1.9523 KOps/s $\color{#d91a1a}-1.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6837ms 0.4957ms 2.0172 KOps/s 2.0555 KOps/s $\color{#d91a1a}-1.86\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.4147ms 2.5700ms 389.1122 Ops/s 393.6223 Ops/s $\color{#d91a1a}-1.15\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7846ms 0.5150ms 1.9418 KOps/s 1.9745 KOps/s $\color{#d91a1a}-1.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.7633ms 0.4980ms 2.0080 KOps/s 2.0588 KOps/s $\color{#d91a1a}-2.47\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8526ms 2.6837ms 372.6233 Ops/s 385.5285 Ops/s $\color{#d91a1a}-3.35\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7661ms 0.6399ms 1.5627 KOps/s 1.5862 KOps/s $\color{#d91a1a}-1.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8605ms 0.6099ms 1.6396 KOps/s 1.6560 KOps/s $\color{#d91a1a}-0.99\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1324s 8.6359ms 115.7962 Ops/s 121.0569 Ops/s $\color{#d91a1a}-4.35\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.5183ms 12.6375ms 79.1296 Ops/s 80.2649 Ops/s $\color{#d91a1a}-1.41\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.7286ms 1.1067ms 903.5614 Ops/s 928.2939 Ops/s $\color{#d91a1a}-2.66\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1118s 5.9343ms 168.5131 Ops/s 172.3143 Ops/s $\color{#d91a1a}-2.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.7756ms 13.0408ms 76.6821 Ops/s 80.8209 Ops/s $\textbf{\color{#d91a1a}-5.12\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6898ms 1.0900ms 917.4135 Ops/s 906.2424 Ops/s $\color{#35bf28}+1.23\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1160s 8.5420ms 117.0686 Ops/s 120.7061 Ops/s $\color{#d91a1a}-3.01\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.3454ms 13.1058ms 76.3020 Ops/s 78.4188 Ops/s $\color{#d91a1a}-2.70\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.3895ms 1.4827ms 674.4508 Ops/s 727.6334 Ops/s $\textbf{\color{#d91a1a}-7.31\%}$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1005s 98.7661ms 10.1249 Ops/s 9.8717 Ops/s $\color{#35bf28}+2.57\%$
test_sync 87.4479ms 86.7697ms 11.5248 Ops/s 11.3352 Ops/s $\color{#35bf28}+1.67\%$
test_async 0.1609s 70.2506ms 14.2348 Ops/s 14.2394 Ops/s $\color{#d91a1a}-0.03\%$
test_single_pixels 0.1120s 0.1106s 9.0394 Ops/s 9.2992 Ops/s $\color{#d91a1a}-2.79\%$
test_sync_pixels 68.3723ms 66.1124ms 15.1258 Ops/s 15.0105 Ops/s $\color{#35bf28}+0.77\%$
test_async_pixels 0.1213s 55.0589ms 18.1624 Ops/s 18.1974 Ops/s $\color{#d91a1a}-0.19\%$
test_simple 0.6559s 0.6553s 1.5261 Ops/s 1.5065 Ops/s $\color{#35bf28}+1.30\%$
test_transformed 0.8687s 0.8681s 1.1519 Ops/s 1.1396 Ops/s $\color{#35bf28}+1.08\%$
test_serial 2.0841s 2.0303s 0.4925 Ops/s 0.4958 Ops/s $\color{#d91a1a}-0.67\%$
test_parallel 1.8042s 1.7406s 0.5745 Ops/s 0.5679 Ops/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-True-True-True-True] 89.2820μs 33.1706μs 30.1472 KOps/s 30.3679 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[True-True-True-True-False] 71.1910μs 19.6925μs 50.7806 KOps/s 51.3136 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-True-True-False-True] 40.1300μs 18.8518μs 53.0452 KOps/s 55.0037 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[True-True-True-False-False] 29.1100μs 11.2441μs 88.9353 KOps/s 91.5299 KOps/s $\color{#d91a1a}-2.83\%$
test_step_mdp_speed[True-True-False-True-True] 54.1500μs 34.5354μs 28.9558 KOps/s 29.8846 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[True-True-False-True-False] 79.9220μs 21.3054μs 46.9365 KOps/s 48.0758 KOps/s $\color{#d91a1a}-2.37\%$
test_step_mdp_speed[True-True-False-False-True] 49.7310μs 20.5019μs 48.7760 KOps/s 50.9318 KOps/s $\color{#d91a1a}-4.23\%$
test_step_mdp_speed[True-True-False-False-False] 37.1110μs 13.1119μs 76.2667 KOps/s 79.2446 KOps/s $\color{#d91a1a}-3.76\%$
test_step_mdp_speed[True-False-True-True-True] 51.1110μs 36.5886μs 27.3309 KOps/s 27.9576 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[True-False-True-True-False] 43.8310μs 23.2684μs 42.9766 KOps/s 43.3660 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-False-True-False-True] 76.7810μs 20.4643μs 48.8657 KOps/s 50.5029 KOps/s $\color{#d91a1a}-3.24\%$
test_step_mdp_speed[True-False-True-False-False] 28.9810μs 13.0577μs 76.5833 KOps/s 77.5769 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[True-False-False-True-True] 64.5610μs 38.0273μs 26.2969 KOps/s 26.6261 KOps/s $\color{#d91a1a}-1.24\%$
test_step_mdp_speed[True-False-False-True-False] 43.5100μs 24.9664μs 40.0539 KOps/s 40.1148 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-False-False-True] 39.6410μs 21.9383μs 45.5823 KOps/s 46.3212 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[True-False-False-False-False] 35.5210μs 14.7258μs 67.9081 KOps/s 68.6452 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[False-True-True-True-True] 58.0510μs 36.8120μs 27.1650 KOps/s 27.7954 KOps/s $\color{#d91a1a}-2.27\%$
test_step_mdp_speed[False-True-True-True-False] 50.1100μs 23.1308μs 43.2324 KOps/s 43.0450 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[False-True-True-False-True] 50.3610μs 24.1771μs 41.3614 KOps/s 42.1831 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[False-True-True-False-False] 36.1110μs 14.7992μs 67.5714 KOps/s 68.6330 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-True-False-True-True] 68.3510μs 37.8772μs 26.4011 KOps/s 26.6026 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-True-False-True-False] 46.9710μs 24.9388μs 40.0982 KOps/s 40.2391 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-False-False-True] 41.1010μs 25.8453μs 38.6918 KOps/s 38.5916 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-True-False-False-False] 34.6000μs 16.9423μs 59.0238 KOps/s 61.1525 KOps/s $\color{#d91a1a}-3.48\%$
test_step_mdp_speed[False-False-True-True-True] 65.7410μs 40.2374μs 24.8525 KOps/s 25.1251 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-False-True-True-False] 46.8910μs 27.1331μs 36.8554 KOps/s 37.1208 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-False-True-False-True] 50.3300μs 26.0467μs 38.3926 KOps/s 38.7296 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-False-True-False-False] 33.5600μs 16.7894μs 59.5613 KOps/s 61.0219 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[False-False-False-True-True] 65.3110μs 41.6849μs 23.9895 KOps/s 24.3524 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[False-False-False-True-False] 52.5200μs 29.0474μs 34.4265 KOps/s 34.9325 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-False-False-False-True] 44.2510μs 27.7789μs 35.9985 KOps/s 37.0465 KOps/s $\color{#d91a1a}-2.83\%$
test_step_mdp_speed[False-False-False-False-False] 45.0320μs 18.4673μs 54.1499 KOps/s 55.6267 KOps/s $\color{#d91a1a}-2.65\%$
test_values[generalized_advantage_estimate-True-True] 23.7209ms 23.1673ms 43.1642 Ops/s 43.8413 Ops/s $\color{#d91a1a}-1.54\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.8663ms 3.2255ms 310.0325 Ops/s 315.6420 Ops/s $\color{#d91a1a}-1.78\%$
test_values[td0_return_estimate-False-False] 93.5710μs 61.7379μs 16.1975 KOps/s 16.8695 KOps/s $\color{#d91a1a}-3.98\%$
test_values[td1_return_estimate-False-False] 51.4280ms 49.8928ms 20.0430 Ops/s 20.4102 Ops/s $\color{#d91a1a}-1.80\%$
test_values[vec_td1_return_estimate-False-False] 2.0560ms 1.7351ms 576.3286 Ops/s 581.2352 Ops/s $\color{#d91a1a}-0.84\%$
test_values[td_lambda_return_estimate-True-False] 80.6086ms 78.8758ms 12.6782 Ops/s 12.8052 Ops/s $\color{#d91a1a}-0.99\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1132ms 1.7307ms 577.8165 Ops/s 581.8944 Ops/s $\color{#d91a1a}-0.70\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 21.8828ms 21.5377ms 46.4301 Ops/s 46.0974 Ops/s $\color{#35bf28}+0.72\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8616ms 0.6713ms 1.4897 KOps/s 1.5112 KOps/s $\color{#d91a1a}-1.42\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6817ms 0.6252ms 1.5996 KOps/s 1.6337 KOps/s $\color{#d91a1a}-2.09\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5032ms 1.4277ms 700.4318 Ops/s 705.3583 Ops/s $\color{#d91a1a}-0.70\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9060ms 0.6453ms 1.5497 KOps/s 1.5756 KOps/s $\color{#d91a1a}-1.64\%$
test_dqn_speed 1.8169ms 1.4132ms 707.6035 Ops/s 729.6596 Ops/s $\color{#d91a1a}-3.02\%$
test_ddpg_speed 2.9459ms 2.6319ms 379.9469 Ops/s 380.2233 Ops/s $\color{#d91a1a}-0.07\%$
test_sac_speed 8.4163ms 7.8029ms 128.1569 Ops/s 117.5999 Ops/s $\textbf{\color{#35bf28}+8.98\%}$
test_redq_speed 10.8266ms 9.9090ms 100.9187 Ops/s 99.1814 Ops/s $\color{#35bf28}+1.75\%$
test_redq_deprec_speed 0.1000s 11.5237ms 86.7777 Ops/s 94.2153 Ops/s $\textbf{\color{#d91a1a}-7.89\%}$
test_td3_speed 7.9695ms 7.8012ms 128.1861 Ops/s 129.7765 Ops/s $\color{#d91a1a}-1.23\%$
test_cql_speed 25.4786ms 24.3104ms 41.1346 Ops/s 41.2624 Ops/s $\color{#d91a1a}-0.31\%$
test_a2c_speed 5.5566ms 5.3557ms 186.7174 Ops/s 194.6089 Ops/s $\color{#d91a1a}-4.06\%$
test_ppo_speed 5.7708ms 5.5723ms 179.4607 Ops/s 184.2912 Ops/s $\color{#d91a1a}-2.62\%$
test_reinforce_speed 4.5436ms 4.3560ms 229.5677 Ops/s 236.1364 Ops/s $\color{#d91a1a}-2.78\%$
test_iql_speed 19.4174ms 18.7879ms 53.2258 Ops/s 53.6694 Ops/s $\color{#d91a1a}-0.83\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9782ms 2.8994ms 344.9002 Ops/s 347.2957 Ops/s $\color{#d91a1a}-0.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6417ms 0.5251ms 1.9045 KOps/s 1.8971 KOps/s $\color{#35bf28}+0.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7285ms 0.5022ms 1.9913 KOps/s 1.9896 KOps/s $\color{#35bf28}+0.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0808ms 2.9272ms 341.6285 Ops/s 349.7757 Ops/s $\color{#d91a1a}-2.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6330ms 0.5188ms 1.9277 KOps/s 1.9256 KOps/s $\color{#35bf28}+0.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.3365ms 0.5002ms 1.9992 KOps/s 2.0147 KOps/s $\color{#d91a1a}-0.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4818ms 1.3560ms 737.4772 Ops/s 746.6968 Ops/s $\color{#d91a1a}-1.23\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4852ms 1.2888ms 775.9329 Ops/s 780.5169 Ops/s $\color{#d91a1a}-0.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1452ms 3.0387ms 329.0924 Ops/s 332.0784 Ops/s $\color{#d91a1a}-0.90\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4271ms 0.6504ms 1.5376 KOps/s 1.5417 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8080ms 0.6245ms 1.6013 KOps/s 1.6052 KOps/s $\color{#d91a1a}-0.24\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0316ms 2.9369ms 340.4983 Ops/s 347.6336 Ops/s $\color{#d91a1a}-2.05\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3172ms 0.5271ms 1.8972 KOps/s 1.8896 KOps/s $\color{#35bf28}+0.40\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6419ms 0.5030ms 1.9881 KOps/s 1.9615 KOps/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1840ms 2.9354ms 340.6648 Ops/s 346.1626 Ops/s $\color{#d91a1a}-1.59\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6142ms 0.5191ms 1.9265 KOps/s 1.9083 KOps/s $\color{#35bf28}+0.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.3686ms 0.5058ms 1.9772 KOps/s 2.0009 KOps/s $\color{#d91a1a}-1.19\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1506ms 3.0533ms 327.5193 Ops/s 332.2877 Ops/s $\color{#d91a1a}-1.44\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7770ms 0.6517ms 1.5345 KOps/s 1.5418 KOps/s $\color{#d91a1a}-0.47\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8154ms 0.6233ms 1.6044 KOps/s 1.5931 KOps/s $\color{#35bf28}+0.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1378s 7.4384ms 134.4373 Ops/s 105.2525 Ops/s $\textbf{\color{#35bf28}+27.73\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.8570ms 14.5518ms 68.7201 Ops/s 69.3627 Ops/s $\color{#d91a1a}-0.93\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1718ms 1.0574ms 945.7438 Ops/s 932.3545 Ops/s $\color{#35bf28}+1.44\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1177s 9.2632ms 107.9538 Ops/s 144.8791 Ops/s $\textbf{\color{#d91a1a}-25.49\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.8913ms 14.6134ms 68.4304 Ops/s 69.0773 Ops/s $\color{#d91a1a}-0.94\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3892ms 1.1914ms 839.3259 Ops/s 903.0199 Ops/s $\textbf{\color{#d91a1a}-7.05\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1161s 7.3339ms 136.3528 Ops/s 138.0696 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9118ms 14.9068ms 67.0835 Ops/s 67.5969 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.4746ms 1.6180ms 618.0579 Ops/s 702.7814 Ops/s $\textbf{\color{#d91a1a}-12.06\%}$

@vmoens vmoens deleted the fix-lint branch April 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot