Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix R2Go once more #2089

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[BugFix] Fix R2Go once more #2089

merged 1 commit into from
Apr 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 18, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2089

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 16 Unrelated Failures

As of commit b778936 with merge base 61c42e4 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@vmoens vmoens added the bug Something isn't working label Apr 18, 2024
@vmoens vmoens merged commit acf168e into main Apr 18, 2024
21 of 35 checks passed
@vmoens vmoens deleted the fix-reward2go-shape branch April 18, 2024 13:58
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1029s 0.1016s 9.8415 Ops/s 9.3242 Ops/s $\textbf{\color{#35bf28}+5.55\%}$
test_sync 88.4960ms 87.7617ms 11.3945 Ops/s 11.4356 Ops/s $\color{#d91a1a}-0.36\%$
test_async 0.1627s 70.8837ms 14.1076 Ops/s 13.9212 Ops/s $\color{#35bf28}+1.34\%$
test_single_pixels 0.1821s 0.1191s 8.3941 Ops/s 8.8989 Ops/s $\textbf{\color{#d91a1a}-5.67\%}$
test_sync_pixels 69.1722ms 67.2295ms 14.8744 Ops/s 15.1023 Ops/s $\color{#d91a1a}-1.51\%$
test_async_pixels 0.1213s 55.0394ms 18.1688 Ops/s 18.0334 Ops/s $\color{#35bf28}+0.75\%$
test_simple 0.6755s 0.6750s 1.4815 Ops/s 1.4430 Ops/s $\color{#35bf28}+2.67\%$
test_transformed 0.9709s 0.9145s 1.0934 Ops/s 1.0877 Ops/s $\color{#35bf28}+0.53\%$
test_serial 2.1690s 2.1120s 0.4735 Ops/s 0.4745 Ops/s $\color{#d91a1a}-0.22\%$
test_parallel 1.8697s 1.8137s 0.5513 Ops/s 0.5636 Ops/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[True-True-True-True-True] 0.1022ms 32.7464μs 30.5377 KOps/s 31.1617 KOps/s $\color{#d91a1a}-2.00\%$
test_step_mdp_speed[True-True-True-True-False] 46.1500μs 20.1133μs 49.7182 KOps/s 51.2089 KOps/s $\color{#d91a1a}-2.91\%$
test_step_mdp_speed[True-True-True-False-True] 44.6510μs 18.6874μs 53.5120 KOps/s 55.0252 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[True-True-True-False-False] 31.5900μs 11.2341μs 89.0144 KOps/s 90.6170 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[True-True-False-True-True] 56.9010μs 34.9179μs 28.6386 KOps/s 29.7223 KOps/s $\color{#d91a1a}-3.65\%$
test_step_mdp_speed[True-True-False-True-False] 43.0220μs 21.7508μs 45.9752 KOps/s 47.6176 KOps/s $\color{#d91a1a}-3.45\%$
test_step_mdp_speed[True-True-False-False-True] 39.9110μs 20.4885μs 48.8079 KOps/s 49.7033 KOps/s $\color{#d91a1a}-1.80\%$
test_step_mdp_speed[True-True-False-False-False] 46.7610μs 13.0681μs 76.5219 KOps/s 77.8169 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-False-True-True-True] 91.7920μs 36.1082μs 27.6945 KOps/s 28.2436 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[True-False-True-True-False] 42.4810μs 23.3211μs 42.8796 KOps/s 43.5364 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-True-False-True] 41.1810μs 20.5522μs 48.6566 KOps/s 50.3184 KOps/s $\color{#d91a1a}-3.30\%$
test_step_mdp_speed[True-False-True-False-False] 34.8710μs 13.1577μs 76.0010 KOps/s 78.4407 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[True-False-False-True-True] 92.4630μs 38.9306μs 25.6868 KOps/s 27.1342 KOps/s $\textbf{\color{#d91a1a}-5.33\%}$
test_step_mdp_speed[True-False-False-True-False] 54.6020μs 25.3921μs 39.3823 KOps/s 40.5055 KOps/s $\color{#d91a1a}-2.77\%$
test_step_mdp_speed[True-False-False-False-True] 55.7920μs 22.2080μs 45.0288 KOps/s 46.2803 KOps/s $\color{#d91a1a}-2.70\%$
test_step_mdp_speed[True-False-False-False-False] 42.5710μs 15.1525μs 65.9957 KOps/s 68.3141 KOps/s $\color{#d91a1a}-3.39\%$
test_step_mdp_speed[False-True-True-True-True] 57.7710μs 37.0194μs 27.0129 KOps/s 28.0414 KOps/s $\color{#d91a1a}-3.67\%$
test_step_mdp_speed[False-True-True-True-False] 45.7310μs 23.9173μs 41.8107 KOps/s 43.2875 KOps/s $\color{#d91a1a}-3.41\%$
test_step_mdp_speed[False-True-True-False-True] 48.1110μs 25.1540μs 39.7551 KOps/s 42.5037 KOps/s $\textbf{\color{#d91a1a}-6.47\%}$
test_step_mdp_speed[False-True-True-False-False] 51.7810μs 15.1161μs 66.1545 KOps/s 68.5336 KOps/s $\color{#d91a1a}-3.47\%$
test_step_mdp_speed[False-True-False-True-True] 64.6220μs 38.4533μs 26.0056 KOps/s 26.4809 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-True-False-True-False] 46.9410μs 25.4493μs 39.2938 KOps/s 40.0404 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[False-True-False-False-True] 52.3210μs 26.5929μs 37.6040 KOps/s 38.9458 KOps/s $\color{#d91a1a}-3.45\%$
test_step_mdp_speed[False-True-False-False-False] 46.6510μs 16.9815μs 58.8877 KOps/s 60.9745 KOps/s $\color{#d91a1a}-3.42\%$
test_step_mdp_speed[False-False-True-True-True] 0.1388ms 40.1963μs 24.8779 KOps/s 25.4589 KOps/s $\color{#d91a1a}-2.28\%$
test_step_mdp_speed[False-False-True-True-False] 48.2110μs 27.5537μs 36.2927 KOps/s 37.5734 KOps/s $\color{#d91a1a}-3.41\%$
test_step_mdp_speed[False-False-True-False-True] 50.6210μs 26.5941μs 37.6023 KOps/s 39.8250 KOps/s $\textbf{\color{#d91a1a}-5.58\%}$
test_step_mdp_speed[False-False-True-False-False] 35.3410μs 16.5800μs 60.3138 KOps/s 61.1228 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-False-True-True] 60.9630μs 41.3680μs 24.1733 KOps/s 24.6604 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-False-False-True-False] 47.7520μs 29.0043μs 34.4777 KOps/s 34.7106 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-False-False-False-True] 58.8210μs 28.2051μs 35.4546 KOps/s 36.9469 KOps/s $\color{#d91a1a}-4.04\%$
test_step_mdp_speed[False-False-False-False-False] 56.8020μs 18.3587μs 54.4700 KOps/s 55.6828 KOps/s $\color{#d91a1a}-2.18\%$
test_values[generalized_advantage_estimate-True-True] 26.4724ms 25.9051ms 38.6024 Ops/s 37.4180 Ops/s $\color{#35bf28}+3.17\%$
test_values[vec_generalized_advantage_estimate-True-True] 80.9191ms 3.1921ms 313.2711 Ops/s 312.4343 Ops/s $\color{#35bf28}+0.27\%$
test_values[td0_return_estimate-False-False] 94.1130μs 66.1252μs 15.1228 KOps/s 15.0915 KOps/s $\color{#35bf28}+0.21\%$
test_values[td1_return_estimate-False-False] 57.8920ms 55.3002ms 18.0831 Ops/s 17.4722 Ops/s $\color{#35bf28}+3.50\%$
test_values[vec_td1_return_estimate-False-False] 2.0386ms 1.7730ms 564.0118 Ops/s 563.4358 Ops/s $\color{#35bf28}+0.10\%$
test_values[td_lambda_return_estimate-True-False] 87.4861ms 86.9805ms 11.4968 Ops/s 10.7071 Ops/s $\textbf{\color{#35bf28}+7.38\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1162ms 1.7713ms 564.5430 Ops/s 565.2396 Ops/s $\color{#d91a1a}-0.12\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.5434ms 24.3378ms 41.0883 Ops/s 38.5671 Ops/s $\textbf{\color{#35bf28}+6.54\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8727ms 0.7119ms 1.4047 KOps/s 1.3149 KOps/s $\textbf{\color{#35bf28}+6.83\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7041ms 0.6567ms 1.5228 KOps/s 1.4448 KOps/s $\textbf{\color{#35bf28}+5.40\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5111ms 1.4628ms 683.6082 Ops/s 680.9399 Ops/s $\color{#35bf28}+0.39\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9384ms 0.6764ms 1.4785 KOps/s 1.4796 KOps/s $\color{#d91a1a}-0.08\%$
test_dqn_speed 9.1326ms 1.4673ms 681.5180 Ops/s 688.0924 Ops/s $\color{#d91a1a}-0.96\%$
test_ddpg_speed 3.0441ms 2.7214ms 367.4624 Ops/s 364.1497 Ops/s $\color{#35bf28}+0.91\%$
test_sac_speed 9.2736ms 8.2657ms 120.9821 Ops/s 121.2977 Ops/s $\color{#d91a1a}-0.26\%$
test_redq_speed 97.7996ms 11.3581ms 88.0433 Ops/s 96.3898 Ops/s $\textbf{\color{#d91a1a}-8.66\%}$
test_redq_deprec_speed 11.7818ms 11.2120ms 89.1903 Ops/s 88.3687 Ops/s $\color{#35bf28}+0.93\%$
test_td3_speed 8.2215ms 8.0756ms 123.8294 Ops/s 123.5776 Ops/s $\color{#35bf28}+0.20\%$
test_cql_speed 26.0840ms 25.4180ms 39.3422 Ops/s 39.8540 Ops/s $\color{#d91a1a}-1.28\%$
test_a2c_speed 6.2141ms 5.5566ms 179.9653 Ops/s 182.8667 Ops/s $\color{#d91a1a}-1.59\%$
test_ppo_speed 6.2803ms 5.8683ms 170.4057 Ops/s 173.2244 Ops/s $\color{#d91a1a}-1.63\%$
test_reinforce_speed 5.5590ms 4.5256ms 220.9649 Ops/s 224.2610 Ops/s $\color{#d91a1a}-1.47\%$
test_iql_speed 20.3679ms 19.3096ms 51.7876 Ops/s 51.1633 Ops/s $\color{#35bf28}+1.22\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9986ms 2.8746ms 347.8790 Ops/s 346.6458 Ops/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1014s 0.6242ms 1.6021 KOps/s 1.8317 KOps/s $\textbf{\color{#d91a1a}-12.53\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7403ms 0.5182ms 1.9299 KOps/s 1.9293 KOps/s $\color{#35bf28}+0.04\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1647ms 2.9232ms 342.0868 Ops/s 344.5388 Ops/s $\color{#d91a1a}-0.71\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4309ms 0.5366ms 1.8635 KOps/s 1.8509 KOps/s $\color{#35bf28}+0.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7340ms 0.5124ms 1.9517 KOps/s 1.9568 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 3.7339ms 1.4395ms 694.7048 Ops/s 567.5841 Ops/s $\textbf{\color{#35bf28}+22.40\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.4623ms 1.3699ms 729.9627 Ops/s 729.0471 Ops/s $\color{#35bf28}+0.13\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1812ms 3.0336ms 329.6400 Ops/s 330.2300 Ops/s $\color{#d91a1a}-0.18\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8417ms 0.6681ms 1.4968 KOps/s 1.4921 KOps/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.3420ms 0.6485ms 1.5421 KOps/s 1.5447 KOps/s $\color{#d91a1a}-0.17\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0162ms 2.9174ms 342.7664 Ops/s 349.5477 Ops/s $\color{#d91a1a}-1.94\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7432ms 0.5445ms 1.8366 KOps/s 1.8443 KOps/s $\color{#d91a1a}-0.42\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.2594ms 0.5259ms 1.9013 KOps/s 1.9157 KOps/s $\color{#d91a1a}-0.75\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0750ms 2.9223ms 342.1992 Ops/s 343.5777 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4165ms 0.5386ms 1.8565 KOps/s 1.8741 KOps/s $\color{#d91a1a}-0.94\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6767ms 0.5144ms 1.9440 KOps/s 1.9538 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2120ms 3.0576ms 327.0576 Ops/s 332.4542 Ops/s $\color{#d91a1a}-1.62\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8219ms 0.6726ms 1.4867 KOps/s 1.4973 KOps/s $\color{#d91a1a}-0.71\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.4848ms 0.6532ms 1.5309 KOps/s 1.5309 KOps/s $-0.00\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1280s 9.5484ms 104.7296 Ops/s 133.6610 Ops/s $\textbf{\color{#d91a1a}-21.65\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.9769ms 14.6252ms 68.3749 Ops/s 68.8907 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.1602ms 1.0754ms 929.8504 Ops/s 919.8280 Ops/s $\color{#35bf28}+1.09\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1151s 7.0482ms 141.8808 Ops/s 141.7012 Ops/s $\color{#35bf28}+0.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.3480ms 14.7518ms 67.7882 Ops/s 68.6423 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2521ms 1.0800ms 925.9121 Ops/s 895.1503 Ops/s $\color{#35bf28}+3.44\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1156s 7.4601ms 134.0466 Ops/s 102.4261 Ops/s $\textbf{\color{#35bf28}+30.87\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.6827ms 15.0024ms 66.6558 Ops/s 67.4734 Ops/s $\color{#d91a1a}-1.21\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7346ms 1.4630ms 683.5215 Ops/s 686.6307 Ops/s $\color{#d91a1a}-0.45\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 54.1947ms 53.2542ms 18.7779 Ops/s 17.5671 Ops/s $\textbf{\color{#35bf28}+6.89\%}$
test_sync 43.3337ms 30.2454ms 33.0629 Ops/s 33.5917 Ops/s $\color{#d91a1a}-1.57\%$
test_async 69.6221ms 27.0766ms 36.9322 Ops/s 34.3524 Ops/s $\textbf{\color{#35bf28}+7.51\%}$
test_simple 0.4084s 0.3518s 2.8429 Ops/s 2.9634 Ops/s $\color{#d91a1a}-4.07\%$
test_transformed 0.5485s 0.4979s 2.0083 Ops/s 1.9733 Ops/s $\color{#35bf28}+1.78\%$
test_serial 1.2827s 1.2260s 0.8156 Ops/s 0.8199 Ops/s $\color{#d91a1a}-0.52\%$
test_parallel 1.0709s 1.0100s 0.9901 Ops/s 0.9872 Ops/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-True-True-True] 0.1915ms 21.3251μs 46.8930 KOps/s 46.9938 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[True-True-True-True-False] 63.7990μs 12.9209μs 77.3942 KOps/s 77.0729 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-True-False-True] 58.8710μs 12.5199μs 79.8728 KOps/s 80.8075 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[True-True-True-False-False] 46.4770μs 7.5795μs 131.9350 KOps/s 132.5103 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-True-False-True-True] 69.1190μs 22.7996μs 43.8604 KOps/s 43.1861 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-True-False-True-False] 45.8560μs 14.2698μs 70.0781 KOps/s 70.6832 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-True-False-False-True] 62.1470μs 13.7870μs 72.5320 KOps/s 67.2401 KOps/s $\textbf{\color{#35bf28}+7.87\%}$
test_step_mdp_speed[True-True-False-False-False] 42.2790μs 8.9043μs 112.3059 KOps/s 111.8821 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-False-True-True-True] 68.4390μs 24.2942μs 41.1621 KOps/s 41.7710 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[True-False-True-True-False] 58.2790μs 15.5869μs 64.1566 KOps/s 64.6492 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[True-False-True-False-True] 40.3360μs 13.7354μs 72.8047 KOps/s 72.3155 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-False-True-False-False] 49.4630μs 8.8497μs 112.9982 KOps/s 109.8361 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[True-False-False-True-True] 62.4870μs 25.4635μs 39.2718 KOps/s 38.6699 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-False-False-True-False] 61.9570μs 16.7919μs 59.5525 KOps/s 60.8738 KOps/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[True-False-False-False-True] 0.1079ms 15.3286μs 65.2377 KOps/s 65.6057 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[True-False-False-False-False] 84.7190μs 10.0843μs 99.1639 KOps/s 100.6089 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-True-True-True-True] 67.1950μs 24.3139μs 41.1288 KOps/s 41.7188 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-True-True-True-False] 61.9360μs 15.5041μs 64.4989 KOps/s 65.4793 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-True-True-False-True] 53.6000μs 15.9595μs 62.6587 KOps/s 62.2090 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-True-True-False-False] 52.5380μs 9.9738μs 100.2631 KOps/s 99.0113 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[False-True-False-True-True] 85.0300μs 25.8136μs 38.7392 KOps/s 39.2894 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[False-True-False-True-False] 46.4770μs 16.7118μs 59.8380 KOps/s 59.8399 KOps/s $-0.00\%$
test_step_mdp_speed[False-True-False-False-True] 55.0240μs 17.1689μs 58.2450 KOps/s 57.6766 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-True-False-False-False] 99.4760μs 11.6208μs 86.0524 KOps/s 89.2545 KOps/s $\color{#d91a1a}-3.59\%$
test_step_mdp_speed[False-False-True-True-True] 70.3220μs 26.6811μs 37.4797 KOps/s 38.3065 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-False-True-True-False] 61.7360μs 18.0947μs 55.2649 KOps/s 56.0991 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[False-False-True-False-True] 54.6230μs 17.2822μs 57.8628 KOps/s 58.7524 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[False-False-True-False-False] 64.0090μs 11.1084μs 90.0220 KOps/s 88.8299 KOps/s $\color{#35bf28}+1.34\%$
test_step_mdp_speed[False-False-False-True-True] 0.1535ms 27.6735μs 36.1357 KOps/s 36.6768 KOps/s $\color{#d91a1a}-1.48\%$
test_step_mdp_speed[False-False-False-True-False] 50.6550μs 19.0348μs 52.5354 KOps/s 53.4591 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[False-False-False-False-True] 41.8080μs 18.1068μs 55.2279 KOps/s 55.5038 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-False-False-False-False] 0.1255ms 12.2569μs 81.5870 KOps/s 82.1115 KOps/s $\color{#d91a1a}-0.64\%$
test_values[generalized_advantage_estimate-True-True] 10.5903ms 9.4054ms 106.3218 Ops/s 105.6071 Ops/s $\color{#35bf28}+0.68\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.8988ms 35.6630ms 28.0402 Ops/s 29.9682 Ops/s $\textbf{\color{#d91a1a}-6.43\%}$
test_values[td0_return_estimate-False-False] 0.2327ms 0.1963ms 5.0938 KOps/s 5.5329 KOps/s $\textbf{\color{#d91a1a}-7.94\%}$
test_values[td1_return_estimate-False-False] 26.1926ms 23.2274ms 43.0526 Ops/s 42.7033 Ops/s $\color{#35bf28}+0.82\%$
test_values[vec_td1_return_estimate-False-False] 36.7902ms 35.3982ms 28.2501 Ops/s 29.6643 Ops/s $\color{#d91a1a}-4.77\%$
test_values[td_lambda_return_estimate-True-False] 36.3782ms 33.4820ms 29.8668 Ops/s 29.4553 Ops/s $\color{#35bf28}+1.40\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.0154ms 35.3946ms 28.2529 Ops/s 29.7494 Ops/s $\textbf{\color{#d91a1a}-5.03\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.0996ms 8.1276ms 123.0370 Ops/s 121.7163 Ops/s $\color{#35bf28}+1.09\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0045ms 1.8054ms 553.8857 Ops/s 512.8708 Ops/s $\textbf{\color{#35bf28}+8.00\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5565ms 0.3528ms 2.8345 KOps/s 2.8588 KOps/s $\color{#d91a1a}-0.85\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.0663ms 44.3317ms 22.5572 Ops/s 22.3732 Ops/s $\color{#35bf28}+0.82\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5071ms 3.0681ms 325.9363 Ops/s 329.2670 Ops/s $\color{#d91a1a}-1.01\%$
test_dqn_speed 7.1774ms 1.3570ms 736.9171 Ops/s 740.4555 Ops/s $\color{#d91a1a}-0.48\%$
test_ddpg_speed 3.3916ms 2.7077ms 369.3228 Ops/s 372.1077 Ops/s $\color{#d91a1a}-0.75\%$
test_sac_speed 13.6703ms 8.5218ms 117.3455 Ops/s 111.0331 Ops/s $\textbf{\color{#35bf28}+5.69\%}$
test_redq_speed 14.5198ms 13.5783ms 73.6467 Ops/s 75.2127 Ops/s $\color{#d91a1a}-2.08\%$
test_redq_deprec_speed 0.1029s 15.5817ms 64.1779 Ops/s 74.8899 Ops/s $\textbf{\color{#d91a1a}-14.30\%}$
test_td3_speed 10.4589ms 8.6645ms 115.4132 Ops/s 123.1749 Ops/s $\textbf{\color{#d91a1a}-6.30\%}$
test_cql_speed 37.9063ms 37.1007ms 26.9537 Ops/s 27.2388 Ops/s $\color{#d91a1a}-1.05\%$
test_a2c_speed 9.5869ms 7.9757ms 125.3808 Ops/s 132.1908 Ops/s $\textbf{\color{#d91a1a}-5.15\%}$
test_ppo_speed 9.6916ms 8.2759ms 120.8331 Ops/s 126.0412 Ops/s $\color{#d91a1a}-4.13\%$
test_reinforce_speed 7.5854ms 6.9135ms 144.6444 Ops/s 148.6339 Ops/s $\color{#d91a1a}-2.68\%$
test_iql_speed 35.7946ms 34.1221ms 29.3065 Ops/s 29.8764 Ops/s $\color{#d91a1a}-1.91\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7673ms 2.5298ms 395.2895 Ops/s 395.9061 Ops/s $\color{#d91a1a}-0.16\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4520ms 0.5143ms 1.9443 KOps/s 1.9351 KOps/s $\color{#35bf28}+0.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6788ms 0.4828ms 2.0714 KOps/s 2.0316 KOps/s $\color{#35bf28}+1.96\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5565ms 2.5369ms 394.1809 Ops/s 404.1188 Ops/s $\color{#d91a1a}-2.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1176ms 0.5005ms 1.9981 KOps/s 1.9826 KOps/s $\color{#35bf28}+0.78\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7309ms 0.4738ms 2.1107 KOps/s 2.0603 KOps/s $\color{#35bf28}+2.45\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.3771ms 1.2318ms 811.8049 Ops/s 812.6308 Ops/s $\color{#d91a1a}-0.10\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5721ms 1.1679ms 856.2369 Ops/s 864.2313 Ops/s $\color{#d91a1a}-0.93\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7177ms 2.6526ms 376.9857 Ops/s 387.2751 Ops/s $\color{#d91a1a}-2.66\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1091ms 0.6361ms 1.5722 KOps/s 1.6185 KOps/s $\color{#d91a1a}-2.86\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9134ms 0.6040ms 1.6557 KOps/s 1.6734 KOps/s $\color{#d91a1a}-1.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7164ms 2.4499ms 408.1836 Ops/s 414.8405 Ops/s $\color{#d91a1a}-1.60\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6689ms 0.5076ms 1.9701 KOps/s 2.0219 KOps/s $\color{#d91a1a}-2.56\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.9366ms 0.4944ms 2.0225 KOps/s 2.0972 KOps/s $\color{#d91a1a}-3.56\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.8019ms 2.5667ms 389.6094 Ops/s 424.5627 Ops/s $\textbf{\color{#d91a1a}-8.23\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8427ms 0.5128ms 1.9502 KOps/s 1.9816 KOps/s $\color{#d91a1a}-1.58\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6333ms 0.4779ms 2.0926 KOps/s 2.1072 KOps/s $\color{#d91a1a}-0.69\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8521ms 2.5905ms 386.0319 Ops/s 401.7456 Ops/s $\color{#d91a1a}-3.91\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9541ms 0.6313ms 1.5839 KOps/s 1.6156 KOps/s $\color{#d91a1a}-1.96\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.8423ms 0.6106ms 1.6378 KOps/s 1.6142 KOps/s $\color{#35bf28}+1.46\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1237s 8.2368ms 121.4057 Ops/s 129.7673 Ops/s $\textbf{\color{#d91a1a}-6.44\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.7314ms 12.3517ms 80.9602 Ops/s 82.1895 Ops/s $\color{#d91a1a}-1.50\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6165ms 1.0487ms 953.5873 Ops/s 704.3106 Ops/s $\textbf{\color{#35bf28}+35.39\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1072s 5.7563ms 173.7238 Ops/s 171.8129 Ops/s $\color{#35bf28}+1.11\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1209s 14.4985ms 68.9728 Ops/s 70.9244 Ops/s $\color{#d91a1a}-2.75\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.8050ms 1.0703ms 934.3033 Ops/s 961.0349 Ops/s $\color{#d91a1a}-2.78\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1203s 6.5611ms 152.4143 Ops/s 164.2178 Ops/s $\textbf{\color{#d91a1a}-7.19\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.4757ms 12.8074ms 78.0796 Ops/s 81.0798 Ops/s $\color{#d91a1a}-3.70\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9102ms 1.3700ms 729.9074 Ops/s 736.2572 Ops/s $\color{#d91a1a}-0.86\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot