Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] missing annotations import #2074

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[BugFix] missing annotations import #2074

merged 1 commit into from
Apr 10, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 10, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2074

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 15 Unrelated Failures

As of commit 62783a9 with merge base 02c8342 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2024
@vmoens vmoens added the bug Something isn't working label Apr 10, 2024
@vmoens vmoens merged commit c9296c1 into main Apr 10, 2024
33 of 52 checks passed
@vmoens vmoens deleted the fix-annotations branch April 10, 2024 10:40
@github-actions GitHub Actions
Copy link

Result of GPU Benchmark Tests

Expand to view detailed results
Name Max Mean Ops
test_single 0.1034s 0.1012s 9.8822 Ops/s
test_sync 88.8387ms 87.8050ms 11.3889 Ops/s
test_async 0.1639s 71.3426ms 14.0169 Ops/s
test_single_pixels 0.1116s 0.1112s 8.9913 Ops/s
test_sync_pixels 0.1229s 69.5171ms 14.3850 Ops/s
test_async_pixels 0.1218s 55.7570ms 17.9350 Ops/s
test_simple 0.6869s 0.6851s 1.4596 Ops/s
test_transformed 0.8963s 0.8934s 1.1193 Ops/s
test_serial 2.1522s 2.1039s 0.4753 Ops/s
test_parallel 1.8456s 1.7765s 0.5629 Ops/s
test_step_mdp_speed[True-True-True-True-True] 84.8010μs 33.2888μs 30.0401 KOps/s
test_step_mdp_speed[True-True-True-True-False] 40.7500μs 19.3595μs 51.6541 KOps/s
test_step_mdp_speed[True-True-True-False-True] 40.5100μs 18.5678μs 53.8566 KOps/s
test_step_mdp_speed[True-True-True-False-False] 29.0400μs 11.2645μs 88.7741 KOps/s
test_step_mdp_speed[True-True-False-True-True] 72.7410μs 34.7597μs 28.7690 KOps/s
test_step_mdp_speed[True-True-False-True-False] 46.6410μs 21.3005μs 46.9473 KOps/s
test_step_mdp_speed[True-True-False-False-True] 45.0600μs 20.4806μs 48.8267 KOps/s
test_step_mdp_speed[True-True-False-False-False] 29.0500μs 12.9972μs 76.9397 KOps/s
test_step_mdp_speed[True-False-True-True-True] 72.8810μs 36.3003μs 27.5480 KOps/s
test_step_mdp_speed[True-False-True-True-False] 52.7400μs 23.3711μs 42.7878 KOps/s
test_step_mdp_speed[True-False-True-False-True] 38.8600μs 20.3541μs 49.1301 KOps/s
test_step_mdp_speed[True-False-True-False-False] 35.0700μs 12.9814μs 77.0333 KOps/s
test_step_mdp_speed[True-False-False-True-True] 67.1010μs 38.1089μs 26.2406 KOps/s
test_step_mdp_speed[True-False-False-True-False] 43.2000μs 25.2814μs 39.5548 KOps/s
test_step_mdp_speed[True-False-False-False-True] 43.7610μs 22.0927μs 45.2638 KOps/s
test_step_mdp_speed[True-False-False-False-False] 34.4700μs 14.9289μs 66.9842 KOps/s
test_step_mdp_speed[False-True-True-True-True] 77.5310μs 36.8143μs 27.1634 KOps/s
test_step_mdp_speed[False-True-True-True-False] 46.1010μs 23.8765μs 41.8822 KOps/s
test_step_mdp_speed[False-True-True-False-True] 49.2810μs 24.1414μs 41.4226 KOps/s
test_step_mdp_speed[False-True-True-False-False] 60.7110μs 14.9815μs 66.7488 KOps/s
test_step_mdp_speed[False-True-False-True-True] 60.8910μs 38.3893μs 26.0489 KOps/s
test_step_mdp_speed[False-True-False-True-False] 50.1410μs 25.4296μs 39.3243 KOps/s
test_step_mdp_speed[False-True-False-False-True] 62.9710μs 25.9943μs 38.4700 KOps/s
test_step_mdp_speed[False-True-False-False-False] 40.6410μs 16.8445μs 59.3664 KOps/s
test_step_mdp_speed[False-False-True-True-True] 61.0800μs 39.9753μs 25.0155 KOps/s
test_step_mdp_speed[False-False-True-True-False] 62.6010μs 27.2951μs 36.6367 KOps/s
test_step_mdp_speed[False-False-True-False-True] 96.1710μs 26.1556μs 38.2328 KOps/s
test_step_mdp_speed[False-False-True-False-False] 40.7110μs 16.9705μs 58.9257 KOps/s
test_step_mdp_speed[False-False-False-True-True] 67.8610μs 42.0243μs 23.7957 KOps/s
test_step_mdp_speed[False-False-False-True-False] 53.0710μs 28.9012μs 34.6007 KOps/s
test_step_mdp_speed[False-False-False-False-True] 54.5010μs 27.5775μs 36.2614 KOps/s
test_step_mdp_speed[False-False-False-False-False] 39.2610μs 18.5810μs 53.8184 KOps/s
test_values[generalized_advantage_estimate-True-True] 25.7708ms 24.6869ms 40.5073 Ops/s
test_values[vec_generalized_advantage_estimate-True-True] 80.7688ms 3.1853ms 313.9430 Ops/s
test_values[td0_return_estimate-False-False] 92.2710μs 64.1543μs 15.5874 KOps/s
test_values[td1_return_estimate-False-False] 54.8562ms 53.2640ms 18.7744 Ops/s
test_values[vec_td1_return_estimate-False-False] 2.0949ms 1.7743ms 563.5955 Ops/s
test_values[td_lambda_return_estimate-True-False] 87.4235ms 85.6527ms 11.6750 Ops/s
test_values[vec_td_lambda_return_estimate-True-False] 2.1109ms 1.7642ms 566.8134 Ops/s
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.4339ms 23.7405ms 42.1221 Ops/s
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8685ms 0.6962ms 1.4364 KOps/s
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7257ms 0.6515ms 1.5350 KOps/s
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5503ms 1.4529ms 688.3023 Ops/s
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9543ms 0.6708ms 1.4908 KOps/s
test_dqn_speed 3.9754ms 1.4442ms 692.4224 Ops/s
test_ddpg_speed 3.0724ms 2.7495ms 363.7062 Ops/s
test_sac_speed 8.4513ms 8.0471ms 124.2690 Ops/s
test_redq_speed 11.1234ms 10.1432ms 98.5887 Ops/s
test_redq_deprec_speed 11.5695ms 11.0787ms 90.2629 Ops/s
test_td3_speed 8.3552ms 8.0503ms 124.2187 Ops/s
test_cql_speed 25.8514ms 25.0047ms 39.9925 Ops/s
test_a2c_speed 5.7233ms 5.4589ms 183.1883 Ops/s
test_ppo_speed 6.0868ms 5.7439ms 174.0976 Ops/s
test_reinforce_speed 4.7071ms 4.3989ms 227.3275 Ops/s
test_iql_speed 20.3092ms 19.1103ms 52.3278 Ops/s
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1697ms 2.9314ms 341.1351 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9331ms 0.5350ms 1.8691 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7154ms 0.5168ms 1.9351 KOps/s
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0973ms 2.9076ms 343.9285 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1028ms 0.5279ms 1.8943 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6662ms 0.5091ms 1.9644 KOps/s
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.4689ms 1.4972ms 667.9340 Ops/s
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 0.1093s 1.5473ms 646.2829 Ops/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1818ms 3.0736ms 325.3493 Ops/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7930ms 0.6621ms 1.5103 KOps/s
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8043ms 0.6423ms 1.5568 KOps/s
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0828ms 2.8858ms 346.5233 Ops/s
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1072s 0.6556ms 1.5254 KOps/s
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6439ms 0.5145ms 1.9436 KOps/s
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1254ms 2.9331ms 340.9381 Ops/s
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2105ms 0.5287ms 1.8913 KOps/s
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6988ms 0.5136ms 1.9472 KOps/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2328ms 3.0564ms 327.1872 Ops/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7871ms 0.6690ms 1.4947 KOps/s
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.3981ms 0.6495ms 1.5397 KOps/s
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1184s 7.1307ms 140.2383 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.3582ms 14.4613ms 69.1503 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1733ms 1.0762ms 929.2165 Ops/s
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1028s 8.8139ms 113.4573 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.0090ms 14.4097ms 69.3976 Ops/s
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1744ms 1.0634ms 940.4028 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1018s 7.1533ms 139.7947 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.4005ms 14.7303ms 67.8875 Ops/s
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.6218ms 1.4567ms 686.4790 Ops/s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot