Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix Isaac #2072

Merged
merged 13 commits into from
Apr 25, 2024
Merged

[BugFix] Fix Isaac #2072

merged 13 commits into from
Apr 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 9, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2072

Note: Links to docs will display an error until the docs builds have been completed.

❌ 22 New Failures, 1 Pending

As of commit 70c3cc7 with merge base 160a946 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
@vmoens vmoens added bug Something isn't working Environments Adds or modifies an environment wrapper labels Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1157s 0.1148s 8.7087 Ops/s 8.7891 Ops/s $\color{#d91a1a}-0.91\%$
test_sync 0.1025s 0.1014s 9.8627 Ops/s 9.8405 Ops/s $\color{#35bf28}+0.23\%$
test_async 0.2010s 80.4082ms 12.4365 Ops/s 10.4947 Ops/s $\textbf{\color{#35bf28}+18.50\%}$
test_single_pixels 0.1293s 0.1283s 7.7950 Ops/s 8.0267 Ops/s $\color{#d91a1a}-2.89\%$
test_sync_pixels 0.1359s 85.2982ms 11.7236 Ops/s 11.9073 Ops/s $\color{#d91a1a}-1.54\%$
test_async_pixels 0.1590s 76.4983ms 13.0722 Ops/s 13.2668 Ops/s $\color{#d91a1a}-1.47\%$
test_simple 0.7585s 0.7556s 1.3235 Ops/s 1.3036 Ops/s $\color{#35bf28}+1.52\%$
test_transformed 1.0275s 1.0115s 0.9886 Ops/s 0.9826 Ops/s $\color{#35bf28}+0.61\%$
test_serial 2.4874s 2.4298s 0.4116 Ops/s 0.4172 Ops/s $\color{#d91a1a}-1.34\%$
test_parallel 2.4000s 2.3590s 0.4239 Ops/s 0.4310 Ops/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-True-True-True-True] 70.9210μs 33.6726μs 29.6977 KOps/s 30.0466 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[True-True-True-True-False] 44.1300μs 19.9910μs 50.0224 KOps/s 50.0881 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-True-True-False-True] 43.0300μs 18.7877μs 53.2263 KOps/s 52.5869 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[True-True-True-False-False] 0.1005ms 11.3505μs 88.1022 KOps/s 88.8855 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[True-True-False-True-True] 65.9410μs 35.4730μs 28.1905 KOps/s 28.5356 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[True-True-False-True-False] 45.1710μs 21.7383μs 46.0017 KOps/s 45.6365 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-True-False-False-True] 48.0600μs 20.6028μs 48.5370 KOps/s 47.8944 KOps/s $\color{#35bf28}+1.34\%$
test_step_mdp_speed[True-True-False-False-False] 27.7200μs 13.2667μs 75.3767 KOps/s 74.8471 KOps/s $\color{#35bf28}+0.71\%$
test_step_mdp_speed[True-False-True-True-True] 84.2510μs 37.2230μs 26.8651 KOps/s 26.9150 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[True-False-True-True-False] 47.0710μs 23.9163μs 41.8124 KOps/s 42.0419 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[True-False-True-False-True] 37.3200μs 20.6299μs 48.4734 KOps/s 47.6012 KOps/s $\color{#35bf28}+1.83\%$
test_step_mdp_speed[True-False-True-False-False] 39.2400μs 13.3061μs 75.1533 KOps/s 75.5179 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-False-True-True] 71.5710μs 38.8824μs 25.7186 KOps/s 25.8077 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-False-False-True-False] 49.5900μs 25.7747μs 38.7977 KOps/s 39.0219 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-False-False-False-True] 40.3700μs 22.3500μs 44.7428 KOps/s 44.3085 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[True-False-False-False-False] 39.0200μs 15.0819μs 66.3048 KOps/s 66.3557 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[False-True-True-True-True] 63.5010μs 37.1081μs 26.9483 KOps/s 26.7354 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-True-True-False] 59.3010μs 24.2369μs 41.2594 KOps/s 42.0334 KOps/s $\color{#d91a1a}-1.84\%$
test_step_mdp_speed[False-True-True-False-True] 45.0000μs 25.3916μs 39.3831 KOps/s 40.6500 KOps/s $\color{#d91a1a}-3.12\%$
test_step_mdp_speed[False-True-True-False-False] 43.2210μs 15.2094μs 65.7486 KOps/s 66.2652 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[False-True-False-True-True] 67.6110μs 39.7874μs 25.1336 KOps/s 25.4550 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-True-False-True-False] 50.7610μs 25.9262μs 38.5710 KOps/s 38.6570 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-False-False-True] 42.4410μs 27.0433μs 36.9778 KOps/s 37.7076 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[False-True-False-False-False] 44.0510μs 16.9598μs 58.9629 KOps/s 58.8094 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-False-True-True-True] 68.4710μs 41.2434μs 24.2463 KOps/s 24.2952 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[False-False-True-True-False] 58.5300μs 28.2526μs 35.3950 KOps/s 36.0145 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[False-False-True-False-True] 50.1110μs 26.7111μs 37.4376 KOps/s 37.5122 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[False-False-True-False-False] 47.4610μs 17.0791μs 58.5512 KOps/s 59.4855 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-False-False-True-True] 71.0310μs 42.8285μs 23.3489 KOps/s 23.4445 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-False-False-True-False] 53.7200μs 29.6609μs 33.7144 KOps/s 33.9954 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-False-False-False-True] 49.0910μs 28.2162μs 35.4407 KOps/s 35.6156 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[False-False-False-False-False] 33.8100μs 18.6955μs 53.4889 KOps/s 53.2601 KOps/s $\color{#35bf28}+0.43\%$
test_values[generalized_advantage_estimate-True-True] 24.7633ms 24.2307ms 41.2700 Ops/s 41.4456 Ops/s $\color{#d91a1a}-0.42\%$
test_values[vec_generalized_advantage_estimate-True-True] 82.3829ms 3.2103ms 311.5014 Ops/s 312.0235 Ops/s $\color{#d91a1a}-0.17\%$
test_values[td0_return_estimate-False-False] 93.3210μs 62.8851μs 15.9020 KOps/s 15.9196 KOps/s $\color{#d91a1a}-0.11\%$
test_values[td1_return_estimate-False-False] 51.8812ms 51.5482ms 19.3993 Ops/s 19.4143 Ops/s $\color{#d91a1a}-0.08\%$
test_values[vec_td1_return_estimate-False-False] 1.9590ms 1.7568ms 569.2068 Ops/s 570.1394 Ops/s $\color{#d91a1a}-0.16\%$
test_values[td_lambda_return_estimate-True-False] 82.7432ms 82.2455ms 12.1587 Ops/s 11.9271 Ops/s $\color{#35bf28}+1.94\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0362ms 1.7532ms 570.3916 Ops/s 570.9331 Ops/s $\color{#d91a1a}-0.09\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.2661ms 23.1444ms 43.2070 Ops/s 44.0739 Ops/s $\color{#d91a1a}-1.97\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8717ms 0.6918ms 1.4454 KOps/s 1.4626 KOps/s $\color{#d91a1a}-1.17\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7129ms 0.6422ms 1.5571 KOps/s 1.5707 KOps/s $\color{#d91a1a}-0.87\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5073ms 1.4471ms 691.0384 Ops/s 693.8440 Ops/s $\color{#d91a1a}-0.40\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9413ms 0.6623ms 1.5099 KOps/s 1.5181 KOps/s $\color{#d91a1a}-0.55\%$
test_dqn_speed 7.8692ms 1.5037ms 665.0429 Ops/s 695.0184 Ops/s $\color{#d91a1a}-4.31\%$
test_ddpg_speed 3.2964ms 3.0194ms 331.1869 Ops/s 341.1566 Ops/s $\color{#d91a1a}-2.92\%$
test_sac_speed 9.1895ms 8.6638ms 115.4230 Ops/s 118.4795 Ops/s $\color{#d91a1a}-2.58\%$
test_redq_speed 98.3996ms 11.4556ms 87.2934 Ops/s 89.0270 Ops/s $\color{#d91a1a}-1.95\%$
test_redq_deprec_speed 12.3971ms 11.9326ms 83.8038 Ops/s 85.8508 Ops/s $\color{#d91a1a}-2.38\%$
test_td3_speed 8.8977ms 8.5585ms 116.8435 Ops/s 118.9780 Ops/s $\color{#d91a1a}-1.79\%$
test_cql_speed 27.3879ms 26.3803ms 37.9071 Ops/s 38.0990 Ops/s $\color{#d91a1a}-0.50\%$
test_a2c_speed 6.1895ms 5.8786ms 170.1077 Ops/s 173.6667 Ops/s $\color{#d91a1a}-2.05\%$
test_ppo_speed 6.3685ms 6.2052ms 161.1561 Ops/s 165.2428 Ops/s $\color{#d91a1a}-2.47\%$
test_reinforce_speed 5.4872ms 4.7810ms 209.1615 Ops/s 212.3133 Ops/s $\color{#d91a1a}-1.48\%$
test_iql_speed 21.2191ms 20.4958ms 48.7906 Ops/s 49.3790 Ops/s $\color{#d91a1a}-1.19\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0739ms 2.8044ms 356.5878 Ops/s 357.9075 Ops/s $\color{#d91a1a}-0.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7509ms 0.6037ms 1.6563 KOps/s 1.6916 KOps/s $\color{#d91a1a}-2.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.6048ms 0.5755ms 1.7377 KOps/s 1.7642 KOps/s $\color{#d91a1a}-1.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0432ms 2.8364ms 352.5612 Ops/s 356.0397 Ops/s $\color{#d91a1a}-0.98\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7365ms 0.5923ms 1.6884 KOps/s 1.7194 KOps/s $\color{#d91a1a}-1.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.6933ms 0.5781ms 1.7297 KOps/s 1.7781 KOps/s $\color{#d91a1a}-2.72\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6856ms 1.5517ms 644.4733 Ops/s 660.3576 Ops/s $\color{#d91a1a}-2.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6288ms 1.4851ms 673.3660 Ops/s 688.8442 Ops/s $\color{#d91a1a}-2.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1039ms 2.9345ms 340.7791 Ops/s 342.8583 Ops/s $\color{#d91a1a}-0.61\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.6329ms 0.7323ms 1.3656 KOps/s 1.3891 KOps/s $\color{#d91a1a}-1.69\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8807ms 0.7036ms 1.4213 KOps/s 1.4391 KOps/s $\color{#d91a1a}-1.23\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9485ms 2.8240ms 354.1036 Ops/s 358.9463 Ops/s $\color{#d91a1a}-1.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7089ms 0.6016ms 1.6623 KOps/s 1.6828 KOps/s $\color{#d91a1a}-1.21\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.6931ms 0.5822ms 1.7177 KOps/s 1.7394 KOps/s $\color{#d91a1a}-1.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2222ms 2.8209ms 354.4909 Ops/s 357.1595 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7002ms 0.5911ms 1.6919 KOps/s 1.7029 KOps/s $\color{#d91a1a}-0.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7633ms 0.5709ms 1.7515 KOps/s 1.7808 KOps/s $\color{#d91a1a}-1.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1308ms 2.9528ms 338.6565 Ops/s 340.2940 Ops/s $\color{#d91a1a}-0.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8635ms 0.7347ms 1.3611 KOps/s 1.3903 KOps/s $\color{#d91a1a}-2.10\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.9236ms 0.7112ms 1.4062 KOps/s 1.4311 KOps/s $\color{#d91a1a}-1.74\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1345s 7.5433ms 132.5686 Ops/s 133.6798 Ops/s $\color{#d91a1a}-0.83\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1268s 17.2248ms 58.0558 Ops/s 58.1538 Ops/s $\color{#d91a1a}-0.17\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.7957ms 1.3390ms 746.8168 Ops/s 854.6574 Ops/s $\textbf{\color{#d91a1a}-12.62\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1173s 7.2159ms 138.5834 Ops/s 139.6469 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.9930ms 14.9577ms 66.8550 Ops/s 66.8527 Ops/s $+0.00\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2535ms 1.2086ms 827.4074 Ops/s 787.4623 Ops/s $\textbf{\color{#35bf28}+5.07\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1188s 7.6509ms 130.7043 Ops/s 133.3253 Ops/s $\color{#d91a1a}-1.97\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.8436ms 15.3381ms 65.1972 Ops/s 65.5607 Ops/s $\color{#d91a1a}-0.55\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7966ms 1.6452ms 607.8269 Ops/s 607.7775 Ops/s $+0.01\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 53.4106ms 53.0167ms 18.8620 Ops/s 18.7446 Ops/s $\color{#35bf28}+0.63\%$
test_sync 38.3074ms 29.6924ms 33.6787 Ops/s 34.9442 Ops/s $\color{#d91a1a}-3.62\%$
test_async 53.0496ms 26.2808ms 38.0506 Ops/s 36.7414 Ops/s $\color{#35bf28}+3.56\%$
test_simple 0.3878s 0.3384s 2.9554 Ops/s 2.9822 Ops/s $\color{#d91a1a}-0.90\%$
test_transformed 0.4764s 0.4750s 2.1054 Ops/s 2.0321 Ops/s $\color{#35bf28}+3.61\%$
test_serial 1.2433s 1.1975s 0.8351 Ops/s 0.8187 Ops/s $\color{#35bf28}+2.00\%$
test_parallel 1.0421s 0.9948s 1.0052 Ops/s 1.0015 Ops/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-True-True-True-True] 63.2670μs 21.6911μs 46.1019 KOps/s 46.8889 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[True-True-True-True-False] 33.7730μs 13.1885μs 75.8235 KOps/s 76.8285 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[True-True-True-False-True] 52.5480μs 12.5906μs 79.4241 KOps/s 80.0738 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[True-True-True-False-False] 30.3460μs 7.6808μs 130.1954 KOps/s 130.7909 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-True-False-True-True] 0.2488ms 23.6749μs 42.2388 KOps/s 43.9955 KOps/s $\color{#d91a1a}-3.99\%$
test_step_mdp_speed[True-True-False-True-False] 50.3730μs 14.5684μs 68.6417 KOps/s 69.3106 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-True-False-False-True] 36.1070μs 13.9406μs 71.7331 KOps/s 72.2966 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[True-True-False-False-False] 48.8310μs 9.0581μs 110.3988 KOps/s 112.2761 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-True-True-True] 52.4780μs 24.4662μs 40.8728 KOps/s 41.6107 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[True-False-True-True-False] 0.1395ms 16.0221μs 62.4139 KOps/s 63.2596 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[True-False-True-False-True] 38.0800μs 13.9582μs 71.6422 KOps/s 72.9708 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-True-False-False] 45.8350μs 8.9723μs 111.4545 KOps/s 113.3429 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-False-True-True] 53.1390μs 25.5939μs 39.0719 KOps/s 39.3432 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[True-False-False-True-False] 43.5710μs 17.1420μs 58.3361 KOps/s 59.7373 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[True-False-False-False-True] 59.4900μs 15.1429μs 66.0375 KOps/s 67.3423 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[True-False-False-False-False] 34.6240μs 10.0862μs 99.1459 KOps/s 99.4071 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[False-True-True-True-True] 57.1060μs 24.4945μs 40.8255 KOps/s 41.2706 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-True-True-False] 54.2500μs 15.8059μs 63.2676 KOps/s 63.6916 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-True-True-False-True] 42.9590μs 16.3542μs 61.1463 KOps/s 61.8595 KOps/s $\color{#d91a1a}-1.15\%$
test_step_mdp_speed[False-True-True-False-False] 33.7220μs 10.2669μs 97.4008 KOps/s 98.1295 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[False-True-False-True-True] 38.2110μs 25.9963μs 38.4670 KOps/s 38.7453 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-False-True-False] 45.3540μs 17.2593μs 57.9399 KOps/s 59.1654 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[False-True-False-False-True] 60.2820μs 17.4273μs 57.3814 KOps/s 57.8947 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-True-False-False-False] 45.4440μs 11.4079μs 87.6588 KOps/s 88.4006 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-False-True-True-True] 66.0130μs 26.9495μs 37.1064 KOps/s 37.7810 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-False-True-True-False] 58.2980μs 18.4389μs 54.2333 KOps/s 54.6034 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-False-True-False-True] 48.8410μs 17.3420μs 57.6636 KOps/s 58.0418 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[False-False-True-False-False] 54.4400μs 11.8450μs 84.4238 KOps/s 89.0599 KOps/s $\textbf{\color{#d91a1a}-5.21\%}$
test_step_mdp_speed[False-False-False-True-True] 0.1132ms 27.9865μs 35.7315 KOps/s 36.3146 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[False-False-False-True-False] 67.6050μs 19.6666μs 50.8475 KOps/s 52.0646 KOps/s $\color{#d91a1a}-2.34\%$
test_step_mdp_speed[False-False-False-False-True] 57.8470μs 18.4083μs 54.3235 KOps/s 55.5402 KOps/s $\color{#d91a1a}-2.19\%$
test_step_mdp_speed[False-False-False-False-False] 35.8270μs 12.4579μs 80.2701 KOps/s 80.9776 KOps/s $\color{#d91a1a}-0.87\%$
test_values[generalized_advantage_estimate-True-True] 9.6676ms 9.2071ms 108.6124 Ops/s 108.0714 Ops/s $\color{#35bf28}+0.50\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.8951ms 35.4680ms 28.1944 Ops/s 30.3265 Ops/s $\textbf{\color{#d91a1a}-7.03\%}$
test_values[td0_return_estimate-False-False] 0.2294ms 0.1640ms 6.0981 KOps/s 5.7477 KOps/s $\textbf{\color{#35bf28}+6.10\%}$
test_values[td1_return_estimate-False-False] 23.8199ms 23.2270ms 43.0534 Ops/s 42.3544 Ops/s $\color{#35bf28}+1.65\%$
test_values[vec_td1_return_estimate-False-False] 36.9702ms 35.5188ms 28.1541 Ops/s 30.2906 Ops/s $\textbf{\color{#d91a1a}-7.05\%}$
test_values[td_lambda_return_estimate-True-False] 34.3880ms 33.2441ms 30.0805 Ops/s 29.7690 Ops/s $\color{#35bf28}+1.05\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.5257ms 35.4709ms 28.1921 Ops/s 30.2860 Ops/s $\textbf{\color{#d91a1a}-6.91\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.3279ms 8.1995ms 121.9581 Ops/s 122.1898 Ops/s $\color{#d91a1a}-0.19\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3670ms 1.8901ms 529.0738 Ops/s 554.5809 Ops/s $\color{#d91a1a}-4.60\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5314ms 0.3465ms 2.8861 KOps/s 2.8427 KOps/s $\color{#35bf28}+1.52\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 53.3474ms 43.7964ms 22.8329 Ops/s 22.6973 Ops/s $\color{#35bf28}+0.60\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7217ms 3.0104ms 332.1797 Ops/s 331.3072 Ops/s $\color{#35bf28}+0.26\%$
test_dqn_speed 7.0315ms 1.3430ms 744.6205 Ops/s 744.9719 Ops/s $\color{#d91a1a}-0.05\%$
test_ddpg_speed 3.3694ms 2.8115ms 355.6850 Ops/s 353.5451 Ops/s $\color{#35bf28}+0.61\%$
test_sac_speed 9.6199ms 8.4111ms 118.8906 Ops/s 118.0810 Ops/s $\color{#35bf28}+0.69\%$
test_redq_speed 87.2395ms 13.8865ms 72.0122 Ops/s 77.2277 Ops/s $\textbf{\color{#d91a1a}-6.75\%}$
test_redq_deprec_speed 14.1720ms 13.1379ms 76.1157 Ops/s 75.7878 Ops/s $\color{#35bf28}+0.43\%$
test_td3_speed 8.6666ms 8.3053ms 120.4055 Ops/s 120.0100 Ops/s $\color{#35bf28}+0.33\%$
test_cql_speed 38.5671ms 36.1753ms 27.6432 Ops/s 27.3781 Ops/s $\color{#35bf28}+0.97\%$
test_a2c_speed 8.4264ms 7.3706ms 135.6742 Ops/s 134.2797 Ops/s $\color{#35bf28}+1.04\%$
test_ppo_speed 8.6146ms 7.6102ms 131.4020 Ops/s 129.9686 Ops/s $\color{#35bf28}+1.10\%$
test_reinforce_speed 7.5935ms 6.5783ms 152.0141 Ops/s 150.6395 Ops/s $\color{#35bf28}+0.91\%$
test_iql_speed 33.8794ms 32.4432ms 30.8231 Ops/s 30.5253 Ops/s $\color{#35bf28}+0.98\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0375ms 2.0177ms 495.6110 Ops/s 497.7432 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1082ms 0.4865ms 2.0554 KOps/s 2.0381 KOps/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8701ms 0.4664ms 2.1439 KOps/s 2.1377 KOps/s $\color{#35bf28}+0.29\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1389ms 1.9768ms 505.8725 Ops/s 501.5375 Ops/s $\color{#35bf28}+0.86\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1499ms 0.4877ms 2.0504 KOps/s 2.0773 KOps/s $\color{#d91a1a}-1.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8551ms 0.4616ms 2.1663 KOps/s 2.1915 KOps/s $\color{#d91a1a}-1.15\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7366ms 1.2145ms 823.3555 Ops/s 812.5510 Ops/s $\color{#35bf28}+1.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6003ms 1.1504ms 869.2819 Ops/s 857.4361 Ops/s $\color{#35bf28}+1.38\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.3832ms 2.1463ms 465.9086 Ops/s 472.7684 Ops/s $\color{#d91a1a}-1.45\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1207ms 0.6009ms 1.6642 KOps/s 1.6481 KOps/s $\color{#35bf28}+0.98\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7816ms 0.5752ms 1.7385 KOps/s 1.7215 KOps/s $\color{#35bf28}+0.99\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.1160ms 2.0143ms 496.4576 Ops/s 502.1408 Ops/s $\color{#d91a1a}-1.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0154ms 0.4905ms 2.0389 KOps/s 2.0212 KOps/s $\color{#35bf28}+0.88\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6179ms 0.4628ms 2.1608 KOps/s 2.1211 KOps/s $\color{#35bf28}+1.87\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1890ms 2.0047ms 498.8365 Ops/s 505.4923 Ops/s $\color{#d91a1a}-1.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8311ms 0.4850ms 2.0620 KOps/s 2.0805 KOps/s $\color{#d91a1a}-0.89\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.5186ms 0.4675ms 2.1389 KOps/s 2.1488 KOps/s $\color{#d91a1a}-0.46\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.3927ms 2.1636ms 462.1826 Ops/s 478.0160 Ops/s $\color{#d91a1a}-3.31\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.6868ms 0.6013ms 1.6632 KOps/s 1.6455 KOps/s $\color{#35bf28}+1.07\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9404ms 0.5810ms 1.7212 KOps/s 1.7101 KOps/s $\color{#35bf28}+0.65\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1055s 7.4832ms 133.6333 Ops/s 132.3029 Ops/s $\color{#35bf28}+1.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 13.9606ms 11.9365ms 83.7764 Ops/s 83.3405 Ops/s $\color{#35bf28}+0.52\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.8263ms 1.1004ms 908.7267 Ops/s 912.7788 Ops/s $\color{#d91a1a}-0.44\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 97.3828ms 5.4838ms 182.3551 Ops/s 180.6072 Ops/s $\color{#35bf28}+0.97\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.3176ms 11.9703ms 83.5403 Ops/s 72.4711 Ops/s $\textbf{\color{#35bf28}+15.27\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5680ms 1.0657ms 938.3655 Ops/s 932.1586 Ops/s $\color{#35bf28}+0.67\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 98.4079ms 7.6598ms 130.5514 Ops/s 169.8832 Ops/s $\textbf{\color{#d91a1a}-23.15\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.5286ms 12.2206ms 81.8287 Ops/s 82.0435 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.4302ms 1.4609ms 684.5302 Ops/s 725.5155 Ops/s $\textbf{\color{#d91a1a}-5.65\%}$

@vmoens vmoens merged commit 23e2121 into main Apr 25, 2024
14 of 23 checks passed
@vmoens vmoens deleted the fix-isaac branch April 25, 2024 14:30
vmoens added a commit that referenced this pull request Apr 25, 2024
@vmoens
Revert "[BugFix] Fix Isaac (#2072)"
bcb9e6d 
This reverts commit 23e2121.
@vmoens vmoens mentioned this pull request Apr 25, 2024
Merged
@vmoens vmoens restored the fix-isaac branch April 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot