Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Remove duplicate if statement in storages #2066

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[Minor] Remove duplicate if statement in storages #2066

merged 1 commit into from
Apr 8, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 8, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2066

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 15 Unrelated Failures

As of commit 58053f5 with merge base cf685b7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@vmoens vmoens added the quality code quality label Apr 8, 2024
@vmoens vmoens merged commit 90542ef into main Apr 8, 2024
33 of 51 checks passed
@vmoens vmoens deleted the remove-duplicate-if branch April 8, 2024 09:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 56.6663ms 54.7709ms 18.2579 Ops/s 17.1987 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_sync 43.6197ms 32.0553ms 31.1961 Ops/s 33.2899 Ops/s $\textbf{\color{#d91a1a}-6.29\%}$
test_async 63.6873ms 29.1448ms 34.3115 Ops/s 36.2314 Ops/s $\textbf{\color{#d91a1a}-5.30\%}$
test_simple 0.4271s 0.3602s 2.7762 Ops/s 2.9327 Ops/s $\textbf{\color{#d91a1a}-5.34\%}$
test_transformed 0.5742s 0.5155s 1.9398 Ops/s 2.0309 Ops/s $\color{#d91a1a}-4.48\%$
test_serial 1.3188s 1.2603s 0.7935 Ops/s 0.8051 Ops/s $\color{#d91a1a}-1.44\%$
test_parallel 1.1009s 1.0209s 0.9795 Ops/s 0.9750 Ops/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[True-True-True-True-True] 0.1729ms 21.1555μs 47.2690 KOps/s 47.2630 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[True-True-True-True-False] 42.6900μs 12.9439μs 77.2564 KOps/s 78.5841 KOps/s $\color{#d91a1a}-1.69\%$
test_step_mdp_speed[True-True-True-False-True] 48.4300μs 12.3568μs 80.9270 KOps/s 81.6272 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-True-True-False-False] 49.2620μs 7.4177μs 134.8128 KOps/s 133.7139 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-True-False-True-True] 67.0060μs 22.5989μs 44.2499 KOps/s 44.8994 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[True-True-False-True-False] 47.9700μs 14.3000μs 69.9302 KOps/s 70.8626 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[True-True-False-False-True] 59.0310μs 13.6227μs 73.4067 KOps/s 74.5198 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[True-True-False-False-False] 41.2480μs 8.7247μs 114.6166 KOps/s 116.0351 KOps/s $\color{#d91a1a}-1.22\%$
test_step_mdp_speed[True-False-True-True-True] 78.9010μs 24.0388μs 41.5994 KOps/s 42.3177 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[True-False-True-True-False] 46.8980μs 15.5918μs 64.1363 KOps/s 65.3840 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[True-False-True-False-True] 44.9840μs 13.7146μs 72.9152 KOps/s 74.1318 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-True-False-False] 59.9620μs 8.6790μs 115.2204 KOps/s 114.3216 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[True-False-False-True-True] 72.5260μs 25.0057μs 39.9908 KOps/s 40.0293 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[True-False-False-True-False] 53.5400μs 16.7185μs 59.8140 KOps/s 60.6424 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[True-False-False-False-True] 47.8700μs 14.7935μs 67.5973 KOps/s 68.7045 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[True-False-False-False-False] 39.7350μs 9.8617μs 101.4026 KOps/s 101.0839 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[False-True-True-True-True] 76.9640μs 24.0112μs 41.6472 KOps/s 41.9322 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-True-True-True-False] 68.9600μs 15.5575μs 64.2776 KOps/s 64.8635 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[False-True-True-False-True] 61.9360μs 15.9698μs 62.6184 KOps/s 63.6734 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[False-True-True-False-False] 36.9900μs 9.8948μs 101.0635 KOps/s 100.9374 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-True-False-True-True] 40.1750μs 25.5856μs 39.0845 KOps/s 38.7614 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-True-False-True-False] 72.5060μs 16.7797μs 59.5958 KOps/s 60.4491 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-True-False-False-True] 59.0810μs 17.1151μs 58.4281 KOps/s 59.2732 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-True-False-False-False] 53.9110μs 11.1823μs 89.4268 KOps/s 90.7296 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-False-True-True-True] 63.1580μs 26.4733μs 37.7739 KOps/s 37.7991 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-False-True-True-False] 51.8680μs 17.9195μs 55.8050 KOps/s 56.2162 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-False-True-False-True] 46.7470μs 17.1476μs 58.3172 KOps/s 58.5125 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[False-False-True-False-False] 48.4200μs 11.0857μs 90.2064 KOps/s 90.0055 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-False-False-True-True] 73.9190μs 27.4181μs 36.4723 KOps/s 36.5551 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-False-True-False] 60.0630μs 18.9506μs 52.7689 KOps/s 52.6117 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[False-False-False-False-True] 69.5410μs 18.1407μs 55.1246 KOps/s 55.8364 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-False-False-False-False] 75.2110μs 12.1742μs 82.1411 KOps/s 82.2361 KOps/s $\color{#d91a1a}-0.12\%$
test_values[generalized_advantage_estimate-True-True] 9.6831ms 9.3983ms 106.4017 Ops/s 101.5481 Ops/s $\color{#35bf28}+4.78\%$
test_values[vec_generalized_advantage_estimate-True-True] 40.8993ms 36.0676ms 27.7257 Ops/s 29.6582 Ops/s $\textbf{\color{#d91a1a}-6.52\%}$
test_values[td0_return_estimate-False-False] 0.2437ms 0.2038ms 4.9065 KOps/s 4.9754 KOps/s $\color{#d91a1a}-1.38\%$
test_values[td1_return_estimate-False-False] 27.2352ms 24.1039ms 41.4871 Ops/s 41.1834 Ops/s $\color{#35bf28}+0.74\%$
test_values[vec_td1_return_estimate-False-False] 38.3926ms 35.7660ms 27.9595 Ops/s 29.5938 Ops/s $\textbf{\color{#d91a1a}-5.52\%}$
test_values[td_lambda_return_estimate-True-False] 36.1063ms 34.4544ms 29.0239 Ops/s 28.6309 Ops/s $\color{#35bf28}+1.37\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.0775ms 35.6665ms 28.0375 Ops/s 29.5432 Ops/s $\textbf{\color{#d91a1a}-5.10\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4623ms 8.2779ms 120.8029 Ops/s 118.2335 Ops/s $\color{#35bf28}+2.17\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3546ms 2.0253ms 493.7492 Ops/s 506.1174 Ops/s $\color{#d91a1a}-2.44\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5276ms 0.3551ms 2.8164 KOps/s 2.8242 KOps/s $\color{#d91a1a}-0.27\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.4972ms 46.0615ms 21.7101 Ops/s 24.0325 Ops/s $\textbf{\color{#d91a1a}-9.66\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 5.0181ms 3.2087ms 311.6547 Ops/s 305.9581 Ops/s $\color{#35bf28}+1.86\%$
test_dqn_speed 1.8335ms 1.3790ms 725.1739 Ops/s 690.8092 Ops/s $\color{#35bf28}+4.97\%$
test_ddpg_speed 3.4355ms 2.7385ms 365.1569 Ops/s 333.5740 Ops/s $\textbf{\color{#35bf28}+9.47\%}$
test_sac_speed 10.6495ms 9.1969ms 108.7321 Ops/s 105.6112 Ops/s $\color{#35bf28}+2.96\%$
test_redq_speed 15.3385ms 13.8507ms 72.1983 Ops/s 71.9201 Ops/s $\color{#35bf28}+0.39\%$
test_redq_deprec_speed 17.5087ms 15.1005ms 66.2231 Ops/s 63.3142 Ops/s $\color{#35bf28}+4.59\%$
test_td3_speed 18.4798ms 9.4126ms 106.2400 Ops/s 107.6618 Ops/s $\color{#d91a1a}-1.32\%$
test_cql_speed 41.0060ms 38.2460ms 26.1465 Ops/s 26.4921 Ops/s $\color{#d91a1a}-1.30\%$
test_a2c_speed 8.9569ms 8.2080ms 121.8325 Ops/s 123.6285 Ops/s $\color{#d91a1a}-1.45\%$
test_ppo_speed 9.1535ms 8.4330ms 118.5812 Ops/s 119.7125 Ops/s $\color{#d91a1a}-0.94\%$
test_reinforce_speed 8.5104ms 7.2628ms 137.6871 Ops/s 141.7059 Ops/s $\color{#d91a1a}-2.84\%$
test_iql_speed 40.5941ms 35.0771ms 28.5086 Ops/s 29.2600 Ops/s $\color{#d91a1a}-2.57\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.4485ms 2.6101ms 383.1261 Ops/s 372.5355 Ops/s $\color{#35bf28}+2.84\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0451ms 0.5372ms 1.8616 KOps/s 1.6638 KOps/s $\textbf{\color{#35bf28}+11.89\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6814ms 0.5019ms 1.9924 KOps/s 1.9818 KOps/s $\color{#35bf28}+0.54\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1686ms 2.6363ms 379.3174 Ops/s 361.4441 Ops/s $\color{#35bf28}+4.94\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0677ms 0.5321ms 1.8793 KOps/s 1.9049 KOps/s $\color{#d91a1a}-1.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7626ms 0.5019ms 1.9925 KOps/s 2.0242 KOps/s $\color{#d91a1a}-1.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.3114ms 1.2629ms 791.8186 Ops/s 792.5599 Ops/s $\color{#d91a1a}-0.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6150ms 1.1950ms 836.7977 Ops/s 847.8208 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.6501ms 2.9821ms 335.3327 Ops/s 348.9851 Ops/s $\color{#d91a1a}-3.91\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8654ms 0.6643ms 1.5053 KOps/s 1.5208 KOps/s $\color{#d91a1a}-1.02\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.8994ms 0.6213ms 1.6094 KOps/s 1.5882 KOps/s $\color{#35bf28}+1.33\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2366ms 2.7127ms 368.6414 Ops/s 360.6620 Ops/s $\color{#35bf28}+2.21\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7699ms 0.5353ms 1.8683 KOps/s 1.8845 KOps/s $\color{#d91a1a}-0.86\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.2238ms 0.5112ms 1.9562 KOps/s 1.9541 KOps/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0426ms 2.5363ms 394.2701 Ops/s 349.3677 Ops/s $\textbf{\color{#35bf28}+12.85\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3570ms 0.5317ms 1.8806 KOps/s 1.8679 KOps/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6995ms 0.5018ms 1.9927 KOps/s 1.9932 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.1251ms 2.7447ms 364.3400 Ops/s 332.0712 Ops/s $\textbf{\color{#35bf28}+9.72\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8656ms 0.6585ms 1.5186 KOps/s 1.5358 KOps/s $\color{#d91a1a}-1.12\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.0209ms 0.6394ms 1.5640 KOps/s 1.5734 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1178s 8.1537ms 122.6438 Ops/s 119.9092 Ops/s $\color{#35bf28}+2.28\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.1506ms 13.0055ms 76.8905 Ops/s 77.9226 Ops/s $\color{#d91a1a}-1.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2272ms 1.0634ms 940.3881 Ops/s 913.9324 Ops/s $\color{#35bf28}+2.89\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1052s 7.8526ms 127.3468 Ops/s 122.0427 Ops/s $\color{#35bf28}+4.35\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.5284ms 12.7637ms 78.3470 Ops/s 76.6707 Ops/s $\color{#35bf28}+2.19\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.2239ms 1.0630ms 940.6947 Ops/s 922.2461 Ops/s $\color{#35bf28}+2.00\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1076s 6.2852ms 159.1032 Ops/s 159.1356 Ops/s $\color{#d91a1a}-0.02\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 20.8723ms 13.6516ms 73.2513 Ops/s 64.3758 Ops/s $\textbf{\color{#35bf28}+13.79\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1823ms 1.4998ms 666.7404 Ops/s 708.1239 Ops/s $\textbf{\color{#d91a1a}-5.84\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 98.0700ms 97.9063ms 10.2138 Ops/s 9.6007 Ops/s $\textbf{\color{#35bf28}+6.39\%}$
test_sync 86.7836ms 86.1849ms 11.6030 Ops/s 11.6316 Ops/s $\color{#d91a1a}-0.25\%$
test_async 0.1611s 70.3011ms 14.2245 Ops/s 11.9276 Ops/s $\textbf{\color{#35bf28}+19.26\%}$
test_single_pixels 0.1789s 0.1160s 8.6230 Ops/s 9.1400 Ops/s $\textbf{\color{#d91a1a}-5.66\%}$
test_sync_pixels 0.1239s 69.5426ms 14.3797 Ops/s 13.8279 Ops/s $\color{#35bf28}+3.99\%$
test_async_pixels 0.1221s 60.9607ms 16.4040 Ops/s 16.6316 Ops/s $\color{#d91a1a}-1.37\%$
test_simple 0.6689s 0.6596s 1.5160 Ops/s 1.4576 Ops/s $\color{#35bf28}+4.01\%$
test_transformed 0.8734s 0.8722s 1.1465 Ops/s 1.0889 Ops/s $\textbf{\color{#35bf28}+5.29\%}$
test_serial 2.1098s 2.0530s 0.4871 Ops/s 0.4690 Ops/s $\color{#35bf28}+3.85\%$
test_parallel 1.7928s 1.7515s 0.5709 Ops/s 0.5629 Ops/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-True-True-True-True] 61.3310μs 34.2830μs 29.1690 KOps/s 30.3026 KOps/s $\color{#d91a1a}-3.74\%$
test_step_mdp_speed[True-True-True-True-False] 34.5200μs 19.8023μs 50.4992 KOps/s 51.0671 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-True-True-False-True] 46.7310μs 19.2992μs 51.8156 KOps/s 53.5084 KOps/s $\color{#d91a1a}-3.16\%$
test_step_mdp_speed[True-True-True-False-False] 28.1210μs 11.4937μs 87.0044 KOps/s 89.3861 KOps/s $\color{#d91a1a}-2.66\%$
test_step_mdp_speed[True-True-False-True-True] 59.0210μs 35.8453μs 27.8977 KOps/s 28.6086 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[True-True-False-True-False] 37.9510μs 22.1165μs 45.2152 KOps/s 46.8446 KOps/s $\color{#d91a1a}-3.48\%$
test_step_mdp_speed[True-True-False-False-True] 42.5210μs 21.1124μs 47.3655 KOps/s 48.3427 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[True-True-False-False-False] 30.6910μs 13.4925μs 74.1150 KOps/s 76.2283 KOps/s $\color{#d91a1a}-2.77\%$
test_step_mdp_speed[True-False-True-True-True] 64.6310μs 37.7394μs 26.4975 KOps/s 26.9978 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[True-False-True-True-False] 44.5300μs 23.9859μs 41.6911 KOps/s 42.4251 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-False-True-False-True] 38.4010μs 20.9640μs 47.7008 KOps/s 48.6283 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[True-False-True-False-False] 38.8910μs 13.3323μs 75.0057 KOps/s 76.0121 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[True-False-False-True-True] 78.3720μs 39.6979μs 25.1902 KOps/s 25.8433 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[True-False-False-True-False] 52.6410μs 25.9204μs 38.5797 KOps/s 39.8300 KOps/s $\color{#d91a1a}-3.14\%$
test_step_mdp_speed[True-False-False-False-True] 44.0710μs 23.0242μs 43.4326 KOps/s 44.6179 KOps/s $\color{#d91a1a}-2.66\%$
test_step_mdp_speed[True-False-False-False-False] 33.0510μs 15.2264μs 65.6754 KOps/s 66.6856 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[False-True-True-True-True] 64.2910μs 37.4771μs 26.6829 KOps/s 27.2160 KOps/s $\color{#d91a1a}-1.96\%$
test_step_mdp_speed[False-True-True-True-False] 45.0310μs 24.1531μs 41.4025 KOps/s 42.5627 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[False-True-True-False-True] 42.8910μs 25.4203μs 39.3387 KOps/s 40.6323 KOps/s $\color{#d91a1a}-3.18\%$
test_step_mdp_speed[False-True-True-False-False] 41.4510μs 15.1624μs 65.9524 KOps/s 66.7648 KOps/s $\color{#d91a1a}-1.22\%$
test_step_mdp_speed[False-True-False-True-True] 68.0710μs 39.7820μs 25.1370 KOps/s 25.6780 KOps/s $\color{#d91a1a}-2.11\%$
test_step_mdp_speed[False-True-False-True-False] 48.8810μs 26.0808μs 38.3424 KOps/s 39.2111 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-False-False-True] 44.7210μs 27.3308μs 36.5888 KOps/s 38.0197 KOps/s $\color{#d91a1a}-3.76\%$
test_step_mdp_speed[False-True-False-False-False] 32.6300μs 17.0561μs 58.6301 KOps/s 59.7770 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[False-False-True-True-True] 68.5010μs 41.1958μs 24.2743 KOps/s 24.4631 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-False-True-True-False] 51.0210μs 27.7657μs 36.0156 KOps/s 36.4410 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[False-False-True-False-True] 76.7220μs 26.4089μs 37.8660 KOps/s 38.7991 KOps/s $\color{#d91a1a}-2.40\%$
test_step_mdp_speed[False-False-True-False-False] 31.5200μs 16.8862μs 59.2199 KOps/s 59.9694 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[False-False-False-True-True] 80.9310μs 42.0951μs 23.7558 KOps/s 23.5236 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-False-False-True-False] 46.2210μs 29.6244μs 33.7560 KOps/s 34.0953 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-False-False-False-True] 54.9710μs 27.9821μs 35.7371 KOps/s 36.0990 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-False-False-False-False] 35.8710μs 18.6475μs 53.6264 KOps/s 54.0476 KOps/s $\color{#d91a1a}-0.78\%$
test_values[generalized_advantage_estimate-True-True] 23.1990ms 22.6646ms 44.1216 Ops/s 44.1316 Ops/s $\color{#d91a1a}-0.02\%$
test_values[vec_generalized_advantage_estimate-True-True] 81.2322ms 3.1733ms 315.1314 Ops/s 315.4533 Ops/s $\color{#d91a1a}-0.10\%$
test_values[td0_return_estimate-False-False] 0.1065ms 61.5827μs 16.2383 KOps/s 16.3270 KOps/s $\color{#d91a1a}-0.54\%$
test_values[td1_return_estimate-False-False] 49.9805ms 48.8610ms 20.4662 Ops/s 20.4592 Ops/s $\color{#35bf28}+0.03\%$
test_values[vec_td1_return_estimate-False-False] 2.0446ms 1.7399ms 574.7603 Ops/s 576.8359 Ops/s $\color{#d91a1a}-0.36\%$
test_values[td_lambda_return_estimate-True-False] 78.7040ms 77.8817ms 12.8400 Ops/s 12.8499 Ops/s $\color{#d91a1a}-0.08\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0965ms 1.7330ms 577.0320 Ops/s 577.7148 Ops/s $\color{#d91a1a}-0.12\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 21.6445ms 21.4446ms 46.6317 Ops/s 46.2243 Ops/s $\color{#35bf28}+0.88\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8463ms 0.6706ms 1.4913 KOps/s 1.5010 KOps/s $\color{#d91a1a}-0.65\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7055ms 0.6253ms 1.5992 KOps/s 1.6069 KOps/s $\color{#d91a1a}-0.48\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4573ms 1.4283ms 700.1146 Ops/s 701.4593 Ops/s $\color{#d91a1a}-0.19\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9455ms 0.6470ms 1.5456 KOps/s 1.5526 KOps/s $\color{#d91a1a}-0.45\%$
test_dqn_speed 3.8256ms 1.3967ms 715.9753 Ops/s 695.5862 Ops/s $\color{#35bf28}+2.93\%$
test_ddpg_speed 2.9906ms 2.6680ms 374.8153 Ops/s 361.9325 Ops/s $\color{#35bf28}+3.56\%$
test_sac_speed 8.1675ms 7.7528ms 128.9855 Ops/s 125.3617 Ops/s $\color{#35bf28}+2.89\%$
test_redq_speed 10.8351ms 9.9258ms 100.7478 Ops/s 97.8512 Ops/s $\color{#35bf28}+2.96\%$
test_redq_deprec_speed 11.2706ms 10.6349ms 94.0299 Ops/s 91.2942 Ops/s $\color{#35bf28}+3.00\%$
test_td3_speed 8.0923ms 7.7121ms 129.6662 Ops/s 125.5090 Ops/s $\color{#35bf28}+3.31\%$
test_cql_speed 26.0771ms 24.9209ms 40.1270 Ops/s 40.0195 Ops/s $\color{#35bf28}+0.27\%$
test_a2c_speed 5.9433ms 5.4324ms 184.0801 Ops/s 182.1760 Ops/s $\color{#35bf28}+1.05\%$
test_ppo_speed 6.4484ms 5.7056ms 175.2653 Ops/s 170.4972 Ops/s $\color{#35bf28}+2.80\%$
test_reinforce_speed 4.8039ms 4.4245ms 226.0126 Ops/s 222.9009 Ops/s $\color{#35bf28}+1.40\%$
test_iql_speed 19.3728ms 18.9030ms 52.9017 Ops/s 51.7787 Ops/s $\color{#35bf28}+2.17\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9805ms 2.8959ms 345.3152 Ops/s 350.3687 Ops/s $\color{#d91a1a}-1.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4239ms 0.5475ms 1.8265 KOps/s 1.8042 KOps/s $\color{#35bf28}+1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7203ms 0.5269ms 1.8978 KOps/s 1.8624 KOps/s $\color{#35bf28}+1.90\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0495ms 2.8850ms 346.6148 Ops/s 348.0354 Ops/s $\color{#d91a1a}-0.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6720ms 0.5403ms 1.8507 KOps/s 1.8288 KOps/s $\color{#35bf28}+1.20\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.2345ms 0.5210ms 1.9195 KOps/s 1.9205 KOps/s $\color{#d91a1a}-0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4993ms 1.3871ms 720.9544 Ops/s 709.5975 Ops/s $\color{#35bf28}+1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4519ms 1.3128ms 761.7091 Ops/s 745.0713 Ops/s $\color{#35bf28}+2.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0652ms 3.0156ms 331.6129 Ops/s 333.5815 Ops/s $\color{#d91a1a}-0.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1929ms 0.6587ms 1.5182 KOps/s 1.5098 KOps/s $\color{#35bf28}+0.56\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8301ms 0.6304ms 1.5863 KOps/s 1.3740 KOps/s $\textbf{\color{#35bf28}+15.45\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9727ms 2.8733ms 348.0279 Ops/s 347.2280 Ops/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6628ms 0.5380ms 1.8587 KOps/s 1.8323 KOps/s $\color{#35bf28}+1.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1060s 0.6328ms 1.5803 KOps/s 1.9188 KOps/s $\textbf{\color{#d91a1a}-17.64\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0298ms 2.9125ms 343.3521 Ops/s 346.6317 Ops/s $\color{#d91a1a}-0.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6426ms 0.5307ms 1.8843 KOps/s 1.8676 KOps/s $\color{#35bf28}+0.90\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6758ms 0.5049ms 1.9804 KOps/s 1.5393 KOps/s $\textbf{\color{#35bf28}+28.65\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1714ms 3.0192ms 331.2149 Ops/s 332.4969 Ops/s $\color{#d91a1a}-0.39\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3324ms 0.6615ms 1.5117 KOps/s 1.4919 KOps/s $\color{#35bf28}+1.33\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1042s 0.7625ms 1.3114 KOps/s 1.5566 KOps/s $\textbf{\color{#d91a1a}-15.75\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1012s 6.6461ms 150.4647 Ops/s 116.0422 Ops/s $\textbf{\color{#35bf28}+29.66\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.3656ms 14.4573ms 69.1692 Ops/s 68.4438 Ops/s $\color{#35bf28}+1.06\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2076ms 1.0942ms 913.9431 Ops/s 940.9680 Ops/s $\color{#d91a1a}-2.87\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1008s 8.5286ms 117.2521 Ops/s 149.4664 Ops/s $\textbf{\color{#d91a1a}-21.55\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.7876ms 14.4275ms 69.3121 Ops/s 60.6056 Ops/s $\textbf{\color{#35bf28}+14.37\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.1057ms 1.0714ms 933.3850 Ops/s 914.4321 Ops/s $\color{#35bf28}+2.07\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.4062ms 6.9640ms 143.5949 Ops/s 143.0668 Ops/s $\color{#35bf28}+0.37\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9646ms 14.7506ms 67.7939 Ops/s 66.9219 Ops/s $\color{#35bf28}+1.30\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4361ms 1.4080ms 710.2416 Ops/s 657.2680 Ops/s $\textbf{\color{#35bf28}+8.06\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot