Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Environment] Meltingpot #2054

Merged
merged 68 commits into from
Apr 17, 2024
Merged

[Environment] Meltingpot #2054

merged 68 commits into from
Apr 17, 2024

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Apr 3, 2024 •
edited
Loading

Wrapper for the https://github.com/google-deepmind/meltingpot multiagent library!

If you try this make sure to use the github main of tensordict as well

cc @ezhang7423 , @DJayalath

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2054

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 530e169 with merge base 730dd45 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
@matteobettini matteobettini marked this pull request as ready for review April 3, 2024 12:53
@matteobettini
Copy link
Contributor Author

We should be good for review!

@ezhang7423
Copy link

Thanks so much @matteobettini. Testing now on my end.

@ezhang7423
Copy link

Worked for me!

@ezhang7423
Copy link

I think we want to add MeltingpotEnv and MeltingpotWrapper to ./torchrl/envs/__init__.py as well?

vmoens
vmoens reviewed Apr 7, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, superb!

.github/workflows/test-linux-libs.yml Outdated Show resolved Hide resolved
torchrl/envs/libs/meltingpot.py Show resolved Hide resolved
torchrl/envs/libs/meltingpot.py Outdated Show resolved Hide resolved
torchrl/envs/libs/meltingpot.py Outdated Show resolved Hide resolved
torchrl/envs/libs/meltingpot.py Outdated Show resolved Hide resolved
torchrl/envs/libs/meltingpot.py Outdated Show resolved Hide resolved
matteobettini and others added 2 commits April 7, 2024 17:29
@matteobettini @vmoens
Update torchrl/envs/libs/meltingpot.py
6cfda1b 
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@matteobettini @vmoens
Update torchrl/envs/libs/meltingpot.py
096bc94 
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@vmoens vmoens added enhancement New feature or request Environments Adds or modifies an environment wrapper labels Apr 7, 2024
@vmoens
Copy link
Contributor

vmoens commented Apr 10, 2024

I don't get why we keep on reverting the change from 4eef4d5, let's first make it work from source and then see if we can improve.

From what I see dmlab2d should be installable on this machine, let's figure out why it's not working
https://pypi.org/project/dmlab2d/#files

@matteobettini
Copy link
Contributor Author

What should we do with this? Is there any way you can allow me to run the CI?

@vmoens
Copy link
Contributor

vmoens commented Apr 16, 2024

It's a docker image issue. Leave it with me!

vmoens
vmoens reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vmoens
vmoens approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit a740559 into pytorch:main Apr 17, 2024
64 of 67 checks passed
@matteobettini matteobettini deleted the melitingpot branch April 17, 2024 21:23
@ezhang7423
Copy link

Congrats @matteobettini @vmoens !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matteobettini @ezhang7423 @vmoens @facebook-github-bot