Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc,Feature] Better doc for modules and list of kwargs when possible #1990

Merged
merged 7 commits into from
Mar 5, 2024
Merged

[Doc,Feature] Better doc for modules and list of kwargs when possible #1990

merged 7 commits into from
Mar 5, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 4, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1990

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 21 Unrelated Failures

As of commit 6a1dd2e with merge base 3a41f40 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 61.0117ms 60.6246ms 16.4950 Ops/s 16.4859 Ops/s $\color{#35bf28}+0.05\%$
test_sync 37.3040ms 32.7272ms 30.5557 Ops/s 30.3074 Ops/s $\color{#35bf28}+0.82\%$
test_async 57.4628ms 31.1686ms 32.0836 Ops/s 32.8634 Ops/s $\color{#d91a1a}-2.37\%$
test_simple 0.4813s 0.4242s 2.3572 Ops/s 2.4152 Ops/s $\color{#d91a1a}-2.40\%$
test_transformed 0.6300s 0.5778s 1.7308 Ops/s 1.7419 Ops/s $\color{#d91a1a}-0.63\%$
test_serial 1.4356s 1.3873s 0.7208 Ops/s 0.7067 Ops/s $\color{#35bf28}+2.00\%$
test_parallel 1.4092s 1.3409s 0.7458 Ops/s 0.7295 Ops/s $\color{#35bf28}+2.23\%$
test_step_mdp_speed[True-True-True-True-True] 0.1479ms 21.8788μs 45.7063 KOps/s 47.6747 KOps/s $\color{#d91a1a}-4.13\%$
test_step_mdp_speed[True-True-True-True-False] 48.8310μs 13.2537μs 75.4506 KOps/s 78.0890 KOps/s $\color{#d91a1a}-3.38\%$
test_step_mdp_speed[True-True-True-False-True] 46.2560μs 12.7295μs 78.5578 KOps/s 81.2979 KOps/s $\color{#d91a1a}-3.37\%$
test_step_mdp_speed[True-True-True-False-False] 39.1930μs 7.6454μs 130.7983 KOps/s 132.7498 KOps/s $\color{#d91a1a}-1.47\%$
test_step_mdp_speed[True-True-False-True-True] 71.7540μs 23.3492μs 42.8280 KOps/s 44.4570 KOps/s $\color{#d91a1a}-3.66\%$
test_step_mdp_speed[True-True-False-True-False] 73.2170μs 14.4285μs 69.3071 KOps/s 70.3986 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[True-True-False-False-True] 50.5840μs 14.0693μs 71.0767 KOps/s 73.7037 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[True-True-False-False-False] 28.5930μs 9.1343μs 109.4776 KOps/s 114.0194 KOps/s $\color{#d91a1a}-3.98\%$
test_step_mdp_speed[True-False-True-True-True] 61.9560μs 24.7788μs 40.3571 KOps/s 41.7260 KOps/s $\color{#d91a1a}-3.28\%$
test_step_mdp_speed[True-False-True-True-False] 49.4320μs 15.8756μs 62.9896 KOps/s 64.1235 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[True-False-True-False-True] 38.7230μs 13.9650μs 71.6074 KOps/s 73.1598 KOps/s $\color{#d91a1a}-2.12\%$
test_step_mdp_speed[True-False-True-False-False] 46.4560μs 8.9934μs 111.1928 KOps/s 113.0007 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[True-False-False-True-True] 55.5530μs 25.3954μs 39.3772 KOps/s 39.8481 KOps/s $\color{#d91a1a}-1.18\%$
test_step_mdp_speed[True-False-False-True-False] 52.7690μs 16.9747μs 58.9114 KOps/s 59.8949 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-False-False-True] 47.1480μs 14.9925μs 66.7001 KOps/s 67.8538 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[True-False-False-False-False] 43.4810μs 10.2943μs 97.1414 KOps/s 100.6933 KOps/s $\color{#d91a1a}-3.53\%$
test_step_mdp_speed[False-True-True-True-True] 52.3780μs 24.2804μs 41.1855 KOps/s 41.8436 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-True-True-True-False] 52.2470μs 15.7758μs 63.3883 KOps/s 64.5296 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[False-True-True-False-True] 79.1970μs 16.2835μs 61.4120 KOps/s 64.1000 KOps/s $\color{#d91a1a}-4.19\%$
test_step_mdp_speed[False-True-True-False-False] 34.7440μs 10.1746μs 98.2837 KOps/s 101.7334 KOps/s $\color{#d91a1a}-3.39\%$
test_step_mdp_speed[False-True-False-True-True] 43.4410μs 26.1304μs 38.2696 KOps/s 39.8965 KOps/s $\color{#d91a1a}-4.08\%$
test_step_mdp_speed[False-True-False-True-False] 44.9640μs 17.3054μs 57.7855 KOps/s 60.3819 KOps/s $\color{#d91a1a}-4.30\%$
test_step_mdp_speed[False-True-False-False-True] 43.7320μs 17.3343μs 57.6892 KOps/s 59.5316 KOps/s $\color{#d91a1a}-3.09\%$
test_step_mdp_speed[False-True-False-False-False] 51.9370μs 11.5522μs 86.5638 KOps/s 91.5210 KOps/s $\textbf{\color{#d91a1a}-5.42\%}$
test_step_mdp_speed[False-False-True-True-True] 60.1820μs 26.8244μs 37.2795 KOps/s 38.5459 KOps/s $\color{#d91a1a}-3.29\%$
test_step_mdp_speed[False-False-True-True-False] 61.1040μs 18.5302μs 53.9660 KOps/s 55.9361 KOps/s $\color{#d91a1a}-3.52\%$
test_step_mdp_speed[False-False-True-False-True] 59.7010μs 17.6667μs 56.6036 KOps/s 59.1277 KOps/s $\color{#d91a1a}-4.27\%$
test_step_mdp_speed[False-False-True-False-False] 41.0970μs 11.4313μs 87.4792 KOps/s 89.9543 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[False-False-False-True-True] 72.7760μs 28.4134μs 35.1946 KOps/s 36.6280 KOps/s $\color{#d91a1a}-3.91\%$
test_step_mdp_speed[False-False-False-True-False] 52.5780μs 19.8817μs 50.2976 KOps/s 52.7779 KOps/s $\color{#d91a1a}-4.70\%$
test_step_mdp_speed[False-False-False-False-True] 66.4430μs 18.5895μs 53.7938 KOps/s 55.9736 KOps/s $\color{#d91a1a}-3.89\%$
test_step_mdp_speed[False-False-False-False-False] 39.3230μs 12.7177μs 78.6309 KOps/s 82.6278 KOps/s $\color{#d91a1a}-4.84\%$
test_values[generalized_advantage_estimate-True-True] 13.1213ms 9.8882ms 101.1310 Ops/s 108.3914 Ops/s $\textbf{\color{#d91a1a}-6.70\%}$
test_values[vec_generalized_advantage_estimate-True-True] 36.9426ms 33.9418ms 29.4622 Ops/s 29.8074 Ops/s $\color{#d91a1a}-1.16\%$
test_values[td0_return_estimate-False-False] 0.2748ms 0.1821ms 5.4925 KOps/s 5.5632 KOps/s $\color{#d91a1a}-1.27\%$
test_values[td1_return_estimate-False-False] 27.1501ms 24.7177ms 40.4568 Ops/s 43.6070 Ops/s $\textbf{\color{#d91a1a}-7.22\%}$
test_values[vec_td1_return_estimate-False-False] 36.3316ms 34.1368ms 29.2939 Ops/s 29.7130 Ops/s $\color{#d91a1a}-1.41\%$
test_values[td_lambda_return_estimate-True-False] 36.7016ms 35.0562ms 28.5256 Ops/s 29.9916 Ops/s $\color{#d91a1a}-4.89\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.5721ms 34.0282ms 29.3874 Ops/s 29.7939 Ops/s $\color{#d91a1a}-1.36\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.4519ms 8.5025ms 117.6126 Ops/s 124.2117 Ops/s $\textbf{\color{#d91a1a}-5.31\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4102ms 2.0107ms 497.3489 Ops/s 550.6082 Ops/s $\textbf{\color{#d91a1a}-9.67\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5917ms 0.3681ms 2.7170 KOps/s 2.8255 KOps/s $\color{#d91a1a}-3.84\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.5901ms 47.0486ms 21.2546 Ops/s 23.6969 Ops/s $\textbf{\color{#d91a1a}-10.31\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.8348ms 3.0379ms 329.1756 Ops/s 329.6035 Ops/s $\color{#d91a1a}-0.13\%$
test_dqn_speed 7.2163ms 1.3840ms 722.5213 Ops/s 726.5808 Ops/s $\color{#d91a1a}-0.56\%$
test_ddpg_speed 3.5526ms 2.7189ms 367.7989 Ops/s 367.4964 Ops/s $\color{#35bf28}+0.08\%$
test_sac_speed 89.9647ms 9.0979ms 109.9159 Ops/s 121.5049 Ops/s $\textbf{\color{#d91a1a}-9.54\%}$
test_redq_speed 15.1125ms 13.4805ms 74.1814 Ops/s 75.5123 Ops/s $\color{#d91a1a}-1.76\%$
test_redq_deprec_speed 14.5062ms 13.2333ms 75.5671 Ops/s 74.5301 Ops/s $\color{#35bf28}+1.39\%$
test_td3_speed 10.2579ms 8.3317ms 120.0241 Ops/s 123.4876 Ops/s $\color{#d91a1a}-2.80\%$
test_cql_speed 37.9593ms 36.5828ms 27.3353 Ops/s 27.6229 Ops/s $\color{#d91a1a}-1.04\%$
test_a2c_speed 8.2832ms 7.5272ms 132.8517 Ops/s 133.7964 Ops/s $\color{#d91a1a}-0.71\%$
test_ppo_speed 9.0742ms 7.7997ms 128.2098 Ops/s 129.1131 Ops/s $\color{#d91a1a}-0.70\%$
test_reinforce_speed 7.5948ms 6.6258ms 150.9256 Ops/s 150.4249 Ops/s $\color{#35bf28}+0.33\%$
test_iql_speed 34.3324ms 33.0517ms 30.2556 Ops/s 30.3807 Ops/s $\color{#d91a1a}-0.41\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3940ms 2.3398ms 427.3858 Ops/s 440.0993 Ops/s $\color{#d91a1a}-2.89\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1845ms 0.5020ms 1.9922 KOps/s 1.9933 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9698ms 0.4886ms 2.0467 KOps/s 2.0841 KOps/s $\color{#d91a1a}-1.80\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5829ms 2.3640ms 423.0180 Ops/s 429.6291 Ops/s $\color{#d91a1a}-1.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7839ms 0.4977ms 2.0091 KOps/s 1.9567 KOps/s $\color{#35bf28}+2.67\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6946ms 0.4766ms 2.0982 KOps/s 2.0348 KOps/s $\color{#35bf28}+3.11\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4711ms 2.4206ms 413.1189 Ops/s 398.5248 Ops/s $\color{#35bf28}+3.66\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9382ms 0.6272ms 1.5943 KOps/s 1.5996 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8891ms 0.5948ms 1.6812 KOps/s 1.6770 KOps/s $\color{#35bf28}+0.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6128ms 2.2881ms 437.0468 Ops/s 445.7160 Ops/s $\color{#d91a1a}-1.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6330ms 0.5081ms 1.9680 KOps/s 2.0023 KOps/s $\color{#d91a1a}-1.71\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7516ms 0.4875ms 2.0514 KOps/s 2.0485 KOps/s $\color{#35bf28}+0.14\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1558ms 2.3631ms 423.1719 Ops/s 440.6887 Ops/s $\color{#d91a1a}-3.97\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0118ms 0.5285ms 1.8921 KOps/s 2.0032 KOps/s $\textbf{\color{#d91a1a}-5.54\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6238ms 0.4736ms 2.1113 KOps/s 2.0984 KOps/s $\color{#35bf28}+0.62\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6844ms 2.4678ms 405.2184 Ops/s 416.4946 Ops/s $\color{#d91a1a}-2.71\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1329ms 0.6390ms 1.5649 KOps/s 1.6124 KOps/s $\color{#d91a1a}-2.95\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.3094ms 0.6099ms 1.6396 KOps/s 1.7010 KOps/s $\color{#d91a1a}-3.61\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1128s 7.8833ms 126.8502 Ops/s 136.5622 Ops/s $\textbf{\color{#d91a1a}-7.11\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.0026ms 12.2288ms 81.7739 Ops/s 84.1670 Ops/s $\color{#d91a1a}-2.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.2455ms 1.0253ms 975.3322 Ops/s 861.5843 Ops/s $\textbf{\color{#35bf28}+13.20\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1039s 7.5582ms 132.3060 Ops/s 142.7113 Ops/s $\textbf{\color{#d91a1a}-7.29\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.6186ms 12.1424ms 82.3560 Ops/s 84.2804 Ops/s $\color{#d91a1a}-2.28\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6331ms 1.0843ms 922.2678 Ops/s 908.1576 Ops/s $\color{#35bf28}+1.55\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 95.0494ms 5.7645ms 173.4762 Ops/s 179.0190 Ops/s $\color{#d91a1a}-3.10\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1123s 14.4616ms 69.1487 Ops/s 71.6193 Ops/s $\color{#d91a1a}-3.45\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.4175ms 1.4600ms 684.9395 Ops/s 740.6030 Ops/s $\textbf{\color{#d91a1a}-7.52\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1126s 0.1125s 8.8897 Ops/s 8.6370 Ops/s $\color{#35bf28}+2.93\%$
test_sync 95.4196ms 94.9801ms 10.5285 Ops/s 10.5188 Ops/s $\color{#35bf28}+0.09\%$
test_async 0.1864s 93.2704ms 10.7215 Ops/s 10.7667 Ops/s $\color{#d91a1a}-0.42\%$
test_single_pixels 0.1247s 0.1239s 8.0729 Ops/s 7.9713 Ops/s $\color{#35bf28}+1.27\%$
test_sync_pixels 82.2731ms 81.6672ms 12.2448 Ops/s 12.1908 Ops/s $\color{#35bf28}+0.44\%$
test_async_pixels 0.1477s 65.0364ms 15.3760 Ops/s 14.5648 Ops/s $\textbf{\color{#35bf28}+5.57\%}$
test_simple 0.8868s 0.8199s 1.2196 Ops/s 1.1873 Ops/s $\color{#35bf28}+2.72\%$
test_transformed 1.0977s 1.0418s 0.9599 Ops/s 0.9310 Ops/s $\color{#35bf28}+3.10\%$
test_serial 2.4480s 2.3955s 0.4175 Ops/s 0.4007 Ops/s $\color{#35bf28}+4.19\%$
test_parallel 2.1542s 2.0881s 0.4789 Ops/s 0.4735 Ops/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[True-True-True-True-True] 0.1141ms 32.5991μs 30.6757 KOps/s 29.9955 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[True-True-True-True-False] 42.8810μs 19.4588μs 51.3907 KOps/s 50.7482 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[True-True-True-False-True] 42.9110μs 18.0434μs 55.4220 KOps/s 52.9710 KOps/s $\color{#35bf28}+4.63\%$
test_step_mdp_speed[True-True-True-False-False] 44.7300μs 10.8955μs 91.7808 KOps/s 88.9431 KOps/s $\color{#35bf28}+3.19\%$
test_step_mdp_speed[True-True-False-True-True] 73.7810μs 34.4950μs 28.9897 KOps/s 28.2123 KOps/s $\color{#35bf28}+2.76\%$
test_step_mdp_speed[True-True-False-True-False] 45.8010μs 21.4098μs 46.7075 KOps/s 46.2995 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[True-True-False-False-True] 0.1029ms 19.9331μs 50.1677 KOps/s 48.4013 KOps/s $\color{#35bf28}+3.65\%$
test_step_mdp_speed[True-True-False-False-False] 35.2100μs 12.7138μs 78.6548 KOps/s 76.0139 KOps/s $\color{#35bf28}+3.47\%$
test_step_mdp_speed[True-False-True-True-True] 66.9610μs 36.6073μs 27.3170 KOps/s 26.7729 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-False-True-True-False] 58.9200μs 23.1368μs 43.2212 KOps/s 42.1458 KOps/s $\color{#35bf28}+2.55\%$
test_step_mdp_speed[True-False-True-False-True] 46.3310μs 19.8867μs 50.2850 KOps/s 48.0408 KOps/s $\color{#35bf28}+4.67\%$
test_step_mdp_speed[True-False-True-False-False] 34.6200μs 12.7483μs 78.4421 KOps/s 76.5083 KOps/s $\color{#35bf28}+2.53\%$
test_step_mdp_speed[True-False-False-True-True] 69.5810μs 38.3867μs 26.0507 KOps/s 25.5482 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[True-False-False-True-False] 48.1200μs 24.7907μs 40.3377 KOps/s 39.5002 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-False-False-False-True] 49.3310μs 22.0648μs 45.3211 KOps/s 44.4851 KOps/s $\color{#35bf28}+1.88\%$
test_step_mdp_speed[True-False-False-False-False] 42.5010μs 14.6016μs 68.4856 KOps/s 66.7278 KOps/s $\color{#35bf28}+2.63\%$
test_step_mdp_speed[False-True-True-True-True] 66.1110μs 36.2636μs 27.5759 KOps/s 26.9287 KOps/s $\color{#35bf28}+2.40\%$
test_step_mdp_speed[False-True-True-True-False] 52.8910μs 22.9687μs 43.5375 KOps/s 42.6648 KOps/s $\color{#35bf28}+2.05\%$
test_step_mdp_speed[False-True-True-False-True] 62.5400μs 24.9750μs 40.0401 KOps/s 40.6137 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-True-True-False-False] 33.8210μs 14.8058μs 67.5413 KOps/s 66.2324 KOps/s $\color{#35bf28}+1.98\%$
test_step_mdp_speed[False-True-False-True-True] 72.5320μs 38.5975μs 25.9084 KOps/s 25.5721 KOps/s $\color{#35bf28}+1.31\%$
test_step_mdp_speed[False-True-False-True-False] 52.0710μs 24.9200μs 40.1284 KOps/s 39.0143 KOps/s $\color{#35bf28}+2.86\%$
test_step_mdp_speed[False-True-False-False-True] 55.9500μs 26.6871μs 37.4713 KOps/s 38.0707 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-True-False-False-False] 38.2210μs 16.4810μs 60.6760 KOps/s 59.1422 KOps/s $\color{#35bf28}+2.59\%$
test_step_mdp_speed[False-False-True-True-True] 0.2226ms 40.4348μs 24.7312 KOps/s 24.3606 KOps/s $\color{#35bf28}+1.52\%$
test_step_mdp_speed[False-False-True-True-False] 64.6410μs 27.0276μs 36.9992 KOps/s 35.8990 KOps/s $\color{#35bf28}+3.06\%$
test_step_mdp_speed[False-False-True-False-True] 0.1875ms 26.5965μs 37.5990 KOps/s 37.8465 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[False-False-True-False-False] 40.8700μs 16.4224μs 60.8923 KOps/s 58.7243 KOps/s $\color{#35bf28}+3.69\%$
test_step_mdp_speed[False-False-False-True-True] 78.6300μs 42.1535μs 23.7228 KOps/s 23.6403 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[False-False-False-True-False] 56.9510μs 28.6494μs 34.9047 KOps/s 33.9457 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[False-False-False-False-True] 52.8210μs 27.9494μs 35.7790 KOps/s 35.6427 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-False-False-False-False] 46.4800μs 18.1315μs 55.1527 KOps/s 53.1835 KOps/s $\color{#35bf28}+3.70\%$
test_values[generalized_advantage_estimate-True-True] 25.0095ms 24.5660ms 40.7067 Ops/s 38.3567 Ops/s $\textbf{\color{#35bf28}+6.13\%}$
test_values[vec_generalized_advantage_estimate-True-True] 84.7464ms 3.2595ms 306.7968 Ops/s 294.6406 Ops/s $\color{#35bf28}+4.13\%$
test_values[td0_return_estimate-False-False] 96.3510μs 63.0860μs 15.8514 KOps/s 14.7710 KOps/s $\textbf{\color{#35bf28}+7.31\%}$
test_values[td1_return_estimate-False-False] 57.3732ms 54.7718ms 18.2576 Ops/s 18.2244 Ops/s $\color{#35bf28}+0.18\%$
test_values[vec_td1_return_estimate-False-False] 2.1868ms 1.7620ms 567.5445 Ops/s 561.9047 Ops/s $\color{#35bf28}+1.00\%$
test_values[td_lambda_return_estimate-True-False] 90.3109ms 89.2143ms 11.2090 Ops/s 11.4405 Ops/s $\color{#d91a1a}-2.02\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0998ms 1.7537ms 570.2386 Ops/s 563.8271 Ops/s $\color{#35bf28}+1.14\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.7731ms 23.5817ms 42.4057 Ops/s 41.5484 Ops/s $\color{#35bf28}+2.06\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9037ms 0.7029ms 1.4227 KOps/s 1.3893 KOps/s $\color{#35bf28}+2.40\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8326ms 0.6773ms 1.4765 KOps/s 1.5147 KOps/s $\color{#d91a1a}-2.52\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5909ms 1.4628ms 683.6109 Ops/s 680.1780 Ops/s $\color{#35bf28}+0.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9219ms 0.6676ms 1.4979 KOps/s 1.4664 KOps/s $\color{#35bf28}+2.15\%$
test_dqn_speed 8.1345ms 1.4428ms 693.0907 Ops/s 635.6052 Ops/s $\textbf{\color{#35bf28}+9.04\%}$
test_ddpg_speed 3.0399ms 2.7345ms 365.6967 Ops/s 357.6712 Ops/s $\color{#35bf28}+2.24\%$
test_sac_speed 8.6821ms 8.2329ms 121.4638 Ops/s 120.7326 Ops/s $\color{#35bf28}+0.61\%$
test_redq_speed 11.5560ms 10.4637ms 95.5682 Ops/s 96.5900 Ops/s $\color{#d91a1a}-1.06\%$
test_redq_deprec_speed 13.0211ms 11.8787ms 84.1842 Ops/s 87.7127 Ops/s $\color{#d91a1a}-4.02\%$
test_td3_speed 15.7042ms 8.1498ms 122.7022 Ops/s 122.6827 Ops/s $\color{#35bf28}+0.02\%$
test_cql_speed 27.0620ms 25.8436ms 38.6943 Ops/s 38.9662 Ops/s $\color{#d91a1a}-0.70\%$
test_a2c_speed 6.0013ms 5.6988ms 175.4761 Ops/s 180.9175 Ops/s $\color{#d91a1a}-3.01\%$
test_ppo_speed 6.2422ms 6.0254ms 165.9654 Ops/s 166.5448 Ops/s $\color{#d91a1a}-0.35\%$
test_reinforce_speed 4.9226ms 4.7222ms 211.7664 Ops/s 217.4516 Ops/s $\color{#d91a1a}-2.61\%$
test_iql_speed 20.6433ms 19.7849ms 50.5436 Ops/s 50.3478 Ops/s $\color{#35bf28}+0.39\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0393ms 2.8344ms 352.8075 Ops/s 348.4973 Ops/s $\color{#35bf28}+1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4726ms 0.5557ms 1.7995 KOps/s 1.8091 KOps/s $\color{#d91a1a}-0.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7247ms 0.5379ms 1.8590 KOps/s 1.8759 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0530ms 2.8331ms 352.9728 Ops/s 348.3438 Ops/s $\color{#35bf28}+1.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6818ms 0.5526ms 1.8095 KOps/s 1.8317 KOps/s $\color{#d91a1a}-1.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7227ms 0.5316ms 1.8811 KOps/s 1.9075 KOps/s $\color{#d91a1a}-1.38\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0932ms 2.9539ms 338.5299 Ops/s 331.6546 Ops/s $\color{#35bf28}+2.07\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.5244ms 0.6858ms 1.4582 KOps/s 1.4796 KOps/s $\color{#d91a1a}-1.45\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8180ms 0.6715ms 1.4892 KOps/s 1.5296 KOps/s $\color{#d91a1a}-2.64\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0164ms 2.8229ms 354.2484 Ops/s 346.4596 Ops/s $\color{#35bf28}+2.25\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2751ms 0.5580ms 1.7920 KOps/s 1.8074 KOps/s $\color{#d91a1a}-0.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6576ms 0.5334ms 1.8749 KOps/s 1.8856 KOps/s $\color{#d91a1a}-0.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0643ms 2.8424ms 351.8203 Ops/s 345.0708 Ops/s $\color{#35bf28}+1.96\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6798ms 0.5475ms 1.8263 KOps/s 1.8350 KOps/s $\color{#d91a1a}-0.47\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1056s 0.6761ms 1.4792 KOps/s 1.9163 KOps/s $\textbf{\color{#d91a1a}-22.81\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1294ms 2.9698ms 336.7239 Ops/s 333.2452 Ops/s $\color{#35bf28}+1.04\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8322ms 0.6827ms 1.4647 KOps/s 1.4786 KOps/s $\color{#d91a1a}-0.94\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7759ms 0.6627ms 1.5090 KOps/s 1.5271 KOps/s $\color{#d91a1a}-1.18\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1071s 8.7297ms 114.5514 Ops/s 113.8368 Ops/s $\color{#35bf28}+0.63\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.8451ms 14.4540ms 69.1849 Ops/s 65.1182 Ops/s $\textbf{\color{#35bf28}+6.25\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2792ms 1.1708ms 854.1236 Ops/s 891.9610 Ops/s $\color{#d91a1a}-4.24\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 98.9022ms 6.6884ms 149.5130 Ops/s 115.9646 Ops/s $\textbf{\color{#35bf28}+28.93\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.3793ms 14.4007ms 69.4412 Ops/s 65.6503 Ops/s $\textbf{\color{#35bf28}+5.77\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3007ms 1.1337ms 882.0393 Ops/s 905.6315 Ops/s $\color{#d91a1a}-2.61\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1028s 9.0052ms 111.0469 Ops/s 140.0771 Ops/s $\textbf{\color{#d91a1a}-20.72\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.3259ms 14.8560ms 67.3128 Ops/s 64.8230 Ops/s $\color{#35bf28}+3.84\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.2098ms 1.6390ms 610.1218 Ops/s 666.7608 Ops/s $\textbf{\color{#d91a1a}-8.49\%}$

@vmoens vmoens changed the title [BugFix] CNN input formatting [Doc] Better doc for modules Mar 4, 2024
@vmoens vmoens added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 4, 2024
@vmoens vmoens changed the title [Doc] Better doc for modules [Doc] Better doc for modules and list of kwargs when possible Mar 4, 2024
@vmoens vmoens changed the title [Doc] Better doc for modules and list of kwargs when possible [Doc,Feature] Better doc for modules and list of kwargs when possible Mar 5, 2024
@vmoens vmoens marked this pull request as ready for review March 5, 2024 08:52
@vmoens vmoens merged commit fe6c070 into main Mar 5, 2024
12 of 21 checks passed
@vmoens vmoens deleted the list_cnn branch March 5, 2024 09:05
vmoens added a commit that referenced this pull request Mar 25, 2024
@vmoens
[Doc,Feature] Better doc for modules and list of kwargs when possible (…
b0a0026 
…#1990)

(cherry picked from commit fe6c070)
vmoens added a commit that referenced this pull request Apr 7, 2024
@vmoens
[Doc,Feature] Better doc for modules and list of kwargs when possible (…
a645912 
…#1990)

(cherry picked from commit fe6c070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot