Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Offline objectives reduction parameter #1984

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

albertbou92
Copy link
Contributor

@albertbou92 albertbou92 commented Mar 1, 2024

Description

Same as #1890, but for Offline losses.

Copy link

pytorch-bot bot commented Mar 1, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1984

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit ce6d5ba with merge base 3a41f40 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens added the enhancement New feature or request label Mar 1, 2024
@albertbou92
Copy link
Contributor Author

albertbou92 commented Mar 1, 2024

Fixing the test errors

@albertbou92
Copy link
Contributor Author

should be fixed now!

@vmoens vmoens merged commit 6abc9bf into pytorch:main Mar 1, 2024
64 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants