Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix broken gym tests #1980

Merged
merged 16 commits into from
Mar 1, 2024
Merged

[BugFix] Fix broken gym tests #1980

merged 16 commits into from
Mar 1, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 28, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1980

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a79c691 with merge base 1c1d558 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2024
@vmoens vmoens added Suitable for minor Suitable to be integrated in minor release (no new feature) and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 28, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 60.2260ms 59.6907ms 16.7530 Ops/s 15.7751 Ops/s $\textbf{\color{#35bf28}+6.20\%}$
test_sync 44.3431ms 34.1102ms 29.3168 Ops/s 30.0581 Ops/s $\color{#d91a1a}-2.47\%$
test_async 55.7058ms 31.4207ms 31.8262 Ops/s 31.0682 Ops/s $\color{#35bf28}+2.44\%$
test_simple 0.4875s 0.4257s 2.3490 Ops/s 2.2300 Ops/s $\textbf{\color{#35bf28}+5.34\%}$
test_transformed 0.6199s 0.5706s 1.7527 Ops/s 1.6588 Ops/s $\textbf{\color{#35bf28}+5.66\%}$
test_serial 1.4430s 1.3825s 0.7233 Ops/s 0.6715 Ops/s $\textbf{\color{#35bf28}+7.71\%}$
test_parallel 1.4191s 1.3641s 0.7331 Ops/s 0.7120 Ops/s $\color{#35bf28}+2.96\%$
test_step_mdp_speed[True-True-True-True-True] 0.1773ms 21.3208μs 46.9025 KOps/s 47.3556 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-True-True-True-False] 55.4720μs 13.1816μs 75.8636 KOps/s 77.8626 KOps/s $\color{#d91a1a}-2.57\%$
test_step_mdp_speed[True-True-True-False-True] 36.9190μs 12.4121μs 80.5666 KOps/s 80.7839 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[True-True-True-False-False] 52.7680μs 7.7002μs 129.8676 KOps/s 133.8518 KOps/s $\color{#d91a1a}-2.98\%$
test_step_mdp_speed[True-True-False-True-True] 53.4390μs 22.7178μs 44.0184 KOps/s 44.9249 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[True-True-False-True-False] 58.5190μs 14.2892μs 69.9830 KOps/s 71.3408 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[True-True-False-False-True] 35.9270μs 13.7705μs 72.6191 KOps/s 73.7933 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[True-True-False-False-False] 60.3320μs 8.8754μs 112.6709 KOps/s 114.5866 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-True-True-True] 0.2576ms 24.8904μs 40.1761 KOps/s 42.2314 KOps/s $\color{#d91a1a}-4.87\%$
test_step_mdp_speed[True-False-True-True-False] 42.9500μs 15.7784μs 63.3778 KOps/s 64.7269 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[True-False-True-False-True] 61.9350μs 13.6802μs 73.0981 KOps/s 72.7232 KOps/s $\color{#35bf28}+0.52\%$
test_step_mdp_speed[True-False-True-False-False] 25.0070μs 8.8638μs 112.8181 KOps/s 113.6750 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-False-False-True-True] 85.4680μs 25.0642μs 39.8975 KOps/s 40.1227 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[True-False-False-True-False] 46.1050μs 16.8585μs 59.3171 KOps/s 60.3251 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[True-False-False-False-True] 74.6690μs 14.8611μs 67.2897 KOps/s 67.6605 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[True-False-False-False-False] 51.2950μs 10.1002μs 99.0080 KOps/s 100.4150 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[False-True-True-True-True] 71.8340μs 24.1574μs 41.3952 KOps/s 41.6087 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-True-True-True-False] 64.1090μs 15.7138μs 63.6383 KOps/s 64.6017 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[False-True-True-False-True] 52.8880μs 15.9587μs 62.6618 KOps/s 62.3875 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[False-True-True-False-False] 0.1914ms 10.8563μs 92.1128 KOps/s 99.2888 KOps/s $\textbf{\color{#d91a1a}-7.23\%}$
test_step_mdp_speed[False-True-False-True-True] 38.9020μs 25.5551μs 39.1311 KOps/s 38.5186 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[False-True-False-True-False] 0.1358ms 17.9200μs 55.8035 KOps/s 59.6686 KOps/s $\textbf{\color{#d91a1a}-6.48\%}$
test_step_mdp_speed[False-True-False-False-True] 43.1800μs 17.2028μs 58.1302 KOps/s 58.0687 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[False-True-False-False-False] 77.9420μs 11.2978μs 88.5127 KOps/s 88.5298 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[False-False-True-True-True] 69.4580μs 26.4472μs 37.8112 KOps/s 37.8319 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-False-True-True-False] 68.5900μs 18.1869μs 54.9847 KOps/s 55.4937 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-False-True-False-True] 57.8580μs 16.9856μs 58.8733 KOps/s 58.8780 KOps/s $-0.01\%$
test_step_mdp_speed[False-False-True-False-False] 63.0670μs 11.4356μs 87.4463 KOps/s 89.9765 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[False-False-False-True-True] 62.9470μs 29.4920μs 33.9075 KOps/s 36.6775 KOps/s $\textbf{\color{#d91a1a}-7.55\%}$
test_step_mdp_speed[False-False-False-True-False] 69.0380μs 19.0766μs 52.4203 KOps/s 51.2646 KOps/s $\color{#35bf28}+2.25\%$
test_step_mdp_speed[False-False-False-False-True] 0.2222ms 18.6409μs 53.6456 KOps/s 55.3346 KOps/s $\color{#d91a1a}-3.05\%$
test_step_mdp_speed[False-False-False-False-False] 43.8510μs 12.3797μs 80.7774 KOps/s 82.0420 KOps/s $\color{#d91a1a}-1.54\%$
test_values[generalized_advantage_estimate-True-True] 11.7228ms 9.5529ms 104.6800 Ops/s 106.6858 Ops/s $\color{#d91a1a}-1.88\%$
test_values[vec_generalized_advantage_estimate-True-True] 49.2689ms 34.2808ms 29.1709 Ops/s 29.6872 Ops/s $\color{#d91a1a}-1.74\%$
test_values[td0_return_estimate-False-False] 0.3167ms 0.1752ms 5.7084 KOps/s 5.5555 KOps/s $\color{#35bf28}+2.75\%$
test_values[td1_return_estimate-False-False] 26.5022ms 23.4652ms 42.6163 Ops/s 42.7670 Ops/s $\color{#d91a1a}-0.35\%$
test_values[vec_td1_return_estimate-False-False] 34.7174ms 33.7692ms 29.6128 Ops/s 29.5930 Ops/s $\color{#35bf28}+0.07\%$
test_values[td_lambda_return_estimate-True-False] 34.4406ms 33.9516ms 29.4537 Ops/s 29.6170 Ops/s $\color{#d91a1a}-0.55\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.9451ms 33.7154ms 29.6601 Ops/s 29.6303 Ops/s $\color{#35bf28}+0.10\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2324ms 8.0461ms 124.2833 Ops/s 123.0910 Ops/s $\color{#35bf28}+0.97\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 5.5424ms 2.2944ms 435.8458 Ops/s 547.0749 Ops/s $\textbf{\color{#d91a1a}-20.33\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6556ms 0.3494ms 2.8618 KOps/s 2.8766 KOps/s $\color{#d91a1a}-0.51\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 40.2402ms 39.4724ms 25.3342 Ops/s 22.6404 Ops/s $\textbf{\color{#35bf28}+11.90\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.9647ms 3.1039ms 322.1725 Ops/s 327.1534 Ops/s $\color{#d91a1a}-1.52\%$
test_dqn_speed 1.9256ms 1.3628ms 733.7712 Ops/s 720.1958 Ops/s $\color{#35bf28}+1.88\%$
test_ddpg_speed 3.3429ms 2.7097ms 369.0440 Ops/s 366.3279 Ops/s $\color{#35bf28}+0.74\%$
test_sac_speed 13.7932ms 8.4142ms 118.8468 Ops/s 119.7937 Ops/s $\color{#d91a1a}-0.79\%$
test_redq_speed 15.8120ms 13.4440ms 74.3829 Ops/s 74.6412 Ops/s $\color{#d91a1a}-0.35\%$
test_redq_deprec_speed 16.4411ms 13.7454ms 72.7516 Ops/s 72.4682 Ops/s $\color{#35bf28}+0.39\%$
test_td3_speed 16.2463ms 8.3915ms 119.1687 Ops/s 120.5764 Ops/s $\color{#d91a1a}-1.17\%$
test_cql_speed 39.6254ms 37.1720ms 26.9020 Ops/s 27.3862 Ops/s $\color{#d91a1a}-1.77\%$
test_a2c_speed 9.7309ms 7.9248ms 126.1860 Ops/s 131.2894 Ops/s $\color{#d91a1a}-3.89\%$
test_ppo_speed 9.3334ms 8.1665ms 122.4520 Ops/s 126.7528 Ops/s $\color{#d91a1a}-3.39\%$
test_reinforce_speed 7.7074ms 6.7043ms 149.1572 Ops/s 147.7488 Ops/s $\color{#35bf28}+0.95\%$
test_iql_speed 34.7783ms 33.0227ms 30.2822 Ops/s 30.3737 Ops/s $\color{#d91a1a}-0.30\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3994ms 2.2936ms 436.0024 Ops/s 416.7223 Ops/s $\color{#35bf28}+4.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6434ms 0.4998ms 2.0010 KOps/s 1.9516 KOps/s $\color{#35bf28}+2.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.5032ms 0.4766ms 2.0983 KOps/s 2.0543 KOps/s $\color{#35bf28}+2.14\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.8948ms 2.4103ms 414.8778 Ops/s 410.2455 Ops/s $\color{#35bf28}+1.13\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8659ms 0.4976ms 2.0096 KOps/s 1.9858 KOps/s $\color{#35bf28}+1.20\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.4992ms 0.4745ms 2.1076 KOps/s 2.0341 KOps/s $\color{#35bf28}+3.61\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8121ms 2.4590ms 406.6773 Ops/s 401.8927 Ops/s $\color{#35bf28}+1.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7531ms 0.6135ms 1.6299 KOps/s 1.5882 KOps/s $\color{#35bf28}+2.63\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.9189ms 0.5992ms 1.6689 KOps/s 1.6418 KOps/s $\color{#35bf28}+1.65\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.4214ms 2.3598ms 423.7575 Ops/s 424.8193 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7097ms 0.5089ms 1.9651 KOps/s 1.9589 KOps/s $\color{#35bf28}+0.32\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.5674ms 0.4854ms 2.0602 KOps/s 2.0656 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5301ms 2.4662ms 405.4858 Ops/s 425.2641 Ops/s $\color{#d91a1a}-4.65\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1512ms 0.4995ms 2.0018 KOps/s 1.9884 KOps/s $\color{#35bf28}+0.67\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6319ms 0.4699ms 2.1282 KOps/s 2.0751 KOps/s $\color{#35bf28}+2.56\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8493ms 2.4926ms 401.1895 Ops/s 403.8620 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9555ms 0.6222ms 1.6072 KOps/s 1.5698 KOps/s $\color{#35bf28}+2.39\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.7937ms 0.5971ms 1.6748 KOps/s 1.6555 KOps/s $\color{#35bf28}+1.17\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1138s 7.7250ms 129.4497 Ops/s 131.7304 Ops/s $\color{#d91a1a}-1.73\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.5997ms 12.0960ms 82.6716 Ops/s 80.6055 Ops/s $\color{#35bf28}+2.56\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.5224ms 1.0302ms 970.6642 Ops/s 941.3764 Ops/s $\color{#35bf28}+3.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1088s 7.6459ms 130.7896 Ops/s 179.4572 Ops/s $\textbf{\color{#d91a1a}-27.12\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.1615ms 11.9850ms 83.4378 Ops/s 81.9617 Ops/s $\color{#35bf28}+1.80\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5198ms 1.0181ms 982.2629 Ops/s 944.0770 Ops/s $\color{#35bf28}+4.04\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 97.0648ms 5.8606ms 170.6306 Ops/s 126.3460 Ops/s $\textbf{\color{#35bf28}+35.05\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.1330ms 13.5977ms 73.5417 Ops/s 79.6078 Ops/s $\textbf{\color{#d91a1a}-7.62\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8692ms 1.3634ms 733.4651 Ops/s 730.0329 Ops/s $\color{#35bf28}+0.47\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1115s 0.1112s 8.9912 Ops/s 8.6931 Ops/s $\color{#35bf28}+3.43\%$
test_sync 95.4056ms 94.8902ms 10.5385 Ops/s 10.4380 Ops/s $\color{#35bf28}+0.96\%$
test_async 0.1793s 90.7367ms 11.0209 Ops/s 10.7246 Ops/s $\color{#35bf28}+2.76\%$
test_single_pixels 0.1221s 0.1217s 8.2161 Ops/s 7.2493 Ops/s $\textbf{\color{#35bf28}+13.34\%}$
test_sync_pixels 82.7203ms 80.4687ms 12.4272 Ops/s 12.0905 Ops/s $\color{#35bf28}+2.79\%$
test_async_pixels 0.1475s 65.0273ms 15.3782 Ops/s 13.8153 Ops/s $\textbf{\color{#35bf28}+11.31\%}$
test_simple 0.7927s 0.7925s 1.2619 Ops/s 1.1841 Ops/s $\textbf{\color{#35bf28}+6.57\%}$
test_transformed 1.0898s 1.0308s 0.9701 Ops/s 0.9430 Ops/s $\color{#35bf28}+2.88\%$
test_serial 2.4252s 2.3655s 0.4227 Ops/s 0.4096 Ops/s $\color{#35bf28}+3.20\%$
test_parallel 2.1615s 2.1042s 0.4752 Ops/s 0.4712 Ops/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[True-True-True-True-True] 65.4310μs 32.4692μs 30.7984 KOps/s 29.9136 KOps/s $\color{#35bf28}+2.96\%$
test_step_mdp_speed[True-True-True-True-False] 0.1135ms 19.5403μs 51.1763 KOps/s 50.6417 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[True-True-True-False-True] 42.3410μs 18.4485μs 54.2049 KOps/s 52.9101 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[True-True-True-False-False] 31.2510μs 11.2522μs 88.8712 KOps/s 89.0354 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-True-False-True-True] 69.8510μs 34.4083μs 29.0627 KOps/s 28.9289 KOps/s $\color{#35bf28}+0.46\%$
test_step_mdp_speed[True-True-False-True-False] 41.3600μs 21.3576μs 46.8217 KOps/s 46.8852 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-False-False-True] 47.8510μs 20.6586μs 48.4060 KOps/s 48.7922 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[True-True-False-False-False] 37.8910μs 12.8578μs 77.7737 KOps/s 75.9300 KOps/s $\color{#35bf28}+2.43\%$
test_step_mdp_speed[True-False-True-True-True] 69.4310μs 36.8084μs 27.1677 KOps/s 27.0749 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-False-True-True-False] 60.3610μs 23.6050μs 42.3638 KOps/s 42.5217 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[True-False-True-False-True] 43.4110μs 20.2955μs 49.2719 KOps/s 49.0624 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[True-False-True-False-False] 33.8700μs 12.7467μs 78.4514 KOps/s 75.5069 KOps/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[True-False-False-True-True] 63.9410μs 38.2694μs 26.1305 KOps/s 25.9566 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[True-False-False-True-False] 47.2410μs 25.3316μs 39.4764 KOps/s 39.5747 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[True-False-False-False-True] 42.1500μs 22.2664μs 44.9106 KOps/s 44.6235 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[True-False-False-False-False] 31.7910μs 15.0071μs 66.6350 KOps/s 66.9806 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[False-True-True-True-True] 63.3310μs 36.5247μs 27.3788 KOps/s 27.2944 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-True-True-True-False] 48.2410μs 23.5397μs 42.4815 KOps/s 42.2569 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[False-True-True-False-True] 47.3610μs 24.5472μs 40.7379 KOps/s 40.5662 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-True-True-False-False] 31.7510μs 14.7799μs 67.6592 KOps/s 66.4326 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[False-True-False-True-True] 70.3610μs 38.8370μs 25.7487 KOps/s 25.8694 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-True-False-True-False] 51.2710μs 25.3248μs 39.4870 KOps/s 39.8248 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-True-False-False-True] 50.0400μs 26.0585μs 38.3752 KOps/s 38.0580 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-True-False-False-False] 88.9920μs 16.5893μs 60.2797 KOps/s 60.2089 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-False-True-True-True] 68.4410μs 40.4722μs 24.7083 KOps/s 24.6240 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-False-True-True-False] 50.0210μs 27.4871μs 36.3807 KOps/s 36.7080 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-False-True-False-True] 50.1320μs 26.2290μs 38.1258 KOps/s 38.4055 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-False-True-False-False] 39.3310μs 16.8859μs 59.2209 KOps/s 59.2136 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[False-False-False-True-True] 0.1121ms 42.1334μs 23.7342 KOps/s 23.9496 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[False-False-False-True-False] 0.1967ms 28.9565μs 34.5346 KOps/s 34.4287 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-False-False-False-True] 50.7810μs 27.9392μs 35.7919 KOps/s 36.1836 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-False-False-False-False] 39.8210μs 18.3785μs 54.4113 KOps/s 54.0344 KOps/s $\color{#35bf28}+0.70\%$
test_values[generalized_advantage_estimate-True-True] 24.7911ms 24.2545ms 41.2295 Ops/s 39.2332 Ops/s $\textbf{\color{#35bf28}+5.09\%}$
test_values[vec_generalized_advantage_estimate-True-True] 83.9435ms 3.2358ms 309.0437 Ops/s 308.0476 Ops/s $\color{#35bf28}+0.32\%$
test_values[td0_return_estimate-False-False] 93.1020μs 63.1325μs 15.8397 KOps/s 15.4415 KOps/s $\color{#35bf28}+2.58\%$
test_values[td1_return_estimate-False-False] 52.6982ms 51.9740ms 19.2404 Ops/s 18.1208 Ops/s $\textbf{\color{#35bf28}+6.18\%}$
test_values[vec_td1_return_estimate-False-False] 2.0485ms 1.7502ms 571.3634 Ops/s 563.6431 Ops/s $\color{#35bf28}+1.37\%$
test_values[td_lambda_return_estimate-True-False] 83.6581ms 82.6746ms 12.0956 Ops/s 11.3629 Ops/s $\textbf{\color{#35bf28}+6.45\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1160ms 1.7490ms 571.7680 Ops/s 565.3940 Ops/s $\color{#35bf28}+1.13\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.2066ms 22.9246ms 43.6212 Ops/s 41.4737 Ops/s $\textbf{\color{#35bf28}+5.18\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8562ms 0.6934ms 1.4421 KOps/s 1.4257 KOps/s $\color{#35bf28}+1.15\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7106ms 0.6390ms 1.5650 KOps/s 1.5301 KOps/s $\color{#35bf28}+2.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5943ms 1.4405ms 694.2101 Ops/s 684.5655 Ops/s $\color{#35bf28}+1.41\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9810ms 0.6565ms 1.5231 KOps/s 1.4783 KOps/s $\color{#35bf28}+3.03\%$
test_dqn_speed 1.8305ms 1.3987ms 714.9321 Ops/s 630.3125 Ops/s $\textbf{\color{#35bf28}+13.43\%}$
test_ddpg_speed 2.8968ms 2.6352ms 379.4721 Ops/s 365.7790 Ops/s $\color{#35bf28}+3.74\%$
test_sac_speed 8.3755ms 7.9165ms 126.3188 Ops/s 123.2703 Ops/s $\color{#35bf28}+2.47\%$
test_redq_speed 12.9313ms 10.1417ms 98.6024 Ops/s 96.6174 Ops/s $\color{#35bf28}+2.05\%$
test_redq_deprec_speed 11.7737ms 11.1671ms 89.5487 Ops/s 88.4655 Ops/s $\color{#35bf28}+1.22\%$
test_td3_speed 7.9115ms 7.8404ms 127.5443 Ops/s 124.8081 Ops/s $\color{#35bf28}+2.19\%$
test_cql_speed 25.3832ms 24.5261ms 40.7728 Ops/s 38.8282 Ops/s $\textbf{\color{#35bf28}+5.01\%}$
test_a2c_speed 5.4535ms 5.1795ms 193.0702 Ops/s 177.6180 Ops/s $\textbf{\color{#35bf28}+8.70\%}$
test_ppo_speed 6.4181ms 5.5161ms 181.2875 Ops/s 167.7249 Ops/s $\textbf{\color{#35bf28}+8.09\%}$
test_reinforce_speed 4.4151ms 4.2092ms 237.5721 Ops/s 219.5318 Ops/s $\textbf{\color{#35bf28}+8.22\%}$
test_iql_speed 19.9123ms 19.0031ms 52.6229 Ops/s 50.9068 Ops/s $\color{#35bf28}+3.37\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0171ms 2.8481ms 351.1144 Ops/s 344.0374 Ops/s $\color{#35bf28}+2.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6956ms 0.5492ms 1.8208 KOps/s 1.7968 KOps/s $\color{#35bf28}+1.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.7693ms 0.5381ms 1.8583 KOps/s 1.8791 KOps/s $\color{#d91a1a}-1.11\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0360ms 2.8592ms 349.7459 Ops/s 342.1224 Ops/s $\color{#35bf28}+2.23\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6755ms 0.5426ms 1.8430 KOps/s 1.8194 KOps/s $\color{#35bf28}+1.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1069s 0.6374ms 1.5688 KOps/s 1.9050 KOps/s $\textbf{\color{#d91a1a}-17.65\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1092ms 2.9867ms 334.8130 Ops/s 329.5863 Ops/s $\color{#35bf28}+1.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8708ms 0.6819ms 1.4664 KOps/s 1.4629 KOps/s $\color{#35bf28}+0.24\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.5981ms 0.6638ms 1.5066 KOps/s 1.5156 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0518ms 2.8511ms 350.7360 Ops/s 343.9700 Ops/s $\color{#35bf28}+1.97\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7600ms 0.5556ms 1.8000 KOps/s 1.7879 KOps/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7109ms 0.5376ms 1.8600 KOps/s 1.8351 KOps/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0532ms 2.8891ms 346.1316 Ops/s 343.2445 Ops/s $\color{#35bf28}+0.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4696ms 0.5436ms 1.8396 KOps/s 1.8400 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8404ms 0.5267ms 1.8987 KOps/s 1.9206 KOps/s $\color{#d91a1a}-1.14\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1605ms 2.9951ms 333.8766 Ops/s 331.5138 Ops/s $\color{#35bf28}+0.71\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9079ms 0.6827ms 1.4648 KOps/s 1.4799 KOps/s $\color{#d91a1a}-1.02\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8755ms 0.6616ms 1.5114 KOps/s 1.5252 KOps/s $\color{#d91a1a}-0.90\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1349s 7.4516ms 134.1996 Ops/s 111.1221 Ops/s $\textbf{\color{#35bf28}+20.77\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.5858ms 14.1007ms 70.9183 Ops/s 66.6617 Ops/s $\textbf{\color{#35bf28}+6.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1629ms 1.0703ms 934.2999 Ops/s 870.8686 Ops/s $\textbf{\color{#35bf28}+7.28\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1032s 8.6688ms 115.3559 Ops/s 114.6378 Ops/s $\color{#35bf28}+0.63\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.3916ms 14.1586ms 70.6286 Ops/s 66.4790 Ops/s $\textbf{\color{#35bf28}+6.24\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.1302ms 1.0536ms 949.0934 Ops/s 896.1530 Ops/s $\textbf{\color{#35bf28}+5.91\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1008s 7.0101ms 142.6510 Ops/s 141.2019 Ops/s $\color{#35bf28}+1.03\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.9479ms 14.4734ms 69.0925 Ops/s 64.0772 Ops/s $\textbf{\color{#35bf28}+7.83\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.6357ms 1.4866ms 672.6894 Ops/s 667.6527 Ops/s $\color{#35bf28}+0.75\%$

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Feb 28, 2024
@vmoens vmoens merged commit 3a41f40 into main Mar 1, 2024
66 of 67 checks passed
vmoens added a commit that referenced this pull request Mar 1, 2024
@vmoens
[BugFix] Fix broken gym tests (#1980)
5f2f418
vmoens added a commit that referenced this pull request Mar 1, 2024
@vmoens
[BugFix] Fix broken gym tests (#1980)
d04f628
vmoens added a commit that referenced this pull request Mar 1, 2024
@vmoens
[BugFix] Fix broken gym tests (#1980)
146341b
@vmoens vmoens deleted the fix-gym-tests branch April 3, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper Suitable for minor Suitable to be integrated in minor release (no new feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot