Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix flaky rb tests #1901

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[BugFix] Fix flaky rb tests #1901

merged 1 commit into from
Feb 12, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 12, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1901

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit fe5abda with merge base 1bd5ec6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1403s 68.1065ms 14.6829 Ops/s 15.8165 Ops/s $\textbf{\color{#d91a1a}-7.17\%}$
test_sync 41.7134ms 35.1318ms 28.4642 Ops/s 29.4226 Ops/s $\color{#d91a1a}-3.26\%$
test_async 0.1352s 33.4640ms 29.8829 Ops/s 29.9435 Ops/s $\color{#d91a1a}-0.20\%$
test_simple 0.5043s 0.4403s 2.2714 Ops/s 2.2830 Ops/s $\color{#d91a1a}-0.51\%$
test_transformed 0.6677s 0.6068s 1.6479 Ops/s 1.6355 Ops/s $\color{#35bf28}+0.76\%$
test_serial 1.5085s 1.4491s 0.6901 Ops/s 0.6767 Ops/s $\color{#35bf28}+1.98\%$
test_parallel 1.4456s 1.3823s 0.7235 Ops/s 0.7305 Ops/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-True-True-True-True] 0.1460ms 21.7253μs 46.0293 KOps/s 45.6044 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-True-True-True-False] 41.2970μs 13.3958μs 74.6501 KOps/s 75.0571 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[True-True-True-False-True] 43.9920μs 12.6267μs 79.1972 KOps/s 78.2826 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-True-True-False-False] 36.9190μs 7.6578μs 130.5852 KOps/s 130.2150 KOps/s $\color{#35bf28}+0.28\%$
test_step_mdp_speed[True-True-False-True-True] 53.5300μs 23.1944μs 43.1139 KOps/s 43.4752 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[True-True-False-True-False] 40.5250μs 14.6706μs 68.1636 KOps/s 68.8129 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-True-False-False-True] 41.3370μs 13.8859μs 72.0155 KOps/s 70.7374 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[True-True-False-False-False] 43.4600μs 8.9652μs 111.5422 KOps/s 111.0379 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[True-False-True-True-True] 61.7140μs 24.4306μs 40.9323 KOps/s 40.0948 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[True-False-True-True-False] 60.1620μs 16.1745μs 61.8258 KOps/s 61.7341 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-False-True-False-True] 50.5640μs 14.0648μs 71.0997 KOps/s 71.1961 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-False-True-False-False] 37.5400μs 9.0893μs 110.0195 KOps/s 110.7398 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-False-False-True-True] 57.4570μs 25.6005μs 39.0618 KOps/s 38.8739 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[True-False-False-True-False] 57.4770μs 17.2568μs 57.9481 KOps/s 58.5591 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-False-False-True] 44.5330μs 15.0937μs 66.2528 KOps/s 66.5858 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-False-False-False] 34.8950μs 10.2401μs 97.6549 KOps/s 99.5583 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[False-True-True-True-True] 75.4900μs 24.2701μs 41.2030 KOps/s 40.7327 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[False-True-True-True-False] 58.5990μs 15.7526μs 63.4814 KOps/s 63.1836 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[False-True-True-False-True] 47.1970μs 16.0018μs 62.4931 KOps/s 61.9084 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[False-True-True-False-False] 45.9560μs 10.2021μs 98.0191 KOps/s 98.7664 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-True-False-True-True] 40.5750μs 25.7002μs 38.9102 KOps/s 38.8188 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[False-True-False-True-False] 41.2270μs 16.9384μs 59.0374 KOps/s 59.2505 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[False-True-False-False-True] 60.3020μs 17.2254μs 58.0538 KOps/s 57.2978 KOps/s $\color{#35bf28}+1.32\%$
test_step_mdp_speed[False-True-False-False-False] 37.3190μs 11.3129μs 88.3945 KOps/s 87.6244 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[False-False-True-True-True] 84.0260μs 27.0177μs 37.0128 KOps/s 37.0674 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-True-True-False] 56.9060μs 18.4639μs 54.1597 KOps/s 54.2955 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-False-True-False-True] 49.5520μs 17.2179μs 58.0791 KOps/s 57.2770 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[False-False-True-False-False] 49.2320μs 11.4023μs 87.7014 KOps/s 87.5108 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-False-False-True-True] 56.4450μs 27.8622μs 35.8910 KOps/s 35.7315 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-False-False-True-False] 59.6910μs 19.8274μs 50.4353 KOps/s 51.5181 KOps/s $\color{#d91a1a}-2.10\%$
test_step_mdp_speed[False-False-False-False-True] 56.3540μs 18.3369μs 54.5348 KOps/s 53.7889 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-False-False-False-False] 43.2400μs 12.4202μs 80.5137 KOps/s 80.8759 KOps/s $\color{#d91a1a}-0.45\%$
test_values[generalized_advantage_estimate-True-True] 12.7328ms 9.5639ms 104.5602 Ops/s 108.7715 Ops/s $\color{#d91a1a}-3.87\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.9445ms 33.5049ms 29.8464 Ops/s 29.9811 Ops/s $\color{#d91a1a}-0.45\%$
test_values[td0_return_estimate-False-False] 0.2312ms 0.1716ms 5.8268 KOps/s 5.5952 KOps/s $\color{#35bf28}+4.14\%$
test_values[td1_return_estimate-False-False] 24.3398ms 23.9651ms 41.7274 Ops/s 43.6710 Ops/s $\color{#d91a1a}-4.45\%$
test_values[vec_td1_return_estimate-False-False] 34.8884ms 33.5849ms 29.7753 Ops/s 29.8584 Ops/s $\color{#d91a1a}-0.28\%$
test_values[td_lambda_return_estimate-True-False] 37.9810ms 34.6239ms 28.8818 Ops/s 30.2040 Ops/s $\color{#d91a1a}-4.38\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.4916ms 33.5952ms 29.7661 Ops/s 29.3967 Ops/s $\color{#35bf28}+1.26\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4121ms 8.3005ms 120.4744 Ops/s 124.8497 Ops/s $\color{#d91a1a}-3.50\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.0843ms 1.7961ms 556.7477 Ops/s 511.4067 Ops/s $\textbf{\color{#35bf28}+8.87\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4311ms 0.3592ms 2.7840 KOps/s 2.8942 KOps/s $\color{#d91a1a}-3.81\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.7709ms 44.7572ms 22.3428 Ops/s 24.8263 Ops/s $\textbf{\color{#d91a1a}-10.00\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5527ms 3.0454ms 328.3690 Ops/s 331.0291 Ops/s $\color{#d91a1a}-0.80\%$
test_dqn_speed 1.8763ms 1.3932ms 717.7463 Ops/s 721.8920 Ops/s $\color{#d91a1a}-0.57\%$
test_ddpg_speed 3.4371ms 2.8022ms 356.8576 Ops/s 361.2804 Ops/s $\color{#d91a1a}-1.22\%$
test_sac_speed 9.2255ms 8.7221ms 114.6518 Ops/s 115.2677 Ops/s $\color{#d91a1a}-0.53\%$
test_redq_speed 14.8119ms 13.6956ms 73.0163 Ops/s 74.1102 Ops/s $\color{#d91a1a}-1.48\%$
test_redq_deprec_speed 14.7253ms 14.0044ms 71.4062 Ops/s 69.2509 Ops/s $\color{#35bf28}+3.11\%$
test_td3_speed 9.6531ms 8.8276ms 113.2809 Ops/s 113.6417 Ops/s $\color{#d91a1a}-0.32\%$
test_cql_speed 39.7445ms 37.2209ms 26.8666 Ops/s 27.1431 Ops/s $\color{#d91a1a}-1.02\%$
test_a2c_speed 8.8594ms 7.4354ms 134.4909 Ops/s 134.5337 Ops/s $\color{#d91a1a}-0.03\%$
test_ppo_speed 7.8345ms 7.5957ms 131.6532 Ops/s 130.1126 Ops/s $\color{#35bf28}+1.18\%$
test_reinforce_speed 7.4617ms 6.6149ms 151.1728 Ops/s 151.7216 Ops/s $\color{#d91a1a}-0.36\%$
test_iql_speed 34.8148ms 33.3272ms 30.0055 Ops/s 30.2514 Ops/s $\color{#d91a1a}-0.81\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2288ms 2.8158ms 355.1432 Ops/s 362.8089 Ops/s $\color{#d91a1a}-2.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6273ms 0.5185ms 1.9286 KOps/s 1.9449 KOps/s $\color{#d91a1a}-0.84\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6214ms 0.4868ms 2.0541 KOps/s 2.0649 KOps/s $\color{#d91a1a}-0.52\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0411ms 2.8591ms 349.7619 Ops/s 357.3993 Ops/s $\color{#d91a1a}-2.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7375ms 0.5158ms 1.9389 KOps/s 1.9547 KOps/s $\color{#d91a1a}-0.81\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7912ms 0.4964ms 2.0144 KOps/s 2.0500 KOps/s $\color{#d91a1a}-1.74\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.3420ms 2.9609ms 337.7364 Ops/s 348.4443 Ops/s $\color{#d91a1a}-3.07\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9467ms 0.6412ms 1.5596 KOps/s 1.5693 KOps/s $\color{#d91a1a}-0.62\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7880ms 0.6149ms 1.6264 KOps/s 1.6436 KOps/s $\color{#d91a1a}-1.05\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0202ms 2.7546ms 363.0239 Ops/s 360.6239 Ops/s $\color{#35bf28}+0.67\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6765ms 0.5197ms 1.9242 KOps/s 1.9210 KOps/s $\color{#35bf28}+0.16\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6783ms 0.4963ms 2.0149 KOps/s 2.0207 KOps/s $\color{#d91a1a}-0.29\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0903ms 2.8076ms 356.1801 Ops/s 347.1523 Ops/s $\color{#35bf28}+2.60\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7285ms 0.5165ms 1.9359 KOps/s 1.9452 KOps/s $\color{#d91a1a}-0.48\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7153ms 0.4947ms 2.0212 KOps/s 2.0300 KOps/s $\color{#d91a1a}-0.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.5259ms 2.9053ms 344.2007 Ops/s 346.3322 Ops/s $\color{#d91a1a}-0.62\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7866ms 0.6391ms 1.5647 KOps/s 1.5800 KOps/s $\color{#d91a1a}-0.97\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7972ms 0.6205ms 1.6116 KOps/s 1.6291 KOps/s $\color{#d91a1a}-1.07\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1207s 8.5516ms 116.9366 Ops/s 115.5939 Ops/s $\color{#35bf28}+1.16\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.4129ms 13.4923ms 74.1161 Ops/s 74.6472 Ops/s $\color{#d91a1a}-0.71\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 3.8824ms 2.5108ms 398.2723 Ops/s 403.3469 Ops/s $\color{#d91a1a}-1.26\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1106s 10.4531ms 95.6651 Ops/s 95.7088 Ops/s $\color{#d91a1a}-0.05\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.7312ms 13.4515ms 74.3409 Ops/s 74.8042 Ops/s $\color{#d91a1a}-0.62\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.9947ms 2.5229ms 396.3652 Ops/s 398.1279 Ops/s $\color{#d91a1a}-0.44\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1073s 8.4858ms 117.8432 Ops/s 95.7179 Ops/s $\textbf{\color{#35bf28}+23.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.0684ms 13.7110ms 72.9341 Ops/s 73.6661 Ops/s $\color{#d91a1a}-0.99\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.3922ms 2.8581ms 349.8882 Ops/s 367.5775 Ops/s $\color{#d91a1a}-4.81\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1178s 0.1175s 8.5075 Ops/s 8.6237 Ops/s $\color{#d91a1a}-1.35\%$
test_sync 0.1742s 0.1030s 9.7103 Ops/s 9.5721 Ops/s $\color{#35bf28}+1.44\%$
test_async 0.1818s 91.7668ms 10.8972 Ops/s 10.9276 Ops/s $\color{#d91a1a}-0.28\%$
test_single_pixels 0.1299s 0.1297s 7.7130 Ops/s 7.8068 Ops/s $\color{#d91a1a}-1.20\%$
test_sync_pixels 81.7799ms 78.4066ms 12.7540 Ops/s 12.6114 Ops/s $\color{#35bf28}+1.13\%$
test_async_pixels 0.1418s 73.8562ms 13.5398 Ops/s 13.4073 Ops/s $\color{#35bf28}+0.99\%$
test_simple 0.9083s 0.8364s 1.1955 Ops/s 1.2078 Ops/s $\color{#d91a1a}-1.02\%$
test_transformed 1.1581s 1.0930s 0.9150 Ops/s 0.9300 Ops/s $\color{#d91a1a}-1.62\%$
test_serial 2.5433s 2.4670s 0.4053 Ops/s 0.4210 Ops/s $\color{#d91a1a}-3.71\%$
test_parallel 2.3122s 2.1464s 0.4659 Ops/s 0.4777 Ops/s $\color{#d91a1a}-2.47\%$
test_step_mdp_speed[True-True-True-True-True] 96.1510μs 32.7480μs 30.5362 KOps/s 30.3809 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[True-True-True-True-False] 44.1200μs 19.8936μs 50.2674 KOps/s 51.3980 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[True-True-True-False-True] 44.8700μs 18.6071μs 53.7430 KOps/s 52.7937 KOps/s $\color{#35bf28}+1.80\%$
test_step_mdp_speed[True-True-True-False-False] 41.4700μs 11.3528μs 88.0842 KOps/s 88.9393 KOps/s $\color{#d91a1a}-0.96\%$
test_step_mdp_speed[True-True-False-True-True] 51.5300μs 34.8265μs 28.7138 KOps/s 28.7930 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[True-True-False-True-False] 40.0600μs 21.7808μs 45.9120 KOps/s 47.2908 KOps/s $\color{#d91a1a}-2.92\%$
test_step_mdp_speed[True-True-False-False-True] 41.1700μs 20.6883μs 48.3364 KOps/s 49.6494 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[True-True-False-False-False] 35.9310μs 13.2432μs 75.5106 KOps/s 77.2429 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[True-False-True-True-True] 0.1251ms 36.9476μs 27.0654 KOps/s 26.7517 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-False-True-True-False] 40.9110μs 23.6764μs 42.2361 KOps/s 42.8444 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[True-False-True-False-True] 44.5200μs 20.6869μs 48.3398 KOps/s 48.8510 KOps/s $\color{#d91a1a}-1.05\%$
test_step_mdp_speed[True-False-True-False-False] 30.2000μs 13.2836μs 75.2808 KOps/s 76.9759 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[True-False-False-True-True] 75.0110μs 39.2043μs 25.5074 KOps/s 25.8582 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-False-False-True-False] 57.6510μs 25.8029μs 38.7554 KOps/s 39.6359 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[True-False-False-False-True] 45.6700μs 22.4714μs 44.5009 KOps/s 45.1956 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-False-False-False-False] 50.0000μs 14.8732μs 67.2352 KOps/s 67.2837 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-True-True-True-True] 55.4500μs 37.0370μs 27.0000 KOps/s 27.0670 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-True-True-False] 38.1710μs 24.0749μs 41.5371 KOps/s 41.8365 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-True-False-True] 54.8310μs 24.5769μs 40.6887 KOps/s 39.9449 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[False-True-True-False-False] 35.7500μs 14.9570μs 66.8582 KOps/s 66.4638 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[False-True-False-True-True] 60.7910μs 38.8219μs 25.7587 KOps/s 25.8143 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-False-True-False] 46.3710μs 25.6853μs 38.9328 KOps/s 39.1009 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[False-True-False-False-True] 42.6810μs 25.9315μs 38.5632 KOps/s 37.8880 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[False-True-False-False-False] 31.7400μs 16.9020μs 59.1646 KOps/s 59.8279 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[False-False-True-True-True] 68.5910μs 40.9550μs 24.4170 KOps/s 24.1079 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-False-True-True-False] 44.3010μs 27.7171μs 36.0788 KOps/s 36.6585 KOps/s $\color{#d91a1a}-1.58\%$
test_step_mdp_speed[False-False-True-False-True] 42.5900μs 25.9531μs 38.5310 KOps/s 37.8093 KOps/s $\color{#35bf28}+1.91\%$
test_step_mdp_speed[False-False-True-False-False] 50.8510μs 17.2486μs 57.9756 KOps/s 59.7815 KOps/s $\color{#d91a1a}-3.02\%$
test_step_mdp_speed[False-False-False-True-True] 60.8310μs 41.6570μs 24.0055 KOps/s 23.5642 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-False-False-True-False] 56.2110μs 29.6087μs 33.7738 KOps/s 34.5276 KOps/s $\color{#d91a1a}-2.18\%$
test_step_mdp_speed[False-False-False-False-True] 48.0410μs 27.2537μs 36.6923 KOps/s 36.0757 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[False-False-False-False-False] 34.5100μs 18.7341μs 53.3785 KOps/s 54.1986 KOps/s $\color{#d91a1a}-1.51\%$
test_values[generalized_advantage_estimate-True-True] 25.1006ms 24.6218ms 40.6145 Ops/s 41.6538 Ops/s $\color{#d91a1a}-2.50\%$
test_values[vec_generalized_advantage_estimate-True-True] 82.3536ms 3.2049ms 312.0219 Ops/s 310.3617 Ops/s $\color{#35bf28}+0.53\%$
test_values[td0_return_estimate-False-False] 0.1003ms 60.8004μs 16.4473 KOps/s 16.9130 KOps/s $\color{#d91a1a}-2.75\%$
test_values[td1_return_estimate-False-False] 54.4063ms 52.5675ms 19.0232 Ops/s 19.7080 Ops/s $\color{#d91a1a}-3.47\%$
test_values[vec_td1_return_estimate-False-False] 2.1359ms 1.7551ms 569.7703 Ops/s 573.6380 Ops/s $\color{#d91a1a}-0.67\%$
test_values[td_lambda_return_estimate-True-False] 84.9198ms 83.8899ms 11.9204 Ops/s 12.3056 Ops/s $\color{#d91a1a}-3.13\%$
test_values[vec_td_lambda_return_estimate-True-False] 4.1694ms 1.7922ms 557.9781 Ops/s 560.1217 Ops/s $\color{#d91a1a}-0.38\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.5126ms 23.1991ms 43.1051 Ops/s 44.3455 Ops/s $\color{#d91a1a}-2.80\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9081ms 0.6951ms 1.4387 KOps/s 1.4506 KOps/s $\color{#d91a1a}-0.82\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7162ms 0.6469ms 1.5459 KOps/s 1.5668 KOps/s $\color{#d91a1a}-1.33\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4884ms 1.4438ms 692.6023 Ops/s 694.5942 Ops/s $\color{#d91a1a}-0.29\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9715ms 0.6561ms 1.5242 KOps/s 1.5367 KOps/s $\color{#d91a1a}-0.81\%$
test_dqn_speed 8.2377ms 1.4626ms 683.7340 Ops/s 701.0999 Ops/s $\color{#d91a1a}-2.48\%$
test_ddpg_speed 3.1780ms 2.7530ms 363.2339 Ops/s 356.3367 Ops/s $\color{#35bf28}+1.94\%$
test_sac_speed 9.0078ms 8.6336ms 115.8269 Ops/s 114.0896 Ops/s $\color{#35bf28}+1.52\%$
test_redq_speed 11.6230ms 10.7506ms 93.0183 Ops/s 93.5714 Ops/s $\color{#d91a1a}-0.59\%$
test_redq_deprec_speed 12.3651ms 11.8319ms 84.5173 Ops/s 84.9040 Ops/s $\color{#d91a1a}-0.46\%$
test_td3_speed 17.9589ms 8.8809ms 112.6012 Ops/s 113.2286 Ops/s $\color{#d91a1a}-0.55\%$
test_cql_speed 27.4861ms 26.2580ms 38.0836 Ops/s 38.3873 Ops/s $\color{#d91a1a}-0.79\%$
test_a2c_speed 5.9760ms 5.4475ms 183.5717 Ops/s 175.3165 Ops/s $\color{#35bf28}+4.71\%$
test_ppo_speed 5.9306ms 5.6893ms 175.7689 Ops/s 169.1265 Ops/s $\color{#35bf28}+3.93\%$
test_reinforce_speed 5.0220ms 4.5358ms 220.4695 Ops/s 215.4213 Ops/s $\color{#35bf28}+2.34\%$
test_iql_speed 20.3058ms 19.7856ms 50.5418 Ops/s 49.0762 Ops/s $\color{#35bf28}+2.99\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7012ms 3.5699ms 280.1163 Ops/s 276.1316 Ops/s $\color{#35bf28}+1.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7279ms 0.5679ms 1.7607 KOps/s 1.7359 KOps/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6915ms 0.5437ms 1.8393 KOps/s 1.8284 KOps/s $\color{#35bf28}+0.60\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8615ms 3.6138ms 276.7138 Ops/s 274.5802 Ops/s $\color{#35bf28}+0.78\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7601ms 0.5597ms 1.7866 KOps/s 1.7553 KOps/s $\color{#35bf28}+1.79\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7515ms 0.5397ms 1.8529 KOps/s 1.8561 KOps/s $\color{#d91a1a}-0.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8816ms 3.7540ms 266.3825 Ops/s 269.6328 Ops/s $\color{#d91a1a}-1.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8401ms 0.6968ms 1.4352 KOps/s 1.4100 KOps/s $\color{#35bf28}+1.78\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8243ms 0.6726ms 1.4868 KOps/s 1.4756 KOps/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7300ms 3.6096ms 277.0422 Ops/s 276.2071 Ops/s $\color{#35bf28}+0.30\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7042ms 0.5680ms 1.7606 KOps/s 1.7451 KOps/s $\color{#35bf28}+0.89\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7061ms 0.5448ms 1.8357 KOps/s 1.8416 KOps/s $\color{#d91a1a}-0.32\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8722ms 3.6404ms 274.6953 Ops/s 273.8687 Ops/s $\color{#35bf28}+0.30\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8271ms 0.5607ms 1.7834 KOps/s 1.7648 KOps/s $\color{#35bf28}+1.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7066ms 0.5362ms 1.8649 KOps/s 1.8533 KOps/s $\color{#35bf28}+0.63\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8645ms 3.7561ms 266.2322 Ops/s 267.3359 Ops/s $\color{#d91a1a}-0.41\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9540ms 0.6981ms 1.4324 KOps/s 1.4108 KOps/s $\color{#35bf28}+1.53\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8053ms 0.6710ms 1.4903 KOps/s 1.4634 KOps/s $\color{#35bf28}+1.83\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1309s 12.6186ms 79.2482 Ops/s 93.5673 Ops/s $\textbf{\color{#d91a1a}-15.30\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.3840ms 16.1014ms 62.1064 Ops/s 61.7855 Ops/s $\color{#35bf28}+0.52\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.7259ms 3.0808ms 324.5947 Ops/s 319.4508 Ops/s $\color{#35bf28}+1.61\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1266s 10.3234ms 96.8676 Ops/s 95.4628 Ops/s $\color{#35bf28}+1.47\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.4190ms 16.1881ms 61.7738 Ops/s 61.0191 Ops/s $\color{#35bf28}+1.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.5516ms 3.1141ms 321.1248 Ops/s 313.9661 Ops/s $\color{#35bf28}+2.28\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1231s 10.3576ms 96.5476 Ops/s 94.9124 Ops/s $\color{#35bf28}+1.72\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.9504ms 16.5182ms 60.5394 Ops/s 51.7174 Ops/s $\textbf{\color{#35bf28}+17.06\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.2996ms 3.4033ms 293.8358 Ops/s 295.2463 Ops/s $\color{#d91a1a}-0.48\%$

@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests Suitable for minor Suitable to be integrated in minor release (no new feature) labels Feb 12, 2024
@vmoens vmoens merged commit 1647fa4 into main Feb 12, 2024
66 of 68 checks passed
@vmoens vmoens deleted the fix-rb-tests branch February 12, 2024 09:25
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[BugFix] Fix flaky rb tests (#1901)
a543415
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature) Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot