Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Temporarily set lazy legacy to True #1840

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[BugFix] Temporarily set lazy legacy to True #1840

merged 1 commit into from
Jan 26, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 26, 2024 •
edited
Loading

Suppresses warnings about lazy_legacy not being defined.

We'll revert it later to False in #1832

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1840

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 19 Unrelated Failures

As of commit b9da8c2 with merge base 6f90397 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2024
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Jan 26, 2024
@vmoens vmoens merged commit 6a42116 into main Jan 26, 2024
32 of 51 checks passed
@vmoens vmoens deleted the set_lazy_legacy_true branch January 26, 2024 10:40
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}15$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1269s 65.2133ms 15.3343 Ops/s 16.0092 Ops/s $\color{#d91a1a}-4.22\%$
test_sync 47.1732ms 36.1803ms 27.6393 Ops/s 30.3758 Ops/s $\textbf{\color{#d91a1a}-9.01\%}$
test_async 0.1338s 32.6422ms 30.6352 Ops/s 30.5955 Ops/s $\color{#35bf28}+0.13\%$
test_simple 0.4892s 0.4300s 2.3253 Ops/s 2.2999 Ops/s $\color{#35bf28}+1.11\%$
test_transformed 0.6466s 0.5955s 1.6794 Ops/s 1.6636 Ops/s $\color{#35bf28}+0.95\%$
test_serial 1.4041s 1.3457s 0.7431 Ops/s 0.7318 Ops/s $\color{#35bf28}+1.55\%$
test_parallel 1.2793s 1.1991s 0.8339 Ops/s 0.8371 Ops/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[True-True-True-True-True] 0.1610ms 21.4076μs 46.7124 KOps/s 48.1468 KOps/s $\color{#d91a1a}-2.98\%$
test_step_mdp_speed[True-True-True-True-False] 46.8480μs 13.0134μs 76.8440 KOps/s 79.3441 KOps/s $\color{#d91a1a}-3.15\%$
test_step_mdp_speed[True-True-True-False-True] 37.1500μs 12.5543μs 79.6538 KOps/s 82.0817 KOps/s $\color{#d91a1a}-2.96\%$
test_step_mdp_speed[True-True-True-False-False] 30.4170μs 7.6412μs 130.8697 KOps/s 136.3753 KOps/s $\color{#d91a1a}-4.04\%$
test_step_mdp_speed[True-True-False-True-True] 55.2230μs 22.8678μs 43.7296 KOps/s 43.9903 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[True-True-False-True-False] 41.0770μs 14.5503μs 68.7269 KOps/s 71.3700 KOps/s $\color{#d91a1a}-3.70\%$
test_step_mdp_speed[True-True-False-False-True] 38.9030μs 14.0807μs 71.0193 KOps/s 73.1357 KOps/s $\color{#d91a1a}-2.89\%$
test_step_mdp_speed[True-True-False-False-False] 59.2480μs 8.8078μs 113.5352 KOps/s 112.4863 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-False-True-True-True] 71.1640μs 24.0408μs 41.5960 KOps/s 41.6977 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[True-False-True-True-False] 41.3480μs 15.8252μs 63.1904 KOps/s 64.9610 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[True-False-True-False-True] 36.0980μs 13.7638μs 72.6546 KOps/s 75.4236 KOps/s $\color{#d91a1a}-3.67\%$
test_step_mdp_speed[True-False-True-False-False] 35.9870μs 8.9111μs 112.2201 KOps/s 114.4723 KOps/s $\color{#d91a1a}-1.97\%$
test_step_mdp_speed[True-False-False-True-True] 68.7380μs 25.4912μs 39.2292 KOps/s 39.8432 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-False-False-True-False] 38.4220μs 16.9409μs 59.0289 KOps/s 59.0959 KOps/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-False-False-False-True] 47.0080μs 14.9422μs 66.9246 KOps/s 68.0732 KOps/s $\color{#d91a1a}-1.69\%$
test_step_mdp_speed[True-False-False-False-False] 41.3980μs 10.1303μs 98.7140 KOps/s 100.5578 KOps/s $\color{#d91a1a}-1.83\%$
test_step_mdp_speed[False-True-True-True-True] 82.2340μs 24.1980μs 41.3257 KOps/s 42.0469 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[False-True-True-True-False] 40.3960μs 15.9756μs 62.5955 KOps/s 64.2022 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[False-True-True-False-True] 85.5740μs 16.3940μs 60.9978 KOps/s 64.5194 KOps/s $\textbf{\color{#d91a1a}-5.46\%}$
test_step_mdp_speed[False-True-True-False-False] 45.2850μs 10.0658μs 99.3460 KOps/s 100.2008 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-True-False-True-True] 53.8000μs 25.3027μs 39.5214 KOps/s 40.7744 KOps/s $\color{#d91a1a}-3.07\%$
test_step_mdp_speed[False-True-False-True-False] 44.8640μs 17.0882μs 58.5200 KOps/s 60.5972 KOps/s $\color{#d91a1a}-3.43\%$
test_step_mdp_speed[False-True-False-False-True] 76.5360μs 17.3172μs 57.7462 KOps/s 59.8708 KOps/s $\color{#d91a1a}-3.55\%$
test_step_mdp_speed[False-True-False-False-False] 51.4760μs 11.4388μs 87.4215 KOps/s 90.8725 KOps/s $\color{#d91a1a}-3.80\%$
test_step_mdp_speed[False-False-True-True-True] 68.1080μs 26.7737μs 37.3500 KOps/s 38.6913 KOps/s $\color{#d91a1a}-3.47\%$
test_step_mdp_speed[False-False-True-True-False] 69.1800μs 18.3655μs 54.4498 KOps/s 56.7215 KOps/s $\color{#d91a1a}-4.00\%$
test_step_mdp_speed[False-False-True-False-True] 60.0930μs 17.2078μs 58.1131 KOps/s 59.4146 KOps/s $\color{#d91a1a}-2.19\%$
test_step_mdp_speed[False-False-True-False-False] 45.4450μs 11.5188μs 86.8146 KOps/s 91.0482 KOps/s $\color{#d91a1a}-4.65\%$
test_step_mdp_speed[False-False-False-True-True] 61.2150μs 28.0858μs 35.6052 KOps/s 37.3004 KOps/s $\color{#d91a1a}-4.54\%$
test_step_mdp_speed[False-False-False-True-False] 54.7320μs 19.5622μs 51.1191 KOps/s 53.2610 KOps/s $\color{#d91a1a}-4.02\%$
test_step_mdp_speed[False-False-False-False-True] 51.7580μs 18.5193μs 53.9977 KOps/s 56.8596 KOps/s $\textbf{\color{#d91a1a}-5.03\%}$
test_step_mdp_speed[False-False-False-False-False] 57.7990μs 12.7380μs 78.5052 KOps/s 82.5561 KOps/s $\color{#d91a1a}-4.91\%$
test_values[generalized_advantage_estimate-True-True] 12.8373ms 12.1778ms 82.1165 Ops/s 81.7528 Ops/s $\color{#35bf28}+0.44\%$
test_values[vec_generalized_advantage_estimate-True-True] 34.8797ms 27.8767ms 35.8723 Ops/s 36.0627 Ops/s $\color{#d91a1a}-0.53\%$
test_values[td0_return_estimate-False-False] 0.2368ms 0.1907ms 5.2434 KOps/s 5.6899 KOps/s $\textbf{\color{#d91a1a}-7.85\%}$
test_values[td1_return_estimate-False-False] 26.3497ms 26.0335ms 38.4120 Ops/s 38.2736 Ops/s $\color{#35bf28}+0.36\%$
test_values[vec_td1_return_estimate-False-False] 36.0379ms 28.0819ms 35.6101 Ops/s 35.4470 Ops/s $\color{#35bf28}+0.46\%$
test_values[td_lambda_return_estimate-True-False] 36.9068ms 36.2269ms 27.6038 Ops/s 27.1297 Ops/s $\color{#35bf28}+1.75\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.4030ms 28.0446ms 35.6574 Ops/s 35.6439 Ops/s $\color{#35bf28}+0.04\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.3606ms 8.1942ms 122.0376 Ops/s 121.4669 Ops/s $\color{#35bf28}+0.47\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 4.7759ms 2.0125ms 496.8878 Ops/s 509.6318 Ops/s $\color{#d91a1a}-2.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 9.3209ms 0.4466ms 2.2391 KOps/s 2.2312 KOps/s $\color{#35bf28}+0.35\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.5212ms 42.1163ms 23.7438 Ops/s 23.0536 Ops/s $\color{#35bf28}+2.99\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 11.5018ms 2.6602ms 375.9078 Ops/s 366.7888 Ops/s $\color{#35bf28}+2.49\%$
test_dqn_speed 83.7152ms 8.1864ms 122.1537 Ops/s 135.5762 Ops/s $\textbf{\color{#d91a1a}-9.90\%}$
test_ddpg_speed 21.6831ms 14.5489ms 68.7338 Ops/s 69.9773 Ops/s $\color{#d91a1a}-1.78\%$
test_sac_speed 35.7471ms 29.4667ms 33.9366 Ops/s 34.5238 Ops/s $\color{#d91a1a}-1.70\%$
test_redq_speed 50.2135ms 45.9884ms 21.7446 Ops/s 22.1299 Ops/s $\color{#d91a1a}-1.74\%$
test_redq_deprec_speed 35.1476ms 26.3243ms 37.9878 Ops/s 40.0786 Ops/s $\textbf{\color{#d91a1a}-5.22\%}$
test_td3_speed 29.8080ms 20.6205ms 48.4954 Ops/s 50.6187 Ops/s $\color{#d91a1a}-4.19\%$
test_cql_speed 93.9670ms 89.1396ms 11.2184 Ops/s 11.6312 Ops/s $\color{#d91a1a}-3.55\%$
test_a2c_speed 29.0988ms 27.5843ms 36.2525 Ops/s 37.7867 Ops/s $\color{#d91a1a}-4.06\%$
test_ppo_speed 29.2025ms 27.7333ms 36.0578 Ops/s 36.9879 Ops/s $\color{#d91a1a}-2.51\%$
test_reinforce_speed 35.7963ms 26.8374ms 37.2615 Ops/s 37.8990 Ops/s $\color{#d91a1a}-1.68\%$
test_iql_speed 71.4408ms 64.4430ms 15.5176 Ops/s 15.6796 Ops/s $\color{#d91a1a}-1.03\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3394ms 1.5420ms 648.4947 Ops/s 700.0695 Ops/s $\textbf{\color{#d91a1a}-7.37\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 9.0035ms 0.5427ms 1.8427 KOps/s 1.9118 KOps/s $\color{#d91a1a}-3.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.8279ms 0.5062ms 1.9754 KOps/s 2.0335 KOps/s $\color{#d91a1a}-2.86\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 1.9475ms 1.5669ms 638.1855 Ops/s 741.6699 Ops/s $\textbf{\color{#d91a1a}-13.95\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9964ms 0.5313ms 1.8822 KOps/s 1.9224 KOps/s $\color{#d91a1a}-2.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 10.2650ms 0.5074ms 1.9710 KOps/s 2.0336 KOps/s $\color{#d91a1a}-3.08\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0972ms 1.7961ms 556.7527 Ops/s 625.8134 Ops/s $\textbf{\color{#d91a1a}-11.04\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 10.6163ms 0.6846ms 1.4606 KOps/s 1.5134 KOps/s $\color{#d91a1a}-3.48\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.9511ms 0.6483ms 1.5424 KOps/s 1.2466 KOps/s $\textbf{\color{#35bf28}+23.72\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2100ms 1.4899ms 671.1716 Ops/s 724.2073 Ops/s $\textbf{\color{#d91a1a}-7.32\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6445ms 0.5277ms 1.8949 KOps/s 1.9168 KOps/s $\color{#d91a1a}-1.15\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.9812ms 0.5114ms 1.9554 KOps/s 1.9814 KOps/s $\color{#d91a1a}-1.31\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.1485ms 1.5254ms 655.5635 Ops/s 736.5055 Ops/s $\textbf{\color{#d91a1a}-10.99\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6694ms 0.5286ms 1.8919 KOps/s 1.9353 KOps/s $\color{#d91a1a}-2.24\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 10.4614ms 0.5159ms 1.9383 KOps/s 2.0006 KOps/s $\color{#d91a1a}-3.12\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.1517ms 1.6805ms 595.0688 Ops/s 645.3170 Ops/s $\textbf{\color{#d91a1a}-7.79\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8360ms 0.6626ms 1.5092 KOps/s 1.5287 KOps/s $\color{#d91a1a}-1.28\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.5092ms 0.6464ms 1.5469 KOps/s 1.5580 KOps/s $\color{#d91a1a}-0.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1223s 12.8704ms 77.6978 Ops/s 95.8563 Ops/s $\textbf{\color{#d91a1a}-18.94\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.6708ms 13.7785ms 72.5766 Ops/s 72.7204 Ops/s $\color{#d91a1a}-0.20\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.5594ms 3.3066ms 302.4252 Ops/s 304.9143 Ops/s $\color{#d91a1a}-0.82\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1179s 10.8615ms 92.0682 Ops/s 95.3355 Ops/s $\color{#d91a1a}-3.43\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.1615ms 14.2615ms 70.1190 Ops/s 73.3133 Ops/s $\color{#d91a1a}-4.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.2725ms 3.4291ms 291.6231 Ops/s 296.0988 Ops/s $\color{#d91a1a}-1.51\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1217s 14.8575ms 67.3060 Ops/s 71.5320 Ops/s $\textbf{\color{#d91a1a}-5.91\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5168ms 15.8239ms 63.1954 Ops/s 64.1953 Ops/s $\color{#d91a1a}-1.56\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 12.5768ms 5.3835ms 185.7529 Ops/s 196.7328 Ops/s $\textbf{\color{#d91a1a}-5.58\%}$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1171s 0.1161s 8.6119 Ops/s 8.6338 Ops/s $\color{#d91a1a}-0.25\%$
test_sync 0.1021s 0.1007s 9.9313 Ops/s 10.4257 Ops/s $\color{#d91a1a}-4.74\%$
test_async 0.2514s 92.1355ms 10.8536 Ops/s 10.9177 Ops/s $\color{#d91a1a}-0.59\%$
test_single_pixels 0.1390s 0.1388s 7.2071 Ops/s 7.1255 Ops/s $\color{#35bf28}+1.14\%$
test_sync_pixels 77.8845ms 77.2371ms 12.9472 Ops/s 13.3334 Ops/s $\color{#d91a1a}-2.90\%$
test_async_pixels 0.1580s 72.7855ms 13.7390 Ops/s 14.1561 Ops/s $\color{#d91a1a}-2.95\%$
test_simple 0.9012s 0.8375s 1.1940 Ops/s 1.2011 Ops/s $\color{#d91a1a}-0.59\%$
test_transformed 1.1476s 1.0930s 0.9149 Ops/s 0.9230 Ops/s $\color{#d91a1a}-0.88\%$
test_serial 2.3490s 2.2849s 0.4377 Ops/s 0.4311 Ops/s $\color{#35bf28}+1.52\%$
test_parallel 1.9254s 1.8076s 0.5532 Ops/s 0.5345 Ops/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[True-True-True-True-True] 0.2125ms 32.9812μs 30.3203 KOps/s 29.5737 KOps/s $\color{#35bf28}+2.52\%$
test_step_mdp_speed[True-True-True-True-False] 0.1076ms 19.7337μs 50.6747 KOps/s 49.6680 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-True-True-False-True] 36.6510μs 18.5244μs 53.9829 KOps/s 52.6872 KOps/s $\color{#35bf28}+2.46\%$
test_step_mdp_speed[True-True-True-False-False] 30.5410μs 11.0505μs 90.4936 KOps/s 86.4137 KOps/s $\color{#35bf28}+4.72\%$
test_step_mdp_speed[True-True-False-True-True] 59.3720μs 34.5988μs 28.9027 KOps/s 28.2915 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[True-True-False-True-False] 42.3220μs 21.6126μs 46.2692 KOps/s 45.1390 KOps/s $\color{#35bf28}+2.50\%$
test_step_mdp_speed[True-True-False-False-True] 45.0110μs 20.3219μs 49.2079 KOps/s 47.7120 KOps/s $\color{#35bf28}+3.14\%$
test_step_mdp_speed[True-True-False-False-False] 83.0010μs 12.9193μs 77.4033 KOps/s 74.1848 KOps/s $\color{#35bf28}+4.34\%$
test_step_mdp_speed[True-False-True-True-True] 61.1300μs 36.9789μs 27.0425 KOps/s 26.2457 KOps/s $\color{#35bf28}+3.04\%$
test_step_mdp_speed[True-False-True-True-False] 46.3510μs 23.8041μs 42.0096 KOps/s 41.3183 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-False-True-False-True] 44.2310μs 20.1805μs 49.5527 KOps/s 47.4181 KOps/s $\color{#35bf28}+4.50\%$
test_step_mdp_speed[True-False-True-False-False] 29.5600μs 13.0015μs 76.9141 KOps/s 74.1008 KOps/s $\color{#35bf28}+3.80\%$
test_step_mdp_speed[True-False-False-True-True] 66.9510μs 38.7448μs 25.8099 KOps/s 25.5773 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[True-False-False-True-False] 44.5000μs 25.6589μs 38.9728 KOps/s 38.3327 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-False-False-False-True] 45.5210μs 21.9201μs 45.6202 KOps/s 43.9496 KOps/s $\color{#35bf28}+3.80\%$
test_step_mdp_speed[True-False-False-False-False] 32.4710μs 14.8567μs 67.3095 KOps/s 65.0277 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-True-True-True-True] 64.9810μs 36.9417μs 27.0697 KOps/s 26.6214 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[False-True-True-True-False] 42.1000μs 23.8855μs 41.8664 KOps/s 41.3186 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[False-True-True-False-True] 50.7620μs 24.5429μs 40.7450 KOps/s 39.5767 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-True-True-False-False] 32.4610μs 15.3368μs 65.2025 KOps/s 63.8699 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[False-True-False-True-True] 62.1810μs 38.5069μs 25.9694 KOps/s 25.4708 KOps/s $\color{#35bf28}+1.96\%$
test_step_mdp_speed[False-True-False-True-False] 49.3610μs 25.4410μs 39.3066 KOps/s 38.1300 KOps/s $\color{#35bf28}+3.09\%$
test_step_mdp_speed[False-True-False-False-True] 55.5310μs 26.6462μs 37.5288 KOps/s 37.0165 KOps/s $\color{#35bf28}+1.38\%$
test_step_mdp_speed[False-True-False-False-False] 36.8900μs 16.7972μs 59.5338 KOps/s 57.8640 KOps/s $\color{#35bf28}+2.89\%$
test_step_mdp_speed[False-False-True-True-True] 0.1537ms 39.7354μs 25.1665 KOps/s 24.3817 KOps/s $\color{#35bf28}+3.22\%$
test_step_mdp_speed[False-False-True-True-False] 49.4710μs 27.3145μs 36.6105 KOps/s 35.3702 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-False-True-False-True] 50.0510μs 26.5121μs 37.7186 KOps/s 37.0592 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[False-False-True-False-False] 39.0300μs 16.9492μs 58.9999 KOps/s 57.7854 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-False-False-True-True] 0.1045ms 42.2580μs 23.6642 KOps/s 23.3131 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[False-False-False-True-False] 53.2000μs 29.3070μs 34.1215 KOps/s 33.5502 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-False-False-False-True] 62.9220μs 28.2977μs 35.3386 KOps/s 35.1598 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-False-False-False-False] 39.4010μs 18.6047μs 53.7498 KOps/s 53.0963 KOps/s $\color{#35bf28}+1.23\%$
test_values[generalized_advantage_estimate-True-True] 24.3730ms 23.8430ms 41.9410 Ops/s 41.6413 Ops/s $\color{#35bf28}+0.72\%$
test_values[vec_generalized_advantage_estimate-True-True] 85.0976ms 3.2501ms 307.6824 Ops/s 309.4039 Ops/s $\color{#d91a1a}-0.56\%$
test_values[td0_return_estimate-False-False] 95.9430μs 59.3591μs 16.8466 KOps/s 16.5706 KOps/s $\color{#35bf28}+1.67\%$
test_values[td1_return_estimate-False-False] 53.7975ms 53.1075ms 18.8297 Ops/s 19.5130 Ops/s $\color{#d91a1a}-3.50\%$
test_values[vec_td1_return_estimate-False-False] 2.1146ms 1.7521ms 570.7385 Ops/s 560.3562 Ops/s $\color{#35bf28}+1.85\%$
test_values[td_lambda_return_estimate-True-False] 86.9778ms 85.0692ms 11.7551 Ops/s 12.2694 Ops/s $\color{#d91a1a}-4.19\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0912ms 1.7412ms 574.3093 Ops/s 574.8954 Ops/s $\color{#d91a1a}-0.10\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.5281ms 24.2212ms 41.2861 Ops/s 44.0614 Ops/s $\textbf{\color{#d91a1a}-6.30\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8200ms 0.6731ms 1.4857 KOps/s 1.4770 KOps/s $\color{#35bf28}+0.59\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7032ms 0.6404ms 1.5614 KOps/s 1.5809 KOps/s $\color{#d91a1a}-1.23\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4909ms 1.4362ms 696.2705 Ops/s 698.6828 Ops/s $\color{#d91a1a}-0.35\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9045ms 0.6483ms 1.5425 KOps/s 1.5487 KOps/s $\color{#d91a1a}-0.40\%$
test_dqn_speed 7.6518ms 7.3563ms 135.9379 Ops/s 133.5623 Ops/s $\color{#35bf28}+1.78\%$
test_ddpg_speed 18.3712ms 14.5224ms 68.8593 Ops/s 68.5238 Ops/s $\color{#35bf28}+0.49\%$
test_sac_speed 29.7808ms 28.7478ms 34.7852 Ops/s 34.3972 Ops/s $\color{#35bf28}+1.13\%$
test_redq_speed 48.9811ms 47.3481ms 21.1202 Ops/s 21.0290 Ops/s $\color{#35bf28}+0.43\%$
test_redq_deprec_speed 24.5785ms 23.6535ms 42.2770 Ops/s 41.7848 Ops/s $\color{#35bf28}+1.18\%$
test_td3_speed 28.8782ms 19.4830ms 51.3268 Ops/s 50.7147 Ops/s $\color{#35bf28}+1.21\%$
test_cql_speed 83.2263ms 81.8924ms 12.2111 Ops/s 12.0562 Ops/s $\color{#35bf28}+1.28\%$
test_a2c_speed 27.4727ms 26.5596ms 37.6512 Ops/s 37.2863 Ops/s $\color{#35bf28}+0.98\%$
test_ppo_speed 27.8742ms 26.6845ms 37.4750 Ops/s 33.8841 Ops/s $\textbf{\color{#35bf28}+10.60\%}$
test_reinforce_speed 26.2058ms 25.5887ms 39.0797 Ops/s 38.9023 Ops/s $\color{#35bf28}+0.46\%$
test_iql_speed 57.4462ms 56.4768ms 17.7064 Ops/s 17.5441 Ops/s $\color{#35bf28}+0.92\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.1857ms 1.8092ms 552.7366 Ops/s 488.2550 Ops/s $\textbf{\color{#35bf28}+13.21\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0518ms 0.8444ms 1.1843 KOps/s 1.1842 KOps/s $\color{#35bf28}+0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0157ms 0.8193ms 1.2206 KOps/s 1.2194 KOps/s $\color{#35bf28}+0.10\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.5291ms 1.8064ms 553.5939 Ops/s 487.6477 Ops/s $\textbf{\color{#35bf28}+13.52\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9833ms 0.8318ms 1.2022 KOps/s 1.2000 KOps/s $\color{#35bf28}+0.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9831ms 0.8093ms 1.2357 KOps/s 1.2349 KOps/s $\color{#35bf28}+0.06\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8094ms 2.0335ms 491.7686 Ops/s 423.6276 Ops/s $\textbf{\color{#35bf28}+16.09\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1612ms 0.9627ms 1.0387 KOps/s 1.0386 KOps/s $+0.01\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.1231ms 0.9389ms 1.0651 KOps/s 1.0671 KOps/s $\color{#d91a1a}-0.19\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6603ms 1.8278ms 547.1140 Ops/s 541.1168 Ops/s $\color{#35bf28}+1.11\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0462ms 0.8441ms 1.1847 KOps/s 1.1821 KOps/s $\color{#35bf28}+0.22\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 1.0293ms 0.8220ms 1.2166 KOps/s 1.2178 KOps/s $\color{#d91a1a}-0.10\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 0.1189s 2.0629ms 484.7540 Ops/s 549.8605 Ops/s $\textbf{\color{#d91a1a}-11.84\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9764ms 0.8332ms 1.2002 KOps/s 1.1980 KOps/s $\color{#35bf28}+0.18\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 1.0246ms 0.8126ms 1.2306 KOps/s 1.2335 KOps/s $\color{#d91a1a}-0.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0975ms 2.0673ms 483.7237 Ops/s 478.5542 Ops/s $\color{#35bf28}+1.08\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1689ms 0.9631ms 1.0383 KOps/s 1.0369 KOps/s $\color{#35bf28}+0.14\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0720ms 0.9386ms 1.0654 KOps/s 1.0646 KOps/s $\color{#35bf28}+0.08\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1180s 9.9035ms 100.9739 Ops/s 97.8355 Ops/s $\color{#35bf28}+3.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.4798ms 14.0338ms 71.2568 Ops/s 70.8491 Ops/s $\color{#35bf28}+0.58\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.1868ms 3.3422ms 299.2075 Ops/s 292.3790 Ops/s $\color{#35bf28}+2.34\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1196s 9.9760ms 100.2404 Ops/s 97.2926 Ops/s $\color{#35bf28}+3.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.3707ms 13.9742ms 71.5604 Ops/s 70.8106 Ops/s $\color{#35bf28}+1.06\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.5225ms 3.3232ms 300.9176 Ops/s 295.2801 Ops/s $\color{#35bf28}+1.91\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1186s 10.1202ms 98.8123 Ops/s 95.9334 Ops/s $\color{#35bf28}+3.00\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1241s 16.3678ms 61.0954 Ops/s 70.4679 Ops/s $\textbf{\color{#d91a1a}-13.30\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.9295ms 3.5221ms 283.9187 Ops/s 278.7095 Ops/s $\color{#35bf28}+1.87\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot