Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc, Feature] Doc improvements for video recording and CSV video formats #1829

Merged
merged 5 commits into from
Jan 23, 2024
Merged

[Doc, Feature] Doc improvements for video recording and CSV video formats #1829

merged 5 commits into from
Jan 23, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 23, 2024 •
edited
Loading

closes #1400

cc @lucasbasquerotto @ADebor

In a previous PR I also refined a lot the docstrings of all the envs we have so all in all the situation should be much better now!

I added a bunch of options in CSVLogger to save videos in a more flexible way.

The doc will be available here https://docs-preview.pytorch.org/pytorch/rl/1829/reference/generated/torchrl.record.VideoRecorder.html#torchrl.record.VideoRecorder

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1829

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 2 Unrelated Failures

As of commit d54f577 with merge base c390cf6 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2024
@vmoens vmoens added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1304s 64.3680ms 15.5357 Ops/s 16.1115 Ops/s $\color{#d91a1a}-3.57\%$
test_sync 50.1615ms 34.8232ms 28.7165 Ops/s 30.6636 Ops/s $\textbf{\color{#d91a1a}-6.35\%}$
test_async 60.5688ms 31.2798ms 31.9695 Ops/s 31.6659 Ops/s $\color{#35bf28}+0.96\%$
test_simple 0.4770s 0.4269s 2.3422 Ops/s 2.3075 Ops/s $\color{#35bf28}+1.51\%$
test_transformed 0.6350s 0.5851s 1.7092 Ops/s 1.6801 Ops/s $\color{#35bf28}+1.73\%$
test_serial 1.4042s 1.3194s 0.7579 Ops/s 0.7418 Ops/s $\color{#35bf28}+2.17\%$
test_parallel 1.1982s 1.1575s 0.8639 Ops/s 0.8411 Ops/s $\color{#35bf28}+2.72\%$
test_step_mdp_speed[True-True-True-True-True] 57.3770μs 21.2428μs 47.0748 KOps/s 45.8187 KOps/s $\color{#35bf28}+2.74\%$
test_step_mdp_speed[True-True-True-True-False] 38.3110μs 13.0194μs 76.8082 KOps/s 74.9708 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[True-True-True-False-True] 77.7550μs 12.5274μs 79.8247 KOps/s 79.2136 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[True-True-True-False-False] 34.7450μs 7.7517μs 129.0035 KOps/s 130.0931 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[True-True-False-True-True] 48.4800μs 22.9536μs 43.5661 KOps/s 43.4685 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-True-False-True-False] 36.0570μs 14.4229μs 69.3340 KOps/s 68.3499 KOps/s $\color{#35bf28}+1.44\%$
test_step_mdp_speed[True-True-False-False-True] 34.0530μs 13.9604μs 71.6313 KOps/s 72.0263 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[True-True-False-False-False] 42.7700μs 8.9980μs 111.1363 KOps/s 111.1792 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[True-False-True-True-True] 50.1040μs 24.1648μs 41.3825 KOps/s 40.8780 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-False-True-True-False] 40.8260μs 15.8539μs 63.0759 KOps/s 62.1692 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[True-False-True-False-True] 45.2550μs 13.7380μs 72.7909 KOps/s 71.5572 KOps/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[True-False-True-False-False] 28.0120μs 8.9085μs 112.2520 KOps/s 109.5653 KOps/s $\color{#35bf28}+2.45\%$
test_step_mdp_speed[True-False-False-True-True] 74.8190μs 25.2402μs 39.6194 KOps/s 38.9143 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[True-False-False-True-False] 45.8260μs 16.9481μs 59.0037 KOps/s 57.3122 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[True-False-False-False-True] 62.9970μs 14.9348μs 66.9578 KOps/s 66.0227 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-False-False-False-False] 37.6710μs 10.0087μs 99.9133 KOps/s 95.9261 KOps/s $\color{#35bf28}+4.16\%$
test_step_mdp_speed[False-True-True-True-True] 50.8250μs 24.1743μs 41.3663 KOps/s 40.4087 KOps/s $\color{#35bf28}+2.37\%$
test_step_mdp_speed[False-True-True-True-False] 47.8990μs 15.9189μs 62.8185 KOps/s 62.0476 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-True-True-False-True] 43.0400μs 16.3447μs 61.1819 KOps/s 61.9976 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-True-True-False-False] 37.0690μs 10.1520μs 98.5024 KOps/s 98.3050 KOps/s $\color{#35bf28}+0.20\%$
test_step_mdp_speed[False-True-False-True-True] 60.3720μs 25.2063μs 39.6726 KOps/s 39.1840 KOps/s $\color{#35bf28}+1.25\%$
test_step_mdp_speed[False-True-False-True-False] 38.4720μs 17.1726μs 58.2324 KOps/s 58.0025 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-True-False-False-True] 44.8630μs 17.4929μs 57.1662 KOps/s 55.9980 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[False-True-False-False-False] 47.6790μs 11.3599μs 88.0291 KOps/s 87.6379 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-False-True-True-True] 64.7110μs 26.5405μs 37.6782 KOps/s 36.7610 KOps/s $\color{#35bf28}+2.50\%$
test_step_mdp_speed[False-False-True-True-False] 60.2320μs 18.3611μs 54.4631 KOps/s 53.1386 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[False-False-True-False-True] 44.3630μs 17.1869μs 58.1837 KOps/s 57.7589 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-True-False-False] 41.1260μs 11.3265μs 88.2887 KOps/s 87.5834 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-False-False-True-True] 64.1800μs 27.5353μs 36.3170 KOps/s 35.7329 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[False-False-False-True-False] 40.7760μs 19.3867μs 51.5816 KOps/s 51.1690 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-False-False-False-True] 41.2270μs 18.3267μs 54.5653 KOps/s 54.6719 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[False-False-False-False-False] 38.7720μs 12.4275μs 80.4670 KOps/s 79.8618 KOps/s $\color{#35bf28}+0.76\%$
test_values[generalized_advantage_estimate-True-True] 13.5208ms 11.9399ms 83.7531 Ops/s 81.9777 Ops/s $\color{#35bf28}+2.17\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.4356ms 28.1776ms 35.4892 Ops/s 35.8225 Ops/s $\color{#d91a1a}-0.93\%$
test_values[td0_return_estimate-False-False] 0.2526ms 0.1753ms 5.7030 KOps/s 4.9347 KOps/s $\textbf{\color{#35bf28}+15.57\%}$
test_values[td1_return_estimate-False-False] 25.7305ms 25.5343ms 39.1630 Ops/s 38.1806 Ops/s $\color{#35bf28}+2.57\%$
test_values[vec_td1_return_estimate-False-False] 35.7142ms 28.5110ms 35.0742 Ops/s 36.0069 Ops/s $\color{#d91a1a}-2.59\%$
test_values[td_lambda_return_estimate-True-False] 39.1642ms 36.2910ms 27.5550 Ops/s 27.8315 Ops/s $\color{#d91a1a}-0.99\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.6916ms 28.3745ms 35.2429 Ops/s 35.8669 Ops/s $\color{#d91a1a}-1.74\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.3070ms 8.0505ms 124.2165 Ops/s 124.7449 Ops/s $\color{#d91a1a}-0.42\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 10.4527ms 1.9039ms 525.2459 Ops/s 514.3880 Ops/s $\color{#35bf28}+2.11\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 8.5864ms 0.4355ms 2.2961 KOps/s 2.2824 KOps/s $\color{#35bf28}+0.60\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 44.5412ms 38.9709ms 25.6602 Ops/s 26.3659 Ops/s $\color{#d91a1a}-2.68\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7033ms 2.6184ms 381.9161 Ops/s 373.0137 Ops/s $\color{#35bf28}+2.39\%$
test_dqn_speed 81.0224ms 7.8781ms 126.9337 Ops/s 130.2791 Ops/s $\color{#d91a1a}-2.57\%$
test_ddpg_speed 20.9431ms 14.2058ms 70.3939 Ops/s 68.0715 Ops/s $\color{#35bf28}+3.41\%$
test_sac_speed 35.2603ms 28.4098ms 35.1991 Ops/s 34.0287 Ops/s $\color{#35bf28}+3.44\%$
test_redq_speed 44.8724ms 43.5553ms 22.9593 Ops/s 21.6802 Ops/s $\textbf{\color{#35bf28}+5.90\%}$
test_redq_deprec_speed 30.3452ms 24.5758ms 40.6904 Ops/s 37.3516 Ops/s $\textbf{\color{#35bf28}+8.94\%}$
test_td3_speed 27.7564ms 19.4593ms 51.3894 Ops/s 48.7213 Ops/s $\textbf{\color{#35bf28}+5.48\%}$
test_cql_speed 85.8049ms 85.0550ms 11.7571 Ops/s 11.1778 Ops/s $\textbf{\color{#35bf28}+5.18\%}$
test_a2c_speed 35.1805ms 26.7413ms 37.3954 Ops/s 36.3331 Ops/s $\color{#35bf28}+2.92\%$
test_ppo_speed 27.4781ms 26.5275ms 37.6967 Ops/s 36.9407 Ops/s $\color{#35bf28}+2.05\%$
test_reinforce_speed 26.9412ms 25.5126ms 39.1964 Ops/s 38.1668 Ops/s $\color{#35bf28}+2.70\%$
test_iql_speed 70.0060ms 61.4839ms 16.2644 Ops/s 15.6646 Ops/s $\color{#35bf28}+3.83\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 1.7161ms 1.3643ms 732.9606 Ops/s 729.5899 Ops/s $\color{#35bf28}+0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 8.8412ms 0.5164ms 1.9365 KOps/s 1.8913 KOps/s $\color{#35bf28}+2.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.8101ms 0.4883ms 2.0481 KOps/s 2.0060 KOps/s $\color{#35bf28}+2.10\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 1.7200ms 1.3207ms 757.1506 Ops/s 661.7810 Ops/s $\textbf{\color{#35bf28}+14.41\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 8.8508ms 0.5122ms 1.9524 KOps/s 1.6536 KOps/s $\textbf{\color{#35bf28}+18.07\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9199ms 0.4780ms 2.0921 KOps/s 2.0215 KOps/s $\color{#35bf28}+3.49\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.2672ms 1.5312ms 653.0686 Ops/s 659.5890 Ops/s $\color{#d91a1a}-0.99\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 9.0005ms 0.6468ms 1.5460 KOps/s 1.5209 KOps/s $\color{#35bf28}+1.65\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.8179ms 0.6166ms 1.6217 KOps/s 1.5849 KOps/s $\color{#35bf28}+2.32\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 1.6812ms 1.3528ms 739.1888 Ops/s 739.8083 Ops/s $\color{#d91a1a}-0.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6554ms 0.5107ms 1.9581 KOps/s 1.8779 KOps/s $\color{#35bf28}+4.27\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 8.7187ms 0.4948ms 2.0210 KOps/s 2.0226 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.0470ms 1.3265ms 753.8686 Ops/s 749.8746 Ops/s $\color{#35bf28}+0.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6478ms 0.5062ms 1.9755 KOps/s 1.9041 KOps/s $\color{#35bf28}+3.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.8046ms 0.4914ms 2.0351 KOps/s 2.0494 KOps/s $\color{#d91a1a}-0.69\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.2583ms 1.5164ms 659.4507 Ops/s 655.5301 Ops/s $\color{#35bf28}+0.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1334ms 0.6466ms 1.5467 KOps/s 1.5030 KOps/s $\color{#35bf28}+2.91\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 9.5330ms 0.6281ms 1.5921 KOps/s 1.6005 KOps/s $\color{#d91a1a}-0.53\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1131s 12.1337ms 82.4150 Ops/s 83.1560 Ops/s $\color{#d91a1a}-0.89\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.2846ms 13.5657ms 73.7153 Ops/s 73.4637 Ops/s $\color{#35bf28}+0.34\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.5074ms 3.2410ms 308.5475 Ops/s 307.4878 Ops/s $\color{#35bf28}+0.34\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1103s 10.3403ms 96.7091 Ops/s 100.5721 Ops/s $\color{#d91a1a}-3.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.9898ms 13.5285ms 73.9181 Ops/s 73.0716 Ops/s $\color{#35bf28}+1.16\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.8767ms 3.3078ms 302.3184 Ops/s 308.7835 Ops/s $\color{#d91a1a}-2.09\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.9994ms 12.0427ms 83.0378 Ops/s 84.4621 Ops/s $\color{#d91a1a}-1.69\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.8598ms 13.7546ms 72.7029 Ops/s 72.3464 Ops/s $\color{#35bf28}+0.49\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.9636ms 3.4335ms 291.2470 Ops/s 288.6241 Ops/s $\color{#35bf28}+0.91\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1153s 0.1142s 8.7554 Ops/s 8.6688 Ops/s $\color{#35bf28}+1.00\%$
test_sync 0.1813s 0.1037s 9.6415 Ops/s 9.5301 Ops/s $\color{#35bf28}+1.17\%$
test_async 0.1808s 91.3582ms 10.9459 Ops/s 10.9830 Ops/s $\color{#d91a1a}-0.34\%$
test_single_pixels 0.1406s 0.1398s 7.1519 Ops/s 7.1033 Ops/s $\color{#35bf28}+0.68\%$
test_sync_pixels 78.5172ms 77.3075ms 12.9354 Ops/s 12.9930 Ops/s $\color{#d91a1a}-0.44\%$
test_async_pixels 0.1434s 72.0473ms 13.8798 Ops/s 13.8215 Ops/s $\color{#35bf28}+0.42\%$
test_simple 0.9210s 0.8423s 1.1872 Ops/s 1.2190 Ops/s $\color{#d91a1a}-2.61\%$
test_transformed 1.0768s 1.0748s 0.9304 Ops/s 0.9426 Ops/s $\color{#d91a1a}-1.29\%$
test_serial 2.3889s 2.3065s 0.4336 Ops/s 0.4276 Ops/s $\color{#35bf28}+1.39\%$
test_parallel 2.1935s 1.9006s 0.5261 Ops/s 0.5462 Ops/s $\color{#d91a1a}-3.67\%$
test_step_mdp_speed[True-True-True-True-True] 0.1651ms 33.2303μs 30.0930 KOps/s 31.6110 KOps/s $\color{#d91a1a}-4.80\%$
test_step_mdp_speed[True-True-True-True-False] 43.9700μs 19.9341μs 50.1652 KOps/s 52.3588 KOps/s $\color{#d91a1a}-4.19\%$
test_step_mdp_speed[True-True-True-False-True] 43.3900μs 18.8390μs 53.0815 KOps/s 55.6373 KOps/s $\color{#d91a1a}-4.59\%$
test_step_mdp_speed[True-True-True-False-False] 40.2310μs 11.2795μs 88.6565 KOps/s 92.3192 KOps/s $\color{#d91a1a}-3.97\%$
test_step_mdp_speed[True-True-False-True-True] 58.2700μs 34.9688μs 28.5969 KOps/s 29.5825 KOps/s $\color{#d91a1a}-3.33\%$
test_step_mdp_speed[True-True-False-True-False] 52.2410μs 21.7180μs 46.0448 KOps/s 47.9992 KOps/s $\color{#d91a1a}-4.07\%$
test_step_mdp_speed[True-True-False-False-True] 62.2110μs 20.7537μs 48.1842 KOps/s 50.4096 KOps/s $\color{#d91a1a}-4.41\%$
test_step_mdp_speed[True-True-False-False-False] 39.7210μs 13.1167μs 76.2389 KOps/s 78.8953 KOps/s $\color{#d91a1a}-3.37\%$
test_step_mdp_speed[True-False-True-True-True] 59.0700μs 36.8829μs 27.1128 KOps/s 28.0913 KOps/s $\color{#d91a1a}-3.48\%$
test_step_mdp_speed[True-False-True-True-False] 83.4710μs 23.7506μs 42.1042 KOps/s 43.8913 KOps/s $\color{#d91a1a}-4.07\%$
test_step_mdp_speed[True-False-True-False-True] 0.1039ms 20.7534μs 48.1849 KOps/s 49.8517 KOps/s $\color{#d91a1a}-3.34\%$
test_step_mdp_speed[True-False-True-False-False] 40.9700μs 13.1477μs 76.0587 KOps/s 79.0337 KOps/s $\color{#d91a1a}-3.76\%$
test_step_mdp_speed[True-False-False-True-True] 62.5010μs 38.4907μs 25.9803 KOps/s 26.7748 KOps/s $\color{#d91a1a}-2.97\%$
test_step_mdp_speed[True-False-False-True-False] 0.1748ms 25.4383μs 39.3108 KOps/s 40.7333 KOps/s $\color{#d91a1a}-3.49\%$
test_step_mdp_speed[True-False-False-False-True] 59.8910μs 22.1043μs 45.2401 KOps/s 46.4066 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[True-False-False-False-False] 32.8210μs 14.8718μs 67.2413 KOps/s 69.3822 KOps/s $\color{#d91a1a}-3.09\%$
test_step_mdp_speed[False-True-True-True-True] 0.1377ms 36.5589μs 27.3531 KOps/s 28.2974 KOps/s $\color{#d91a1a}-3.34\%$
test_step_mdp_speed[False-True-True-True-False] 43.4600μs 23.5915μs 42.3882 KOps/s 44.2304 KOps/s $\color{#d91a1a}-4.16\%$
test_step_mdp_speed[False-True-True-False-True] 56.1410μs 24.4252μs 40.9412 KOps/s 42.4513 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[False-True-True-False-False] 59.0300μs 14.9607μs 66.8416 KOps/s 69.3080 KOps/s $\color{#d91a1a}-3.56\%$
test_step_mdp_speed[False-True-False-True-True] 65.4900μs 38.4657μs 25.9972 KOps/s 27.0244 KOps/s $\color{#d91a1a}-3.80\%$
test_step_mdp_speed[False-True-False-True-False] 99.4510μs 25.5874μs 39.0818 KOps/s 40.5487 KOps/s $\color{#d91a1a}-3.62\%$
test_step_mdp_speed[False-True-False-False-True] 59.7600μs 26.2768μs 38.0564 KOps/s 39.2378 KOps/s $\color{#d91a1a}-3.01\%$
test_step_mdp_speed[False-True-False-False-False] 36.9200μs 16.6635μs 60.0113 KOps/s 60.8140 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-True-True-True] 71.4710μs 40.3505μs 24.7828 KOps/s 25.6108 KOps/s $\color{#d91a1a}-3.23\%$
test_step_mdp_speed[False-False-True-True-False] 50.1400μs 27.4425μs 36.4399 KOps/s 37.3806 KOps/s $\color{#d91a1a}-2.52\%$
test_step_mdp_speed[False-False-True-False-True] 55.1410μs 26.2212μs 38.1370 KOps/s 38.5699 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[False-False-True-False-False] 0.1011ms 16.7634μs 59.6539 KOps/s 60.9494 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[False-False-False-True-True] 67.1510μs 41.9199μs 23.8550 KOps/s 24.5234 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[False-False-False-True-False] 66.5110μs 29.2125μs 34.2319 KOps/s 35.1909 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[False-False-False-False-True] 58.6400μs 27.6782μs 36.1296 KOps/s 36.9543 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[False-False-False-False-False] 38.0400μs 18.5029μs 54.0456 KOps/s 55.4017 KOps/s $\color{#d91a1a}-2.45\%$
test_values[generalized_advantage_estimate-True-True] 25.1026ms 24.3806ms 41.0162 Ops/s 40.5718 Ops/s $\color{#35bf28}+1.10\%$
test_values[vec_generalized_advantage_estimate-True-True] 94.3941ms 3.4494ms 289.9042 Ops/s 304.3299 Ops/s $\color{#d91a1a}-4.74\%$
test_values[td0_return_estimate-False-False] 93.4010μs 61.8136μs 16.1777 KOps/s 16.8302 KOps/s $\color{#d91a1a}-3.88\%$
test_values[td1_return_estimate-False-False] 54.2710ms 52.7868ms 18.9441 Ops/s 18.7326 Ops/s $\color{#35bf28}+1.13\%$
test_values[vec_td1_return_estimate-False-False] 2.0679ms 1.7577ms 568.9298 Ops/s 555.8564 Ops/s $\color{#35bf28}+2.35\%$
test_values[td_lambda_return_estimate-True-False] 86.2678ms 84.8766ms 11.7818 Ops/s 11.3984 Ops/s $\color{#35bf28}+3.36\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0339ms 1.7690ms 565.3026 Ops/s 570.4731 Ops/s $\color{#d91a1a}-0.91\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.9059ms 23.2473ms 43.0157 Ops/s 41.8946 Ops/s $\color{#35bf28}+2.68\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9674ms 0.6925ms 1.4440 KOps/s 1.4498 KOps/s $\color{#d91a1a}-0.40\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6961ms 0.6549ms 1.5270 KOps/s 1.5401 KOps/s $\color{#d91a1a}-0.86\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5462ms 1.4566ms 686.5078 Ops/s 680.2787 Ops/s $\color{#35bf28}+0.92\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9660ms 0.6678ms 1.4975 KOps/s 1.4972 KOps/s $\color{#35bf28}+0.02\%$
test_dqn_speed 7.6169ms 7.2669ms 137.6094 Ops/s 138.3799 Ops/s $\color{#d91a1a}-0.56\%$
test_ddpg_speed 0.1438s 16.0856ms 62.1674 Ops/s 70.4211 Ops/s $\textbf{\color{#d91a1a}-11.72\%}$
test_sac_speed 29.5784ms 28.6401ms 34.9161 Ops/s 34.7645 Ops/s $\color{#35bf28}+0.44\%$
test_redq_speed 49.2080ms 47.6744ms 20.9756 Ops/s 20.9434 Ops/s $\color{#35bf28}+0.15\%$
test_redq_deprec_speed 25.1301ms 24.1897ms 41.3399 Ops/s 41.1766 Ops/s $\color{#35bf28}+0.40\%$
test_td3_speed 30.8717ms 19.6329ms 50.9349 Ops/s 50.7358 Ops/s $\color{#35bf28}+0.39\%$
test_cql_speed 84.8720ms 83.4332ms 11.9856 Ops/s 11.8709 Ops/s $\color{#35bf28}+0.97\%$
test_a2c_speed 27.9319ms 26.4813ms 37.7624 Ops/s 37.4320 Ops/s $\color{#35bf28}+0.88\%$
test_ppo_speed 27.5705ms 26.4941ms 37.7443 Ops/s 37.1514 Ops/s $\color{#35bf28}+1.60\%$
test_reinforce_speed 27.1290ms 25.7174ms 38.8842 Ops/s 38.5809 Ops/s $\color{#35bf28}+0.79\%$
test_iql_speed 59.4298ms 57.7769ms 17.3080 Ops/s 17.1062 Ops/s $\color{#35bf28}+1.18\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6139ms 1.8370ms 544.3633 Ops/s 542.5884 Ops/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0006ms 0.8465ms 1.1813 KOps/s 1.1822 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9586ms 0.8226ms 1.2156 KOps/s 1.2169 KOps/s $\color{#d91a1a}-0.11\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6535ms 1.8311ms 546.1212 Ops/s 548.5028 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0032ms 0.8342ms 1.1987 KOps/s 1.2007 KOps/s $\color{#d91a1a}-0.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9820ms 0.8113ms 1.2326 KOps/s 1.2328 KOps/s $\color{#d91a1a}-0.01\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 0.1378s 2.3855ms 419.1978 Ops/s 481.7356 Ops/s $\textbf{\color{#d91a1a}-12.98\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1165ms 0.9652ms 1.0361 KOps/s 1.0406 KOps/s $\color{#d91a1a}-0.43\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0876ms 0.9422ms 1.0613 KOps/s 1.0635 KOps/s $\color{#d91a1a}-0.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.1387s 2.1531ms 464.4438 Ops/s 539.9398 Ops/s $\textbf{\color{#d91a1a}-13.98\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0112ms 0.8461ms 1.1818 KOps/s 1.1820 KOps/s $\color{#d91a1a}-0.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9867ms 0.8239ms 1.2137 KOps/s 1.2148 KOps/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4831ms 1.8258ms 547.7120 Ops/s 472.1552 Ops/s $\textbf{\color{#35bf28}+16.00\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9859ms 0.8345ms 1.1983 KOps/s 1.1986 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9564ms 0.8121ms 1.2314 KOps/s 1.2318 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8358ms 2.0923ms 477.9513 Ops/s 474.6918 Ops/s $\color{#35bf28}+0.69\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1096ms 0.9662ms 1.0350 KOps/s 1.0374 KOps/s $\color{#d91a1a}-0.24\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0848ms 0.9424ms 1.0612 KOps/s 1.0601 KOps/s $\color{#35bf28}+0.10\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1277s 10.5101ms 95.1470 Ops/s 94.0588 Ops/s $\color{#35bf28}+1.16\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.7549ms 14.2123ms 70.3615 Ops/s 72.1720 Ops/s $\color{#d91a1a}-2.51\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.2391ms 3.4080ms 293.4303 Ops/s 286.6850 Ops/s $\color{#35bf28}+2.35\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1348s 10.6511ms 93.8873 Ops/s 95.3269 Ops/s $\color{#d91a1a}-1.51\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.5974ms 14.1954ms 70.4454 Ops/s 60.9350 Ops/s $\textbf{\color{#35bf28}+15.61\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.6912ms 3.4202ms 292.3832 Ops/s 292.8344 Ops/s $\color{#d91a1a}-0.15\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1315s 13.3324ms 75.0051 Ops/s 92.0391 Ops/s $\textbf{\color{#d91a1a}-18.51\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.8507ms 14.4228ms 69.3349 Ops/s 70.6194 Ops/s $\color{#d91a1a}-1.82\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.1756ms 3.6249ms 275.8734 Ops/s 276.4668 Ops/s $\color{#d91a1a}-0.21\%$

@vmoens vmoens merged commit 24d14ad into main Jan 23, 2024
63 of 65 checks passed
@vmoens vmoens deleted the doc-fixes branch January 23, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Video recording for the PPO example
2 participants
@vmoens @facebook-github-bot