-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor multi-env / multiprocessing seeding logic to make it uncorrelated across runs #182
Refactor multi-env / multiprocessing seeding logic to make it uncorrelated across runs #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments but looks like we're on the right track!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry meant to ask for changes :)
I made some logic change and most of unit tests pass.
I think it fails because of this line in mock class. Thank you, |
2dc4537
to
5a8241e
Compare
…essing_seeding_logic
…ng_logic' into 129_enhance_multiprocessing_seeding_logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to understand better what's going on :)
eb014f6
to
64593a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Let's fix the 2 things I pointed and we're good to go!!
64593a3
to
ab3622a
Compare
ab3622a
to
78e41e4
Compare
Resolves issue #129