Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix windows CI #1746

Merged
merged 29 commits into from
Dec 20, 2023
Merged

[CI] Fix windows CI #1746

merged 29 commits into from
Dec 20, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 14, 2023 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 14, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1746

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (27 Unrelated Failures)

As of commit 3b0f48e with merge base 4d3a0c6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}10$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 71.5094ms 65.5928ms 15.2456 Ops/s 15.0115 Ops/s $\color{#35bf28}+1.56\%$
test_sync 41.7855ms 35.6650ms 28.0387 Ops/s 27.1273 Ops/s $\color{#35bf28}+3.36\%$
test_async 66.1414ms 33.7806ms 29.6028 Ops/s 30.0148 Ops/s $\color{#d91a1a}-1.37\%$
test_simple 0.4918s 0.4447s 2.2488 Ops/s 2.2560 Ops/s $\color{#d91a1a}-0.32\%$
test_transformed 0.6587s 0.6124s 1.6329 Ops/s 1.6444 Ops/s $\color{#d91a1a}-0.70\%$
test_serial 1.4300s 1.3849s 0.7221 Ops/s 0.7258 Ops/s $\color{#d91a1a}-0.52\%$
test_parallel 1.3921s 1.3290s 0.7524 Ops/s 0.7550 Ops/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[True-True-True-True-True] 0.1430ms 21.8320μs 45.8044 KOps/s 45.6711 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-True-True-True-False] 35.7370μs 13.3167μs 75.0934 KOps/s 75.9124 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-True-True-False-True] 47.7800μs 12.9578μs 77.1737 KOps/s 78.4781 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-True-True-False-False] 36.7090μs 7.9103μs 126.4167 KOps/s 127.6239 KOps/s $\color{#d91a1a}-0.95\%$
test_step_mdp_speed[True-True-False-True-True] 62.6470μs 23.2495μs 43.0116 KOps/s 43.2771 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[True-True-False-True-False] 33.8030μs 14.5763μs 68.6047 KOps/s 67.4459 KOps/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[True-True-False-False-True] 47.5090μs 13.9024μs 71.9298 KOps/s 71.4804 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[True-True-False-False-False] 53.9600μs 9.1481μs 109.3122 KOps/s 111.7847 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[True-False-True-True-True] 63.4790μs 24.2466μs 41.2428 KOps/s 40.9362 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[True-False-True-True-False] 49.2830μs 15.9443μs 62.7184 KOps/s 63.2631 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-False-True-False-True] 57.5590μs 13.9032μs 71.9259 KOps/s 71.7208 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-False-True-False-False] 34.1930μs 9.0900μs 110.0104 KOps/s 109.2044 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[True-False-False-True-True] 59.2110μs 25.5758μs 39.0995 KOps/s 38.0804 KOps/s $\color{#35bf28}+2.68\%$
test_step_mdp_speed[True-False-False-True-False] 51.5940μs 17.2756μs 57.8852 KOps/s 58.7367 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[True-False-False-False-True] 39.3830μs 15.3000μs 65.3596 KOps/s 64.5667 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-False-False-False-False] 43.7220μs 10.2566μs 97.4987 KOps/s 99.5714 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[False-True-True-True-True] 68.2190μs 24.3890μs 41.0021 KOps/s 40.6758 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-True-True-False] 37.2500μs 16.1800μs 61.8047 KOps/s 63.9053 KOps/s $\color{#d91a1a}-3.29\%$
test_step_mdp_speed[False-True-True-False-True] 57.3580μs 16.4059μs 60.9538 KOps/s 62.4181 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-True-False-False] 34.9750μs 10.3789μs 96.3497 KOps/s 97.0194 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-True-False-True-True] 65.4920μs 25.9520μs 38.5327 KOps/s 39.2927 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[False-True-False-True-False] 39.6040μs 17.3443μs 57.6559 KOps/s 58.7540 KOps/s $\color{#d91a1a}-1.87\%$
test_step_mdp_speed[False-True-False-False-True] 52.0680μs 17.4712μs 57.2370 KOps/s 57.9064 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-True-False-False-False] 34.4740μs 11.5597μs 86.5078 KOps/s 88.1202 KOps/s $\color{#d91a1a}-1.83\%$
test_step_mdp_speed[False-False-True-True-True] 57.0770μs 27.1447μs 36.8396 KOps/s 37.3445 KOps/s $\color{#d91a1a}-1.35\%$
test_step_mdp_speed[False-False-True-True-False] 74.1290μs 18.5277μs 53.9732 KOps/s 54.3623 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-False-True-False-True] 50.7140μs 17.7840μs 56.2304 KOps/s 56.7302 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[False-False-True-False-False] 46.0460μs 11.5672μs 86.4514 KOps/s 86.2460 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[False-False-False-True-True] 69.3990μs 28.0208μs 35.6878 KOps/s 35.6315 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[False-False-False-True-False] 68.5080μs 19.6631μs 50.8568 KOps/s 51.3264 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-False-False-False-True] 0.2921ms 19.7260μs 50.6945 KOps/s 54.5996 KOps/s $\textbf{\color{#d91a1a}-7.15\%}$
test_step_mdp_speed[False-False-False-False-False] 0.2174ms 13.2454μs 75.4982 KOps/s 80.3934 KOps/s $\textbf{\color{#d91a1a}-6.09\%}$
test_values[generalized_advantage_estimate-True-True] 12.2498ms 11.9441ms 83.7235 Ops/s 83.3694 Ops/s $\color{#35bf28}+0.42\%$
test_values[vec_generalized_advantage_estimate-True-True] 35.6270ms 27.8862ms 35.8600 Ops/s 35.7939 Ops/s $\color{#35bf28}+0.18\%$
test_values[td0_return_estimate-False-False] 0.2496ms 0.1748ms 5.7215 KOps/s 5.6775 KOps/s $\color{#35bf28}+0.77\%$
test_values[td1_return_estimate-False-False] 26.2736ms 25.1795ms 39.7149 Ops/s 40.0829 Ops/s $\color{#d91a1a}-0.92\%$
test_values[vec_td1_return_estimate-False-False] 36.2734ms 28.0793ms 35.6134 Ops/s 35.9372 Ops/s $\color{#d91a1a}-0.90\%$
test_values[td_lambda_return_estimate-True-False] 36.8781ms 35.6737ms 28.0319 Ops/s 28.8171 Ops/s $\color{#d91a1a}-2.72\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.5009ms 27.7843ms 35.9915 Ops/s 35.8537 Ops/s $\color{#35bf28}+0.38\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.2390ms 8.1375ms 122.8872 Ops/s 124.8659 Ops/s $\color{#d91a1a}-1.58\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 9.9952ms 1.8853ms 530.4251 Ops/s 515.6391 Ops/s $\color{#35bf28}+2.87\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4952ms 0.4295ms 2.3281 KOps/s 2.3754 KOps/s $\color{#d91a1a}-1.99\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.3493ms 39.9148ms 25.0534 Ops/s 24.3499 Ops/s $\color{#35bf28}+2.89\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.7585ms 2.6352ms 379.4839 Ops/s 379.0810 Ops/s $\color{#35bf28}+0.11\%$
test_dqn_speed 9.7869ms 1.6403ms 609.6343 Ops/s 616.0975 Ops/s $\color{#d91a1a}-1.05\%$
test_ddpg_speed 12.2061ms 3.6779ms 271.8976 Ops/s 270.8317 Ops/s $\color{#35bf28}+0.39\%$
test_sac_speed 85.8047ms 11.4510ms 87.3284 Ops/s 96.6067 Ops/s $\textbf{\color{#d91a1a}-9.60\%}$
test_redq_speed 26.3713ms 19.7745ms 50.5702 Ops/s 53.2399 Ops/s $\textbf{\color{#d91a1a}-5.01\%}$
test_redq_deprec_speed 24.9507ms 15.6872ms 63.7462 Ops/s 66.4428 Ops/s $\color{#d91a1a}-4.06\%$
test_td3_speed 18.6086ms 10.6634ms 93.7787 Ops/s 94.0914 Ops/s $\color{#d91a1a}-0.33\%$
test_cql_speed 48.6733ms 40.8061ms 24.5061 Ops/s 24.3677 Ops/s $\color{#35bf28}+0.57\%$
test_a2c_speed 16.4040ms 8.1180ms 123.1825 Ops/s 117.0645 Ops/s $\textbf{\color{#35bf28}+5.23\%}$
test_ppo_speed 17.6336ms 8.4880ms 117.8127 Ops/s 113.3088 Ops/s $\color{#35bf28}+3.97\%$
test_reinforce_speed 15.5255ms 7.2034ms 138.8233 Ops/s 128.6964 Ops/s $\textbf{\color{#35bf28}+7.87\%}$
test_iql_speed 42.2337ms 34.3610ms 29.1027 Ops/s 26.6540 Ops/s $\textbf{\color{#35bf28}+9.19\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2558ms 1.8213ms 549.0574 Ops/s 508.2579 Ops/s $\textbf{\color{#35bf28}+8.03\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.6206ms 1.9082ms 524.0574 Ops/s 506.4172 Ops/s $\color{#35bf28}+3.48\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 2.9655ms 1.9506ms 512.6631 Ops/s 511.6319 Ops/s $\color{#35bf28}+0.20\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.3369ms 1.8679ms 535.3506 Ops/s 552.1788 Ops/s $\color{#d91a1a}-3.05\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.8929ms 1.9697ms 507.6830 Ops/s 468.6146 Ops/s $\textbf{\color{#35bf28}+8.34\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 2.8909ms 1.9835ms 504.1654 Ops/s 483.6141 Ops/s $\color{#35bf28}+4.25\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.3605ms 1.8679ms 535.3640 Ops/s 530.4195 Ops/s $\color{#35bf28}+0.93\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.9751ms 2.0659ms 484.0585 Ops/s 529.0554 Ops/s $\textbf{\color{#d91a1a}-8.51\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.5874ms 2.0876ms 479.0164 Ops/s 518.5405 Ops/s $\textbf{\color{#d91a1a}-7.62\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8070ms 1.9131ms 522.7236 Ops/s 544.7926 Ops/s $\color{#d91a1a}-4.05\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 97.9781ms 2.1138ms 473.0910 Ops/s 520.3994 Ops/s $\textbf{\color{#d91a1a}-9.09\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.0297ms 1.9352ms 516.7358 Ops/s 525.9922 Ops/s $\color{#d91a1a}-1.76\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9186ms 1.8608ms 537.4072 Ops/s 547.0232 Ops/s $\color{#d91a1a}-1.76\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 98.3494ms 2.1048ms 475.0973 Ops/s 524.2009 Ops/s $\textbf{\color{#d91a1a}-9.37\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.4324ms 1.9355ms 516.6493 Ops/s 514.7093 Ops/s $\color{#35bf28}+0.38\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9375ms 1.8663ms 535.8206 Ops/s 548.4371 Ops/s $\color{#d91a1a}-2.30\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 97.6088ms 2.1119ms 473.5035 Ops/s 525.8956 Ops/s $\textbf{\color{#d91a1a}-9.96\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 2.8767ms 1.9184ms 521.2601 Ops/s 522.9995 Ops/s $\color{#d91a1a}-0.33\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1354s 16.2328ms 61.6036 Ops/s 59.2396 Ops/s $\color{#35bf28}+3.99\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 94.9640ms 15.4835ms 64.5847 Ops/s 64.9323 Ops/s $\color{#d91a1a}-0.54\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 95.9018ms 15.3855ms 64.9961 Ops/s 66.3066 Ops/s $\color{#d91a1a}-1.98\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 96.5649ms 15.4129ms 64.8808 Ops/s 66.1239 Ops/s $\color{#d91a1a}-1.88\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 93.6900ms 15.2648ms 65.5102 Ops/s 65.5887 Ops/s $\color{#d91a1a}-0.12\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 95.3204ms 17.1364ms 58.3553 Ops/s 65.6552 Ops/s $\textbf{\color{#d91a1a}-11.12\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 95.7338ms 15.4942ms 64.5404 Ops/s 64.0557 Ops/s $\color{#35bf28}+0.76\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1068s 15.8610ms 63.0478 Ops/s 63.7668 Ops/s $\color{#d91a1a}-1.13\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1054s 14.2581ms 70.1357 Ops/s 63.7946 Ops/s $\textbf{\color{#35bf28}+9.94\%}$

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1226s 0.1223s 8.1783 Ops/s 7.9867 Ops/s $\color{#35bf28}+2.40\%$
test_sync 0.1026s 0.1023s 9.7747 Ops/s 9.7368 Ops/s $\color{#35bf28}+0.39\%$
test_async 0.2743s 0.1018s 9.8191 Ops/s 9.9258 Ops/s $\color{#d91a1a}-1.08\%$
test_single_pixels 0.1324s 0.1319s 7.5801 Ops/s 6.7388 Ops/s $\textbf{\color{#35bf28}+12.48\%}$
test_sync_pixels 96.7086ms 95.5147ms 10.4696 Ops/s 10.4577 Ops/s $\color{#35bf28}+0.11\%$
test_async_pixels 0.2467s 91.5399ms 10.9242 Ops/s 10.8320 Ops/s $\color{#35bf28}+0.85\%$
test_simple 0.9601s 0.8898s 1.1238 Ops/s 1.0877 Ops/s $\color{#35bf28}+3.32\%$
test_transformed 1.1965s 1.1341s 0.8818 Ops/s 0.8594 Ops/s $\color{#35bf28}+2.60\%$
test_serial 2.4710s 2.4670s 0.4054 Ops/s 0.3897 Ops/s $\color{#35bf28}+4.01\%$
test_parallel 2.6055s 2.5124s 0.3980 Ops/s 0.3940 Ops/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[True-True-True-True-True] 99.6210μs 33.1937μs 30.1262 KOps/s 29.9318 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-True-True-True-False] 50.1510μs 20.2355μs 49.4181 KOps/s 50.2283 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[True-True-True-False-True] 43.4400μs 18.9343μs 52.8141 KOps/s 52.6087 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[True-True-True-False-False] 31.1000μs 11.5911μs 86.2731 KOps/s 86.4047 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-True-False-True-True] 68.2410μs 35.2034μs 28.4063 KOps/s 28.2753 KOps/s $\color{#35bf28}+0.46\%$
test_step_mdp_speed[True-True-False-True-False] 46.0700μs 21.9248μs 45.6104 KOps/s 45.5369 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-False-False-True] 45.0510μs 21.0670μs 47.4676 KOps/s 47.6830 KOps/s $\color{#d91a1a}-0.45\%$
test_step_mdp_speed[True-True-False-False-False] 51.7500μs 13.7310μs 72.8280 KOps/s 74.0143 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[True-False-True-True-True] 67.4600μs 37.3349μs 26.7846 KOps/s 26.4653 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[True-False-True-True-False] 47.1810μs 23.9774μs 41.7059 KOps/s 41.8133 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-False-True-False-True] 45.6810μs 21.0388μs 47.5312 KOps/s 47.3870 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-False-True-False-False] 29.4100μs 13.6576μs 73.2194 KOps/s 74.1122 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[True-False-False-True-True] 62.8500μs 38.3618μs 26.0676 KOps/s 25.3112 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[True-False-False-True-False] 64.9600μs 25.8192μs 38.7309 KOps/s 38.5435 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-False-False-False-True] 59.1810μs 23.0361μs 43.4101 KOps/s 43.8643 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-False-False-False] 36.0700μs 15.4697μs 64.6424 KOps/s 65.3490 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-True-True-True] 60.8410μs 36.5046μs 27.3938 KOps/s 26.3086 KOps/s $\color{#35bf28}+4.12\%$
test_step_mdp_speed[False-True-True-True-False] 46.2810μs 23.8175μs 41.9859 KOps/s 41.5407 KOps/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[False-True-True-False-True] 51.5000μs 24.4653μs 40.8742 KOps/s 39.9613 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[False-True-True-False-False] 34.8700μs 15.3661μs 65.0782 KOps/s 65.3534 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-False-True-True] 77.2810μs 38.7355μs 25.8161 KOps/s 25.4621 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-True-False-True-False] 48.0900μs 25.9244μs 38.5737 KOps/s 38.8516 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[False-True-False-False-True] 50.6200μs 26.6337μs 37.5464 KOps/s 37.6521 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-True-False-False-False] 36.1100μs 17.0368μs 58.6964 KOps/s 57.6708 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[False-False-True-True-True] 67.1400μs 40.1877μs 24.8832 KOps/s 24.2980 KOps/s $\color{#35bf28}+2.41\%$
test_step_mdp_speed[False-False-True-True-False] 51.6700μs 28.0383μs 35.6655 KOps/s 35.9099 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-False-True-False-True] 47.4200μs 26.5751μs 37.6293 KOps/s 37.3154 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[False-False-True-False-False] 38.5810μs 17.0648μs 58.6001 KOps/s 58.1978 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-False-False-True-True] 85.4810μs 42.1709μs 23.7130 KOps/s 22.9659 KOps/s $\color{#35bf28}+3.25\%$
test_step_mdp_speed[False-False-False-True-False] 56.8900μs 29.6211μs 33.7598 KOps/s 33.5817 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[False-False-False-False-True] 50.9610μs 28.0712μs 35.6237 KOps/s 35.2977 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-False-False-False-False] 34.9100μs 19.0862μs 52.3939 KOps/s 52.1704 KOps/s $\color{#35bf28}+0.43\%$
test_values[generalized_advantage_estimate-True-True] 26.3054ms 25.8066ms 38.7497 Ops/s 37.6473 Ops/s $\color{#35bf28}+2.93\%$
test_values[vec_generalized_advantage_estimate-True-True] 85.7733ms 3.3036ms 302.6977 Ops/s 292.4617 Ops/s $\color{#35bf28}+3.50\%$
test_values[td0_return_estimate-False-False] 0.1035ms 66.7790μs 14.9748 KOps/s 14.3107 KOps/s $\color{#35bf28}+4.64\%$
test_values[td1_return_estimate-False-False] 57.2273ms 56.6015ms 17.6674 Ops/s 17.3257 Ops/s $\color{#35bf28}+1.97\%$
test_values[vec_td1_return_estimate-False-False] 2.1179ms 1.7920ms 558.0214 Ops/s 554.3630 Ops/s $\color{#35bf28}+0.66\%$
test_values[td_lambda_return_estimate-True-False] 93.7374ms 90.9055ms 11.0004 Ops/s 10.8648 Ops/s $\color{#35bf28}+1.25\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1418ms 1.7876ms 559.4182 Ops/s 554.0474 Ops/s $\color{#35bf28}+0.97\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.7452ms 24.9591ms 40.0655 Ops/s 39.3541 Ops/s $\color{#35bf28}+1.81\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9075ms 0.7306ms 1.3688 KOps/s 1.3489 KOps/s $\color{#35bf28}+1.47\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8341ms 0.6893ms 1.4508 KOps/s 1.4462 KOps/s $\color{#35bf28}+0.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5387ms 1.4804ms 675.5040 Ops/s 669.9689 Ops/s $\color{#35bf28}+0.83\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9705ms 0.7050ms 1.4184 KOps/s 1.4038 KOps/s $\color{#35bf28}+1.04\%$
test_dqn_speed 1.9404ms 1.4727ms 679.0059 Ops/s 623.0219 Ops/s $\textbf{\color{#35bf28}+8.99\%}$
test_ddpg_speed 4.3541ms 3.3712ms 296.6273 Ops/s 299.8954 Ops/s $\color{#d91a1a}-1.09\%$
test_sac_speed 9.7978ms 9.3303ms 107.1782 Ops/s 106.9451 Ops/s $\color{#35bf28}+0.22\%$
test_redq_speed 19.0378ms 16.6855ms 59.9322 Ops/s 60.0234 Ops/s $\color{#d91a1a}-0.15\%$
test_redq_deprec_speed 14.0318ms 13.0886ms 76.4024 Ops/s 76.7343 Ops/s $\color{#d91a1a}-0.43\%$
test_td3_speed 19.1680ms 9.5333ms 104.8955 Ops/s 104.1160 Ops/s $\color{#35bf28}+0.75\%$
test_cql_speed 35.3514ms 34.1540ms 29.2791 Ops/s 29.6996 Ops/s $\color{#d91a1a}-1.42\%$
test_a2c_speed 8.1773ms 7.2260ms 138.3892 Ops/s 139.4906 Ops/s $\color{#d91a1a}-0.79\%$
test_ppo_speed 8.5617ms 7.4903ms 133.5052 Ops/s 132.1034 Ops/s $\color{#35bf28}+1.06\%$
test_reinforce_speed 7.4340ms 6.2655ms 159.6032 Ops/s 161.0059 Ops/s $\color{#d91a1a}-0.87\%$
test_iql_speed 28.3885ms 27.1750ms 36.7985 Ops/s 36.6564 Ops/s $\color{#35bf28}+0.39\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1323ms 2.4955ms 400.7138 Ops/s 400.3769 Ops/s $\color{#35bf28}+0.08\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 3.8034ms 2.6780ms 373.4136 Ops/s 331.5164 Ops/s $\textbf{\color{#35bf28}+12.64\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.7002ms 2.6902ms 371.7156 Ops/s 370.4469 Ops/s $\color{#35bf28}+0.34\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1984ms 2.4775ms 403.6259 Ops/s 396.9614 Ops/s $\color{#35bf28}+1.68\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.9898ms 2.6927ms 371.3683 Ops/s 331.9346 Ops/s $\textbf{\color{#35bf28}+11.88\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6918ms 2.6775ms 373.4843 Ops/s 370.5524 Ops/s $\color{#35bf28}+0.79\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.7260ms 2.4972ms 400.4499 Ops/s 398.0127 Ops/s $\color{#35bf28}+0.61\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.8178ms 2.6752ms 373.7982 Ops/s 332.2185 Ops/s $\textbf{\color{#35bf28}+12.52\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.7451ms 2.6801ms 373.1194 Ops/s 371.0881 Ops/s $\color{#35bf28}+0.55\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9244ms 2.5076ms 398.7860 Ops/s 397.0661 Ops/s $\color{#35bf28}+0.43\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.0791ms 2.6905ms 371.6765 Ops/s 329.6722 Ops/s $\textbf{\color{#35bf28}+12.74\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.7648ms 2.6811ms 372.9872 Ops/s 368.1571 Ops/s $\color{#35bf28}+1.31\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0990ms 2.5054ms 399.1391 Ops/s 398.2487 Ops/s $\color{#35bf28}+0.22\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.4052ms 2.6880ms 372.0280 Ops/s 331.9936 Ops/s $\textbf{\color{#35bf28}+12.06\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6490ms 2.6787ms 373.3142 Ops/s 370.2967 Ops/s $\color{#35bf28}+0.81\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1228ms 2.5085ms 398.6463 Ops/s 395.6866 Ops/s $\color{#35bf28}+0.75\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.7419ms 2.6909ms 371.6223 Ops/s 371.2396 Ops/s $\color{#35bf28}+0.10\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.9347ms 2.6888ms 371.9087 Ops/s 371.3703 Ops/s $\color{#35bf28}+0.14\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1829s 18.5260ms 53.9783 Ops/s 53.5232 Ops/s $\color{#35bf28}+0.85\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1210s 17.0818ms 58.5420 Ops/s 57.7764 Ops/s $\color{#35bf28}+1.33\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1221s 17.0833ms 58.5367 Ops/s 57.8655 Ops/s $\color{#35bf28}+1.16\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1209s 17.1421ms 58.3358 Ops/s 57.3731 Ops/s $\color{#35bf28}+1.68\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1199s 14.9334ms 66.9641 Ops/s 57.4332 Ops/s $\textbf{\color{#35bf28}+16.59\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1215s 17.1434ms 58.3315 Ops/s 65.8195 Ops/s $\textbf{\color{#d91a1a}-11.38\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1202s 17.0230ms 58.7439 Ops/s 57.8743 Ops/s $\color{#35bf28}+1.50\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1219s 17.0635ms 58.6048 Ops/s 57.6587 Ops/s $\color{#35bf28}+1.64\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1205s 17.1342ms 58.3627 Ops/s 57.4273 Ops/s $\color{#35bf28}+1.63\%$

@atalman
Copy link

atalman commented Dec 14, 2023

@vmoens the torch pip install on windows is fixed. Please take a look at the next issue: https://github.com/pytorch/rl/actions/runs/7211403586/job/19652490509?pr=1746#step:9:578

@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Dec 15, 2023
@vmoens vmoens marked this pull request as ready for review December 19, 2023 10:23
@vmoens vmoens merged commit f0b4814 into main Dec 20, 2023
16 of 35 checks passed
@vmoens vmoens deleted the fix-windows-ci branch December 20, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @atalman @facebook-github-bot