Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Algorithm] Update discrete SAC example #1745

Merged
merged 10 commits into from
Jan 9, 2024
Merged

[Algorithm] Update discrete SAC example #1745

merged 10 commits into from
Jan 9, 2024

Conversation

BY571
Copy link
Contributor

@BY571 BY571 commented Dec 13, 2023

Description

Update discrete SAC example similar to other off-policy scripts. Preparation for another PR to update the discrete SAC objective with separate actor/qvalue/alpha loss calculations.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1745

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 11b8fa5 with merge base 11a82c3 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2023
@vmoens vmoens changed the title Update discrete SAC example [Algorithm] Update discrete SAC example Dec 14, 2023
vmoens
vmoens approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

examples/discrete_sac/config.yaml Outdated Show resolved Hide resolved
@vmoens vmoens added the new algo New algorithm request or PR label Dec 14, 2023
vmoens
vmoens reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BY571 I forgot: we need to adapt the examples CI too!

@vmoens
Copy link
Contributor

vmoens commented Jan 5, 2024

@BY571 the examples CI is still failing because of a relative import to utils

rl/examples/discrete_sac/discrete_sac.py

Lines 25 to 33 in bfcf90a

from utils import (
log_metrics,
make_collector,
make_environment,
make_loss_module,
make_optimizer,
make_replay_buffer,
make_sac_agent,
)

@vmoens vmoens merged commit 6c68f7e into pytorch:main Jan 9, 2024
58 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BY571 @vmoens @facebook-github-bot