Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix discord link #1701

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[Doc] Fix discord link #1701

merged 1 commit into from
Nov 15, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 15, 2023 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 15, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1701

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 0a7cf8b with merge base 0a38cbc (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2023
@vmoens vmoens marked this pull request as ready for review November 15, 2023 21:27
@vmoens vmoens added the documentation Improvements or additions to documentation label Nov 15, 2023
@vmoens vmoens merged commit 9b9860f into main Nov 15, 2023
1 check passed
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 58.1257ms 57.5532ms 17.3752 Ops/s 16.2970 Ops/s $\textbf{\color{#35bf28}+6.62\%}$
test_sync 41.1699ms 31.7939ms 31.4525 Ops/s 31.3864 Ops/s $\color{#35bf28}+0.21\%$
test_async 63.7659ms 30.0930ms 33.2303 Ops/s 33.5199 Ops/s $\color{#d91a1a}-0.86\%$
test_simple 0.4553s 0.4127s 2.4232 Ops/s 2.4154 Ops/s $\color{#35bf28}+0.32\%$
test_transformed 0.6026s 0.5674s 1.7625 Ops/s 1.7462 Ops/s $\color{#35bf28}+0.93\%$
test_serial 1.2171s 1.1727s 0.8527 Ops/s 0.8205 Ops/s $\color{#35bf28}+3.93\%$
test_parallel 1.1251s 1.0770s 0.9285 Ops/s 0.9163 Ops/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-True-True-True-True] 0.2348ms 20.2034μs 49.4967 KOps/s 50.4649 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[True-True-True-True-False] 55.9810μs 12.3760μs 80.8015 KOps/s 83.1460 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[True-True-True-False-True] 39.9940μs 12.5166μs 79.8940 KOps/s 81.9157 KOps/s $\color{#d91a1a}-2.47\%$
test_step_mdp_speed[True-True-True-False-False] 58.2780μs 7.4987μs 133.3569 KOps/s 135.8810 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[True-True-False-True-True] 54.5620μs 21.2141μs 47.1384 KOps/s 47.6087 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-True-False-True-False] 66.9250μs 13.4337μs 74.4398 KOps/s 74.7823 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-True-False-False-True] 35.8960μs 13.7383μs 72.7891 KOps/s 73.5186 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-True-False-False-False] 41.5470μs 8.5137μs 117.4579 KOps/s 116.5755 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[True-False-True-True-True] 46.9470μs 22.4439μs 44.5555 KOps/s 45.0812 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-False-True-True-False] 37.7700μs 14.4812μs 69.0549 KOps/s 69.6677 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[True-False-True-False-True] 1.6483ms 13.8432μs 72.2376 KOps/s 75.0684 KOps/s $\color{#d91a1a}-3.77\%$
test_step_mdp_speed[True-False-True-False-False] 35.0540μs 8.5627μs 116.7853 KOps/s 118.2598 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-False-True-True] 70.9420μs 23.4058μs 42.7244 KOps/s 43.1947 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-False-False-True-False] 53.5590μs 15.3964μs 64.9501 KOps/s 64.9703 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-False-False-False-True] 66.5130μs 14.7556μs 67.7711 KOps/s 68.4562 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[True-False-False-False-False] 32.0590μs 9.6069μs 104.0918 KOps/s 103.0738 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-True-True-True-True] 74.4080μs 22.3104μs 44.8222 KOps/s 45.5497 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[False-True-True-True-False] 45.2240μs 14.3560μs 69.6574 KOps/s 69.3295 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[False-True-True-False-True] 65.2320μs 15.4512μs 64.7199 KOps/s 65.8007 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[False-True-True-False-False] 39.2330μs 9.6698μs 103.4146 KOps/s 104.2054 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-True-False-True-True] 67.6860μs 23.4430μs 42.6567 KOps/s 43.2340 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-True-False-True-False] 48.2400μs 15.2784μs 65.4520 KOps/s 65.0773 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-False-False-True] 70.9420μs 16.4430μs 60.8160 KOps/s 60.8130 KOps/s $+0.01\%$
test_step_mdp_speed[False-True-False-False-False] 36.8390μs 10.5603μs 94.6946 KOps/s 94.2318 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[False-False-True-True-True] 61.0340μs 24.5573μs 40.7210 KOps/s 41.1316 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-False-True-True-False] 45.5750μs 16.4887μs 60.6476 KOps/s 60.8502 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[False-False-True-False-True] 62.0350μs 16.5635μs 60.3736 KOps/s 61.4074 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[False-False-True-False-False] 37.0690μs 10.6105μs 94.2467 KOps/s 94.6168 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-False-False-True-True] 0.1001ms 25.6648μs 38.9639 KOps/s 39.6846 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[False-False-False-True-False] 49.6720μs 17.4918μs 57.1696 KOps/s 58.2789 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[False-False-False-False-True] 45.8550μs 17.3645μs 57.5888 KOps/s 58.2673 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-False-False-False-False] 64.7800μs 11.5857μs 86.3129 KOps/s 86.4220 KOps/s $\color{#d91a1a}-0.13\%$
test_values[generalized_advantage_estimate-True-True] 20.5194ms 11.8362ms 84.4868 Ops/s 72.3681 Ops/s $\textbf{\color{#35bf28}+16.75\%}$
test_values[vec_generalized_advantage_estimate-True-True] 36.5300ms 26.3609ms 37.9350 Ops/s 37.1493 Ops/s $\color{#35bf28}+2.12\%$
test_values[td0_return_estimate-False-False] 0.2638ms 0.1802ms 5.5492 KOps/s 5.6495 KOps/s $\color{#d91a1a}-1.78\%$
test_values[td1_return_estimate-False-False] 26.5615ms 24.7985ms 40.3250 Ops/s 39.7140 Ops/s $\color{#35bf28}+1.54\%$
test_values[vec_td1_return_estimate-False-False] 28.9270ms 26.2234ms 38.1338 Ops/s 37.2351 Ops/s $\color{#35bf28}+2.41\%$
test_values[td_lambda_return_estimate-True-False] 38.5870ms 34.7842ms 28.7487 Ops/s 28.2763 Ops/s $\color{#35bf28}+1.67\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.4147ms 26.7838ms 37.3360 Ops/s 37.4935 Ops/s $\color{#d91a1a}-0.42\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.0194ms 7.7688ms 128.7205 Ops/s 128.4859 Ops/s $\color{#35bf28}+0.18\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 3.3394ms 1.9554ms 511.3994 Ops/s 477.3964 Ops/s $\textbf{\color{#35bf28}+7.12\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 11.2985ms 0.4441ms 2.2519 KOps/s 2.3235 KOps/s $\color{#d91a1a}-3.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 50.8964ms 41.3294ms 24.1958 Ops/s 24.4907 Ops/s $\color{#d91a1a}-1.20\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 13.1094ms 2.5272ms 395.6898 Ops/s 394.5746 Ops/s $\color{#35bf28}+0.28\%$
test_dqn_speed 15.4900ms 1.5630ms 639.7965 Ops/s 592.5352 Ops/s $\textbf{\color{#35bf28}+7.98\%}$
test_ddpg_speed 14.3296ms 2.8503ms 350.8361 Ops/s 351.4848 Ops/s $\color{#d91a1a}-0.18\%$
test_sac_speed 19.9021ms 8.1989ms 121.9680 Ops/s 121.4462 Ops/s $\color{#35bf28}+0.43\%$
test_redq_speed 26.5428ms 15.2682ms 65.4957 Ops/s 66.0769 Ops/s $\color{#d91a1a}-0.88\%$
test_redq_deprec_speed 25.2272ms 13.5641ms 73.7243 Ops/s 73.2109 Ops/s $\color{#35bf28}+0.70\%$
test_td3_speed 9.3875ms 8.3101ms 120.3352 Ops/s 119.8995 Ops/s $\color{#35bf28}+0.36\%$
test_cql_speed 46.1197ms 35.2116ms 28.3997 Ops/s 28.2173 Ops/s $\color{#35bf28}+0.65\%$
test_a2c_speed 22.3019ms 7.9174ms 126.3043 Ops/s 128.0884 Ops/s $\color{#d91a1a}-1.39\%$
test_ppo_speed 20.0624ms 8.1650ms 122.4739 Ops/s 125.1662 Ops/s $\color{#d91a1a}-2.15\%$
test_reinforce_speed 18.1370ms 6.8444ms 146.1057 Ops/s 144.4356 Ops/s $\color{#35bf28}+1.16\%$
test_iql_speed 42.9733ms 31.7479ms 31.4982 Ops/s 31.4146 Ops/s $\color{#35bf28}+0.27\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2914ms 1.5855ms 630.7212 Ops/s 633.5371 Ops/s $\color{#d91a1a}-0.44\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.4667ms 1.7007ms 587.9942 Ops/s 595.8605 Ops/s $\color{#d91a1a}-1.32\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 2.8891ms 1.6808ms 594.9648 Ops/s 590.6037 Ops/s $\color{#35bf28}+0.74\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 0.1968s 1.8760ms 533.0458 Ops/s 626.6270 Ops/s $\textbf{\color{#d91a1a}-14.93\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.6182ms 1.6628ms 601.4102 Ops/s 582.0629 Ops/s $\color{#35bf28}+3.32\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 2.3863ms 1.6791ms 595.5499 Ops/s 605.7942 Ops/s $\color{#d91a1a}-1.69\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.0739ms 1.5851ms 630.8645 Ops/s 632.5641 Ops/s $\color{#d91a1a}-0.27\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.2545ms 1.6867ms 592.8815 Ops/s 588.9880 Ops/s $\color{#35bf28}+0.66\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 2.6617ms 1.6900ms 591.7130 Ops/s 594.5277 Ops/s $\color{#d91a1a}-0.47\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3181ms 1.5725ms 635.9192 Ops/s 639.8259 Ops/s $\color{#d91a1a}-0.61\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.4600ms 1.6822ms 594.4423 Ops/s 517.2864 Ops/s $\textbf{\color{#35bf28}+14.92\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 2.9394ms 1.6957ms 589.7112 Ops/s 594.4053 Ops/s $\color{#d91a1a}-0.79\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.2947ms 1.6065ms 622.4578 Ops/s 630.4541 Ops/s $\color{#d91a1a}-1.27\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.5963ms 1.6873ms 592.6741 Ops/s 583.1959 Ops/s $\color{#35bf28}+1.63\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1194s 1.9794ms 505.1998 Ops/s 588.2957 Ops/s $\textbf{\color{#d91a1a}-14.12\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 1.9927ms 1.5583ms 641.7386 Ops/s 632.9747 Ops/s $\color{#35bf28}+1.38\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.2344ms 1.6918ms 591.0703 Ops/s 588.7289 Ops/s $\color{#35bf28}+0.40\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 2.4473ms 1.6960ms 589.6156 Ops/s 591.0782 Ops/s $\color{#d91a1a}-0.25\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1845s 20.5944ms 48.5570 Ops/s 47.9647 Ops/s $\color{#35bf28}+1.23\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1038s 16.8623ms 59.3038 Ops/s 57.4271 Ops/s $\color{#35bf28}+3.27\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1129s 19.1010ms 52.3533 Ops/s 51.5418 Ops/s $\color{#35bf28}+1.57\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1033s 16.9553ms 58.9786 Ops/s 58.0510 Ops/s $\color{#35bf28}+1.60\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1051s 18.5589ms 53.8826 Ops/s 52.0622 Ops/s $\color{#35bf28}+3.50\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1016s 16.8171ms 59.4632 Ops/s 51.4390 Ops/s $\textbf{\color{#35bf28}+15.60\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1024s 18.6588ms 53.5941 Ops/s 57.5238 Ops/s $\textbf{\color{#d91a1a}-6.83\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1030s 16.9414ms 59.0269 Ops/s 50.6350 Ops/s $\textbf{\color{#35bf28}+16.57\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1039s 18.7579ms 53.3108 Ops/s 57.4035 Ops/s $\textbf{\color{#d91a1a}-7.13\%}$

@vmoens vmoens deleted the reset-discord-link branch November 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot