Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficiency improvement in VecNorm, TensorDict and env tensor casting #168

Merged
merged 19 commits into from
May 26, 2022
Merged

Efficiency improvement in VecNorm, TensorDict and env tensor casting #168

merged 19 commits into from
May 26, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 25, 2022 •
edited
Loading

Brings several important improvements in efficiency

  • Removes lots of try / except in TensorDict and TensorSpec that were encountered quite often
  • makes np casting to tensor and inversely more efficient
  • refactor operation order in VecNorm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2022
@vmoens vmoens added enhancement New feature or request and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 25, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2022
@vmoens vmoens changed the title Efficiency improvement in VecNorm Efficiency improvement in VecNorm, TensorDict and env tensor casting May 26, 2022
@vmoens vmoens merged commit f0ab441 into main May 26, 2022
@vmoens vmoens deleted the efficiency_improvement branch May 26, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot