Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update rollout_recurrent.png to account for terminal #1677

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Doc] Update rollout_recurrent.png to account for terminal #1677

merged 1 commit into from
Nov 7, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 7, 2023 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1677

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 18 Unrelated Failures

As of commit cfe3795 with merge base 97abb93 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2023
@vmoens vmoens added the documentation Improvements or additions to documentation label Nov 7, 2023
@vmoens vmoens merged commit eebef29 into main Nov 7, 2023
25 of 47 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 61.2607ms 60.9109ms 16.4174 Ops/s 15.8352 Ops/s $\color{#35bf28}+3.68\%$
test_sync 41.7060ms 34.6854ms 28.8306 Ops/s 29.5047 Ops/s $\color{#d91a1a}-2.28\%$
test_async 54.8823ms 31.4156ms 31.8313 Ops/s 32.2446 Ops/s $\color{#d91a1a}-1.28\%$
test_simple 0.4919s 0.4474s 2.2351 Ops/s 2.3081 Ops/s $\color{#d91a1a}-3.16\%$
test_transformed 0.6329s 0.5878s 1.7013 Ops/s 1.6694 Ops/s $\color{#35bf28}+1.92\%$
test_serial 1.2822s 1.2328s 0.8111 Ops/s 0.7946 Ops/s $\color{#35bf28}+2.09\%$
test_parallel 1.2812s 1.2368s 0.8085 Ops/s 0.8095 Ops/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-True-True-True-True] 0.2256ms 24.4038μs 40.9773 KOps/s 41.2073 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[True-True-True-True-False] 41.5880μs 14.6710μs 68.1617 KOps/s 69.4514 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[True-True-True-False-True] 40.5460μs 15.0404μs 66.4874 KOps/s 67.4191 KOps/s $\color{#d91a1a}-1.38\%$
test_step_mdp_speed[True-True-True-False-False] 25.8990μs 8.7537μs 114.2373 KOps/s 114.4838 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[True-True-False-True-True] 57.2970μs 26.0601μs 38.3728 KOps/s 38.6748 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[True-True-False-True-False] 49.2420μs 16.2612μs 61.4961 KOps/s 63.0249 KOps/s $\color{#d91a1a}-2.43\%$
test_step_mdp_speed[True-True-False-False-True] 36.5480μs 16.4783μs 60.6858 KOps/s 60.8816 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[True-True-False-False-False] 35.7970μs 10.3759μs 96.3772 KOps/s 100.0359 KOps/s $\color{#d91a1a}-3.66\%$
test_step_mdp_speed[True-False-True-True-True] 58.6000μs 27.5125μs 36.3471 KOps/s 36.7896 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[True-False-True-True-False] 41.8280μs 17.6445μs 56.6747 KOps/s 58.1337 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[True-False-True-False-True] 44.8830μs 16.5848μs 60.2961 KOps/s 61.2933 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[True-False-True-False-False] 41.9380μs 10.3446μs 96.6692 KOps/s 98.7502 KOps/s $\color{#d91a1a}-2.11\%$
test_step_mdp_speed[True-False-False-True-True] 62.0060μs 29.1879μs 34.2608 KOps/s 34.8972 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-False-True-False] 49.0510μs 19.1765μs 52.1473 KOps/s 53.7527 KOps/s $\color{#d91a1a}-2.99\%$
test_step_mdp_speed[True-False-False-False-True] 52.0570μs 17.8447μs 56.0392 KOps/s 56.2555 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[True-False-False-False-False] 38.2810μs 11.7791μs 84.8965 KOps/s 87.0766 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[False-True-True-True-True] 62.1450μs 27.6317μs 36.1904 KOps/s 36.9607 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[False-True-True-True-False] 42.9000μs 17.8099μs 56.1485 KOps/s 57.5004 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-True-False-True] 43.1910μs 19.3063μs 51.7965 KOps/s 53.1891 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[False-True-True-False-False] 31.9900μs 11.7721μs 84.9468 KOps/s 85.6701 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-True-False-True-True] 74.3780μs 28.8734μs 34.6340 KOps/s 35.3701 KOps/s $\color{#d91a1a}-2.08\%$
test_step_mdp_speed[False-True-False-True-False] 41.4570μs 19.0869μs 52.3919 KOps/s 53.8054 KOps/s $\color{#d91a1a}-2.63\%$
test_step_mdp_speed[False-True-False-False-True] 48.3410μs 20.6862μs 48.3414 KOps/s 49.6683 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[False-True-False-False-False] 40.4660μs 13.0453μs 76.6559 KOps/s 77.5126 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[False-False-True-True-True] 78.8270μs 30.9011μs 32.3613 KOps/s 33.4433 KOps/s $\color{#d91a1a}-3.24\%$
test_step_mdp_speed[False-False-True-True-False] 68.2170μs 20.6383μs 48.4536 KOps/s 49.6028 KOps/s $\color{#d91a1a}-2.32\%$
test_step_mdp_speed[False-False-True-False-True] 48.9920μs 20.7447μs 48.2051 KOps/s 49.2357 KOps/s $\color{#d91a1a}-2.09\%$
test_step_mdp_speed[False-False-True-False-False] 53.4700μs 13.1285μs 76.1700 KOps/s 76.3078 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[False-False-False-True-True] 85.8500μs 31.5615μs 31.6842 KOps/s 31.9636 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-False-False-True-False] 46.6770μs 21.9283μs 45.6031 KOps/s 46.5408 KOps/s $\color{#d91a1a}-2.01\%$
test_step_mdp_speed[False-False-False-False-True] 54.4510μs 21.7292μs 46.0211 KOps/s 46.6095 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-False-False-False-False] 45.2040μs 14.3167μs 69.8484 KOps/s 71.3358 KOps/s $\color{#d91a1a}-2.09\%$
test_values[generalized_advantage_estimate-True-True] 12.3265ms 11.9694ms 83.5462 Ops/s 83.4660 Ops/s $\color{#35bf28}+0.10\%$
test_values[vec_generalized_advantage_estimate-True-True] 33.8486ms 26.3039ms 38.0171 Ops/s 37.7232 Ops/s $\color{#35bf28}+0.78\%$
test_values[td0_return_estimate-False-False] 0.2470ms 0.1770ms 5.6486 KOps/s 5.6707 KOps/s $\color{#d91a1a}-0.39\%$
test_values[td1_return_estimate-False-False] 28.2770ms 25.4925ms 39.2273 Ops/s 38.8046 Ops/s $\color{#35bf28}+1.09\%$
test_values[vec_td1_return_estimate-False-False] 34.1241ms 26.3398ms 37.9653 Ops/s 36.7734 Ops/s $\color{#35bf28}+3.24\%$
test_values[td_lambda_return_estimate-True-False] 38.6370ms 35.7125ms 28.0014 Ops/s 27.5263 Ops/s $\color{#35bf28}+1.73\%$
test_values[vec_td_lambda_return_estimate-True-False] 97.2972ms 29.9247ms 33.4172 Ops/s 37.5487 Ops/s $\textbf{\color{#d91a1a}-11.00\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4373ms 8.0981ms 123.4851 Ops/s 122.7478 Ops/s $\color{#35bf28}+0.60\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 4.9536ms 1.9593ms 510.3931 Ops/s 545.4120 Ops/s $\textbf{\color{#d91a1a}-6.42\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 8.4636ms 0.4390ms 2.2778 KOps/s 2.3595 KOps/s $\color{#d91a1a}-3.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.8006ms 40.1148ms 24.9285 Ops/s 25.0605 Ops/s $\color{#d91a1a}-0.53\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.3357ms 2.5122ms 398.0504 Ops/s 397.8078 Ops/s $\color{#35bf28}+0.06\%$
test_dqn_speed 9.6413ms 1.7048ms 586.5899 Ops/s 603.6453 Ops/s $\color{#d91a1a}-2.83\%$
test_ddpg_speed 11.0545ms 3.1343ms 319.0469 Ops/s 333.5027 Ops/s $\color{#d91a1a}-4.33\%$
test_sac_speed 25.6214ms 8.7881ms 113.7899 Ops/s 118.4737 Ops/s $\color{#d91a1a}-3.95\%$
test_redq_speed 29.0313ms 16.6378ms 60.1040 Ops/s 61.3755 Ops/s $\color{#d91a1a}-2.07\%$
test_redq_deprec_speed 22.7433ms 14.1913ms 70.4659 Ops/s 70.7501 Ops/s $\color{#d91a1a}-0.40\%$
test_td3_speed 13.9321ms 8.7654ms 114.0855 Ops/s 116.1706 Ops/s $\color{#d91a1a}-1.79\%$
test_cql_speed 45.4520ms 36.6695ms 27.2706 Ops/s 27.5421 Ops/s $\color{#d91a1a}-0.99\%$
test_a2c_speed 16.1229ms 7.9537ms 125.7277 Ops/s 123.2192 Ops/s $\color{#35bf28}+2.04\%$
test_ppo_speed 16.7312ms 8.3127ms 120.2976 Ops/s 113.5419 Ops/s $\textbf{\color{#35bf28}+5.95\%}$
test_reinforce_speed 15.1326ms 7.0449ms 141.9459 Ops/s 135.6774 Ops/s $\color{#35bf28}+4.62\%$
test_iql_speed 40.4743ms 32.5421ms 30.7294 Ops/s 20.9805 Ops/s $\textbf{\color{#35bf28}+46.47\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.4679ms 1.8629ms 536.7993 Ops/s 537.0278 Ops/s $\color{#d91a1a}-0.04\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.8959ms 1.9955ms 501.1242 Ops/s 502.3772 Ops/s $\color{#d91a1a}-0.25\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.0735ms 2.0145ms 496.4079 Ops/s 487.2821 Ops/s $\color{#35bf28}+1.87\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.3079ms 1.8776ms 532.5916 Ops/s 539.6690 Ops/s $\color{#d91a1a}-1.31\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1234s 2.2743ms 439.6909 Ops/s 494.2012 Ops/s $\textbf{\color{#d91a1a}-11.03\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 2.7949ms 2.0414ms 489.8675 Ops/s 487.7108 Ops/s $\color{#35bf28}+0.44\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4534ms 1.8538ms 539.4297 Ops/s 526.1778 Ops/s $\color{#35bf28}+2.52\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.9416ms 1.9868ms 503.3122 Ops/s 499.0433 Ops/s $\color{#35bf28}+0.86\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1213s 2.2952ms 435.6997 Ops/s 494.9005 Ops/s $\textbf{\color{#d91a1a}-11.96\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7368ms 1.8587ms 538.0126 Ops/s 538.1176 Ops/s $\color{#d91a1a}-0.02\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.9500ms 1.9892ms 502.7033 Ops/s 500.8132 Ops/s $\color{#35bf28}+0.38\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 2.9345ms 2.0023ms 499.4195 Ops/s 494.8228 Ops/s $\color{#35bf28}+0.93\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7230ms 1.8641ms 536.4567 Ops/s 538.2855 Ops/s $\color{#d91a1a}-0.34\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1208s 2.2875ms 437.1618 Ops/s 506.2802 Ops/s $\textbf{\color{#d91a1a}-13.65\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.0189ms 2.0232ms 494.2705 Ops/s 501.8042 Ops/s $\color{#d91a1a}-1.50\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.3948ms 1.8665ms 535.7635 Ops/s 546.5242 Ops/s $\color{#d91a1a}-1.97\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.3380ms 2.0086ms 497.8553 Ops/s 494.7443 Ops/s $\color{#35bf28}+0.63\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1271s 2.3179ms 431.4230 Ops/s 499.0995 Ops/s $\textbf{\color{#d91a1a}-13.56\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2564s 22.0697ms 45.3110 Ops/s 44.0836 Ops/s $\color{#35bf28}+2.78\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1178s 21.3587ms 46.8193 Ops/s 52.4213 Ops/s $\textbf{\color{#d91a1a}-10.69\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1293s 19.6469ms 50.8986 Ops/s 47.7547 Ops/s $\textbf{\color{#35bf28}+6.58\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1284s 21.9759ms 45.5045 Ops/s 52.8740 Ops/s $\textbf{\color{#d91a1a}-13.94\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1204s 19.3843ms 51.5882 Ops/s 47.2704 Ops/s $\textbf{\color{#35bf28}+9.13\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1196s 21.5010ms 46.5096 Ops/s 47.2880 Ops/s $\color{#d91a1a}-1.65\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1175s 19.2847ms 51.8547 Ops/s 52.1821 Ops/s $\color{#d91a1a}-0.63\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1247s 21.6934ms 46.0969 Ops/s 47.2185 Ops/s $\color{#d91a1a}-2.38\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1200s 19.4582ms 51.3921 Ops/s 52.3880 Ops/s $\color{#d91a1a}-1.90\%$

@vmoens vmoens deleted the update_figure_recurrent branch November 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot