Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] 0.2.1 #1642

Merged
merged 12 commits into from
Oct 25, 2023
Merged

[Release] 0.2.1 #1642

merged 12 commits into from
Oct 25, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 23, 2023 •
edited
Loading

Fixes a bug in the M1 wheels which prevents them from being used with torch 2.1.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2023
@vmoens vmoens temporarily deployed to pytorchbot-env October 23, 2023 15:23 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 23, 2023 15:23 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 23, 2023 15:23 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 23, 2023 15:23 — with GitHub Actions Inactive
@vmoens vmoens added the ciflow/binaries/all Build all binaries label Oct 24, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2023

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:09 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:09 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:09 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:09 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:25 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:25 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:25 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 24, 2023 14:25 — with GitHub Actions Inactive
This was referenced Oct 24, 2023
Closed
Closed
Closed
@vmoens vmoens changed the title [NOMERG] 0.2.1 [Release] 0.2.1 Oct 25, 2023
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 14:53 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 14:53 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 14:53 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 14:53 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}16$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 93.9217ms 93.2565ms 10.7231 Ops/s 10.2004 Ops/s $\textbf{\color{#35bf28}+5.12\%}$
test_sync 63.1469ms 52.6299ms 19.0006 Ops/s 19.2972 Ops/s $\color{#d91a1a}-1.54\%$
test_async 0.1005s 50.2499ms 19.9005 Ops/s 19.5670 Ops/s $\color{#35bf28}+1.70\%$
test_simple 0.7680s 0.6725s 1.4869 Ops/s 1.4888 Ops/s $\color{#d91a1a}-0.12\%$
test_transformed 0.9974s 0.9148s 1.0932 Ops/s 1.0583 Ops/s $\color{#35bf28}+3.30\%$
test_serial 2.0245s 1.9340s 0.5171 Ops/s 0.5158 Ops/s $\color{#35bf28}+0.25\%$
test_parallel 2.4232s 2.3372s 0.4279 Ops/s 0.4293 Ops/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[True-True-True-True-True] 0.2110ms 43.1504μs 23.1747 KOps/s 22.4428 KOps/s $\color{#35bf28}+3.26\%$
test_step_mdp_speed[True-True-True-True-False] 61.7010μs 24.7579μs 40.3912 KOps/s 39.5370 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[True-True-True-False-True] 73.3010μs 30.3222μs 32.9792 KOps/s 31.9961 KOps/s $\color{#35bf28}+3.07\%$
test_step_mdp_speed[True-True-True-False-False] 50.9000μs 16.9983μs 58.8294 KOps/s 56.9173 KOps/s $\color{#35bf28}+3.36\%$
test_step_mdp_speed[True-True-False-True-True] 75.3000μs 44.8193μs 22.3118 KOps/s 21.8166 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[True-True-False-True-False] 63.9000μs 26.4027μs 37.8749 KOps/s 37.2402 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-True-False-False-True] 0.1167ms 32.3213μs 30.9394 KOps/s 30.2528 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[True-True-False-False-False] 61.4000μs 18.9819μs 52.6818 KOps/s 51.1058 KOps/s $\color{#35bf28}+3.08\%$
test_step_mdp_speed[True-False-True-True-True] 0.1074ms 46.7680μs 21.3822 KOps/s 20.9921 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[True-False-True-True-False] 82.0010μs 28.1331μs 35.5453 KOps/s 34.4266 KOps/s $\color{#35bf28}+3.25\%$
test_step_mdp_speed[True-False-True-False-True] 73.5010μs 32.4088μs 30.8558 KOps/s 30.1543 KOps/s $\color{#35bf28}+2.33\%$
test_step_mdp_speed[True-False-True-False-False] 89.6000μs 18.8380μs 53.0842 KOps/s 50.3378 KOps/s $\textbf{\color{#35bf28}+5.46\%}$
test_step_mdp_speed[True-False-False-True-True] 0.1127ms 48.9599μs 20.4249 KOps/s 20.4015 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[True-False-False-True-False] 58.3000μs 29.9871μs 33.3476 KOps/s 32.5691 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[True-False-False-False-True] 85.8000μs 34.3204μs 29.1372 KOps/s 28.7302 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-False-False-False-False] 50.3000μs 20.4920μs 48.7996 KOps/s 46.7084 KOps/s $\color{#35bf28}+4.48\%$
test_step_mdp_speed[False-True-True-True-True] 0.1025ms 47.0270μs 21.2644 KOps/s 20.9703 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[False-True-True-True-False] 59.6000μs 28.2364μs 35.4153 KOps/s 34.7457 KOps/s $\color{#35bf28}+1.93\%$
test_step_mdp_speed[False-True-True-False-True] 0.1139ms 36.7682μs 27.1975 KOps/s 26.9394 KOps/s $\color{#35bf28}+0.96\%$
test_step_mdp_speed[False-True-True-False-False] 55.0000μs 20.8666μs 47.9234 KOps/s 46.3625 KOps/s $\color{#35bf28}+3.37\%$
test_step_mdp_speed[False-True-False-True-True] 0.1781ms 48.2392μs 20.7300 KOps/s 20.2716 KOps/s $\color{#35bf28}+2.26\%$
test_step_mdp_speed[False-True-False-True-False] 67.1000μs 29.7483μs 33.6154 KOps/s 32.9451 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-True-False-False-True] 74.2000μs 37.8860μs 26.3950 KOps/s 25.7376 KOps/s $\color{#35bf28}+2.55\%$
test_step_mdp_speed[False-True-False-False-False] 50.4000μs 22.5214μs 44.4021 KOps/s 42.7360 KOps/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[False-False-True-True-True] 84.4000μs 49.9648μs 20.0141 KOps/s 19.4137 KOps/s $\color{#35bf28}+3.09\%$
test_step_mdp_speed[False-False-True-True-False] 1.5681ms 32.0529μs 31.1985 KOps/s 30.8624 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[False-False-True-False-True] 71.4000μs 37.8403μs 26.4269 KOps/s 25.5713 KOps/s $\color{#35bf28}+3.35\%$
test_step_mdp_speed[False-False-True-False-False] 65.9000μs 22.5659μs 44.3147 KOps/s 43.0772 KOps/s $\color{#35bf28}+2.87\%$
test_step_mdp_speed[False-False-False-True-True] 83.9000μs 51.3090μs 19.4898 KOps/s 18.9937 KOps/s $\color{#35bf28}+2.61\%$
test_step_mdp_speed[False-False-False-True-False] 0.1130ms 33.3865μs 29.9522 KOps/s 29.4112 KOps/s $\color{#35bf28}+1.84\%$
test_step_mdp_speed[False-False-False-False-True] 74.3010μs 38.9775μs 25.6558 KOps/s 25.3461 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[False-False-False-False-False] 69.7010μs 24.0862μs 41.5175 KOps/s 40.5574 KOps/s $\color{#35bf28}+2.37\%$
test_values[generalized_advantage_estimate-True-True] 17.0910ms 15.5371ms 64.3623 Ops/s 64.7730 Ops/s $\color{#d91a1a}-0.63\%$
test_values[vec_generalized_advantage_estimate-True-True] 57.3144ms 47.1862ms 21.1926 Ops/s 21.0054 Ops/s $\color{#35bf28}+0.89\%$
test_values[td0_return_estimate-False-False] 0.7647ms 0.5703ms 1.7535 KOps/s 1.9920 KOps/s $\textbf{\color{#d91a1a}-11.97\%}$
test_values[td1_return_estimate-False-False] 36.8367ms 33.9648ms 29.4422 Ops/s 29.4051 Ops/s $\color{#35bf28}+0.13\%$
test_values[vec_td1_return_estimate-False-False] 56.9691ms 47.4308ms 21.0833 Ops/s 20.8562 Ops/s $\color{#35bf28}+1.09\%$
test_values[td_lambda_return_estimate-True-False] 48.7190ms 47.7765ms 20.9308 Ops/s 20.9990 Ops/s $\color{#d91a1a}-0.32\%$
test_values[vec_td_lambda_return_estimate-True-False] 60.9386ms 48.0730ms 20.8017 Ops/s 21.4617 Ops/s $\color{#d91a1a}-3.07\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 12.5767ms 11.9860ms 83.4306 Ops/s 82.8207 Ops/s $\color{#35bf28}+0.74\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 11.0417ms 4.0146ms 249.0933 Ops/s 248.4197 Ops/s $\color{#35bf28}+0.27\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 1.1021ms 0.5715ms 1.7498 KOps/s 1.7614 KOps/s $\color{#d91a1a}-0.66\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 64.7668ms 63.0961ms 15.8489 Ops/s 17.2641 Ops/s $\textbf{\color{#d91a1a}-8.20\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.1457ms 3.6049ms 277.4010 Ops/s 249.9633 Ops/s $\textbf{\color{#35bf28}+10.98\%}$
test_dqn_speed 8.5138ms 2.5185ms 397.0612 Ops/s 394.5733 Ops/s $\color{#35bf28}+0.63\%$
test_ddpg_speed 11.3608ms 4.8426ms 206.5021 Ops/s 215.1755 Ops/s $\color{#d91a1a}-4.03\%$
test_sac_speed 25.1943ms 14.3321ms 69.7734 Ops/s 79.0499 Ops/s $\textbf{\color{#d91a1a}-11.73\%}$
test_redq_speed 27.1155ms 22.9351ms 43.6013 Ops/s 46.3629 Ops/s $\textbf{\color{#d91a1a}-5.96\%}$
test_redq_deprec_speed 26.2531ms 20.6557ms 48.4128 Ops/s 51.7564 Ops/s $\textbf{\color{#d91a1a}-6.46\%}$
test_td3_speed 16.5097ms 14.1898ms 70.4731 Ops/s 76.5779 Ops/s $\textbf{\color{#d91a1a}-7.97\%}$
test_cql_speed 50.5698ms 45.2274ms 22.1105 Ops/s 25.3989 Ops/s $\textbf{\color{#d91a1a}-12.95\%}$
test_a2c_speed 13.7938ms 9.8705ms 101.3117 Ops/s 124.1770 Ops/s $\textbf{\color{#d91a1a}-18.41\%}$
test_ppo_speed 17.5615ms 10.3619ms 96.5070 Ops/s 108.5969 Ops/s $\textbf{\color{#d91a1a}-11.13\%}$
test_reinforce_speed 14.2418ms 7.3489ms 136.0756 Ops/s 157.1417 Ops/s $\textbf{\color{#d91a1a}-13.41\%}$
test_iql_speed 40.8299ms 33.7329ms 29.6446 Ops/s 28.7408 Ops/s $\color{#35bf28}+3.14\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0826ms 3.0001ms 333.3254 Ops/s 347.3752 Ops/s $\color{#d91a1a}-4.04\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1832s 3.7474ms 266.8520 Ops/s 325.3149 Ops/s $\textbf{\color{#d91a1a}-17.97\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.6390ms 3.1123ms 321.3048 Ops/s 322.3249 Ops/s $\color{#d91a1a}-0.32\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.9141ms 2.9315ms 341.1177 Ops/s 346.0728 Ops/s $\color{#d91a1a}-1.43\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.5602ms 3.1007ms 322.5128 Ops/s 329.5748 Ops/s $\color{#d91a1a}-2.14\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.9735ms 3.1557ms 316.8859 Ops/s 322.3690 Ops/s $\color{#d91a1a}-1.70\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8532ms 3.0285ms 330.1990 Ops/s 342.4544 Ops/s $\color{#d91a1a}-3.58\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 7.0022ms 3.1654ms 315.9165 Ops/s 332.6131 Ops/s $\textbf{\color{#d91a1a}-5.02\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.3154ms 3.1158ms 320.9438 Ops/s 326.0367 Ops/s $\color{#d91a1a}-1.56\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6971ms 2.9108ms 343.5445 Ops/s 346.3161 Ops/s $\color{#d91a1a}-0.80\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 5.6740ms 3.1363ms 318.8491 Ops/s 324.3437 Ops/s $\color{#d91a1a}-1.69\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.8177ms 3.0990ms 322.6816 Ops/s 325.2150 Ops/s $\color{#d91a1a}-0.78\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.4649ms 2.9125ms 343.3432 Ops/s 340.2927 Ops/s $\color{#35bf28}+0.90\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.8690ms 3.0951ms 323.0920 Ops/s 327.5269 Ops/s $\color{#d91a1a}-1.35\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.6215ms 3.1157ms 320.9576 Ops/s 327.7126 Ops/s $\color{#d91a1a}-2.06\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7858ms 3.0187ms 331.2652 Ops/s 340.7895 Ops/s $\color{#d91a1a}-2.79\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.1086ms 3.1434ms 318.1264 Ops/s 318.1768 Ops/s $\color{#d91a1a}-0.02\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.2555ms 3.1383ms 318.6396 Ops/s 321.4609 Ops/s $\color{#d91a1a}-0.88\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3295s 36.9871ms 27.0364 Ops/s 29.5232 Ops/s $\textbf{\color{#d91a1a}-8.42\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1813s 30.0515ms 33.2762 Ops/s 30.2997 Ops/s $\textbf{\color{#35bf28}+9.82\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1782s 33.1306ms 30.1835 Ops/s 33.5379 Ops/s $\textbf{\color{#d91a1a}-10.00\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1841s 30.0278ms 33.3025 Ops/s 30.0730 Ops/s $\textbf{\color{#35bf28}+10.74\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1908s 33.9530ms 29.4525 Ops/s 32.3613 Ops/s $\textbf{\color{#d91a1a}-8.99\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1838s 30.1821ms 33.1323 Ops/s 29.2273 Ops/s $\textbf{\color{#35bf28}+13.36\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1864s 33.6044ms 29.7580 Ops/s 32.0730 Ops/s $\textbf{\color{#d91a1a}-7.22\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1922s 30.7175ms 32.5548 Ops/s 29.6366 Ops/s $\textbf{\color{#35bf28}+9.85\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1923s 33.9804ms 29.4287 Ops/s 29.2134 Ops/s $\color{#35bf28}+0.74\%$

@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 15:11 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 15:11 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 15:11 — with GitHub Actions Inactive
@vmoens vmoens temporarily deployed to pytorchbot-env October 25, 2023 15:11 — with GitHub Actions Inactive
@vmoens vmoens merged commit 1bb192e into main Oct 25, 2023
109 of 118 checks passed
@vmoens vmoens deleted the release/0.2.1 branch October 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/binaries/all Build all binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot