Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix shape setting in CompositeSpec #1620

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[BugFix] Fix shape setting in CompositeSpec #1620

merged 4 commits into from
Oct 10, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 10, 2023

Description

CompositeSpec.shape = smth wasn't appropriately changing the batch-size of nested items.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2023
@vmoens vmoens linked an issue Oct 10, 2023 that may be closed by this pull request
3 tasks
@vmoens vmoens added the bug Something isn't working label Oct 10, 2023
vmoens and others added 2 commits October 10, 2023 13:56
Co-authored-by: Matteo Bettini <55539777+matteobettini@users.noreply.github.com>
Co-authored-by: Matteo Bettini <55539777+matteobettini@users.noreply.github.com>
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 5e81445 into main Oct 10, 2023
36 of 61 checks passed
@vmoens vmoens deleted the fix-1614 branch October 10, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fail to instantiate gym env with nested dict observation
3 participants