Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Versioning] Write version all cases in setup.py #1579

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[Versioning] Write version all cases in setup.py #1579

merged 1 commit into from
Sep 27, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 27, 2023 •
edited
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2023
@vmoens vmoens added the versioning Versioning change (version number etc) label Sep 27, 2023
@vmoens vmoens merged commit cbece6b into main Sep 27, 2023
@vmoens vmoens deleted the version_in_setup branch September 27, 2023 16:03
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 66.1611ms 65.4668ms 15.2749 Ops/s 15.0896 Ops/s $\color{#35bf28}+1.23\%$
test_sync 41.9860ms 35.9233ms 27.8371 Ops/s 28.0756 Ops/s $\color{#d91a1a}-0.85\%$
test_async 61.8471ms 34.7145ms 28.8064 Ops/s 28.7496 Ops/s $\color{#35bf28}+0.20\%$
test_simple 0.6037s 0.5387s 1.8562 Ops/s 1.8367 Ops/s $\color{#35bf28}+1.06\%$
test_transformed 0.7569s 0.7160s 1.3966 Ops/s 1.3957 Ops/s $\color{#35bf28}+0.07\%$
test_serial 1.5670s 1.5182s 0.6587 Ops/s 0.6447 Ops/s $\color{#35bf28}+2.17\%$
test_parallel 1.3648s 1.3119s 0.7623 Ops/s 0.7215 Ops/s $\textbf{\color{#35bf28}+5.65\%}$
test_step_mdp_speed[True-True-True-True-True] 0.1898ms 42.4068μs 23.5811 KOps/s 23.9616 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[True-True-True-True-False] 49.8990μs 23.8957μs 41.8485 KOps/s 41.0168 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[True-True-True-False-True] 57.6000μs 29.7722μs 33.5884 KOps/s 34.2978 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[True-True-True-False-False] 47.4000μs 16.6020μs 60.2337 KOps/s 59.9890 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[True-True-False-True-True] 0.1103ms 43.7104μs 22.8778 KOps/s 22.9106 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-False-True-False] 92.0000μs 25.5930μs 39.0732 KOps/s 38.0893 KOps/s $\color{#35bf28}+2.58\%$
test_step_mdp_speed[True-True-False-False-True] 56.4000μs 31.3334μs 31.9148 KOps/s 31.7824 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-False-False-False] 74.0000μs 18.4510μs 54.1975 KOps/s 53.7678 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-False-True-True-True] 0.1064ms 45.7757μs 21.8456 KOps/s 21.7082 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[True-False-True-True-False] 53.2000μs 27.5137μs 36.3455 KOps/s 35.4698 KOps/s $\color{#35bf28}+2.47\%$
test_step_mdp_speed[True-False-True-False-True] 90.3000μs 31.4911μs 31.7550 KOps/s 31.6046 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[True-False-True-False-False] 43.6000μs 18.5268μs 53.9759 KOps/s 53.8021 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-False-False-True-True] 0.1043ms 47.2260μs 21.1748 KOps/s 20.7635 KOps/s $\color{#35bf28}+1.98\%$
test_step_mdp_speed[True-False-False-True-False] 87.9000μs 29.0133μs 34.4670 KOps/s 33.6515 KOps/s $\color{#35bf28}+2.42\%$
test_step_mdp_speed[True-False-False-False-True] 79.4000μs 32.9254μs 30.3717 KOps/s 30.6566 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-False-False-False-False] 83.7990μs 20.1960μs 49.5148 KOps/s 48.9825 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[False-True-True-True-True] 0.1049ms 45.5960μs 21.9317 KOps/s 21.7550 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-True-True-True-False] 81.5000μs 27.6211μs 36.2042 KOps/s 35.4827 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-True-True-False-True] 99.6000μs 34.1765μs 29.2598 KOps/s 29.4578 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-True-True-False-False] 66.5000μs 20.2649μs 49.3464 KOps/s 48.9403 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-True-False-True-True] 0.1082ms 47.2443μs 21.1666 KOps/s 21.1839 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[False-True-False-True-False] 54.7000μs 29.1371μs 34.3205 KOps/s 33.2482 KOps/s $\color{#35bf28}+3.23\%$
test_step_mdp_speed[False-True-False-False-True] 91.5000μs 35.9785μs 27.7944 KOps/s 27.9502 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-True-False-False-False] 76.3000μs 21.9000μs 45.6621 KOps/s 44.6338 KOps/s $\color{#35bf28}+2.30\%$
test_step_mdp_speed[False-False-True-True-True] 83.6000μs 48.7727μs 20.5033 KOps/s 20.2585 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[False-False-True-True-False] 76.9000μs 31.1696μs 32.0825 KOps/s 31.1637 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-False-True-False-True] 61.3000μs 35.7472μs 27.9742 KOps/s 28.1224 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[False-False-True-False-False] 70.8990μs 21.6685μs 46.1500 KOps/s 45.2999 KOps/s $\color{#35bf28}+1.88\%$
test_step_mdp_speed[False-False-False-True-True] 0.1084ms 50.2483μs 19.9012 KOps/s 19.7191 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-False-False-True-False] 58.2990μs 32.3746μs 30.8884 KOps/s 29.7775 KOps/s $\color{#35bf28}+3.73\%$
test_step_mdp_speed[False-False-False-False-True] 96.9000μs 37.3757μs 26.7553 KOps/s 26.8598 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-False-False-False-False] 92.8990μs 23.0633μs 43.3589 KOps/s 42.3902 KOps/s $\color{#35bf28}+2.29\%$
test_values[generalized_advantage_estimate-True-True] 15.0912ms 14.5300ms 68.8231 Ops/s 67.9325 Ops/s $\color{#35bf28}+1.31\%$
test_values[vec_generalized_advantage_estimate-True-True] 62.1697ms 52.3226ms 19.1122 Ops/s 18.8769 Ops/s $\color{#35bf28}+1.25\%$
test_values[td0_return_estimate-False-False] 1.3272ms 0.5260ms 1.9012 KOps/s 2.4751 KOps/s $\textbf{\color{#d91a1a}-23.19\%}$
test_values[td1_return_estimate-False-False] 15.3351ms 13.9550ms 71.6588 Ops/s 72.0877 Ops/s $\color{#d91a1a}-0.59\%$
test_values[vec_td1_return_estimate-False-False] 62.1848ms 53.1417ms 18.8176 Ops/s 18.7589 Ops/s $\color{#35bf28}+0.31\%$
test_values[td_lambda_return_estimate-True-False] 38.8986ms 33.0054ms 30.2980 Ops/s 29.9624 Ops/s $\color{#35bf28}+1.12\%$
test_values[vec_td_lambda_return_estimate-True-False] 66.5380ms 53.1048ms 18.8307 Ops/s 18.5080 Ops/s $\color{#35bf28}+1.74\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 12.4983ms 12.3086ms 81.2438 Ops/s 79.4038 Ops/s $\color{#35bf28}+2.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 9.0071ms 2.8077ms 356.1642 Ops/s 279.6983 Ops/s $\textbf{\color{#35bf28}+27.34\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7722ms 0.4862ms 2.0567 KOps/s 2.0067 KOps/s $\color{#35bf28}+2.49\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 64.7723ms 54.7745ms 18.2567 Ops/s 18.7833 Ops/s $\color{#d91a1a}-2.80\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.2754ms 4.2089ms 237.5931 Ops/s 236.6479 Ops/s $\color{#35bf28}+0.40\%$
test_dqn_speed 7.8937ms 2.3316ms 428.8884 Ops/s 426.4621 Ops/s $\color{#35bf28}+0.57\%$
test_ddpg_speed 9.9133ms 4.0223ms 248.6166 Ops/s 246.9591 Ops/s $\color{#35bf28}+0.67\%$
test_sac_speed 17.1499ms 11.1106ms 90.0041 Ops/s 90.1966 Ops/s $\color{#d91a1a}-0.21\%$
test_redq_speed 30.9786ms 22.3685ms 44.7057 Ops/s 55.7046 Ops/s $\textbf{\color{#d91a1a}-19.75\%}$
test_redq_deprec_speed 23.0573ms 16.8513ms 59.3426 Ops/s 53.3201 Ops/s $\textbf{\color{#35bf28}+11.29\%}$
test_td3_speed 13.2451ms 12.0703ms 82.8483 Ops/s 84.5472 Ops/s $\color{#d91a1a}-2.01\%$
test_cql_speed 50.2594ms 43.1888ms 23.1542 Ops/s 29.7207 Ops/s $\textbf{\color{#d91a1a}-22.09\%}$
test_a2c_speed 10.8519ms 7.4474ms 134.2753 Ops/s 147.4115 Ops/s $\textbf{\color{#d91a1a}-8.91\%}$
test_ppo_speed 13.2829ms 6.8857ms 145.2289 Ops/s 142.8680 Ops/s $\color{#35bf28}+1.65\%$
test_reinforce_speed 11.7629ms 5.8985ms 169.5335 Ops/s 173.0036 Ops/s $\color{#d91a1a}-2.01\%$
test_iql_speed 42.0400ms 34.5239ms 28.9654 Ops/s 35.4937 Ops/s $\textbf{\color{#d91a1a}-18.39\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3356ms 2.6058ms 383.7573 Ops/s 374.2122 Ops/s $\color{#35bf28}+2.55\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.7364ms 2.7646ms 361.7197 Ops/s 322.5845 Ops/s $\textbf{\color{#35bf28}+12.13\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.9842ms 2.7537ms 363.1446 Ops/s 360.1041 Ops/s $\color{#35bf28}+0.84\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7871ms 2.6982ms 370.6123 Ops/s 379.5813 Ops/s $\color{#d91a1a}-2.36\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.4442ms 2.7977ms 357.4340 Ops/s 358.8490 Ops/s $\color{#d91a1a}-0.39\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.7832ms 2.7783ms 359.9380 Ops/s 358.4861 Ops/s $\color{#35bf28}+0.40\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0280ms 2.6702ms 374.5011 Ops/s 375.3579 Ops/s $\color{#d91a1a}-0.23\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1195s 3.1200ms 320.5173 Ops/s 356.9503 Ops/s $\textbf{\color{#d91a1a}-10.21\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1160s 3.0664ms 326.1109 Ops/s 359.4297 Ops/s $\textbf{\color{#d91a1a}-9.27\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2235ms 2.6274ms 380.6037 Ops/s 375.5688 Ops/s $\color{#35bf28}+1.34\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1132s 3.0865ms 323.9870 Ops/s 361.0473 Ops/s $\textbf{\color{#d91a1a}-10.26\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.7361ms 2.7866ms 358.8605 Ops/s 354.3874 Ops/s $\color{#35bf28}+1.26\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.6491ms 2.6733ms 374.0676 Ops/s 375.5780 Ops/s $\color{#d91a1a}-0.40\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.2732ms 2.8058ms 356.4008 Ops/s 309.6259 Ops/s $\textbf{\color{#35bf28}+15.11\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 5.0856ms 2.8519ms 350.6452 Ops/s 360.6479 Ops/s $\color{#d91a1a}-2.77\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5191ms 2.7407ms 364.8643 Ops/s 372.8733 Ops/s $\color{#d91a1a}-2.15\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.2714ms 2.8126ms 355.5429 Ops/s 355.7380 Ops/s $\color{#d91a1a}-0.05\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.5133ms 2.8169ms 355.0022 Ops/s 358.9931 Ops/s $\color{#d91a1a}-1.11\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2211s 26.9577ms 37.0951 Ops/s 35.7262 Ops/s $\color{#35bf28}+3.83\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1188s 26.4444ms 37.8151 Ops/s 41.3449 Ops/s $\textbf{\color{#d91a1a}-8.54\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1202s 24.5096ms 40.8004 Ops/s 37.8445 Ops/s $\textbf{\color{#35bf28}+7.81\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1233s 26.9048ms 37.1681 Ops/s 41.1843 Ops/s $\textbf{\color{#d91a1a}-9.75\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1182s 24.4558ms 40.8901 Ops/s 37.5713 Ops/s $\textbf{\color{#35bf28}+8.83\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1226s 26.6211ms 37.5641 Ops/s 41.1757 Ops/s $\textbf{\color{#d91a1a}-8.77\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1240s 24.8327ms 40.2694 Ops/s 38.0041 Ops/s $\textbf{\color{#35bf28}+5.96\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1241s 26.8134ms 37.2948 Ops/s 41.0003 Ops/s $\textbf{\color{#d91a1a}-9.04\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1238s 26.9171ms 37.1512 Ops/s 37.6454 Ops/s $\color{#d91a1a}-1.31\%$

vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[Versioning] Write version all cases in setup.py (pytorch#1579)
2d5720e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. versioning Versioning change (version number etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot