Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Missing lint #1556

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[Minor] Missing lint #1556

merged 3 commits into from
Sep 20, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 20, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
@vmoens vmoens marked this pull request as ready for review September 20, 2023 15:05
@vmoens
Merge remote-tracking branch 'origin/main' into spec_unbind
02589ca 
# Conflicts:
#	torchrl/data/tensor_specs.py
@vmoens vmoens merged commit 57f1220 into main Sep 20, 2023
@vmoens vmoens deleted the spec_unbind branch September 20, 2023 15:06
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}9$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 65.5067ms 65.0330ms 15.3768 Ops/s 15.2759 Ops/s $\color{#35bf28}+0.66\%$
test_sync 0.1041s 37.7555ms 26.4862 Ops/s 23.6730 Ops/s $\textbf{\color{#35bf28}+11.88\%}$
test_async 69.1141ms 34.7460ms 28.7803 Ops/s 29.1734 Ops/s $\color{#d91a1a}-1.35\%$
test_simple 0.5870s 0.5353s 1.8681 Ops/s 1.8918 Ops/s $\color{#d91a1a}-1.25\%$
test_transformed 0.7433s 0.7012s 1.4261 Ops/s 1.4079 Ops/s $\color{#35bf28}+1.30\%$
test_serial 1.5855s 1.5363s 0.6509 Ops/s 0.6459 Ops/s $\color{#35bf28}+0.78\%$
test_parallel 1.4231s 1.3696s 0.7301 Ops/s 0.7334 Ops/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[True-True-True-True-True] 0.3824ms 41.2382μs 24.2493 KOps/s 24.2563 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-True-True-True-False] 0.1311ms 23.5325μs 42.4944 KOps/s 41.8966 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[True-True-True-False-True] 51.0000μs 28.9678μs 34.5211 KOps/s 34.4287 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-True-True-False-False] 38.7990μs 16.1701μs 61.8424 KOps/s 60.7638 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[True-True-False-True-True] 93.3990μs 42.9645μs 23.2750 KOps/s 23.4894 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-True-False-True-False] 49.1990μs 25.2894μs 39.5423 KOps/s 39.3209 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[True-True-False-False-True] 83.5000μs 31.1626μs 32.0898 KOps/s 32.4948 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-True-False-False-False] 34.1000μs 18.2313μs 54.8507 KOps/s 54.7550 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[True-False-True-True-True] 0.1551ms 45.2343μs 22.1071 KOps/s 22.3235 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-False-True-True-False] 55.0000μs 27.2551μs 36.6904 KOps/s 36.7428 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-False-True-False-True] 72.2000μs 30.9579μs 32.3020 KOps/s 32.3313 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-False-True-False-False] 77.3990μs 18.0488μs 55.4053 KOps/s 54.9245 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[True-False-False-True-True] 84.2000μs 46.4072μs 21.5484 KOps/s 21.5931 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[True-False-False-True-False] 66.9000μs 28.5137μs 35.0708 KOps/s 34.9870 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[True-False-False-False-True] 55.2000μs 31.9919μs 31.2579 KOps/s 30.7219 KOps/s $\color{#35bf28}+1.74\%$
test_step_mdp_speed[True-False-False-False-False] 61.5000μs 19.6507μs 50.8888 KOps/s 50.4752 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[False-True-True-True-True] 73.6000μs 44.8866μs 22.2784 KOps/s 21.9955 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[False-True-True-True-False] 52.3990μs 27.0798μs 36.9278 KOps/s 36.8302 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[False-True-True-False-True] 58.1990μs 33.4768μs 29.8714 KOps/s 29.7565 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-True-True-False-False] 2.8175ms 19.9127μs 50.2191 KOps/s 49.4641 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[False-True-False-True-True] 69.7990μs 46.1708μs 21.6587 KOps/s 21.7141 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-False-True-False] 79.2990μs 28.8263μs 34.6906 KOps/s 34.7240 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[False-True-False-False-True] 60.7000μs 34.9711μs 28.5951 KOps/s 28.4289 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-False-False-False] 0.1291ms 21.3857μs 46.7602 KOps/s 45.8048 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[False-False-True-True-True] 77.7000μs 47.8579μs 20.8952 KOps/s 20.8484 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-False-True-True-False] 73.9000μs 30.7869μs 32.4814 KOps/s 32.2836 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[False-False-True-False-True] 59.3000μs 34.9570μs 28.6066 KOps/s 28.3431 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-False-True-False-False] 52.1000μs 21.2148μs 47.1368 KOps/s 46.3900 KOps/s $\color{#35bf28}+1.61\%$
test_step_mdp_speed[False-False-False-True-True] 73.9990μs 49.2317μs 20.3121 KOps/s 20.3323 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[False-False-False-True-False] 80.7000μs 31.6822μs 31.5634 KOps/s 30.9333 KOps/s $\color{#35bf28}+2.04\%$
test_step_mdp_speed[False-False-False-False-True] 60.6990μs 36.3880μs 27.4816 KOps/s 27.3792 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[False-False-False-False-False] 67.3000μs 22.6956μs 44.0613 KOps/s 43.7315 KOps/s $\color{#35bf28}+0.75\%$
test_values[generalized_advantage_estimate-True-True] 14.0508ms 13.6224ms 73.4085 Ops/s 73.5177 Ops/s $\color{#d91a1a}-0.15\%$
test_values[vec_generalized_advantage_estimate-True-True] 55.5045ms 50.9111ms 19.6421 Ops/s 19.4531 Ops/s $\color{#35bf28}+0.97\%$
test_values[td0_return_estimate-False-False] 0.3093ms 0.1961ms 5.0982 KOps/s 5.3390 KOps/s $\color{#d91a1a}-4.51\%$
test_values[td1_return_estimate-False-False] 15.2733ms 13.5000ms 74.0743 Ops/s 75.2911 Ops/s $\color{#d91a1a}-1.62\%$
test_values[vec_td1_return_estimate-False-False] 60.3912ms 51.0261ms 19.5978 Ops/s 19.5683 Ops/s $\color{#35bf28}+0.15\%$
test_values[td_lambda_return_estimate-True-False] 32.7292ms 32.1113ms 31.1417 Ops/s 31.0898 Ops/s $\color{#35bf28}+0.17\%$
test_values[vec_td_lambda_return_estimate-True-False] 55.0484ms 50.3739ms 19.8515 Ops/s 19.5551 Ops/s $\color{#35bf28}+1.52\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 13.1722ms 12.1272ms 82.4591 Ops/s 82.7969 Ops/s $\color{#d91a1a}-0.41\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 7.1913ms 2.4137ms 414.2981 Ops/s 421.3791 Ops/s $\color{#d91a1a}-1.68\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6393ms 0.4159ms 2.4047 KOps/s 2.4321 KOps/s $\color{#d91a1a}-1.13\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 52.1893ms 51.6068ms 19.3773 Ops/s 18.8417 Ops/s $\color{#35bf28}+2.84\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 5.0153ms 3.8037ms 262.8985 Ops/s 263.5794 Ops/s $\color{#d91a1a}-0.26\%$
test_dqn_speed 6.8405ms 1.7872ms 559.5272 Ops/s 576.3917 Ops/s $\color{#d91a1a}-2.93\%$
test_ddpg_speed 7.5338ms 2.5069ms 398.8944 Ops/s 407.1542 Ops/s $\color{#d91a1a}-2.03\%$
test_sac_speed 13.0933ms 8.0577ms 124.1053 Ops/s 125.7422 Ops/s $\color{#d91a1a}-1.30\%$
test_redq_speed 20.3691ms 15.0151ms 66.5997 Ops/s 67.3600 Ops/s $\color{#d91a1a}-1.13\%$
test_redq_deprec_speed 17.2569ms 12.5845ms 79.4630 Ops/s 80.1831 Ops/s $\color{#d91a1a}-0.90\%$
test_td3_speed 13.1637ms 9.8096ms 101.9407 Ops/s 102.8714 Ops/s $\color{#d91a1a}-0.90\%$
test_cql_speed 26.7963ms 25.5438ms 39.1484 Ops/s 31.6840 Ops/s $\textbf{\color{#35bf28}+23.56\%}$
test_a2c_speed 10.3850ms 5.3622ms 186.4915 Ops/s 184.5663 Ops/s $\color{#35bf28}+1.04\%$
test_ppo_speed 10.8368ms 5.6589ms 176.7143 Ops/s 174.2590 Ops/s $\color{#35bf28}+1.41\%$
test_reinforce_speed 9.0879ms 4.1475ms 241.1104 Ops/s 239.5801 Ops/s $\color{#35bf28}+0.64\%$
test_iql_speed 28.2843ms 21.3771ms 46.7790 Ops/s 42.1031 Ops/s $\textbf{\color{#35bf28}+11.11\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1503ms 2.4571ms 406.9898 Ops/s 369.8302 Ops/s $\textbf{\color{#35bf28}+10.05\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 3.8037ms 2.6167ms 382.1546 Ops/s 368.7233 Ops/s $\color{#35bf28}+3.64\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.2166ms 2.6145ms 382.4781 Ops/s 378.2905 Ops/s $\color{#35bf28}+1.11\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6595ms 2.4601ms 406.4805 Ops/s 385.5827 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.7442ms 2.6116ms 382.9140 Ops/s 378.4735 Ops/s $\color{#35bf28}+1.17\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5269ms 2.5875ms 386.4725 Ops/s 376.9409 Ops/s $\color{#35bf28}+2.53\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2169ms 2.4593ms 406.6209 Ops/s 393.8957 Ops/s $\color{#35bf28}+3.23\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.2568ms 2.5664ms 389.6569 Ops/s 381.8642 Ops/s $\color{#35bf28}+2.04\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.2993ms 2.5863ms 386.6572 Ops/s 384.4681 Ops/s $\color{#35bf28}+0.57\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1824ms 2.4196ms 413.2867 Ops/s 409.3925 Ops/s $\color{#35bf28}+0.95\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.0016ms 2.5716ms 388.8603 Ops/s 370.8788 Ops/s $\color{#35bf28}+4.85\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.1329ms 2.5485ms 392.3919 Ops/s 383.0687 Ops/s $\color{#35bf28}+2.43\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3211ms 2.5416ms 393.4496 Ops/s 406.0174 Ops/s $\color{#d91a1a}-3.10\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 4.2353ms 2.6766ms 373.6123 Ops/s 380.0231 Ops/s $\color{#d91a1a}-1.69\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.3451ms 2.5863ms 386.6542 Ops/s 383.7625 Ops/s $\color{#35bf28}+0.75\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6458ms 2.4037ms 416.0216 Ops/s 339.8150 Ops/s $\textbf{\color{#35bf28}+22.43\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.7888ms 2.5946ms 385.4121 Ops/s 380.1704 Ops/s $\color{#35bf28}+1.38\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.3618ms 2.5673ms 389.5156 Ops/s 381.8014 Ops/s $\color{#35bf28}+2.02\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1991s 25.5359ms 39.1606 Ops/s 35.8785 Ops/s $\textbf{\color{#35bf28}+9.15\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1110s 25.4676ms 39.2657 Ops/s 41.9170 Ops/s $\textbf{\color{#d91a1a}-6.33\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1131s 23.5613ms 42.4425 Ops/s 38.9450 Ops/s $\textbf{\color{#35bf28}+8.98\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1084s 25.2501ms 39.6038 Ops/s 41.5778 Ops/s $\color{#d91a1a}-4.75\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1111s 23.5486ms 42.4654 Ops/s 41.9486 Ops/s $\color{#35bf28}+1.23\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1134s 25.5017ms 39.2131 Ops/s 42.1133 Ops/s $\textbf{\color{#d91a1a}-6.89\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1109s 23.5277ms 42.5031 Ops/s 39.2483 Ops/s $\textbf{\color{#35bf28}+8.29\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1100s 25.3363ms 39.4691 Ops/s 42.2218 Ops/s $\textbf{\color{#d91a1a}-6.52\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1074s 25.1886ms 39.7004 Ops/s 38.9115 Ops/s $\color{#35bf28}+2.03\%$

vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[Minor] Missing lint (pytorch#1556)
4470fc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot