Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] Filter out warnings in subprocs #1552

Merged
merged 6 commits into from
Sep 20, 2023
Merged

[Quality] Filter out warnings in subprocs #1552

merged 6 commits into from
Sep 20, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 20, 2023 •
edited
Loading

Don't thank me, a beer will do
Depends on #1551

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
@vmoens vmoens added the quality code quality label Sep 20, 2023
@vmoens vmoens changed the title [Minor] Filter out warnings in subprocs [Quality] Filter out warnings in subprocs Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}13$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 76.1173ms 75.5811ms 13.2308 Ops/s 12.6968 Ops/s $\color{#35bf28}+4.21\%$
test_sync 0.1203s 44.2523ms 22.5977 Ops/s 21.5545 Ops/s $\color{#35bf28}+4.84\%$
test_async 72.2885ms 40.3008ms 24.8134 Ops/s 24.2468 Ops/s $\color{#35bf28}+2.34\%$
test_simple 0.7200s 0.6431s 1.5549 Ops/s 1.5718 Ops/s $\color{#d91a1a}-1.07\%$
test_transformed 0.8755s 0.8295s 1.2056 Ops/s 1.1747 Ops/s $\color{#35bf28}+2.63\%$
test_serial 1.8498s 1.7941s 0.5574 Ops/s 0.5410 Ops/s $\color{#35bf28}+3.03\%$
test_parallel 1.5342s 1.4903s 0.6710 Ops/s 0.6458 Ops/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[True-True-True-True-True] 0.1882ms 44.1539μs 22.6481 KOps/s 22.3635 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[True-True-True-True-False] 0.2536ms 25.0353μs 39.9437 KOps/s 40.1171 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-True-True-False-True] 51.6010μs 31.4242μs 31.8226 KOps/s 31.8472 KOps/s $\color{#d91a1a}-0.08\%$
test_step_mdp_speed[True-True-True-False-False] 72.1010μs 17.3974μs 57.4799 KOps/s 56.9929 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-True-False-True-True] 0.1058ms 45.8426μs 21.8138 KOps/s 21.7746 KOps/s $\color{#35bf28}+0.18\%$
test_step_mdp_speed[True-True-False-True-False] 0.2461ms 26.7955μs 37.3196 KOps/s 37.2053 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[True-True-False-False-True] 0.1259ms 33.1473μs 30.1684 KOps/s 29.5520 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[True-True-False-False-False] 41.6000μs 19.3857μs 51.5845 KOps/s 51.9335 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[True-False-True-True-True] 0.1460ms 48.0189μs 20.8251 KOps/s 20.9002 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[True-False-True-True-False] 0.1059ms 28.9417μs 34.5522 KOps/s 34.8610 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[True-False-True-False-True] 90.9010μs 33.4060μs 29.9347 KOps/s 29.1861 KOps/s $\color{#35bf28}+2.57\%$
test_step_mdp_speed[True-False-True-False-False] 91.3020μs 19.6321μs 50.9370 KOps/s 51.5938 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[True-False-False-True-True] 79.9010μs 49.4675μs 20.2153 KOps/s 20.2011 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[True-False-False-True-False] 0.1828ms 30.6563μs 32.6198 KOps/s 32.8628 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[True-False-False-False-True] 0.1142ms 34.9064μs 28.6480 KOps/s 28.9501 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-False-False-False] 0.1289ms 21.1453μs 47.2919 KOps/s 47.9557 KOps/s $\color{#d91a1a}-1.38\%$
test_step_mdp_speed[False-True-True-True-True] 78.4010μs 47.9789μs 20.8425 KOps/s 21.0706 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-True-True-False] 93.9010μs 28.6115μs 34.9510 KOps/s 34.9507 KOps/s $+0.00\%$
test_step_mdp_speed[False-True-True-False-True] 0.1271ms 37.0524μs 26.9888 KOps/s 27.0086 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-True-True-False-False] 3.5382ms 21.5948μs 46.3074 KOps/s 46.0298 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[False-True-False-True-True] 0.1477ms 49.5926μs 20.1643 KOps/s 20.3817 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[False-True-False-True-False] 66.2010μs 30.5279μs 32.7569 KOps/s 32.8246 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[False-True-False-False-True] 0.1328ms 38.4741μs 25.9915 KOps/s 25.8626 KOps/s $\color{#35bf28}+0.50\%$
test_step_mdp_speed[False-True-False-False-False] 1.5760ms 23.4058μs 42.7245 KOps/s 42.8451 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-False-True-True-True] 0.1754ms 51.9667μs 19.2431 KOps/s 19.5843 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[False-False-True-True-False] 83.4010μs 32.3653μs 30.8973 KOps/s 30.8644 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[False-False-True-False-True] 90.2010μs 38.9992μs 25.6416 KOps/s 25.7116 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[False-False-True-False-False] 61.4000μs 22.9862μs 43.5044 KOps/s 43.5837 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[False-False-False-True-True] 0.1857ms 53.1477μs 18.8155 KOps/s 19.3894 KOps/s $\color{#d91a1a}-2.96\%$
test_step_mdp_speed[False-False-False-True-False] 60.3010μs 33.6362μs 29.7299 KOps/s 29.8170 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-False-False-False-True] 0.1897ms 39.3812μs 25.3928 KOps/s 25.1733 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-False-False-False-False] 0.1365ms 24.5453μs 40.7410 KOps/s 40.6566 KOps/s $\color{#35bf28}+0.21\%$
test_values[generalized_advantage_estimate-True-True] 15.0508ms 13.7584ms 72.6828 Ops/s 70.9169 Ops/s $\color{#35bf28}+2.49\%$
test_values[vec_generalized_advantage_estimate-True-True] 47.2538ms 41.7126ms 23.9736 Ops/s 23.0776 Ops/s $\color{#35bf28}+3.88\%$
test_values[td0_return_estimate-False-False] 0.5232ms 0.2442ms 4.0952 KOps/s 3.2314 KOps/s $\textbf{\color{#35bf28}+26.73\%}$
test_values[td1_return_estimate-False-False] 13.6815ms 13.3344ms 74.9939 Ops/s 73.2648 Ops/s $\color{#35bf28}+2.36\%$
test_values[vec_td1_return_estimate-False-False] 48.4044ms 42.1144ms 23.7449 Ops/s 23.2392 Ops/s $\color{#35bf28}+2.18\%$
test_values[td_lambda_return_estimate-True-False] 32.5412ms 32.2052ms 31.0509 Ops/s 31.0598 Ops/s $\color{#d91a1a}-0.03\%$
test_values[vec_td_lambda_return_estimate-True-False] 60.3932ms 41.9838ms 23.8187 Ops/s 22.3257 Ops/s $\textbf{\color{#35bf28}+6.69\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 13.7931ms 11.9305ms 83.8185 Ops/s 83.8174 Ops/s $+0.00\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 3.8276ms 3.4601ms 289.0061 Ops/s 283.5985 Ops/s $\color{#35bf28}+1.91\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7293ms 0.4706ms 2.1247 KOps/s 1.9640 KOps/s $\textbf{\color{#35bf28}+8.18\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 60.5225ms 56.0719ms 17.8342 Ops/s 16.5414 Ops/s $\textbf{\color{#35bf28}+7.82\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 9.8457ms 3.0725ms 325.4657 Ops/s 326.0551 Ops/s $\color{#d91a1a}-0.18\%$
test_dqn_speed 5.7434ms 1.9071ms 524.3589 Ops/s 504.5014 Ops/s $\color{#35bf28}+3.94\%$
test_ddpg_speed 9.0596ms 2.7922ms 358.1457 Ops/s 349.0622 Ops/s $\color{#35bf28}+2.60\%$
test_sac_speed 17.9460ms 9.1544ms 109.2369 Ops/s 111.0083 Ops/s $\color{#d91a1a}-1.60\%$
test_redq_speed 19.7766ms 16.9907ms 58.8558 Ops/s 58.0045 Ops/s $\color{#35bf28}+1.47\%$
test_redq_deprec_speed 20.4973ms 13.7114ms 72.9318 Ops/s 69.1479 Ops/s $\textbf{\color{#35bf28}+5.47\%}$
test_td3_speed 12.6884ms 10.9849ms 91.0340 Ops/s 88.6846 Ops/s $\color{#35bf28}+2.65\%$
test_cql_speed 34.1337ms 29.2801ms 34.1529 Ops/s 27.6068 Ops/s $\textbf{\color{#35bf28}+23.71\%}$
test_a2c_speed 11.6211ms 5.6576ms 176.7526 Ops/s 169.0270 Ops/s $\color{#35bf28}+4.57\%$
test_ppo_speed 12.3067ms 5.8381ms 171.2897 Ops/s 166.6778 Ops/s $\color{#35bf28}+2.77\%$
test_reinforce_speed 11.2330ms 4.2855ms 233.3445 Ops/s 216.8997 Ops/s $\textbf{\color{#35bf28}+7.58\%}$
test_iql_speed 31.3142ms 21.8105ms 45.8496 Ops/s 41.5568 Ops/s $\textbf{\color{#35bf28}+10.33\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.2224ms 2.8074ms 356.2043 Ops/s 355.8469 Ops/s $\color{#35bf28}+0.10\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.7371ms 2.8382ms 352.3373 Ops/s 338.4376 Ops/s $\color{#35bf28}+4.11\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.6421ms 2.9290ms 341.4086 Ops/s 348.7488 Ops/s $\color{#d91a1a}-2.10\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9304ms 2.7232ms 367.2105 Ops/s 364.8423 Ops/s $\color{#35bf28}+0.65\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.5184ms 2.8995ms 344.8863 Ops/s 346.5824 Ops/s $\color{#d91a1a}-0.49\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 5.2832ms 2.9115ms 343.4635 Ops/s 347.3766 Ops/s $\color{#d91a1a}-1.13\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8022ms 2.7889ms 358.5656 Ops/s 365.8605 Ops/s $\color{#d91a1a}-1.99\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 5.3763ms 2.9486ms 339.1425 Ops/s 346.3249 Ops/s $\color{#d91a1a}-2.07\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.0783ms 2.9061ms 344.1077 Ops/s 339.9464 Ops/s $\color{#35bf28}+1.22\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2922ms 2.7289ms 366.4502 Ops/s 362.7926 Ops/s $\color{#35bf28}+1.01\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.5286ms 2.9050ms 344.2380 Ops/s 344.7840 Ops/s $\color{#d91a1a}-0.16\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.6985ms 2.8947ms 345.4567 Ops/s 300.4377 Ops/s $\textbf{\color{#35bf28}+14.98\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3911ms 2.6827ms 372.7609 Ops/s 363.6680 Ops/s $\color{#35bf28}+2.50\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.4547ms 2.8600ms 349.6497 Ops/s 347.0908 Ops/s $\color{#35bf28}+0.74\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 5.1009ms 2.9408ms 340.0387 Ops/s 339.1063 Ops/s $\color{#35bf28}+0.27\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6534ms 2.7954ms 357.7274 Ops/s 359.9012 Ops/s $\color{#d91a1a}-0.60\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.3074ms 2.8836ms 346.7872 Ops/s 340.9956 Ops/s $\color{#35bf28}+1.70\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8560ms 2.8969ms 345.1951 Ops/s 286.0862 Ops/s $\textbf{\color{#35bf28}+20.66\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2852s 30.3255ms 32.9756 Ops/s 33.4031 Ops/s $\color{#d91a1a}-1.28\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1455s 29.5237ms 33.8710 Ops/s 39.6010 Ops/s $\textbf{\color{#d91a1a}-14.47\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1429s 26.7106ms 37.4383 Ops/s 33.0206 Ops/s $\textbf{\color{#35bf28}+13.38\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1559s 29.9381ms 33.4022 Ops/s 35.8705 Ops/s $\textbf{\color{#d91a1a}-6.88\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1484s 27.1290ms 36.8609 Ops/s 32.8830 Ops/s $\textbf{\color{#35bf28}+12.10\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1499s 29.9643ms 33.3731 Ops/s 35.6525 Ops/s $\textbf{\color{#d91a1a}-6.39\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1498s 27.2787ms 36.6587 Ops/s 32.3143 Ops/s $\textbf{\color{#35bf28}+13.44\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1526s 30.1585ms 33.1582 Ops/s 32.8001 Ops/s $\color{#35bf28}+1.09\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1538s 30.2408ms 33.0680 Ops/s 36.5642 Ops/s $\textbf{\color{#d91a1a}-9.56\%}$

matteobettini
matteobettini reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less goo

@vmoens vmoens merged commit 1301d6c into main Sep 20, 2023
@vmoens vmoens deleted the fix_warnings_subproc branch September 20, 2023 14:45
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[Quality] Filter out warnings in subprocs (pytorch#1552)
16bb91c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobettini matteobettini matteobettini approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @matteobettini @facebook-github-bot