Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Remove import of test class #1549

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[Test] Remove import of test class #1549

merged 2 commits into from
Sep 20, 2023

Conversation

matteobettini
Copy link
Contributor

This PR removes the import of test_env from the test_collector file

@matteobettini
amend
14e318a 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
vmoens
vmoens reviewed Sep 20, 2023
View reviewed changes
test/test_collector.py Outdated Show resolved Hide resolved
@matteobettini
amend
7d3cb16 
Signed-off-by: Matteo Bettini <matbet@meta.com>
vmoens
vmoens approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@vmoens vmoens added the Tests Incomplete or broken unit tests label Sep 20, 2023
@vmoens vmoens merged commit f13cd77 into pytorch:main Sep 20, 2023
@matteobettini matteobettini deleted the fix_test_collector branch September 20, 2023 10:52
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@matteobettini @vmoens
[Test] Remove import of test class (pytorch#1549)
cab3324 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot