[Algorithm] Update DQN example #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…te_dqn_example # Conflicts: # examples/dqn/dqn_carpole.py
Update dqn example
vmoens
approved these changes
Sep 15, 2023
examples/dqn/dqn_carpole.py
Outdated
| @@ -0,0 +1,171 @@ | |||
| """ | |||
| DQN Benchmarks: CartPole-v1 | |||
There was a problem hiding this comment.
Benchmarks in the repo is intended for runtime benchmark.
I would call this evaluation. At the end of the day, I think that what we will want is the following directory tree:
torchrl/
├── benchmarks/
│ ├── component_x/
│ │ ├── benchmark_workflow_1/
│ │ ├── benchmark_workflow_2/
│ │ └── ...
│ ├── algorithm_y/
│ │ ├── benchmark_workflow_1/
│ │ ├── benchmark_workflow_2/
│ │ └── ...
│ └── ...
├── evaluation/
│ ├── component_x/
│ │ ├── evaluation_metrics_1/
│ │ ├── evaluation_metrics_2/
│ │ └── ...
│ ├── algorithm_y/
│ │ ├── evaluation_metrics_1/
│ │ ├── evaluation_metrics_2/
│ │ └── ...
│ └── ...
└── ...
…into update_dqn_example
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1512
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (9 Unrelated Failures)As of commit 97e7aa5 with merge base 25bd8a5 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@albertbou92 the example CI is failing bc we did not update the runs there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reproduce known DQN benchmarks.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!