Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup] Update setup.py python versions #1496

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[Setup] Update setup.py python versions #1496

merged 2 commits into from
Sep 6, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 6, 2023 •
edited
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2023
matteobettini
matteobettini approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens added the versioning Versioning change (version number etc) label Sep 6, 2023
@vmoens vmoens marked this pull request as ready for review September 6, 2023 10:45
@vmoens vmoens merged commit d729f3d into main Sep 6, 2023
@vmoens vmoens deleted the python_versions_doc branch September 6, 2023 10:45
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1631s 0.1628s 6.1417 Ops/s 6.1063 Ops/s $\color{#35bf28}+0.58\%$
test_sync 0.1896s 0.1011s 9.8873 Ops/s 10.6742 Ops/s $\textbf{\color{#d91a1a}-7.37\%}$
test_async 0.2427s 88.4197ms 11.3097 Ops/s 10.7112 Ops/s $\textbf{\color{#35bf28}+5.59\%}$
test_simple 0.8182s 0.7343s 1.3618 Ops/s 1.3344 Ops/s $\color{#35bf28}+2.06\%$
test_transformed 1.9896s 1.9361s 0.5165 Ops/s 0.5186 Ops/s $\color{#d91a1a}-0.40\%$
test_serial 2.0923s 2.0229s 0.4944 Ops/s 0.4841 Ops/s $\color{#35bf28}+2.12\%$
test_parallel 1.9864s 1.8549s 0.5391 Ops/s 0.5316 Ops/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[True-True-True-True-True] 7.2291ms 57.8972μs 17.2720 KOps/s 18.5767 KOps/s $\textbf{\color{#d91a1a}-7.02\%}$
test_step_mdp_speed[True-True-True-True-False] 2.6877ms 32.2899μs 30.9694 KOps/s 32.6679 KOps/s $\textbf{\color{#d91a1a}-5.20\%}$
test_step_mdp_speed[True-True-True-False-True] 3.1863ms 38.4675μs 25.9959 KOps/s 26.4347 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-True-True-False-False] 1.5003ms 21.8251μs 45.8187 KOps/s 48.2732 KOps/s $\textbf{\color{#d91a1a}-5.08\%}$
test_step_mdp_speed[True-True-False-True-True] 0.1096ms 53.6422μs 18.6420 KOps/s 17.7851 KOps/s $\color{#35bf28}+4.82\%$
test_step_mdp_speed[True-True-False-True-False] 60.4040μs 31.5175μs 31.7284 KOps/s 30.6751 KOps/s $\color{#35bf28}+3.43\%$
test_step_mdp_speed[True-True-False-False-True] 80.0040μs 38.0987μs 26.2476 KOps/s 24.6844 KOps/s $\textbf{\color{#35bf28}+6.33\%}$
test_step_mdp_speed[True-True-False-False-False] 61.9040μs 22.7419μs 43.9717 KOps/s 42.9646 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-False-True-True-True] 85.2050μs 55.5060μs 18.0161 KOps/s 17.0979 KOps/s $\textbf{\color{#35bf28}+5.37\%}$
test_step_mdp_speed[True-False-True-True-False] 1.7247ms 34.7161μs 28.8051 KOps/s 28.0815 KOps/s $\color{#35bf28}+2.58\%$
test_step_mdp_speed[True-False-True-False-True] 72.0040μs 38.0771μs 26.2625 KOps/s 24.9314 KOps/s $\textbf{\color{#35bf28}+5.34\%}$
test_step_mdp_speed[True-False-True-False-False] 68.4040μs 22.2561μs 44.9314 KOps/s 42.4366 KOps/s $\textbf{\color{#35bf28}+5.88\%}$
test_step_mdp_speed[True-False-False-True-True] 78.2050μs 57.6148μs 17.3566 KOps/s 16.7508 KOps/s $\color{#35bf28}+3.62\%$
test_step_mdp_speed[True-False-False-True-False] 71.3040μs 35.3228μs 28.3104 KOps/s 26.7682 KOps/s $\textbf{\color{#35bf28}+5.76\%}$
test_step_mdp_speed[True-False-False-False-True] 0.1085ms 39.8498μs 25.0942 KOps/s 23.7224 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_step_mdp_speed[True-False-False-False-False] 48.3030μs 24.1712μs 41.3715 KOps/s 39.0780 KOps/s $\textbf{\color{#35bf28}+5.87\%}$
test_step_mdp_speed[False-True-True-True-True] 0.2088ms 56.0727μs 17.8340 KOps/s 17.0859 KOps/s $\color{#35bf28}+4.38\%$
test_step_mdp_speed[False-True-True-True-False] 0.1031ms 33.4719μs 29.8758 KOps/s 28.6683 KOps/s $\color{#35bf28}+4.21\%$
test_step_mdp_speed[False-True-True-False-True] 97.0050μs 42.8409μs 23.3422 KOps/s 22.4680 KOps/s $\color{#35bf28}+3.89\%$
test_step_mdp_speed[False-True-True-False-False] 3.3735ms 24.9238μs 40.1223 KOps/s 38.1239 KOps/s $\textbf{\color{#35bf28}+5.24\%}$
test_step_mdp_speed[False-True-False-True-True] 0.1137ms 57.8423μs 17.2884 KOps/s 16.6092 KOps/s $\color{#35bf28}+4.09\%$
test_step_mdp_speed[False-True-False-True-False] 70.7040μs 35.5852μs 28.1015 KOps/s 27.0981 KOps/s $\color{#35bf28}+3.70\%$
test_step_mdp_speed[False-True-False-False-True] 0.1621ms 45.1455μs 22.1506 KOps/s 21.5620 KOps/s $\color{#35bf28}+2.73\%$
test_step_mdp_speed[False-True-False-False-False] 88.1050μs 26.6247μs 37.5591 KOps/s 32.9581 KOps/s $\textbf{\color{#35bf28}+13.96\%}$
test_step_mdp_speed[False-False-True-True-True] 0.1192ms 59.8525μs 16.7077 KOps/s 13.7207 KOps/s $\textbf{\color{#35bf28}+21.77\%}$
test_step_mdp_speed[False-False-True-True-False] 92.3060μs 38.0077μs 26.3104 KOps/s 23.6459 KOps/s $\textbf{\color{#35bf28}+11.27\%}$
test_step_mdp_speed[False-False-True-False-True] 0.1185ms 44.5742μs 22.4345 KOps/s 21.3796 KOps/s $\color{#35bf28}+4.93\%$
test_step_mdp_speed[False-False-True-False-False] 65.8040μs 26.9906μs 37.0500 KOps/s 35.8887 KOps/s $\color{#35bf28}+3.24\%$
test_step_mdp_speed[False-False-False-True-True] 99.5060μs 61.1791μs 16.3455 KOps/s 15.7577 KOps/s $\color{#35bf28}+3.73\%$
test_step_mdp_speed[False-False-False-True-False] 76.1040μs 39.8558μs 25.0904 KOps/s 24.1696 KOps/s $\color{#35bf28}+3.81\%$
test_step_mdp_speed[False-False-False-False-True] 80.0050μs 45.9600μs 21.7581 KOps/s 21.0354 KOps/s $\color{#35bf28}+3.44\%$
test_step_mdp_speed[False-False-False-False-False] 0.1082ms 28.6209μs 34.9395 KOps/s 33.6010 KOps/s $\color{#35bf28}+3.98\%$
test_values[generalized_advantage_estimate-True-True] 16.1880ms 15.0494ms 66.4479 Ops/s 64.6102 Ops/s $\color{#35bf28}+2.84\%$
test_values[vec_generalized_advantage_estimate-True-True] 68.2130ms 54.0268ms 18.5093 Ops/s 19.3189 Ops/s $\color{#d91a1a}-4.19\%$
test_values[td0_return_estimate-False-False] 0.4366ms 0.2948ms 3.3926 KOps/s 3.2930 KOps/s $\color{#35bf28}+3.02\%$
test_values[td1_return_estimate-False-False] 14.8628ms 14.7242ms 67.9155 Ops/s 66.4250 Ops/s $\color{#35bf28}+2.24\%$
test_values[vec_td1_return_estimate-False-False] 67.3347ms 53.0175ms 18.8617 Ops/s 19.7149 Ops/s $\color{#d91a1a}-4.33\%$
test_values[td_lambda_return_estimate-True-False] 38.4224ms 34.8562ms 28.6893 Ops/s 27.7140 Ops/s $\color{#35bf28}+3.52\%$
test_values[vec_td_lambda_return_estimate-True-False] 65.0788ms 54.0056ms 18.5166 Ops/s 19.9369 Ops/s $\textbf{\color{#d91a1a}-7.12\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 13.3810ms 12.9727ms 77.0848 Ops/s 74.6090 Ops/s $\color{#35bf28}+3.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 15.1785ms 4.2083ms 237.6269 Ops/s 216.6195 Ops/s $\textbf{\color{#35bf28}+9.70\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 8.4901ms 0.6419ms 1.5579 KOps/s 1.6669 KOps/s $\textbf{\color{#d91a1a}-6.54\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 74.1228ms 68.6663ms 14.5632 Ops/s 15.8683 Ops/s $\textbf{\color{#d91a1a}-8.22\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2528ms 3.6136ms 276.7351 Ops/s 268.7596 Ops/s $\color{#35bf28}+2.97\%$
test_dqn_speed 10.4848ms 2.3059ms 433.6647 Ops/s 377.2584 Ops/s $\textbf{\color{#35bf28}+14.95\%}$
test_ddpg_speed 12.1249ms 3.6107ms 276.9571 Ops/s 265.2546 Ops/s $\color{#35bf28}+4.41\%$
test_sac_speed 19.1939ms 10.5309ms 94.9587 Ops/s 92.3949 Ops/s $\color{#35bf28}+2.77\%$
test_redq_speed 29.3397ms 20.6296ms 48.4740 Ops/s 49.0118 Ops/s $\color{#d91a1a}-1.10\%$
test_redq_deprec_speed 26.3212ms 18.5577ms 53.8859 Ops/s 60.0691 Ops/s $\textbf{\color{#d91a1a}-10.29\%}$
test_td3_speed 15.5036ms 13.6188ms 73.4281 Ops/s 72.0544 Ops/s $\color{#35bf28}+1.91\%$
test_cql_speed 43.3261ms 35.2673ms 28.3549 Ops/s 26.5556 Ops/s $\textbf{\color{#35bf28}+6.78\%}$
test_a2c_speed 15.5362ms 7.3455ms 136.1378 Ops/s 126.5112 Ops/s $\textbf{\color{#35bf28}+7.61\%}$
test_ppo_speed 17.3356ms 7.8399ms 127.5529 Ops/s 110.7192 Ops/s $\textbf{\color{#35bf28}+15.20\%}$
test_reinforce_speed 14.1046ms 5.8778ms 170.1310 Ops/s 174.0219 Ops/s $\color{#d91a1a}-2.24\%$
test_iql_speed 40.1424ms 30.7555ms 32.5145 Ops/s 35.6057 Ops/s $\textbf{\color{#d91a1a}-8.68\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0964ms 3.2570ms 307.0322 Ops/s 297.2168 Ops/s $\color{#35bf28}+3.30\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.8842ms 3.4116ms 293.1191 Ops/s 288.1483 Ops/s $\color{#35bf28}+1.73\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.6958ms 3.4028ms 293.8753 Ops/s 286.6557 Ops/s $\color{#35bf28}+2.52\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.6746ms 3.2671ms 306.0849 Ops/s 298.5059 Ops/s $\color{#35bf28}+2.54\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 5.4293ms 3.3835ms 295.5523 Ops/s 290.5732 Ops/s $\color{#35bf28}+1.71\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.1276ms 3.3993ms 294.1744 Ops/s 246.7461 Ops/s $\textbf{\color{#35bf28}+19.22\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7604ms 3.2706ms 305.7563 Ops/s 304.4936 Ops/s $\color{#35bf28}+0.41\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1752s 4.0225ms 248.6037 Ops/s 288.3689 Ops/s $\textbf{\color{#d91a1a}-13.79\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.3613ms 3.4441ms 290.3554 Ops/s 288.5399 Ops/s $\color{#35bf28}+0.63\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.2860s 4.2445ms 235.6003 Ops/s 295.4748 Ops/s $\textbf{\color{#d91a1a}-20.26\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.8994ms 3.4162ms 292.7230 Ops/s 287.9515 Ops/s $\color{#35bf28}+1.66\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.3616ms 3.4388ms 290.7976 Ops/s 287.1999 Ops/s $\color{#35bf28}+1.25\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.4001ms 3.2860ms 304.3230 Ops/s 299.7210 Ops/s $\color{#35bf28}+1.54\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 6.3596ms 3.4224ms 292.1909 Ops/s 286.7695 Ops/s $\color{#35bf28}+1.89\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 6.3557ms 3.4221ms 292.2142 Ops/s 286.8253 Ops/s $\color{#35bf28}+1.88\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7393ms 3.2479ms 307.8876 Ops/s 297.3230 Ops/s $\color{#35bf28}+3.55\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.9176ms 3.4522ms 289.6662 Ops/s 289.3220 Ops/s $\color{#35bf28}+0.12\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 6.9767ms 3.4000ms 294.1173 Ops/s 288.9540 Ops/s $\color{#35bf28}+1.79\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2878s 38.4417ms 26.0134 Ops/s 28.6286 Ops/s $\textbf{\color{#d91a1a}-9.13\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1947s 33.7232ms 29.6532 Ops/s 29.0481 Ops/s $\color{#35bf28}+2.08\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1699s 34.1398ms 29.2913 Ops/s 30.2624 Ops/s $\color{#d91a1a}-3.21\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1764s 34.6468ms 28.8627 Ops/s 29.0759 Ops/s $\color{#d91a1a}-0.73\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1835s 32.2720ms 30.9866 Ops/s 31.7386 Ops/s $\color{#d91a1a}-2.37\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1735s 34.4933ms 28.9912 Ops/s 29.0175 Ops/s $\color{#d91a1a}-0.09\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1711s 31.2343ms 32.0161 Ops/s 31.4881 Ops/s $\color{#35bf28}+1.68\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1731s 34.2970ms 29.1571 Ops/s 28.9916 Ops/s $\color{#35bf28}+0.57\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1690s 31.3728ms 31.8747 Ops/s 31.8400 Ops/s $\color{#35bf28}+0.11\%$

vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[Setup] Update setup.py python versions (pytorch#1496)
12ebcce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobettini matteobettini matteobettini approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. versioning Versioning change (version number etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @matteobettini @facebook-github-bot