Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Test split trajs #1445

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[Test] Test split trajs #1445

merged 1 commit into from
Aug 4, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Aug 4, 2023 •
edited
Loading

missing from #1444

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2023
@vmoens vmoens marked this pull request as ready for review August 4, 2023 13:20
@vmoens vmoens merged commit 83dfff3 into main Aug 4, 2023
@vmoens vmoens deleted the missing_tests branch August 4, 2023 13:21
@vmoens vmoens added the Tests Incomplete or broken unit tests label Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1739s 0.1732s 5.7750 Ops/s 5.7995 Ops/s $\color{#d91a1a}-0.42\%$
test_sync 0.2047s 0.1070s 9.3495 Ops/s 10.0385 Ops/s $\textbf{\color{#d91a1a}-6.86\%}$
test_async 0.1539s 0.1056s 9.4676 Ops/s 10.1148 Ops/s $\textbf{\color{#d91a1a}-6.40\%}$
test_simple 0.8369s 0.7437s 1.3446 Ops/s 1.3606 Ops/s $\color{#d91a1a}-1.17\%$
test_transformed 2.0778s 2.0016s 0.4996 Ops/s 0.5000 Ops/s $\color{#d91a1a}-0.09\%$
test_serial 2.3905s 2.3164s 0.4317 Ops/s 0.4399 Ops/s $\color{#d91a1a}-1.87\%$
test_parallel 2.1742s 2.1070s 0.4746 Ops/s 0.4990 Ops/s $\color{#d91a1a}-4.88\%$
test_step_mdp_speed[True-True-True-True-True] 1.5577ms 54.4790μs 18.3557 KOps/s 19.0787 KOps/s $\color{#d91a1a}-3.79\%$
test_step_mdp_speed[True-True-True-True-False] 0.4233ms 29.7219μs 33.6452 KOps/s 34.2627 KOps/s $\color{#d91a1a}-1.80\%$
test_step_mdp_speed[True-True-True-False-True] 78.7030μs 37.2598μs 26.8386 KOps/s 27.3826 KOps/s $\color{#d91a1a}-1.99\%$
test_step_mdp_speed[True-True-True-False-False] 0.1128ms 20.2700μs 49.3339 KOps/s 50.2689 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[True-True-False-True-True] 0.1397ms 54.3612μs 18.3955 KOps/s 18.4354 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[True-True-False-True-False] 80.9020μs 31.5433μs 31.7024 KOps/s 31.8312 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[True-True-False-False-True] 78.8030μs 39.3377μs 25.4209 KOps/s 25.6496 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[True-True-False-False-False] 58.4020μs 22.6716μs 44.1080 KOps/s 44.4213 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-True-True-True] 2.2914ms 56.5229μs 17.6919 KOps/s 17.8193 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-True-True-False] 73.7030μs 33.7350μs 29.6428 KOps/s 29.7535 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[True-False-True-False-True] 0.1004ms 39.3037μs 25.4429 KOps/s 26.1264 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[True-False-True-False-False] 97.8030μs 22.5377μs 44.3702 KOps/s 45.2613 KOps/s $\color{#d91a1a}-1.97\%$
test_step_mdp_speed[True-False-False-True-True] 0.2121ms 59.1157μs 16.9160 KOps/s 17.2115 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[True-False-False-True-False] 78.3030μs 35.9923μs 27.7838 KOps/s 28.1774 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[True-False-False-False-True] 79.5030μs 41.0622μs 24.3533 KOps/s 24.4536 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[True-False-False-False-False] 60.8020μs 24.6289μs 40.6027 KOps/s 40.9105 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[False-True-True-True-True] 0.2278ms 56.4186μs 17.7247 KOps/s 17.8444 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-True-True-True-False] 76.2030μs 33.9548μs 29.4509 KOps/s 29.5166 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-True-False-True] 83.4030μs 46.0131μs 21.7329 KOps/s 21.8095 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-True-False-False] 0.1071ms 25.4797μs 39.2470 KOps/s 39.9061 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[False-True-False-True-True] 0.1478ms 58.5698μs 17.0736 KOps/s 17.1358 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[False-True-False-True-False] 0.1139ms 35.9194μs 27.8401 KOps/s 28.1406 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[False-True-False-False-True] 82.0030μs 48.0293μs 20.8206 KOps/s 20.8137 KOps/s $\color{#35bf28}+0.03\%$
test_step_mdp_speed[False-True-False-False-False] 75.7020μs 27.4171μs 36.4736 KOps/s 36.7264 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-False-True-True-True] 0.1017ms 60.6416μs 16.4903 KOps/s 16.7117 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-True-True-False] 0.1266ms 37.8465μs 26.4225 KOps/s 26.5960 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[False-False-True-False-True] 0.1488ms 48.5019μs 20.6177 KOps/s 21.2494 KOps/s $\color{#d91a1a}-2.97\%$
test_step_mdp_speed[False-False-True-False-False] 61.4020μs 27.0725μs 36.9378 KOps/s 37.2376 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[False-False-False-True-True] 0.1511ms 62.2456μs 16.0654 KOps/s 16.2386 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[False-False-False-True-False] 75.7030μs 39.7570μs 25.1528 KOps/s 25.3446 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-False-False-False-True] 0.2092ms 50.4454μs 19.8234 KOps/s 20.2037 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[False-False-False-False-False] 63.4020μs 29.3083μs 34.1200 KOps/s 34.1628 KOps/s $\color{#d91a1a}-0.13\%$
test_values[generalized_advantage_estimate-True-True] 16.9702ms 16.4876ms 60.6517 Ops/s 62.5270 Ops/s $\color{#d91a1a}-3.00\%$
test_values[vec_generalized_advantage_estimate-True-True] 62.7191ms 54.7576ms 18.2623 Ops/s 18.6116 Ops/s $\color{#d91a1a}-1.88\%$
test_values[td0_return_estimate-False-False] 0.4580ms 0.3247ms 3.0795 KOps/s 3.4192 KOps/s $\textbf{\color{#d91a1a}-9.94\%}$
test_values[td1_return_estimate-False-False] 19.8035ms 16.2729ms 61.4519 Ops/s 64.5792 Ops/s $\color{#d91a1a}-4.84\%$
test_values[vec_td1_return_estimate-False-False] 61.3050ms 52.7621ms 18.9530 Ops/s 19.1408 Ops/s $\color{#d91a1a}-0.98\%$
test_values[td_lambda_return_estimate-True-False] 38.5138ms 38.0957ms 26.2497 Ops/s 27.1151 Ops/s $\color{#d91a1a}-3.19\%$
test_values[vec_td_lambda_return_estimate-True-False] 71.7596ms 55.0058ms 18.1799 Ops/s 19.1568 Ops/s $\textbf{\color{#d91a1a}-5.10\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 14.3994ms 14.3156ms 69.8537 Ops/s 72.0412 Ops/s $\color{#d91a1a}-3.04\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 20.4522ms 4.5218ms 221.1499 Ops/s 240.5870 Ops/s $\textbf{\color{#d91a1a}-8.08\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 4.5481ms 0.7421ms 1.3476 KOps/s 1.6519 KOps/s $\textbf{\color{#d91a1a}-18.42\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 74.6185ms 69.8064ms 14.3253 Ops/s 14.0815 Ops/s $\color{#35bf28}+1.73\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.4385ms 4.0390ms 247.5869 Ops/s 244.4180 Ops/s $\color{#35bf28}+1.30\%$
test_dqn_speed 10.6925ms 1.9911ms 502.2474 Ops/s 499.0179 Ops/s $\color{#35bf28}+0.65\%$
test_ddpg_speed 14.8845ms 3.8250ms 261.4402 Ops/s 257.7372 Ops/s $\color{#35bf28}+1.44\%$
test_sac_speed 17.2543ms 11.4138ms 87.6134 Ops/s 86.9273 Ops/s $\color{#35bf28}+0.79\%$
test_redq_speed 29.8938ms 18.4767ms 54.1223 Ops/s 55.0681 Ops/s $\color{#d91a1a}-1.72\%$
test_redq_deprec_speed 26.3182ms 16.9170ms 59.1121 Ops/s 57.8089 Ops/s $\color{#35bf28}+2.25\%$
test_td3_speed 18.1090ms 14.0507ms 71.1709 Ops/s 73.2570 Ops/s $\color{#d91a1a}-2.85\%$
test_cql_speed 41.9048ms 35.3212ms 28.3116 Ops/s 21.5372 Ops/s $\textbf{\color{#35bf28}+31.45\%}$
test_a2c_speed 18.0760ms 7.5923ms 131.7132 Ops/s 127.4822 Ops/s $\color{#35bf28}+3.32\%$
test_ppo_speed 16.2890ms 7.8787ms 126.9250 Ops/s 111.2580 Ops/s $\textbf{\color{#35bf28}+14.08\%}$
test_reinforce_speed 15.8968ms 5.7956ms 172.5435 Ops/s 155.0601 Ops/s $\textbf{\color{#35bf28}+11.28\%}$
test_iql_speed 38.8190ms 30.3800ms 32.9164 Ops/s 34.9037 Ops/s $\textbf{\color{#d91a1a}-5.69\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.6621ms 3.4757ms 287.7148 Ops/s 291.4780 Ops/s $\color{#d91a1a}-1.29\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 7.4874ms 3.6126ms 276.8074 Ops/s 277.7920 Ops/s $\color{#d91a1a}-0.35\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.2322s 4.3269ms 231.1128 Ops/s 279.2613 Ops/s $\textbf{\color{#d91a1a}-17.24\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1627ms 3.4533ms 289.5797 Ops/s 289.9443 Ops/s $\color{#d91a1a}-0.13\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 7.8275ms 3.5869ms 278.7895 Ops/s 276.2918 Ops/s $\color{#35bf28}+0.90\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 8.0174ms 3.6151ms 276.6187 Ops/s 276.9415 Ops/s $\color{#d91a1a}-0.12\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8279ms 3.4520ms 289.6855 Ops/s 286.0242 Ops/s $\color{#35bf28}+1.28\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.9082ms 3.6109ms 276.9379 Ops/s 276.7042 Ops/s $\color{#35bf28}+0.08\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.1362ms 3.6129ms 276.7889 Ops/s 280.4355 Ops/s $\color{#d91a1a}-1.30\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.7586ms 3.5088ms 284.9974 Ops/s 289.8476 Ops/s $\color{#d91a1a}-1.67\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 6.3353ms 3.5947ms 278.1874 Ops/s 237.5467 Ops/s $\textbf{\color{#35bf28}+17.11\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1844s 4.2247ms 236.7050 Ops/s 238.8453 Ops/s $\color{#d91a1a}-0.90\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1286ms 3.5064ms 285.1894 Ops/s 288.6992 Ops/s $\color{#d91a1a}-1.22\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1801s 4.1631ms 240.2051 Ops/s 234.5395 Ops/s $\color{#35bf28}+2.42\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.6619ms 3.5809ms 279.2605 Ops/s 233.6737 Ops/s $\textbf{\color{#35bf28}+19.51\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.1496ms 3.4530ms 289.6022 Ops/s 284.6670 Ops/s $\color{#35bf28}+1.73\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 6.9525ms 3.5566ms 281.1695 Ops/s 235.8872 Ops/s $\textbf{\color{#35bf28}+19.20\%}$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.3405ms 3.5687ms 280.2105 Ops/s 234.1613 Ops/s $\textbf{\color{#35bf28}+19.67\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.3474s 36.6543ms 27.2819 Ops/s 26.4448 Ops/s $\color{#35bf28}+3.17\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1889s 36.4069ms 27.4674 Ops/s 30.0380 Ops/s $\textbf{\color{#d91a1a}-8.56\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1939s 33.4837ms 29.8653 Ops/s 27.0106 Ops/s $\textbf{\color{#35bf28}+10.57\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1976s 36.7973ms 27.1759 Ops/s 30.1601 Ops/s $\textbf{\color{#d91a1a}-9.89\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1947s 36.8345ms 27.1484 Ops/s 27.1770 Ops/s $\color{#d91a1a}-0.11\%$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1970s 33.3500ms 29.9850 Ops/s 27.1552 Ops/s $\textbf{\color{#35bf28}+10.42\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1929s 36.8015ms 27.1728 Ops/s 29.8864 Ops/s $\textbf{\color{#d91a1a}-9.08\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1911s 33.0909ms 30.2197 Ops/s 26.9557 Ops/s $\textbf{\color{#35bf28}+12.11\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1971s 37.1436ms 26.9226 Ops/s 30.1384 Ops/s $\textbf{\color{#d91a1a}-10.67\%}$

vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[Test] Test split trajs (pytorch#1445)
9cf41c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot