Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] unlock in tensordictmodules tests #1417

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[BugFix] unlock in tensordictmodules tests #1417

merged 1 commit into from
Jul 27, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 27, 2023 •
edited
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2023
@vmoens vmoens marked this pull request as ready for review July 27, 2023 09:49
@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests labels Jul 27, 2023
matteobettini
matteobettini approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1433s 0.1430s 6.9915 Ops/s 7.0013 Ops/s $\color{#d91a1a}-0.14\%$
test_sync 0.1495s 80.6451ms 12.4000 Ops/s 13.2488 Ops/s $\textbf{\color{#d91a1a}-6.41\%}$
test_async 0.1918s 74.3487ms 13.4501 Ops/s 13.6739 Ops/s $\color{#d91a1a}-1.64\%$
test_simple 0.6767s 0.6135s 1.6301 Ops/s 1.6282 Ops/s $\color{#35bf28}+0.12\%$
test_transformed 1.7146s 1.6632s 0.6013 Ops/s 0.6022 Ops/s $\color{#d91a1a}-0.16\%$
test_serial 1.9735s 1.9175s 0.5215 Ops/s 0.5192 Ops/s $\color{#35bf28}+0.44\%$
test_parallel 1.6543s 1.5659s 0.6386 Ops/s 0.6513 Ops/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[True-True-True-True-True] 0.1056ms 44.5163μs 22.4637 KOps/s 22.5220 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-True-True-True-False] 0.1155ms 25.2903μs 39.5409 KOps/s 40.1419 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[True-True-True-False-True] 54.6010μs 31.6385μs 31.6070 KOps/s 31.5804 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[True-True-True-False-False] 0.1989ms 17.6035μs 56.8069 KOps/s 56.8775 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[True-True-False-True-True] 0.1078ms 46.1430μs 21.6718 KOps/s 21.7641 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[True-True-False-True-False] 51.5010μs 27.0533μs 36.9640 KOps/s 37.3365 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[True-True-False-False-True] 0.1075ms 33.5867μs 29.7737 KOps/s 30.1121 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[True-True-False-False-False] 69.8010μs 19.5586μs 51.1285 KOps/s 51.6347 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[True-False-True-True-True] 69.5010μs 48.1718μs 20.7591 KOps/s 20.9863 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-False-True-True-False] 51.4010μs 28.7306μs 34.8061 KOps/s 35.3347 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[True-False-True-False-True] 0.1442ms 33.8436μs 29.5477 KOps/s 30.0958 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-True-False-False] 38.4000μs 19.3580μs 51.6583 KOps/s 52.2267 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-False-False-True-True] 0.1876ms 49.8637μs 20.0547 KOps/s 20.3036 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-False-True-False] 83.9010μs 30.6167μs 32.6620 KOps/s 33.1970 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[True-False-False-False-True] 80.5010μs 35.6770μs 28.0293 KOps/s 28.4676 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-False-False-False-False] 46.9010μs 21.0778μs 47.4433 KOps/s 48.1028 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-True-True-True-True] 97.9020μs 47.9276μs 20.8648 KOps/s 20.9893 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[False-True-True-True-False] 51.8010μs 29.0000μs 34.4828 KOps/s 35.2591 KOps/s $\color{#d91a1a}-2.20\%$
test_step_mdp_speed[False-True-True-False-True] 81.3010μs 39.4227μs 25.3661 KOps/s 25.6878 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[False-True-True-False-False] 48.1010μs 22.0678μs 45.3149 KOps/s 45.6898 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-True-False-True-True] 69.2010μs 49.9147μs 20.0342 KOps/s 20.1822 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-True-False-True-False] 52.1010μs 30.5787μs 32.7025 KOps/s 33.1884 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[False-True-False-False-True] 69.3020μs 40.8869μs 24.4577 KOps/s 24.5429 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-False-False-False] 0.2812ms 23.9122μs 41.8196 KOps/s 42.0854 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[False-False-True-True-True] 0.4335ms 51.4833μs 19.4238 KOps/s 19.5623 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-False-True-True-False] 48.6010μs 32.2394μs 31.0179 KOps/s 31.3938 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[False-False-True-False-True] 60.8010μs 40.5320μs 24.6719 KOps/s 24.7628 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-False-True-False-False] 70.4010μs 23.5627μs 42.4400 KOps/s 43.2652 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[False-False-False-True-True] 75.8010μs 52.7981μs 18.9401 KOps/s 18.9690 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-False-True-False] 57.1010μs 33.8708μs 29.5240 KOps/s 29.7994 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-False-False-False-True] 61.2010μs 42.0658μs 23.7723 KOps/s 23.8022 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-False-False-False-False] 51.1010μs 25.2292μs 39.6366 KOps/s 39.9191 KOps/s $\color{#d91a1a}-0.71\%$
test_values[generalized_advantage_estimate-True-True] 13.7475ms 12.7146ms 78.6500 Ops/s 76.2552 Ops/s $\color{#35bf28}+3.14\%$
test_values[vec_generalized_advantage_estimate-True-True] 47.2611ms 40.5201ms 24.6791 Ops/s 24.2058 Ops/s $\color{#35bf28}+1.96\%$
test_values[td0_return_estimate-False-False] 0.2969ms 0.1818ms 5.5014 KOps/s 5.3523 KOps/s $\color{#35bf28}+2.79\%$
test_values[td1_return_estimate-False-False] 12.6143ms 12.3609ms 80.9003 Ops/s 78.4629 Ops/s $\color{#35bf28}+3.11\%$
test_values[vec_td1_return_estimate-False-False] 48.5730ms 40.3917ms 24.7576 Ops/s 24.3985 Ops/s $\color{#35bf28}+1.47\%$
test_values[td_lambda_return_estimate-True-False] 30.6702ms 29.9834ms 33.3518 Ops/s 32.7508 Ops/s $\color{#35bf28}+1.84\%$
test_values[vec_td_lambda_return_estimate-True-False] 50.9864ms 40.4431ms 24.7261 Ops/s 24.3132 Ops/s $\color{#35bf28}+1.70\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.6260ms 11.4467ms 87.3612 Ops/s 85.9168 Ops/s $\color{#35bf28}+1.68\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 3.9223ms 3.3026ms 302.7917 Ops/s 302.0834 Ops/s $\color{#35bf28}+0.23\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5314ms 0.4278ms 2.3376 KOps/s 2.3178 KOps/s $\color{#35bf28}+0.85\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 56.7850ms 54.4602ms 18.3620 Ops/s 18.2111 Ops/s $\color{#35bf28}+0.83\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.1754ms 2.7437ms 364.4658 Ops/s 365.4924 Ops/s $\color{#d91a1a}-0.28\%$
test_dqn_speed 1.7596ms 1.4337ms 697.4935 Ops/s 694.9041 Ops/s $\color{#35bf28}+0.37\%$
test_ddpg_speed 3.0502ms 2.6799ms 373.1492 Ops/s 371.1072 Ops/s $\color{#35bf28}+0.55\%$
test_sac_speed 8.3443ms 7.8258ms 127.7818 Ops/s 128.9675 Ops/s $\color{#d91a1a}-0.92\%$
test_redq_speed 13.6908ms 13.0320ms 76.7340 Ops/s 77.1951 Ops/s $\color{#d91a1a}-0.60\%$
test_redq_deprec_speed 15.6098ms 11.6309ms 85.9781 Ops/s 86.0007 Ops/s $\color{#d91a1a}-0.03\%$
test_td3_speed 9.8852ms 9.2533ms 108.0697 Ops/s 106.3916 Ops/s $\color{#35bf28}+1.58\%$
test_cql_speed 26.0968ms 24.3657ms 41.0412 Ops/s 32.3391 Ops/s $\textbf{\color{#35bf28}+26.91\%}$
test_a2c_speed 8.6143ms 5.0676ms 197.3307 Ops/s 201.7647 Ops/s $\color{#d91a1a}-2.20\%$
test_ppo_speed 11.6637ms 5.2606ms 190.0914 Ops/s 183.6250 Ops/s $\color{#35bf28}+3.52\%$
test_reinforce_speed 7.1583ms 3.8659ms 258.6702 Ops/s 256.9521 Ops/s $\color{#35bf28}+0.67\%$
test_iql_speed 20.5112ms 19.4200ms 51.4934 Ops/s 49.3043 Ops/s $\color{#35bf28}+4.44\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3435ms 2.5691ms 389.2349 Ops/s 379.4464 Ops/s $\color{#35bf28}+2.58\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.5011ms 2.7662ms 361.5060 Ops/s 359.8301 Ops/s $\color{#35bf28}+0.47\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1474s 3.1567ms 316.7900 Ops/s 361.7895 Ops/s $\textbf{\color{#d91a1a}-12.44\%}$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5995ms 2.6018ms 384.3440 Ops/s 382.7202 Ops/s $\color{#35bf28}+0.42\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1403s 3.1399ms 318.4789 Ops/s 361.1234 Ops/s $\textbf{\color{#d91a1a}-11.81\%}$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.8980ms 2.7811ms 359.5679 Ops/s 359.5146 Ops/s $\color{#35bf28}+0.01\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9288ms 2.5460ms 392.7739 Ops/s 388.4988 Ops/s $\color{#35bf28}+1.10\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.4363ms 2.7391ms 365.0879 Ops/s 359.4417 Ops/s $\color{#35bf28}+1.57\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6996ms 2.8054ms 356.4531 Ops/s 360.6707 Ops/s $\color{#d91a1a}-1.17\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.4231ms 2.5879ms 386.4108 Ops/s 386.7664 Ops/s $\color{#d91a1a}-0.09\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 4.8638ms 2.7347ms 365.6663 Ops/s 359.1404 Ops/s $\color{#35bf28}+1.82\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.1393s 3.1559ms 316.8635 Ops/s 357.5967 Ops/s $\textbf{\color{#d91a1a}-11.39\%}$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3596ms 2.5569ms 391.1009 Ops/s 385.1653 Ops/s $\color{#35bf28}+1.54\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.9845ms 2.7398ms 364.9896 Ops/s 358.2478 Ops/s $\color{#35bf28}+1.88\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.4436ms 2.7612ms 362.1617 Ops/s 359.6782 Ops/s $\color{#35bf28}+0.69\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5958ms 2.5525ms 391.7755 Ops/s 384.4849 Ops/s $\color{#35bf28}+1.90\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 4.0409ms 2.7009ms 370.2447 Ops/s 359.2361 Ops/s $\color{#35bf28}+3.06\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8760ms 2.7788ms 359.8616 Ops/s 357.8054 Ops/s $\color{#35bf28}+0.57\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2739s 29.6966ms 33.6739 Ops/s 31.6659 Ops/s $\textbf{\color{#35bf28}+6.34\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1411s 29.1727ms 34.2786 Ops/s 37.5520 Ops/s $\textbf{\color{#d91a1a}-8.72\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1410s 26.7552ms 37.3759 Ops/s 33.2757 Ops/s $\textbf{\color{#35bf28}+12.32\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1471s 27.0466ms 36.9733 Ops/s 37.4159 Ops/s $\color{#d91a1a}-1.18\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1420s 26.6235ms 37.5608 Ops/s 34.2784 Ops/s $\textbf{\color{#35bf28}+9.58\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1392s 28.9505ms 34.5417 Ops/s 37.4979 Ops/s $\textbf{\color{#d91a1a}-7.88\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1461s 26.8517ms 37.2416 Ops/s 34.0441 Ops/s $\textbf{\color{#35bf28}+9.39\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1420s 29.1520ms 34.3030 Ops/s 37.3648 Ops/s $\textbf{\color{#d91a1a}-8.19\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1450s 26.9491ms 37.1070 Ops/s 33.8937 Ops/s $\textbf{\color{#35bf28}+9.48\%}$

@vmoens vmoens merged commit fc8fe4c into main Jul 27, 2023
@vmoens vmoens deleted the fix_tdmodule_tests branch July 27, 2023 10:06
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[BugFix] unlock in tensordictmodules tests (pytorch#1417)
d6f4129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobettini matteobettini matteobettini approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @matteobettini @facebook-github-bot