-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Features] Conv3dNet and PermuteTransform #1398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 19, 2023
vmoens
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Really useful thanks a mil!
A few suggestions
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
# Conflicts: # test/test_modules.py # test/test_transforms.py
vmoens
approved these changes
Sep 16, 2023
albertbou92
pushed a commit
to PyTorchRL/rl
that referenced
this pull request
Sep 18, 2023
Co-authored-by: vmoens <vincentmoens@gmail.com>
vmoens
added a commit
to hyerra/rl
that referenced
this pull request
Oct 10, 2023
Co-authored-by: vmoens <vincentmoens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add features of
Conv3dNet
, similar to ConvNet but with 3d convolution layers, andPermuteTransform
being a utility tool to transform tensors to ones with shape required by conv3d.Types of changes