Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Nested keys to probabilistic modules #1363

Merged
merged 5 commits into from
Jul 7, 2023
Merged

[BugFix] Nested keys to probabilistic modules #1363

merged 5 commits into from
Jul 7, 2023

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jul 6, 2023 •
edited
Loading

No description provided.

@matteobettini
amend
e244fe5 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2023
@matteobettini
tests
5ea0d26 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as ready for review July 6, 2023 12:15
@matteobettini
Merge branch 'main' into probabilistic_nested
a7d2ee3 
# Conflicts:
#	torchrl/modules/tensordict_module/probabilistic.py
@matteobettini
amend
5163fe8 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
Merge branch 'main' into probabilistic_nested
bfaed2a
vmoens
vmoens approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 17faca8 into pytorch:main Jul 7, 2023
@matteobettini matteobettini deleted the probabilistic_nested branch July 7, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot