Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add link to paper in readme #1298

Merged
merged 2 commits into from
Jun 20, 2023
Merged

[Doc] Add link to paper in readme #1298

merged 2 commits into from
Jun 20, 2023

Conversation

giadefa
Copy link
Contributor

@giadefa giadefa commented Jun 19, 2023

Added link to paper

Added link to paper
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2023
@vmoens vmoens changed the title Update README.md [Doc] Add link to paper in readme Jun 19, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an aesthetic suggestion to avoid having the plain link exposed in the text.

README.md Outdated Show resolved Hide resolved
ok

Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
@matteobettini
Copy link
Contributor

Just a note. Check this doesn't show up in the anonymized version after merging this

@vmoens
Copy link
Contributor

vmoens commented Jun 20, 2023

Just a note. Check this doesn't show up in the anonymized version after merging this

This is why this is on hold :)
We can also anonymise the link

@matteobettini
Copy link
Contributor

matteobettini commented Jun 20, 2023

If all external links are blocked in the anonymized github link we can merge this without problems.

@vmoens vmoens merged commit fa92624 into pytorch:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants