Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Separate losses #1240

Merged
merged 19 commits into from
Jun 26, 2023
Merged

[Feature] Separate losses #1240

merged 19 commits into from
Jun 26, 2023

Conversation

MateuszGuzek
Copy link
Contributor

@MateuszGuzek MateuszGuzek commented Jun 7, 2023 •
edited
Loading

Description

TD3 should have the option of tying or not the parameters of the actor and qvalue network as in #1037. We should test whether the loss is backprop on qvalue net or not in the tests

  • TD3
  • Ditto for DDPGLoss
  • Ditto for IQLLoss
  • Ditto for reinforce
  • Ditto for A2C
  • Ditto for SAC
  • Ditto for REDQ (+ deprecated version)

Motivation and Context

The first 7 tasks of #1058

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2023
@vmoens vmoens added the enhancement New feature or request label Jun 13, 2023
vmoens
vmoens reviewed Jun 13, 2023
View reviewed changes
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
vmoens
vmoens reviewed Jun 19, 2023
View reviewed changes
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
test/test_cost.py Outdated Show resolved Hide resolved
@MateuszGuzek MateuszGuzek marked this pull request as ready for review June 21, 2023 10:43
vmoens
vmoens approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fantastic work
Can you just comment on REDQ: has the default behaviour changed?

test/test_cost.py Show resolved Hide resolved
@vmoens vmoens merged commit 56518a7 into pytorch:main Jun 26, 2023
@MateuszGuzek MateuszGuzek deleted the separate_losses_option branch June 26, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MateuszGuzek @vmoens @facebook-github-bot