[BugFix] Fix missing ("next", "observation") key in dispatch of losses #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Blonck
added
bug
vmoens
approved these changes
Jun 6, 2023
torchrl/objectives/a2c.py
Outdated
| >>> loss_val | ||
| (tensor(1.7593, grad_fn=<MeanBackward0>), tensor(0.2344, grad_fn=<MeanBackward0>), tensor(1.5480), tensor(-0.0155, grad_fn=<MulBackward0>)) | ||
| (tensor(4.3483, grad_fn=<MeanBackward0>), tensor(1.4114, grad_fn=<MeanBackward0>), tensor(2.5165), tensor(-0.0252, grad_fn=<MulBackward0>)) |
There was a problem hiding this comment.
maybe we don't want to print these values (such that we don't pollute PRs with diffs that aren't relevant?)
There was a problem hiding this comment.
Good point, I will just remove it.
torchrl/objectives/iql.py
Outdated
| ... next_reward=torch.randn(*batch, 1)) | ||
| >>> loss_val | ||
| (tensor(1.4535, grad_fn=<MeanBackward0>), tensor(0.8389, grad_fn=<MeanBackward0>), tensor(0.3406, grad_fn=<MeanBackward0>), tensor(3.3441)) | ||
| (tensor(1.4535, grad_fn=<MeanBackward0>), tensor(0.7506, grad_fn=<MeanBackward0>), tensor(0.3406, grad_fn=<MeanBackward0>), tensor(3.3441)) |
facebook-github-bot
added
the
CLA Signed
vmoens
reviewed
Jun 6, 2023
torchrl/objectives/a2c.py
Outdated
Comment on lines
152
to
153
| >>> loss_val | ||
| (tensor(4.3483, grad_fn=<MeanBackward0>), tensor(1.4114, grad_fn=<MeanBackward0>), tensor(2.5165), tensor(-0.0252, grad_fn=<MulBackward0>)) |
There was a problem hiding this comment.
We can still print something :)
You could do
loss_actor, loss_val, *etc = fun_call(**kwargs)
loss_actor.backward() # for instance
anything that makes it feel like "this is a tensor"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing ("next", "dispatch") key of in_keys from IQL, DDPG, and A2C loss module.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!