[Algo] Update offpolicy examples #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
reviewed
May 30, 2023
There was a problem hiding this comment.
LGTM
Would it make sense to have configs a bit more "structured" like
collector:
frames_per_batch: 1000
replay_buffer:
size: 1_000_000
then access the fields through
cfg.collector.frames_per_batch
?
Also, how deep do we want the config to be? Maybe we could let the users control the number of cells etc?
Don't we need to update the examples worflow in the CI?
Comment on lines
+93
to
+94
| alpha=0.7, | ||
| beta=0.5, |
There was a problem hiding this comment.
we could make that parametrizable too
vmoens
reviewed
May 30, 2023
There was a problem hiding this comment.
LGTM
Would it make sense to have configs a bit more "structured" like
collector:
frames_per_batch: 1000
replay_buffer:
size: 1_000_000
then access the fields through
cfg.collector.frames_per_batch
?
Also, how deep do we want the config to be? Maybe we could let the users control the number of cells etc?
Don't we need to update the examples worflow in the CI?
vmoens
reviewed
May 30, 2023
… into update_offpolicy_examples
… into update_offpolicy_examples
…pdate_offpolicy_examples
vmoens
reviewed
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the off-policy examples for ddpg, td3 and sac to simple scripts