Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Auto-init updaters and raise a warning if not present #1092

Merged
merged 4 commits into from
Apr 26, 2023
Merged

[Feature] Auto-init updaters and raise a warning if not present #1092

merged 4 commits into from
Apr 26, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 26, 2023 •
edited
Loading

Description

Raises a warning if a loss has target params that are not associated with a target net updater.
Also calls update.init_() during __init__.

cc @matteobettini

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2023
@vmoens vmoens added bug Something isn't working enhancement New feature or request labels Apr 26, 2023
@vmoens vmoens merged commit cd02ee0 into main Apr 26, 2023
@vmoens vmoens deleted the flag_unset_updater branch April 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot