Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Benchmarking worflow #1028

Merged
merged 15 commits into from
Apr 6, 2023
Merged

[Feature] Benchmarking worflow #1028

merged 15 commits into from
Apr 6, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 6, 2023 •
edited
Loading

Description

Things to benchmark:

  • Env, Serial, ParallelEnv
  • Collectors (single, multiproc,)
  • Replay buffers
  • Advantages

Others? Anything outstanding?

There's a tradeoff between: number of iterations (high precision of the benchmark) and runtime (we can't collect 100 times 100K frames with the collectors, that would take ages).

To do separately

  • Collectors (distributed)
  • loss modules
  • TensordictModules (safe)

@albertbou92 @BY571 @matteobettini @shagunsodhani

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 6, 2023
@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Apr 6, 2023
@vmoens vmoens merged commit 38496d2 into main Apr 6, 2023
@vmoens vmoens deleted the benchmark_wf branch April 6, 2023 14:13
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Apr 12, 2023
@vmoens @albertbou92
[Feature] Benchmarking worflow (pytorch#1028)
2f38131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot