Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Agent class #101

Merged
merged 63 commits into from
May 7, 2022
Merged

Refactor Agent class #101

merged 63 commits into from
May 7, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 28, 2022 •
edited
Loading

Deprecates the Agent class in favour of a Trainer class.
The trainer can be decorated by a series of hooks that execute algorithm-specific operations.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2022
@vmoens vmoens added enhancement New feature or request bc breaking backward compatibility breaking change quality code quality labels May 6, 2022
@vmoens vmoens changed the title [WIP] Refactor Agent class Refactor Agent class May 7, 2022
@vmoens vmoens marked this pull request as ready for review May 7, 2022 10:14
@vmoens vmoens added the major major refactoring in the code base label May 7, 2022
@vmoens vmoens merged commit 61601b9 into main May 7, 2022
@vmoens vmoens mentioned this pull request May 14, 2022
Closed
@vmoens vmoens deleted the agent_refactoring branch May 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request major major refactoring in the code base quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot