Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix,Feature,Doc] Fix replay buffers sampling info, docstrings and iteration #1003

Merged
merged 6 commits into from
Mar 29, 2023
Merged

[BugFix,Feature,Doc] Fix replay buffers sampling info, docstrings and iteration #1003

merged 6 commits into from
Mar 29, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 29, 2023 •
edited
Loading

Description

Makes all args keyword only args in replay buffers for clarity.

Improve docstrings.

Fixes the following bugs:

  • Iterating multiple times over a replay buffer leads to an empty iterator the second time and on
  • include_info=False (default) leads to rubbish in the index entry, which harms training

cc @BY571 @matteobettini

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2023
@vmoens vmoens added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 29, 2023
@vmoens vmoens merged commit e26d148 into main Mar 29, 2023
@vmoens vmoens deleted the fix_rb branch March 29, 2023 15:05
@vmoens vmoens mentioned this pull request Mar 30, 2023
Closed
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Apr 12, 2023
@vmoens @albertbou92
[BugFix,Feature,Doc] Fix replay buffers sampling info, docstrings and…
a65324b 
… iteration (pytorch#1003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot