Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add an API to reset LossModule parameters #2538

Closed
1 task done
kurtamohler opened this issue Nov 6, 2024 · 0 comments · Fixed by #2546
Closed
1 task done

[Feature Request] Add an API to reset LossModule parameters #2538

kurtamohler opened this issue Nov 6, 2024 · 0 comments · Fixed by #2546
Assignees
@kurtamohler
Labels
enhancement New feature or request Objectives

Comments

@kurtamohler
Copy link
Collaborator

kurtamohler commented Nov 6, 2024 •
edited
Loading

Motivation

LossModule should have a good API to reset parameters.

Solution

#2017 was an attempt at providing this feature. The discussion in that PR (particularly #2017 (comment)) mentions some ideas for how it could be improved.

Alternatives

Additional context

Checklist

  • I have checked that there is no similar issue in the repo (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtamohler kurtamohler

Labels
enhancement New feature or request Objectives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] Add LossModule.reset_parameters_recursive kurtamohler/torchrl
1 participant
@kurtamohler