You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When depth and num_cells are both not specified, MLP will by default create a fully-connected neural network with three hidden layers, each with 32 neurons.
This is somewhat surprising, as I would imaging leaving depth and num_cells unspecified would lead to a neural network with no hidden layer at all. Not sure why use depth=3 and num_cells=32 as default here :)
This is not really a bug report, just IMHO a weird design choice which is also not documented. Would appreciate if we can discuss and reconsider this.
I agree, it's more a historical debt than anything meaningful.
I will make a PR to progressively deprecate this.
In the future, I can see two default behaviours for your example:
no depth, just a linear layer
error: one must say what depth / number of cells is to be used
Let me know what you think would make more sense here!
Describe the bug
When
depth
andnum_cells
are both not specified,MLP
will by default create a fully-connected neural network with three hidden layers, each with 32 neurons.This is somewhat surprising, as I would imaging leaving
depth
andnum_cells
unspecified would lead to a neural network with no hidden layer at all. Not sure why usedepth=3
andnum_cells=32
as default here :)This is not really a bug report, just IMHO a weird design choice which is also not documented. Would appreciate if we can discuss and reconsider this.
To Reproduce
Expected behavior
System info
Reason and Possible fixes
rl/torchrl/modules/models/models.py
Lines 182 to 188 in 0063741
Checklist
The text was updated successfully, but these errors were encountered: