Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert TensorDictModuleWrappers to TensorDictModules #2295

Closed
1 task done
kurtamohler opened this issue Jul 18, 2024 · 0 comments · Fixed by #2298
Closed
1 task done

Convert TensorDictModuleWrappers to TensorDictModules #2295

kurtamohler opened this issue Jul 18, 2024 · 0 comments · Fixed by #2298
Assignees
@kurtamohler
Labels
enhancement New feature or request

Comments

@kurtamohler
Copy link
Collaborator

kurtamohler commented Jul 18, 2024 •
edited
Loading

Motivation

EGreedyWrapper was converted to EGreedyModule a while ago because TensorDictModules are more user-friendly than TensorDictModuleWrappers.

There are still some TensorDictModuleWrappers that have not been converted to a TensorDictModule:

Solution

We should convert these remaining TensorDictModuleWrappers to TensorDictModules.

Alternatives

Additional context

Checklist

  • I have checked that there is no similar issue in the repo (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtamohler kurtamohler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Refactor] Update all instances of exploration *Wrapper to *Module kurtamohler/torchrl
1 participant
@kurtamohler