Skip to content

Commit

Permalink
[CI] Temporarily remove snapshot from CI (#2000)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vmoens
vmoens authored Mar 7, 2024
1 parent 130a213 commit ad73733
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
12 changes: 6 additions & 6 deletions .github/unittest/linux/scripts/run_all.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,12 @@ fi
# smoke test
python -c "import functorch"

# install snapshot
if [[ "$TORCH_VERSION" == "nightly" ]]; then
pip3 install git+https://github.com/pytorch/torchsnapshot
else
pip3 install torchsnapshot
fi
## install snapshot
#if [[ "$TORCH_VERSION" == "nightly" ]]; then
# pip3 install git+https://github.com/pytorch/torchsnapshot
#else
# pip3 install torchsnapshot
#fi

# install tensordict
if [[ "$RELEASE" == 0 ]]; then
Expand Down
4 changes: 2 additions & 2 deletions .github/unittest/linux_distributed/scripts/install.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ fi
# smoke test
python -c "import functorch"

# install snapshot
pip install git+https://github.com/pytorch/torchsnapshot
## install snapshot
#pip install git+https://github.com/pytorch/torchsnapshot

# install tensordict
if [[ "$RELEASE" == 0 ]]; then
Expand Down
4 changes: 2 additions & 2 deletions .github/unittest/linux_examples/scripts/run_all.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ fi
# smoke test
python -c "import functorch"

# install snapshot
pip install git+https://github.com/pytorch/torchsnapshot
## install snapshot
#pip install git+https://github.com/pytorch/torchsnapshot

# install tensordict
if [[ "$RELEASE" == 0 ]]; then
Expand Down

1 comment on commit ad73733

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ad73733 Previous: 07eb02d Ratio
benchmarks/test_replaybuffer_benchmark.py::test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 339.0484078875357 iter/sec (stddev: 0.013517025579048296) 920.8061584265723 iter/sec (stddev: 0.0001515523147415429) 2.72

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.